Jacob are you the right owner for this?

> Jacob are you the right owner for this?

Probably for the time being.

This bug has an owner, thus, it's been triaged. Changing status to "assigned".

I believe none of this is needed for single-process mash.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/907ced37ec104cea9d03e7b14b8b57b30482bcc9

commit 907ced37ec104cea9d03e7b14b8b57b30482bcc9
Author: James Cook <jamescook@chromium.org>
Date: Mon Aug 27 16:16:36 2018

chromeos: Clean up LoginDisplayHostWebUI constructor

Pull initialize_webui_hidden_ computation into a utility function.
This simplifies various IsUsingWindowService() checks for mash.

Bug: 143298, 756071
Change-Id: I538ea8597f2fd970dbd246a9ee184144a76462ca
Reviewed-on: https://chromium-review.googlesource.com/1189052
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586276}
[modify] https://crrev.com/907ced37ec104cea9d03e7b14b8b57b30482bcc9/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/907ced37ec104cea9d03e7b14b8b57b30482bcc9/chromeos/chromeos_switches.cc
[modify] https://crrev.com/907ced37ec104cea9d03e7b14b8b57b30482bcc9/chromeos/chromeos_switches.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adc0e8057d3389c54d498aa5ee38c8305e05ee69

commit adc0e8057d3389c54d498aa5ee38c8305e05ee69
Author: James Cook <jamescook@chromium.org>
Date: Mon Aug 27 23:28:11 2018

chromeos: Fix some login animation code for SingleProcessMash

Most of the animations are supported. This fixes a large number of
kiosk browser_tests under SingleProcessMash.

Remove an unnecessary workaround for ash process crashes at the login
screen. Now that we don't have a separate window server process an
ash crash will result in a clean exit(1) of the browser.

There is still one potential issue with animated avatar icons. I'm
following up with the graphics guys on that one.

Bug: 756071,  613746 ,  691134 
Test: OOBE/login with SingleProcessMash, browser_tests *Kiosk*
Change-Id: Ib72482a3011eabfc6453e7be9e83341063aa4704
Reviewed-on: https://chromium-review.googlesource.com/1191083
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586484}
[modify] https://crrev.com/adc0e8057d3389c54d498aa5ee38c8305e05ee69/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/adc0e8057d3389c54d498aa5ee38c8305e05ee69/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/adc0e8057d3389c54d498aa5ee38c8305e05ee69/testing/buildbot/filters/chromeos.single_process_mash.fyi.browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4242b2ed67e24f903cdae610f27963c93daa37d3

commit 4242b2ed67e24f903cdae610f27963c93daa37d3
Author: James Cook <jamescook@chromium.org>
Date: Tue Aug 28 21:19:33 2018

Revert "chromeos: Fix some login animation code for SingleProcessMash"

This reverts commit adc0e8057d3389c54d498aa5ee38c8305e05ee69.

Reason for revert: Broke single_process_mash_fyi_browser_tests

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20ChromiumOS/34094

UserAddingScreenTest.AddingSeveralUsers
PreferencesTestForceWebUiLogin.MultiProfiles
ChromeSessionManagerTest.LoginExistingUsers
NSSContextChromeOSBrowserTest.TwoUsers
SystemTrayClientClockTest.TestMultiProfile24HourClock

Original change's description:
> chromeos: Fix some login animation code for SingleProcessMash
>
> Most of the animations are supported. This fixes a large number of
> kiosk browser_tests under SingleProcessMash.
>
> Remove an unnecessary workaround for ash process crashes at the login
> screen. Now that we don't have a separate window server process an
> ash crash will result in a clean exit(1) of the browser.
>
> There is still one potential issue with animated avatar icons. I'm
> following up with the graphics guys on that one.
>
> Bug: 756071,  613746 ,  691134 
> Test: OOBE/login with SingleProcessMash, browser_tests *Kiosk*
> Change-Id: Ib72482a3011eabfc6453e7be9e83341063aa4704
> Reviewed-on: https://chromium-review.googlesource.com/1191083
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#586484}

TBR=jamescook@chromium.org,xiyuan@chromium.org

Change-Id: Ic2143414a902fee9a44a95db94d682eb79ce493a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 756071,  613746 ,  691134 
Reviewed-on: https://chromium-review.googlesource.com/1194867
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586854}
[modify] https://crrev.com/4242b2ed67e24f903cdae610f27963c93daa37d3/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/4242b2ed67e24f903cdae610f27963c93daa37d3/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/4242b2ed67e24f903cdae610f27963c93daa37d3/testing/buildbot/filters/chromeos.single_process_mash.fyi.browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e2d55204d52f26d1779c118468702e8aa3395a5

commit 9e2d55204d52f26d1779c118468702e8aa3395a5
Author: James Cook <jamescook@chromium.org>
Date: Wed Aug 29 00:27:08 2018

Reland "chromeos: Fix some login animation code for SingleProcessMash"

This reverts commit 4242b2ed67e24f903cdae610f27963c93daa37d3.

Fixed by skipping login animation when adding a secondary user in a
multiprofile session. Neither SingleProcessMash nor MultiProcessMash
support MultiUserWindowManagerChromeOS, but the login code depends on
it to complete animations for adding new users.

Original change's description:
> Revert "chromeos: Fix some login animation code for SingleProcessMash"
>
> This reverts commit adc0e8057d3389c54d498aa5ee38c8305e05ee69.
>
> Reason for revert: Broke single_process_mash_fyi_browser_tests
>
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20ChromiumOS/34094
>
> UserAddingScreenTest.AddingSeveralUsers
> PreferencesTestForceWebUiLogin.MultiProfiles
> ChromeSessionManagerTest.LoginExistingUsers
> NSSContextChromeOSBrowserTest.TwoUsers
> SystemTrayClientClockTest.TestMultiProfile24HourClock
>
> Original change's description:
> > chromeos: Fix some login animation code for SingleProcessMash
> >
> > Most of the animations are supported. This fixes a large number of
> > kiosk browser_tests under SingleProcessMash.
> >
> > Remove an unnecessary workaround for ash process crashes at the login
> > screen. Now that we don't have a separate window server process an
> > ash crash will result in a clean exit(1) of the browser.
> >
> > There is still one potential issue with animated avatar icons. I'm
> > following up with the graphics guys on that one.
> >
> > Bug: 756071,  613746 ,  691134 
> > Test: OOBE/login with SingleProcessMash, browser_tests *Kiosk*
> > Change-Id: Ib72482a3011eabfc6453e7be9e83341063aa4704
> > Reviewed-on: https://chromium-review.googlesource.com/1191083
> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> > Commit-Queue: James Cook <jamescook@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#586484}
>
> TBR=jamescook@chromium.org,xiyuan@chromium.org
>
> Change-Id: Ic2143414a902fee9a44a95db94d682eb79ce493a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 756071,  613746 ,  691134 
> Reviewed-on: https://chromium-review.googlesource.com/1194867
> Reviewed-by: James Cook <jamescook@chromium.org>
> Commit-Queue: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#586854}

Bug: 756071,  613746 ,  691134 
Change-Id: Ie571456b9e242c70f38cf4771c1afaa3f66cb020
Reviewed-on: https://chromium-review.googlesource.com/1194833
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586962}
[modify] https://crrev.com/9e2d55204d52f26d1779c118468702e8aa3395a5/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/9e2d55204d52f26d1779c118468702e8aa3395a5/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/9e2d55204d52f26d1779c118468702e8aa3395a5/chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc
[modify] https://crrev.com/9e2d55204d52f26d1779c118468702e8aa3395a5/testing/buildbot/filters/chromeos.single_process_mash.fyi.browser_tests.filter