The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3d01a91059fc6ab782b149c840167f1fb2aef53

commit f3d01a91059fc6ab782b149c840167f1fb2aef53
Author: Blake O'Hare <blakeo@chromium.org>
Date: Tue Oct 10 05:02:48 2017

Remove unused #include's in input_method_manager_impl.cc

Which will also help remove some query noise while addressing
crbug.com/756059

Bug: 756059
Change-Id: Ib1ce004001d63f16540b9b5e4dfb6b5ad10c18fd
Reviewed-on: https://chromium-review.googlesource.com/700279
Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507592}
[modify] https://crrev.com/f3d01a91059fc6ab782b149c840167f1fb2aef53/chrome/browser/chromeos/input_method/input_method_manager_impl.cc

Some notes:

This is effectively a cover bug for 3 things that need to happen:

1) SendKeyEvent needs to be refactored in input_method_engine.cc

2) (mentioned in  crbug.com/738531 ) -> Move the CandidateWindow into Ash (used from candidate_window_controller_impl.cc) and then trigger via mojo call

3) (also mentioned in  crbug.com/738531 ) -> Similarly move the ModeIndicator into Ash used from mode_indicator_controller.cc

Hi Shu, could you help triage? Thanks!

Re #4, I opened issue 869737 to track 2).

blakeo@, can you please elaborate more about 1)?
I don't quite understand why SendKeyEvent needs to be refactored.
Thanks!

Re #9, I got it: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/input_method/input_method_engine.cc?l=335.

jamescook@: should ash access be removed in the tests under c/b/chromeos/input_method?

ash/public is the only thing non-ash code should depend upon.

There is some code that should be easily converted to work with single-process mash here. Specifically Shell::GetRootWindowForNewWindows can now use Screen::GetDisplayForNewWindows().

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/031c8b0aa1b1ace5bad989acddf568ddd832e893

commit 031c8b0aa1b1ace5bad989acddf568ddd832e893
Author: Shu Chen <shuchen@google.com>
Date: Thu Aug 16 06:47:19 2018

Cleanup some ash deps under c/b/chromeos/input_method/.

Bug: 756059
Change-Id: Ie76d9b9e8e755f05efbd38c141685f4a3e1da600
Reviewed-on: https://chromium-review.googlesource.com/1175642
Commit-Queue: Shu Chen <shuchen@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583567}
[modify] https://crrev.com/031c8b0aa1b1ace5bad989acddf568ddd832e893/chrome/browser/chromeos/input_method/DEPS
[modify] https://crrev.com/031c8b0aa1b1ace5bad989acddf568ddd832e893/chrome/browser/chromeos/input_method/input_method_engine.cc
[modify] https://crrev.com/031c8b0aa1b1ace5bad989acddf568ddd832e893/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc
[modify] https://crrev.com/031c8b0aa1b1ace5bad989acddf568ddd832e893/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
[modify] https://crrev.com/031c8b0aa1b1ace5bad989acddf568ddd832e893/ui/base/ime/mock_ime_input_context_handler.cc
[modify] https://crrev.com/031c8b0aa1b1ace5bad989acddf568ddd832e893/ui/base/ime/mock_ime_input_context_handler.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c379ddb0084016c3188cd385c8bd316253b2fdd

commit 3c379ddb0084016c3188cd385c8bd316253b2fdd
Author: Shu Chen <shuchen@google.com>
Date: Fri Aug 17 01:51:59 2018

Moves TestImeController from ash/ime/ to c/b/ui/ash/.

So that the input_method_manager_impl_unittest won't depend on ash/.

Bug: 756059
Change-Id: Ibba9f87a05d322489a1778658c5bc4adffd908e4
Reviewed-on: https://chromium-review.googlesource.com/1177217
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583936}
[modify] https://crrev.com/3c379ddb0084016c3188cd385c8bd316253b2fdd/ash/BUILD.gn
[modify] https://crrev.com/3c379ddb0084016c3188cd385c8bd316253b2fdd/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc
[modify] https://crrev.com/3c379ddb0084016c3188cd385c8bd316253b2fdd/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/3c379ddb0084016c3188cd385c8bd316253b2fdd/chrome/browser/ui/ash/ime_controller_client_unittest.cc
[rename] https://crrev.com/3c379ddb0084016c3188cd385c8bd316253b2fdd/chrome/browser/ui/ash/test_ime_controller.cc
[rename] https://crrev.com/3c379ddb0084016c3188cd385c8bd316253b2fdd/chrome/browser/ui/ash/test_ime_controller.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff3c1bc90abe7e1d0ebfdddc2289c2e0388dde39

commit ff3c1bc90abe7e1d0ebfdddc2289c2e0388dde39
Author: Shu Chen <shuchen@google.com>
Date: Sat Aug 18 02:23:29 2018

Removes the ash dependency in TextInputTestHelper.

Bug: 756059
Change-Id: Ieeea588c60e51a95cf89f86ee13cc77b2eba3883
Reviewed-on: https://chromium-review.googlesource.com/1179114
Commit-Queue: Shu Chen <shuchen@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584287}
[modify] https://crrev.com/ff3c1bc90abe7e1d0ebfdddc2289c2e0388dde39/chrome/browser/chromeos/input_method/textinput_browsertest.cc
[modify] https://crrev.com/ff3c1bc90abe7e1d0ebfdddc2289c2e0388dde39/chrome/browser/chromeos/input_method/textinput_surroundingtext_browsertest.cc
[modify] https://crrev.com/ff3c1bc90abe7e1d0ebfdddc2289c2e0388dde39/chrome/browser/chromeos/input_method/textinput_test_helper.cc
[modify] https://crrev.com/ff3c1bc90abe7e1d0ebfdddc2289c2e0388dde39/chrome/browser/chromeos/input_method/textinput_test_helper.h
[modify] https://crrev.com/ff3c1bc90abe7e1d0ebfdddc2289c2e0388dde39/chrome/browser/ui/ash/keyboard_end_to_end_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d7499de9212862a88b3c77212b420a1c48cfea0

commit 5d7499de9212862a88b3c77212b420a1c48cfea0
Author: Scott Violet <sky@chromium.org>
Date: Mon Oct 22 16:02:07 2018

chromeos: get CandidateWindowView to work for mash

The bubble implementation no longer needs the parent, instead it uses
Screen::GetDisplayForNewWindows(), which is what the code was using parent
for before.

BUG=756059
TEST=none

Change-Id: Ia58b6144cc6133027827f23ab240e094027c9a36
Reviewed-on: https://chromium-review.googlesource.com/c/1292513
Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601596}
[modify] https://crrev.com/5d7499de9212862a88b3c77212b420a1c48cfea0/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc
[modify] https://crrev.com/5d7499de9212862a88b3c77212b420a1c48cfea0/chrome/browser/chromeos/input_method/textinput_test_helper.cc
[modify] https://crrev.com/5d7499de9212862a88b3c77212b420a1c48cfea0/ui/chromeos/ime/candidate_window_view.cc

The remaining includes of ash are only in classic mode, so they should be fine (they have been updated with mash-ok). I'm moving this to fixed.

We have one major usage that I am aware of in InputMethodManagerImpl::GetInputMethodKeyboardController().

keyboard::KeyboardController is part of ash. We need to replace calls to this to use ChromeKeyboardControllerClient::Get() instead.

Besides #20, the issue 869737 is still on going and blocking this issue.

Stephen, is InputMethodManagerImpl::GetInputMethodKeyboardController only an issue in multi-process?

Yes, that is correct, this now should only affect Multi-Process Mash. I'll change the label.