New issue
Advanced search Search tips

Issue 756056 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 557405

Blocking:
issue 678705



Sign in to add a comment

mash: Remove ash access from chrome/browser/chromeos/arc

Project Member Reported by jamescook@chromium.org, Aug 16 2017

Issue description

Replace with mojo apis. See ash/README.md and go/mustash.

 
Blockedon: 557405
Blocking: 678705
Components: -Internals>MUS Internals>Services>WindowService
Components: -Internals>Services>WindowService Internals>Services>Ash
Labels: -Proj-Mustash-Mash
Project Member

Comment 5 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a8de9498d9c268aa2a48b35a6dca323702f88bc

commit 9a8de9498d9c268aa2a48b35a6dca323702f88bc
Author: James Cook <jamescook@chromium.org>
Date: Wed May 02 15:30:37 2018

cros: Remove ash reference from ArcKioskAppLauncher

For mustash (out-of-process ash, see //ash/README.md) code in the
browser process cannot call directly into ash.

Pin the kiosk app window by setting a window property instead of
calling into ash code.

Test:
* Add logging to ArcKioskAppLauncher and deploy to Chromebook
* Enterprise enroll Chromebook to test domain
* Move Chromebook to ARC++ test organizational unit
* Sign in and allow policy to force-push app
* Sign out, observe app auto-launch
* Hit escape, see toast saying app is pinned fullscreen
* Observe logs in /var/log/ui/ui.LATEST

Bug:  756056 
Change-Id: I8ac35030bf8b44429096a14ec9a6ad71617e85d8
Reviewed-on: https://chromium-review.googlesource.com/1037775
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555397}
[modify] https://crrev.com/9a8de9498d9c268aa2a48b35a6dca323702f88bc/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_launcher.cc

Owner: jamescook@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment