New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756053 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

pylib.utils failures chromeos perf unit tests

Project Member Reported by warx@chromium.org, Aug 16 2017

Issue description

Labels: -Pri-2 Pri-1
Owner: bsheedy@chromium.org
Status: Assigned (was: Untriaged)
Summary: pylib.utils failures chromeos perf unit tests (was: amd64-generic-telemetry: telemetry_UnitTestsServer.perf failed)
First failing build:
https://uberchromegw.corp.google.com/i/chromiumos.chromium/builders/amd64-generic-telemetry/builds/12171

pylib.utils appears to be missing, and this CL seems to be responsible:
https://chromium-review.googlesource.com/c/608984


Failing stack:
08/15 21:26:58.255 INFO |run_chromeos_tests:0052| [277/323] fetch_benchmark_deps_unittest.FetchBenchmarkDepsUnittest.testFetchOctane failed unexpectedly 0.0531s:
08/15 21:26:58.255 INFO |run_chromeos_tests:0052|   Traceback (most recent call last):
08/15 21:26:58.256 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/tools/perf/fetch_benchmark_deps_unittest.py", line 67, in testFetchOctane
08/15 21:26:58.256 INFO |run_chromeos_tests:0052|       self._RunFetchBenchmarkDepsTest('octane', NormPaths(expected))
08/15 21:26:58.256 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/tools/perf/fetch_benchmark_deps_unittest.py", line 47, in _RunFetchBenchmarkDepsTest
08/15 21:26:58.257 INFO |run_chromeos_tests:0052|       fetch_benchmark_deps.main(args, output)
08/15 21:26:58.257 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/tools/perf/fetch_benchmark_deps.py", line 101, in main
08/15 21:26:58.257 INFO |run_chromeos_tests:0052|       options.benchmark_name, config)
08/15 21:26:58.258 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/benchmark_runner.py", line 276, in GetBenchmarkByName
08/15 21:26:58.258 INFO |run_chromeos_tests:0052|       matched = _MatchBenchmarkName(name, environment, exact_matches=True)
08/15 21:26:58.258 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/benchmark_runner.py", line 263, in _MatchBenchmarkName
08/15 21:26:58.259 INFO |run_chromeos_tests:0052|       for benchmark_class in _Benchmarks(environment):
08/15 21:26:58.259 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/decorators.py", line 35, in Cacher
08/15 21:26:58.259 INFO |run_chromeos_tests:0052|       cacher.__cache[key] = obj(*args, **kwargs)
08/15 21:26:58.260 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/benchmark_runner.py", line 241, in _Benchmarks
08/15 21:26:58.260 INFO |run_chromeos_tests:0052|       index_by_class_name=True).values()
08/15 21:26:58.260 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/common/py_utils/py_utils/discover.py", line 98, in DiscoverClasses
08/15 21:26:58.261 INFO |run_chromeos_tests:0052|       modules = DiscoverModules(start_dir, top_level_dir, pattern)
08/15 21:26:58.261 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/common/py_utils/py_utils/discover.py", line 57, in DiscoverModules
08/15 21:26:58.261 INFO |run_chromeos_tests:0052|       module = __import__(module_name, fromlist=[True])
08/15 21:26:58.262 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/tools/perf/contrib/vr_benchmarks/vr_benchmarks/vr_memory.py", line 12, in <module>
08/15 21:26:58.262 INFO |run_chromeos_tests:0052|       from contrib.vr_benchmarks.vr_page_sets import webvr_sample_pages
08/15 21:26:58.262 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/tools/perf/contrib/vr_benchmarks/vr_page_sets/webvr_sample_pages.py", line 14, in <module>
08/15 21:26:58.263 INFO |run_chromeos_tests:0052|       from contrib.vr_benchmarks.vr_page_sets import (
08/15 21:26:58.263 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/tools/perf/contrib/vr_benchmarks/vr_page_sets/shared_android_vr_page_state.py", line 8, in <module>
08/15 21:26:58.263 INFO |run_chromeos_tests:0052|       from pylib.utils import shared_preference_utils
08/15 21:26:58.264 INFO |run_chromeos_tests:0052|   ImportError: No module named pylib.utils


7 tests are failing:
FetchBenchmarkDepsUnittest.testFetchOctane
FetchBenchmarkDepsUnittest.testFetchServingDirs
FetchBenchmarkDepsUnittest.testFetchWPRs
ScriptsSmokeTest.testRunBenchmarkRunListsOutBenchmarks
ScriptsSmokeTest.testRunBenchmarkRunNonExistingBenchmark
ScriptsSmokeTest.testRunRecordWprList
ScriptsSmokeTest.testRunTrybotWithTypo
Reverting https://chromium-review.googlesource.com/c/608984 would also require reverting https://chromium-review.googlesource.com/c/616320.

//tools/perf:perf includes the necessary files, and the path to the module is added just before the attempted import. Does the failing test not depend on //tools/perf:perf?
Reverts are up at https://chromium-review.googlesource.com/c/617620 and https://chromium-review.googlesource.com/c/617660, although I'll need a committer to LGTM them.

Comment 4 by warx@chromium.org, Aug 17 2017

Status: Fixed (was: Assigned)
amd64-generic-telemetry turns green, thanks

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment