New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 756052 link

Starred by 2 users
Status: Verified
Owner:
mthiesse@chromium.org
Closed: Sep 2017
Cc:
vsupruniuk@google.com
█ leilei@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-XR



Sign in to add a comment

WebVR fails in split screen mode and after exiting split screen mode, and causes crash

Project Member Reported by dbbrooks@chromium.org, Aug 16 2017 
Chrome Version: 62.0.3185.0
OS: Android N
VRCore: 1.8.163477258

What steps will reproduce the problem?
(1) Open Chrome to https://webvr.info/samples/03-vr-presentation.html
(2) Press and hold recent apps button to enter split screen mode
(3) Hit the enter VR button on the webvr samples page

What is the expected result? WebVR 3D presentation mode starts

What happens instead? screen is dimmed, nothing else happens.

(4) exit split screen mode by long pressing the recent apps button

What is the expected result? Nothing

What happens instead? Sometimes the DON flow is triggered, sometimes nothing. If nothing happens, then you press the Enter VR button, you will get an error msg. You can't then enter 3D mode without restarting Chrome. A couple times Chrome crashed at this point. (crash ID's below)


Crash ID's:
53a5f5805869ce1c
41733a20a9601bdf
split_mode.png
546 KB View Download
presentation_denied.png
758 KB View Download

Comment 1 by mthiesse@chromium.org, Aug 16 2017

Labels: Pri-2 Type-Bug-Regression
Owner: mthiesse@chromium.org
Status: Assigned (was: Untriaged)
I'll take a look. This was previously working.

Comment 2 by ddorwin@chromium.org, Sep 12 2017

Components: Blink>WebVR
Labels: -Pri-2 M-63 Pri-1

Comment 3 by mthiesse@chromium.org, Sep 14 2017 

Interestingly I can only repro in landscape. If the phone is in portrait it works as expected.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4d04977de1d314b46ca9343c659e856d4241a13

commit d4d04977de1d314b46ca9343c659e856d4241a13
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Fri Sep 15 19:51:46 2017

VR: Don't wait for window mode to change before entering VR.

VrShellImpl no longer cares which orientation it's in when it's created,
so we can make our VR startup synchronous and fix some bugs caused by
the waiting for window mode changes.

Bug:  756052 
Change-Id: I40dcb76e1c66981ade934d106c1e3520918abb06
Reviewed-on: https://chromium-review.googlesource.com/667926
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502333}
[modify] https://crrev.com/d4d04977de1d314b46ca9343c659e856d4241a13/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/d4d04977de1d314b46ca9343c659e856d4241a13/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Comment 5 by mthiesse@chromium.org, Sep 18 2017

Status: Fixed (was: Assigned)

Comment 6 by dbbrooks@chromium.org, Oct 4 2017

Status: Verified (was: Fixed)
verified in 63.0.3223.7

Comment 7 by btebbs@chromium.org, Jul 4

Components: Internals>XR

Comment 8 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR
►

Sign in to add a comment