New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756048 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

ARIA grids with authoring errors drop content from accessibility tree

Project Member Reported by dmazz...@chromium.org, Aug 16 2017

Issue description

Chrome is currently too strict at dealing with ARIA grids in the event of an authoring error.

A correct grid should look like this:

    <div role="grid">
      <div role="row">
        <div role="gridcell">A1</div>
        <div role="gridcell">B1</div>
      </div>
      <div role="row">
        <div role="gridcell">A2</div>
        <div role="gridcell">B2</div>
      </div>
    </div>

However, authors sometimes make the following errors:

* Extra wrapping elements between the grid and the row
* Extra wrapping elements between the row and the gridcell
* Extra content inside of the grid that's not in a gridcell.

Currently Chrome drops content from grids that's malformed in this way, which is really bad!

We need to fix that.

Some real sites that exhibit this behavior now (may change):

1. http://youtube.com/tv (not intended to be used in a desktop browser, but nevertheless demonstrates this bug) - try to navigate through the shows/movies using a screen reader

2. Quickbooks Online: log into Quickbooks then select Customers, then try to navigate through the content using a screen reader

3. Amazon - this page has an ARIA grid that Chrome drops most or all content from: https://www.amazon.com/gp/offer-listing/B01IENFJ14/ref=sr_1_1_olp?ie=UTF8qid=1500932409sr=8-1keywords=dyson+v8+absolute

 
Here's an HTML page demonstrating the various authoring errors we want to deal with.

The HTML is attached, but here's a JSBin link to try it out directly: http://output.jsbin.com/teqodirude


badgrids.html
2.5 KB View Download
Cc: -aleventhal@chromium.org
Owner: aleventhal@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85a25ac4c5196fa21cf671bd4270a912959aaec2

commit 85a25ac4c5196fa21cf671bd4270a912959aaec2
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Thu Aug 31 20:56:34 2017

Support poorly-authored ARIA grids with extra elements wrapping cells or rows

We should not assume that ARIA grids are authored with a perfect structure.

Bug:  756048 
Change-Id: I84b605f5f83213433fd2be551707b07d3c7c0ac9
Reviewed-on: https://chromium-review.googlesource.com/624069
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498994}
[modify] https://crrev.com/85a25ac4c5196fa21cf671bd4270a912959aaec2/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[add] https://crrev.com/85a25ac4c5196fa21cf671bd4270a912959aaec2/content/test/data/accessibility/aria/aria-grid-extra-wrap-elems-expected-blink.txt
[add] https://crrev.com/85a25ac4c5196fa21cf671bd4270a912959aaec2/content/test/data/accessibility/aria/aria-grid-extra-wrap-elems.html
[modify] https://crrev.com/85a25ac4c5196fa21cf671bd4270a912959aaec2/content/test/data/accessibility/aria/aria-sort-html-table.html
[modify] https://crrev.com/85a25ac4c5196fa21cf671bd4270a912959aaec2/content/test/data/accessibility/aria/table-column-hidden-expected-blink.txt
[modify] https://crrev.com/85a25ac4c5196fa21cf671bd4270a912959aaec2/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp
[modify] https://crrev.com/85a25ac4c5196fa21cf671bd4270a912959aaec2/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.h
[modify] https://crrev.com/85a25ac4c5196fa21cf671bd4270a912959aaec2/third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.cpp
[modify] https://crrev.com/85a25ac4c5196fa21cf671bd4270a912959aaec2/third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.h
[modify] https://crrev.com/85a25ac4c5196fa21cf671bd4270a912959aaec2/third_party/WebKit/Source/modules/accessibility/AXARIAGridRow.cpp
[modify] https://crrev.com/85a25ac4c5196fa21cf671bd4270a912959aaec2/third_party/WebKit/Source/modules/accessibility/AXARIAGridRow.h
[modify] https://crrev.com/85a25ac4c5196fa21cf671bd4270a912959aaec2/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/85a25ac4c5196fa21cf671bd4270a912959aaec2/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/85a25ac4c5196fa21cf671bd4270a912959aaec2/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[modify] https://crrev.com/85a25ac4c5196fa21cf671bd4270a912959aaec2/third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp
[modify] https://crrev.com/85a25ac4c5196fa21cf671bd4270a912959aaec2/third_party/WebKit/Source/modules/accessibility/AXTableCell.h
[modify] https://crrev.com/85a25ac4c5196fa21cf671bd4270a912959aaec2/third_party/WebKit/Source/modules/accessibility/AXTableRow.h

Status: Fixed (was: Started)
Cc: nek...@chromium.org dsexton@chromium.org
 Issue 792045  has been merged into this issue.

Sign in to add a comment