New issue
Advanced search Search tips

Issue 756029 link

Starred by 0 users
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Aug 2017
Cc:
igrigo...@chromium.org
msramek@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 719108



Sign in to add a comment

Privacy changes for the network quality estimates exposed via JS API

Project Member Reported by tbansal@chromium.org, Aug 16 2017 
Three changes needed:

1. Up to 10% random noise should be added to the network quality estimates before exposing it via Javascript API. The noise should be a function of the hostname, and the noise should remain constant for a given hostname.

2. The current bucket size in the network quality estimates is 25 msec (for RTT) and 25 Kbps (for downlink). This means currently the estimate is rounded off to the nearest 25 msec or 25 kbps before exposing it via JS API. The bucket size should be updated to 50 msec / 50 kbps.

3. The upper limit on the estimates should be added. For RTT, the upper limit is 3000 msec, and for kbps it is 10000 kbps.

Comment 1 by tbansal@chromium.org, Aug 16 2017

Cc: igrigo...@chromium.org

Comment 2 by bengr@chromium.org, Aug 16 2017 

Why should the noise be a function of the hostname? Please refer to relevant spec/docs.

Comment 3 by msramek@chromium.org, Aug 16 2017

Components: Privacy
It should be actually origin. No need to deviate from the standard principle that origin is a security boundary.

Comment 4 by tbansal@chromium.org, Aug 16 2017

Labels: -Pri-3 M-62 Pri-2
Corresponding Github bug: https://github.com/WICG/netinfo/issues/64
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f609e92a2ac7f44160901945b55337fcbf5e17a5

commit f609e92a2ac7f44160901945b55337fcbf5e17a5
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Aug 16 18:20:08 2017

Add noise to the network quality estimates.

Up to 10% noise is added to the network quality estimates. The
noise is a function of the hostname.

Update the bucket to 50 msec (from 25 msec), and 50 kbps (from 25 kbps).

Put an upper limit on the RTT and downlink values reported.

Bug:  756029 
Change-Id: Ida1afc14c5e855d8a06857c76d83b9912f663822
Reviewed-on: https://chromium-review.googlesource.com/604887
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494868}
[modify] https://crrev.com/f609e92a2ac7f44160901945b55337fcbf5e17a5/content/browser/net_info_browsertest.cc
[modify] https://crrev.com/f609e92a2ac7f44160901945b55337fcbf5e17a5/third_party/WebKit/LayoutTests/external/wpt/netinfo/netinfo-basics.html
[modify] https://crrev.com/f609e92a2ac7f44160901945b55337fcbf5e17a5/third_party/WebKit/LayoutTests/netinfo/basic-operation.html
[modify] https://crrev.com/f609e92a2ac7f44160901945b55337fcbf5e17a5/third_party/WebKit/LayoutTests/netinfo/estimate-basic-operation.html
[modify] https://crrev.com/f609e92a2ac7f44160901945b55337fcbf5e17a5/third_party/WebKit/LayoutTests/netinfo/estimate-multiple-frames.html
[modify] https://crrev.com/f609e92a2ac7f44160901945b55337fcbf5e17a5/third_party/WebKit/LayoutTests/netinfo/estimate-web-worker.html
[modify] https://crrev.com/f609e92a2ac7f44160901945b55337fcbf5e17a5/third_party/WebKit/LayoutTests/netinfo/network-quality.html
[modify] https://crrev.com/f609e92a2ac7f44160901945b55337fcbf5e17a5/third_party/WebKit/LayoutTests/netinfo/resources/netinfo_common.js
[modify] https://crrev.com/f609e92a2ac7f44160901945b55337fcbf5e17a5/third_party/WebKit/LayoutTests/netinfo/type-change-no-listener.html
[modify] https://crrev.com/f609e92a2ac7f44160901945b55337fcbf5e17a5/third_party/WebKit/LayoutTests/netinfo/unregister-during-event.html
[modify] https://crrev.com/f609e92a2ac7f44160901945b55337fcbf5e17a5/third_party/WebKit/LayoutTests/netinfo/web-worker.html
[modify] https://crrev.com/f609e92a2ac7f44160901945b55337fcbf5e17a5/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
[modify] https://crrev.com/f609e92a2ac7f44160901945b55337fcbf5e17a5/third_party/WebKit/Source/modules/netinfo/NetworkInformation.h
[modify] https://crrev.com/f609e92a2ac7f44160901945b55337fcbf5e17a5/third_party/WebKit/Source/platform/DEPS
[modify] https://crrev.com/f609e92a2ac7f44160901945b55337fcbf5e17a5/third_party/WebKit/Source/platform/network/NetworkStateNotifier.h

Comment 6 by tbansal@chromium.org, Aug 21 2017

Status: Fixed (was: Started)

Comment 7 by tbansal@chromium.org, Aug 21 2017

Blocking: 719108
►

Sign in to add a comment