New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756027 link

Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue 756145
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

system_health.common_desktop failing on chromium.perf/Mac 10.11 Perf

Project Member Reported by simonhatch@chromium.org, Aug 16 2017

Issue description

system_health.common_desktop failing on chromium.perf/Mac 10.11 Perf

Builders failed on: 
- Mac 10.11 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Mac%2010.11%20Perf


Failing page:
- browse:search:google
 
From log:

#
# Fatal error in , line 0
# 

#
# Fatal error in , line 0
# API fatal error handler returned after process out of memoryAPI fatal error handler returned after process out of memory
#

==== C stack trace ===============================


#

==== C stack trace ===============================

    0   d8                                  0x00000001011a9f73 v8::base::debug::StackTrace::StackTrace() + 19
    1   d8                                  0x00000001011ac07b v8::platform::(anonymous namespace)::PrintStackTrace() + 27
    2   d8                                  0x00000001011a7f0c V8_Fatal + 220
    3   d8                                  0x00000001011b9537 v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) + 583
    4   d8                                  0x00000001015e38d4 v8::internal::EvacuateNewSpaceVisitor::Visit(v8::internal::HeapObject*) + 292
    5   d8                                  0x00000001015de96b bool v8::internal::LiveObjectVisitor::VisitBlackObjects<v8::internal::EvacuateNewSpaceVisitor>(v8::internal::MemoryChunk*, v8::internal::MarkingState const&, v8::internal::EvacuateNewSpaceVisitor*, v8::internal::LiveObjectVisitor::IterationMode) + 155
        0   d8                                  0x00000001011a9f73 v8::base::debug::StackTrace::StackTrace() + 19
    1   d8                                  0x00000001011ac07b v8::platform::(anonymous namespace)::PrintStackTrace() + 27
    2   d8                                  0x00000001011a7f0c V8_Fatal + 220
    3   d8                                  0x00000001011b9537 v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) + 583
    4   d8                                  0x00000001015e38d4 v8::internal::EvacuateNewSpaceVisitor::Visit(v8::internal::HeapObject*) + 292
    5   d8                                  0x00000001015de96b bool v8::internal::LiveObjectVisitor::VisitBlackObjects<v8::internal::EvacuateNewSpaceVisitor>(v8::internal::MemoryChunk*, v8::internal::MarkingState const&, v8::internal::EvacuateNewSpaceVisitor*, v8::internal::LiveObjectVisitor::IterationMode) + 155
    6   d8                                  0x00000001015de62c v8::internal::FullEvacuator::EvacuatePage(v8::internal::Page*, v8::internal::MarkingState const&) + 124
    7   d8                                  0x00000001015ec150 v8::internal::PageParallelJob<v8::internal::EvacuationJobTraits>::Task::RunInternal() + 128
    8   d8                                  0x00000001011b2079 v8::platform::WorkerThread::Run() + 25
    9   d8                                  0x00000001011a9787 v8::base::ThreadEntry(void*) + 87
    10  libsystem_pthread.dylib             0x00007fff967f399d _pthread_body + 131
    11  libsystem_pthread.dylib             0x00007fff967f391a _pthread_body + 0
    12  libsystem_pthread.dylib             0x00007fff967f1351 thread_start + 13
6   d8                                  0x00000001015de62c v8::internal::FullEvacuator::EvacuatePage(v8::internal::Page*, v8::internal::MarkingState const&) + 124
    7   d8                                  0x00000001015ec150 v8::internal::PageParallelJob<v8::internal::EvacuationJobTraits>::Task::RunInternal() + 128
    Received signal 4 <unknown> 0001011a8de2
8   d8                                  0x00000001011b2079 v8::platform::WorkerThread::Run() + 25
Unknown stack
[  FAILED  ] /b/s/w/it4h87R8/tmpxCj8k7.html (3215130 ms)
(WARNING) 2017-08-16 01:05:01,807 timeline_based_measurement._ComputeTimelineBasedMetrics:325  Processing resulting traces took 3215.235 seconds
Traceback (most recent call last):
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/value/failure.py", line 41, in _GetExcInfoFromMessage
    raise Exception(message)
Exception: Unknown stack
Owner: u...@chromium.org
Status: Assigned (was: Available)
Assign to ulan@ to triage since this is a v8 issue

Comment 4 by u...@chromium.org, Aug 16 2017

Owner: petermarshall@chromium.org
Thanks for starting bisect.

Ned, please assign future V8 regressions to V8 stability or V8 memory sheriff (go/v8 shows who is the current sheriff)

Assigning to V8 memory sheriff for triaging. Peter, there is nothing actionable until bisect in #2 finishes.


Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30fe4e31e1847faaaf041c51b3601c5f5f5678c9

commit 30fe4e31e1847faaaf041c51b3601c5f5f5678c9
Author: Simon <simonhatch@chromium.org>
Date: Wed Aug 16 17:58:47 2017

Disable system_health.common_desktop page for Mac 10.11

Page:
- browse:search:google

TBR=rnephew@chromium.org

Bug:  756027 
Change-Id: I5f0790a1b6069f4eb06db7614bca4cc7c31eb5ba
Reviewed-on: https://chromium-review.googlesource.com/617261
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494854}
[modify] https://crrev.com/30fe4e31e1847faaaf041c51b3601c5f5f5678c9/tools/perf/page_sets/system_health/expectations.py

Cc: petermarshall@chromium.org
Owner: simonhatch@chromium.org
The bisect has "result": "SUCCESS" but doesn't seem to have actually given a result or posted here in the bug. Could you take a look?
Thanks for bringing this to our attention! Filed https://bugs.chromium.org/p/monorail/issues/detail?id=2984 on the bug not being updated.

It looks like the test passed both on the good AND bad revisions of the bisect: https://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/1698


I kicked off another bisect on the range 494399:494660
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Aug 19 2017

Mergedinto: 756145
Status: Duplicate (was: Assigned)

=== BISECT JOB RESULTS ===
Test failure found with culprit

Suspected Commit
  Author : Greg Kerr
  Commit : 9705b7aaabf4c81d4e9cb13174338df9bde61cc4
  Date   : Tue Aug 15 19:42:42 2017
  Subject: Enable Finch Trial Test for MacV2Sandbox.

Bisect Details
  Configuration: mac_10_11_perf_bisect
  Benchmark    : system_health.common_desktop
  Metric       : timeToFirstContentfulPaint_avg/browse_search/browse_search_google

Revision             Exit Code      N
chromium@494399      0 +- N/A       20      good
chromium@494465      0 +- N/A       20      good
chromium@494498      0 +- N/A       20      good
chromium@494500      0 +- N/A       20      good
chromium@494501      0 +- N/A       20      good
chromium@494502      1 +- N/A       20      bad       <--
chromium@494506      1 +- N/A       20      bad
chromium@494514      1 +- N/A       20      bad
chromium@494530      1 +- N/A       20      bad
chromium@494660      1 +- N/A       20      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.search.google system_health.common_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8970902082475037872


For feedback, file a bug with component Speed>Bisection
I don't think this is a dupe of a Fixed issue? Also what's happening here, I see a commit landed that disabled the test? Is it still failing?
Owner: charliea@chromium.org
Status: Assigned (was: Duplicate)
The test was disabled so someone needs to enable it to ensure it's passing after the fix in  bug 756145 . charliea: can you do that?
I'm kicking off a perf try job to see.
I already did that here: https://chromium-review.googlesource.com/c/624007

Sorry, I should have updated this bug to reflect the fact that I did indeed launch the job.

The job was successful, so I'll go ahead and reenable it now.
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87e1dfe334ce7be241abd99a80cfd84c1fa2e831

commit 87e1dfe334ce7be241abd99a80cfd84c1fa2e831
Author: Charlie Andrews <charliea@chromium.org>
Date: Mon Aug 21 22:25:51 2017

Reenable system_health.common_desktop:browse:search:google

TBR=kerrnel@chromium.org,sullivan@chromium.org
Bug:756027

Change-Id: I2ffec9cac2b49f57e6b59e3eab02047f85472271
Reviewed-on: https://chromium-review.googlesource.com/624007
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496086}
[modify] https://crrev.com/87e1dfe334ce7be241abd99a80cfd84c1fa2e831/tools/perf/page_sets/system_health/expectations.py

I don't see the test failing now, but charliea@ can you confirm that the issue appears resolved?
I see system_health.memory_desktop failing, but is that a different issue?
Status: Fixed (was: Assigned)
Either way, looks like it's not failing anymore, so going to close this as Fixed.

Sign in to add a comment