New issue
Advanced search Search tips

Issue 756009 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Add SUBRESOURCE_FILTER metadata parsing in SafeBrowsing V4

Project Member Reported by csharrison@chromium.org, Aug 16 2017

Issue description

We need to distinguish between
 - Abusive ads violating sites
 - Better ads standards violating sites
 - both

Additionally, we are interested in adding
 - A "warning" bit to just log devtools messages
 - An "experimental" bit to only enforce on specific finch configurations.
 
Labels: -Type-Bug SafeBrowsing-Triaged Type-Feature
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/374b428695e3b72d188a08c6009b1e8862539621

commit 374b428695e3b72d188a08c6009b1e8862539621
Author: Charles Harrison <csharrison@chromium.org>
Date: Wed Aug 23 15:35:55 2017

Add metadata for subresource filter list

This adds the following metadata:
key: "sf_pattern_type"
values: {"BETTER_ADS", "ABUSIVE_ADS", "ALL_ADS"}

key: "experimental"
values: {"true", "false"}

Bug:  756009 
Change-Id: I8dbd3498ee59014fd64b4583ab8cdd99c2ab361f
Reviewed-on: https://chromium-review.googlesource.com/616120
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Varun Khaneja (slow) <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496692}
[modify] https://crrev.com/374b428695e3b72d188a08c6009b1e8862539621/components/safe_browsing/db/safe_browsing_api_handler_unittest.cc
[modify] https://crrev.com/374b428695e3b72d188a08c6009b1e8862539621/components/safe_browsing/db/safe_browsing_api_handler_util.cc
[modify] https://crrev.com/374b428695e3b72d188a08c6009b1e8862539621/components/safe_browsing_db/metadata.proto
[modify] https://crrev.com/374b428695e3b72d188a08c6009b1e8862539621/components/safe_browsing_db/util.h
[modify] https://crrev.com/374b428695e3b72d188a08c6009b1e8862539621/components/safe_browsing_db/v4_get_hash_protocol_manager.cc
[modify] https://crrev.com/374b428695e3b72d188a08c6009b1e8862539621/components/safe_browsing_db/v4_get_hash_protocol_manager.h
[modify] https://crrev.com/374b428695e3b72d188a08c6009b1e8862539621/components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc
[modify] https://crrev.com/374b428695e3b72d188a08c6009b1e8862539621/tools/metrics/histograms/enums.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbd2d4434be6efa22b94705a4a353baf27ca70dd

commit dbd2d4434be6efa22b94705a4a353baf27ca70dd
Author: Charles Harrison <csharrison@chromium.org>
Date: Tue Oct 03 21:31:15 2017

[subresource_filter] Implement warning metadata

This patch introduces new metadata parsing for SafeBrowsing.

This patch also beefs up test infrastructure so browser tests can
insert entries with arbitrary metadata into lists.

Bug:  756009 
Change-Id: I2aad6348c6b9ec41b223a46c318b41f6a137221b
Reviewed-on: https://chromium-review.googlesource.com/682654
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506183}
[modify] https://crrev.com/dbd2d4434be6efa22b94705a4a353baf27ca70dd/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify] https://crrev.com/dbd2d4434be6efa22b94705a4a353baf27ca70dd/chrome/browser/safe_browsing/test_safe_browsing_database_helper.cc
[modify] https://crrev.com/dbd2d4434be6efa22b94705a4a353baf27ca70dd/chrome/browser/safe_browsing/test_safe_browsing_database_helper.h
[modify] https://crrev.com/dbd2d4434be6efa22b94705a4a353baf27ca70dd/chrome/browser/safe_browsing/v4_test_utils.cc
[modify] https://crrev.com/dbd2d4434be6efa22b94705a4a353baf27ca70dd/chrome/browser/safe_browsing/v4_test_utils.h
[modify] https://crrev.com/dbd2d4434be6efa22b94705a4a353baf27ca70dd/chrome/browser/subresource_filter/subresource_filter_browser_test_harness.cc
[modify] https://crrev.com/dbd2d4434be6efa22b94705a4a353baf27ca70dd/components/safe_browsing/db/safe_browsing_api_handler_unittest.cc
[modify] https://crrev.com/dbd2d4434be6efa22b94705a4a353baf27ca70dd/components/safe_browsing/db/safe_browsing_api_handler_util.cc
[modify] https://crrev.com/dbd2d4434be6efa22b94705a4a353baf27ca70dd/components/safe_browsing/db/util.cc
[modify] https://crrev.com/dbd2d4434be6efa22b94705a4a353baf27ca70dd/components/safe_browsing/db/util.h
[modify] https://crrev.com/dbd2d4434be6efa22b94705a4a353baf27ca70dd/components/safe_browsing/db/v4_get_hash_protocol_manager.cc
[modify] https://crrev.com/dbd2d4434be6efa22b94705a4a353baf27ca70dd/components/safe_browsing/db/v4_get_hash_protocol_manager_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3db74558a1e9978a3ff9e84a5773358545141d9e

commit 3db74558a1e9978a3ff9e84a5773358545141d9e
Author: Shivani Sharma <shivanisha@chromium.org>
Date: Wed Oct 11 20:10:00 2017

[subresource_filter] Warning metadata bit should lead to logging console
message.

Warning sites should also have their activation state marked as disabled
as we do not them to have resource blocking / pop up blocking.

Bug:  756009 
Change-Id: Ied23c4b373e33a110a5fa6b85ee2333201191afb
Reviewed-on: https://chromium-review.googlesource.com/702776
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508087}
[modify] https://crrev.com/3db74558a1e9978a3ff9e84a5773358545141d9e/chrome/browser/subresource_filter/subresource_filter_browser_test_harness.cc
[modify] https://crrev.com/3db74558a1e9978a3ff9e84a5773358545141d9e/chrome/browser/subresource_filter/subresource_filter_browser_test_harness.h
[modify] https://crrev.com/3db74558a1e9978a3ff9e84a5773358545141d9e/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
[modify] https://crrev.com/3db74558a1e9978a3ff9e84a5773358545141d9e/chrome/browser/subresource_filter/subresource_filter_popup_browsertest.cc
[modify] https://crrev.com/3db74558a1e9978a3ff9e84a5773358545141d9e/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
[modify] https://crrev.com/3db74558a1e9978a3ff9e84a5773358545141d9e/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h
[modify] https://crrev.com/3db74558a1e9978a3ff9e84a5773358545141d9e/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc
[modify] https://crrev.com/3db74558a1e9978a3ff9e84a5773358545141d9e/components/subresource_filter/core/browser/subresource_filter_constants.h

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/890f8aa05f9b11c35237cc5d8e084a7c6eec7575

commit 890f8aa05f9b11c35237cc5d8e084a7c6eec7575
Author: Charles Harrison <csharrison@chromium.org>
Date: Tue Oct 31 00:26:14 2017

AbusiveExperienceEnforce: add end to end safe browsing test

This CL adds a new harness to the safe browsing triggered popup
blocker browser test which mocks HTTP responses from the safe browsing
server.

It also tweaks the ScopedLoggingObserver to stop listening (globally)
on messages when it is destroyed, and it only considers messages that
have come in since it is instantiated.

Bug:  756009 , 756089 
Change-Id: I2ad8bcebbdaf09252fa323e9de49c0de943e372b
Reviewed-on: https://chromium-review.googlesource.com/731406
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512689}
[modify] https://crrev.com/890f8aa05f9b11c35237cc5d8e084a7c6eec7575/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_browsertest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5734f6cffa1a71c25043ee82ec7e67c0f3e06756

commit 5734f6cffa1a71c25043ee82ec7e67c0f3e06756
Author: Matt Menke <mmenke@chromium.org>
Date: Tue Oct 31 09:41:55 2017

Disable failing tests when the network service is enabled.

SafeBrowsingTriggeredInterceptingBrowserTest.AbusiveMetadata: new test.
SSLUITestCommittedInterstitials.ErrorPageType: new test.

virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html:
old test, flaking a lot (And did my last shift, too).

TBR=mmenke@chromium.org

Bug:  729849 , 756009 , 756089 , 778857 
Change-Id: I08ef0853db0d709e57ce2eb4ca1d3ac3960b6bcc
Reviewed-on: https://chromium-review.googlesource.com/746363
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512791}
[modify] https://crrev.com/5734f6cffa1a71c25043ee82ec7e67c0f3e06756/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/5734f6cffa1a71c25043ee82ec7e67c0f3e06756/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation

Status: Fixed (was: Started)

Sign in to add a comment