New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756008 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

11.6%-71.9% regression in memory.desktop at 494048:494171

Project Member Reported by ellenpli@google.com, Aug 16 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 16 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=756008

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=09232d5de576a4f33537b556d4a731ffe4b5c47b008c1f2d241404e6e03d287f


Bot(s) for this bug's original alert(s):

chromium-rel-mac12
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 16 2017

Cc: jbau...@chromium.org
Owner: jbau...@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author jbauman@chromium.org ===

Hi jbauman@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : jbauman
  Commit : 20bcdb14c7a6f0801522d23693f530d4f224d727
  Date   : Mon Aug 14 19:44:30 2017
  Subject: Revert of Allow creating GLImage-backed textures with glTexStorage2D. (patchset #7 id:120001 of https://codereview.chromium.org/2945673002/ )

Bisect Details
  Configuration: mac_10_12_perf_bisect
  Benchmark    : memory.desktop
  Metric       : memory:chrome:all_processes:reported_by_chrome:gpu:effective_size_avg/TrivialGifPageSharedPageState
  Change       : 56.12% | 15561532.0 -> 24294408.0

Revision             Result                       N
chromium@494047      15561532 +- 3.72529e-09      6      good
chromium@494109      15561532 +- 0.0              6      good
chromium@494125      15561532 +- 0.0              6      good
chromium@494133      15561532 +- 0.0              6      good
chromium@494137      15561532 +- 0.0              6      good
chromium@494138      24854195 +- 3878316          6      bad       <--
chromium@494139      25413981 +- 3066078          6      bad
chromium@494140      24689644 +- 4502787          6      bad
chromium@494171      24294408 +- 4113575          6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=TrivialGifPageSharedPageState memory.desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8971091698122520912


For feedback, file a bug with component Speed>Bisection
Owner: sunn...@chromium.org
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Aug 16 2017

Cc: liber...@chromium.org
 Issue 756108  has been merged into this issue.
Status: WontFix (was: Assigned)
This is because of a revert. The revert itself was because of a perf regression caused by that CL (see  issue 755136 ), though it's nice to see that there was an improvement too.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Aug 17 2017

 Issue 756079  has been merged into this issue.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Aug 17 2017

 Issue 756078  has been merged into this issue.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Aug 21 2017

Cc: liberato@google.com
 Issue 757305  has been merged into this issue.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Aug 21 2017

 Issue 757324  has been merged into this issue.

Sign in to add a comment