Potential memory leak in resource coordinator |
|||
Issue descriptionA Chrome browser with native-heap-profiling was navigating random webpages for multiple days. A memory dump (chrome://tracing) was grabbed to look to objects alive. They are pointing to potential memory leaks. This was tested on a recent Canary M62 on windows 10, for more than 5 days. The culprit seems to be: resource_coordinator::MetricsCollector::OnWebContentsPropertyChanged See attached stackframe for more details. * 120K objects are alive, which are retaining 6.7M bytes.
,
Aug 16 2017
os-arch: "x86_64", os-name: "Windows NT", revision: "cdd15784955039742fe9a8235581922d41b82d78-refs/heads/master@{#492239}", product-version: "Chrome/62.0.3178.0",
,
Aug 18 2017
It looks like we didn't remove entry from the map and the map grows too big. I am fixing this in one of my patches.
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4 commit 9d35d8488f3d49d73d1bd38d5e496fbae6c403f4 Author: Peiyong Lin <lpy@chromium.org> Date: Mon Aug 21 23:18:37 2017 [GRC] Report first alert fired UMA for background tabs. This patch adds UMA histogram to report first alert fired happen for background tabs, histogram records the time from when the tab becomes background to when a JavaScript alert is fired. Minor fix: Remove entry from web_contents_data_map_ when WebContentsCoordinationUnit is destroyed. BUG= 731270 , 756004 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: If04a495aef60d7e300177271547a472792da5c3b Reviewed-on: https://chromium-review.googlesource.com/614913 Commit-Queue: lpy <lpy@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Zhen Wang <zhenw@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#496113} [modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/services/resource_coordinator/coordination_unit/coordination_unit_graph_observer.h [modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.cc [modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.h [modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/services/resource_coordinator/coordination_unit/metrics_collector.cc [modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/services/resource_coordinator/coordination_unit/metrics_collector.h [modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/services/resource_coordinator/coordination_unit/metrics_collector_unittest.cc [modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/services/resource_coordinator/public/interfaces/signals.mojom [modify] https://crrev.com/9d35d8488f3d49d73d1bd38d5e496fbae6c403f4/tools/metrics/histograms/histograms.xml
,
Aug 22 2017
Marked as fixed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by etienneb@chromium.org
, Aug 16 2017