[cronet] cronet_impl_platform_proguard.cfg should not contain chromium classes |
||||
Issue descriptionSome dontwarns were added as a part of a test change (https://codereview.chromium.org/2935503002). We should revisit this to see why exactly these dontwarns are needed. # https://android.googlesource.com/platform/sdk/+/marshmallow-mr1-release/files/proguard-android.txt#54 -dontwarn android.support.** # Generated for chrome apk and not included into cronet. -dontwarn org.chromium.base.BuildConfig -dontwarn org.chromium.base.library_loader.NativeLibraries -dontwarn org.chromium.base.multidex.ChromiumMultiDexInstaller
,
Aug 16 2017
Thanks for the fix!
,
Aug 16 2017
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afd79e70c1013387ff49115098d4a3265c26f8bf commit afd79e70c1013387ff49115098d4a3265c26f8bf Author: Paul Jensen <pauljensen@chromium.org> Date: Wed Aug 16 16:57:33 2017 [Cronet] Move test change to from production proguard file to test one. Reverts crrev.com/489896 change to a production proguard file and moves the new lines to a test proguard file. Bug: 755999 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I9924365e905f6c4a7f3d667eb3dc7eacac3d7d12 Reviewed-on: https://chromium-review.googlesource.com/616960 Reviewed-by: Helen Li <xunjieli@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#494829} [modify] https://crrev.com/afd79e70c1013387ff49115098d4a3265c26f8bf/components/cronet/android/cronet_impl_platform_proguard.cfg [modify] https://crrev.com/afd79e70c1013387ff49115098d4a3265c26f8bf/components/cronet/android/test/proguard.cfg
,
Aug 16 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by pauljensen@chromium.org
, Aug 16 2017