Issue metadata
Sign in to add a comment
|
45 kb regression in resource_sizes (MonochromePublic.apk) at 494376:494376 |
||||||||||||||||||||
Issue descriptionCaused by "Switch SkSL to std::string." Commit 6573882a8924b04644910dc3cf42a790cdb01d39 (part of Skia roll, actual commit: 93ba0a4fc85f04bc1be9429983df1e57473b49a7) Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=494376 Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase
,
Aug 16 2017
Thanks for the heads up. Yes, the performance wins (within the framework, and elsewhere) were pretty significant. Getting a std::string fix globally would be nice, and we're still looking at follow-up changes to get the same perf wins in other ways. For now, we'd like to keep this in, though. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by estevenson@chromium.org
, Aug 16 2017Cc: estevenson@chromium.org
Labels: -Pri-3 Pri-2
Owner: brianosman@chromium.org
Status: Assigned (was: Available)