New issue
Advanced search Search tips

Issue 755991 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression

Blocked on:
issue 738155



Sign in to add a comment

45 kb regression in resource_sizes (MonochromePublic.apk) at 494376:494376

Project Member Reported by estevenson@chromium.org, Aug 16 2017

Issue description

Blockedon: 738155
Cc: estevenson@chromium.org
Labels: -Pri-3 Pri-2
Owner: brianosman@chromium.org
Status: Assigned (was: Available)
brianosman@ - It's not clear to me whether or not this increase was expected. However, we already have an issue tracking adding noinline to std::string constructors so there might not be anything to do here at this time.

Feel free to close as "Won't Fix" if you think the performance gains are worth the 45 kb while we look at changing std::string itself.
Status: WontFix (was: Assigned)
Thanks for the heads up. Yes, the performance wins (within the framework, and elsewhere) were pretty significant. Getting a std::string fix globally would be nice, and we're still looking at follow-up changes to get the same perf wins in other ways. For now, we'd like to keep this in, though.

Sign in to add a comment