RemoteSuggestionsDatabaseTest.SavePersist is flaky |
||||||
Issue descriptionLooks like it has been flaky for a long while, see https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=components_unittests&tests=RemoteSuggestionsDatabaseTest.SavePersist. Example log: [ RUN ] RemoteSuggestionsDatabaseTest.SavePersist [2598:19971:0812/000740.342654:885845925623:WARNING:leveldb_database.cc(81)] Unable to open /var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.HWzZNc/snippets: IO error: /var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.HWzZNc/snippets/LOCK: Lock file already locked. (ChromeMethodOnly: 15::LockFile) ../../components/ntp_snippets/remote/remote_suggestions_database_unittest.cc:205: Failure Actual function call count doesn't match EXPECT_CALL(*this, OnImageLoaded(image_data))... Expected: to be called once Actual: never called - unsatisfied and active ../../components/ntp_snippets/remote/remote_suggestions_database_unittest.cc:201: Failure Actual function call count doesn't match EXPECT_CALL(*this, OnSnippetsLoadedImpl(ElementsAre(PointeeEq(snippet.get()))))... Expected: to be called once Actual: never called - unsatisfied and active [ FAILED ] RemoteSuggestionsDatabaseTest.SavePersist (92 ms) I'll go ahead and disable the test.
,
Aug 16 2017
Sigh, I guess that's what you get when you do disk I/O in a unit test :( These tests should use a FakeDB instead of an actual ProtoDatabaseImpl. CCing some more folks who might have cycles to take this over.
,
Aug 17 2017
,
Oct 13 2017
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34f124ce2d3050095f21fafd73da141d983d849d commit 34f124ce2d3050095f21fafd73da141d983d849d Author: Marc Treib <treib@chromium.org> Date: Tue Oct 17 18:44:12 2017 Rewrite RemoteSuggestionsDatabaseTests to use FakeDB Previously, these tests used real databases, including disk I/O. Better to use fakes for unit tests. Bug: 755985 Change-Id: Icb9043593ff3bce6f54b9803294cf81a0944d4b3 Reviewed-on: https://chromium-review.googlesource.com/720810 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#509450} [modify] https://crrev.com/34f124ce2d3050095f21fafd73da141d983d849d/components/ntp_snippets/remote/remote_suggestions_database.cc [modify] https://crrev.com/34f124ce2d3050095f21fafd73da141d983d849d/components/ntp_snippets/remote/remote_suggestions_database.h [modify] https://crrev.com/34f124ce2d3050095f21fafd73da141d983d849d/components/ntp_snippets/remote/remote_suggestions_database_unittest.cc
,
Oct 18 2017
That should do it.
,
Jan 24 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Aug 16 2017