Issue metadata
Sign in to add a comment
|
40%-432.9% regression in loading.desktop at 494048:494274 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 16 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8971096278049157488
,
Aug 16 2017
=== BISECT JOB RESULTS === NO Perf regression found Bisect Details Configuration: winx64intel_perf_bisect Benchmark : loading.desktop Metric : timeToFirstMeaningfulPaint_avg/pcv1-warm/goo.ne.jp Revision Result N chromium@494089 3082.58 +- 1352.82 21 good chromium@494204 3027.13 +- 1509.05 21 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=goo.ne.jp loading.desktop More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8971096278049157488 For feedback, file a bug with component Speed>Bisection
,
Sep 21 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8967815457490312608
,
Sep 21 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8967815413081824192
,
Sep 21 2017
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/15f02c2fb80000
,
Sep 21 2017
There seem to be multiple steps up and down here. Excited to see if we get a result from pinpoint in #6.
,
Sep 21 2017
📍 Pinpoint job completed. https://pinpoint-dot-chromeperf.appspot.com/job/15f02c2fb80000 Convert loading.desktop page set to WprGo By ksakamoto@chromium.org · Tue Aug 15 04:08:53 2017 chromium@ca2e6be7bac44462efdd864ef346311b9a6033de Change error pages to use a new chrome-error:// scheme. By alexmos@chromium.org · Wed Aug 16 16:20:00 2017 chromium@71f48559772345f1005a0e24eb27b01feada9439
,
Sep 21 2017
ksakamoto, kouhei: results of the pinpoint job in #8 are interesting. you can see that the test stops producing values at the WPR conversion CL: Convert loading.desktop page set to WprGo By ksakamoto@chromium.org · Tue Aug 15 04:08:53 2017 chromium@ca2e6be7bac44462efdd864ef346311b9a6033de Then it starts again at "Change error pages to use a new chrome-error:// scheme." but that CL seems unrelated. Could the WprGo conversion have made the test flaky?
,
Sep 21 2017
=== Auto-CCing suspected CL author ksakamoto@chromium.org === Hi ksakamoto@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Kunihiko Sakamoto Commit : ca2e6be7bac44462efdd864ef346311b9a6033de Date : Tue Aug 15 04:08:53 2017 Subject: Convert loading.desktop page set to WprGo Bisect Details Configuration: winx64intel_perf_bisect Benchmark : loading.desktop Metric : timeToFirstMeaningfulPaint_avg/pcv1-cold/goo.ne.jp Change : 125.42% | 1639.98916668 -> 3696.91133334 Revision Result N chromium@494018 1639.99 +- 159.089 6 good chromium@494171 1589.93 +- 25.1249 6 good chromium@494248 1594.46 +- 54.6044 6 good chromium@494286 1589.04 +- 28.5577 6 good chromium@494305 1614.89 +- 92.2649 6 good chromium@494315 1595.1 +- 39.7738 6 good chromium@494320 1591.59 +- 33.6109 6 good chromium@494322 1605.9 +- 61.8315 6 good chromium@494323 3915.88 +- 1090.37 6 bad <-- chromium@494324 3696.91 +- 287.058 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=goo.ne.jp loading.desktop More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8967815413081824192 For feedback, file a bug with component Speed>Bisection
,
Sep 21 2017
=== BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Kunihiko Sakamoto Commit : ca2e6be7bac44462efdd864ef346311b9a6033de Date : Tue Aug 15 04:08:53 2017 Subject: Convert loading.desktop page set to WprGo Bisect Details Configuration: winx64nvidia_perf_bisect Benchmark : loading.desktop Metric : timeToFirstMeaningfulPaint_avg/pcv1-cold/goo.ne.jp Change : 130.31% | 1612.23183334 -> 3713.05550002 Revision Result N chromium@494015 1612.23 +- 108.362 6 good chromium@494170 1608.29 +- 53.3574 6 good chromium@494247 1607.51 +- 49.1036 6 good chromium@494286 1616.17 +- 80.8547 6 good chromium@494305 1600.94 +- 33.8684 6 good chromium@494315 1597.91 +- 15.5041 6 good chromium@494320 1606.22 +- 60.955 6 good chromium@494322 1599.64 +- 32.0254 6 good chromium@494323 3824.68 +- 890.258 6 bad <-- chromium@494324 3713.06 +- 219.887 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=goo.ne.jp loading.desktop More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8967815457490312608 For feedback, file a bug with component Speed>Bisection
,
Sep 22 2017
The PremierLeague story causes redirect loop after the WprGo conversion. We should re-record this page. The "Change error pages to use a new chrome-error:// scheme." CL is actually relevant. We blacklisted error page URL (data:text/html,chromewebdata) but it no longer works and loading metrics are reported for the chrome-error:// page.
,
Sep 22 2017
,
Sep 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1a6004a1f74be41be5ae08096247f1cfa4acd7b commit b1a6004a1f74be41be5ae08096247f1cfa4acd7b Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Mon Sep 25 04:33:00 2017 Roll src/third_party/catapult/ fdacc64db..a8018a628 (1 commit) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/fdacc64db061..a8018a6284d0 $ git log fdacc64db..a8018a628 --date=short --no-merges --format='%ad %ae %s' 2017-09-24 ksakamoto Update error page URL in loading_metric blacklist Created with: roll-dep src/third_party/catapult BUG= 755983 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib8a58800671406e5156130a0e526b8d382483332 Reviewed-on: https://chromium-review.googlesource.com/680395 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#503979} [modify] https://crrev.com/b1a6004a1f74be41be5ae08096247f1cfa4acd7b/DEPS
,
Jan 5 2018
ksakamoto: Is this bug fixed with the CL in #14?
,
Jan 15 2018
Yes, closing. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Aug 16 2017