New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 755961 link

Starred by 2 users
Status: Verified
Owner:
gambard@chromium.org
Closed: Aug 2017
Cc:
mard...@chromium.org
█ nepper@chromium.org
█ noyau@chromium.org
pinkerton@chromium.org
amyroberts@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Use a single switch for controlling omnibox suggestions and content suggestions

Project Member Reported by gambard@chromium.org, Aug 16 2017 
What steps will reproduce the problem?
 With ContentSuggestions enabled
(1) Open Chrome -> Settings -> Privacy

What is the expected result?
Only one switch should be present with "Search and sites suggestions". It should enable the omnibox suggestions and the content suggestions on the NTP.

What happens instead?
The switches are split in two:
- "Search and site suggestions" controlling the omnibox suggestions
- "Article suggestions" controlling the content suggestions.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5404ed9129e67321c37a455469e91dcfcc202f3b

commit 5404ed9129e67321c37a455469e91dcfcc202f3b
Author: gambard <gambard@chromium.org>
Date: Thu Aug 17 11:33:11 2017

Merge omnibox and content suggestions settings

The privacy settings controlling the suggestions displayed in the NTP
and omnibox need to be merged in one.

Bug:  755961 
Change-Id: I015d859a1ffa07baee7d0391a96a0ae8035587ae
Reviewed-on: https://chromium-review.googlesource.com/616774
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495140}
[modify] https://crrev.com/5404ed9129e67321c37a455469e91dcfcc202f3b/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/5404ed9129e67321c37a455469e91dcfcc202f3b/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory_util.cc
[modify] https://crrev.com/5404ed9129e67321c37a455469e91dcfcc202f3b/ios/chrome/browser/pref_names.cc
[modify] https://crrev.com/5404ed9129e67321c37a455469e91dcfcc202f3b/ios/chrome/browser/pref_names.h
[modify] https://crrev.com/5404ed9129e67321c37a455469e91dcfcc202f3b/ios/chrome/browser/prefs/browser_prefs.mm
[modify] https://crrev.com/5404ed9129e67321c37a455469e91dcfcc202f3b/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm
[modify] https://crrev.com/5404ed9129e67321c37a455469e91dcfcc202f3b/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm

Comment 2 by gambard@chromium.org, Aug 17 2017

Status: Fixed (was: Assigned)

Comment 3 by subhashi...@chromium.org, Aug 22 2017

Status: Verified (was: Fixed)
Verified in:

App Version: 62.0.3193.0 canary
iOS Version: 10.3.3, 11.0 beta 7
Devices: iPhone 5, iPhone 7 Plus, iPad Air 2

Only one option 'Search and Site Suggestions' is available in Menu>Settings>privacy which controls the content suggestions displayed in NTP and Omnibox. Please See the screenshot attached.
SearchandShowSuggestions.PNG
159 KB View Download
►

Sign in to add a comment