Needs to add padding in the account chooser view |
|||||
Issue descriptionCreating an Android bug for crbug.com/739151#c7
,
Aug 16 2017
Nice, that looks better to me. Amy - can you confirm and then re-assign to Boris?
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8790e7502782f58a1b4f8a6b89cadaab70a5fee5 commit 8790e7502782f58a1b4f8a6b89cadaab70a5fee5 Author: Boris Sazonov <bsazonov@chromium.org> Date: Thu Aug 17 13:23:51 2017 [Android] Add top padding to button bar in AccountSigninView This CL adds 16dp padding on top of the button bar in AccountSigninView so a tap slightly above the buttons won't hit an account row. Bug: 755947 Change-Id: I6e6e3cb500af585da0a67f836d459441c0d55c22 Reviewed-on: https://chromium-review.googlesource.com/617780 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#495157} [modify] https://crrev.com/8790e7502782f58a1b4f8a6b89cadaab70a5fee5/chrome/android/java/res/layout/account_signin_view.xml
,
Aug 17 2017
Amy, I've just landed CL with 16dp padding on top of button bar according to your specs in https://crbug.com/739151#c7 . Happy to make amendments if you want any.
,
Aug 17 2017
Marking it as assigned to make sure Amy sees it. Amy, if it looks good to you, feel free to mark as fixed.
,
Aug 21 2017
LGTM |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bsazonov@chromium.org
, Aug 16 2017192 KB
192 KB View Download
206 KB
206 KB View Download