New issue
Advanced search Search tips

Issue 755947 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Needs to add padding in the account chooser view

Project Member Reported by jlebel@chromium.org, Aug 16 2017

Issue description

Creating an Android bug for  crbug.com/739151#c7 


 
Status: Started (was: Assigned)
Layout with 16dp padding on top of button bar.
DeviceScreenshot_2017-08-16_21:12:51.png
192 KB View Download
DeviceScreenshot_2017-08-16_18:18:58.png
206 KB View Download

Comment 2 by ew...@chromium.org, Aug 16 2017

Cc: bsazonov@chromium.org
Owner: amyroberts@chromium.org
Nice, that looks better to me. Amy - can you confirm and then re-assign to Boris?
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8790e7502782f58a1b4f8a6b89cadaab70a5fee5

commit 8790e7502782f58a1b4f8a6b89cadaab70a5fee5
Author: Boris Sazonov <bsazonov@chromium.org>
Date: Thu Aug 17 13:23:51 2017

[Android] Add top padding to button bar in AccountSigninView

This CL adds 16dp padding on top of the button bar in AccountSigninView
so a tap slightly above the buttons won't hit an account row.

Bug:  755947 
Change-Id: I6e6e3cb500af585da0a67f836d459441c0d55c22
Reviewed-on: https://chromium-review.googlesource.com/617780
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495157}
[modify] https://crrev.com/8790e7502782f58a1b4f8a6b89cadaab70a5fee5/chrome/android/java/res/layout/account_signin_view.xml

Components: Services>SignIn UI>Browser>Profiles
Amy, I've just landed CL with 16dp padding on top of button bar according to your specs in  https://crbug.com/739151#c7 . Happy to make amendments if you want any.

Comment 5 by ew...@chromium.org, Aug 17 2017

Status: Assigned (was: Started)
Marking it as assigned to make sure Amy sees it.

Amy, if it looks good to you, feel free to mark as fixed.
Status: Fixed (was: Assigned)
LGTM

Sign in to add a comment