PrerenderingOffliner is disabled in trunk and in Finch (according to OfflinePageBackgroundLoader.json), should be removable now.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9e69daaec55e841dcb7abf4645346dc8351ca3b commit e9e69daaec55e841dcb7abf4645346dc8351ca3b Author: Egor Pasko <pasko@chromium.org> Date: Wed Sep 06 00:47:59 2017 offline_pages: always use BackgroundLoader in eval test This removed one instance of PrerenderingOffliner. Hopefully there is no need to evaluate how the prerendering-based offliner performs. But assuming that the run_offline_page_evaluation_test.py is still useful. Confirmed locally that chrome_apk builds with enable_offline_pages_harness = true. Bug: 755934 Change-Id: Id1a871a6573fd7df596276819f1b0ea086e7a394 Reviewed-on: https://chromium-review.googlesource.com/649628 Reviewed-by: Peter Williamson <petewil@chromium.org> Reviewed-by: Yafei Duan <romax@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#499820} [modify] https://crrev.com/e9e69daaec55e841dcb7abf4645346dc8351ca3b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/evaluation/OfflinePageEvaluationBridge.java [modify] https://crrev.com/e9e69daaec55e841dcb7abf4645346dc8351ca3b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java [modify] https://crrev.com/e9e69daaec55e841dcb7abf4645346dc8351ca3b/chrome/browser/offline_pages/android/evaluation/offline_page_evaluation_bridge.cc [modify] https://crrev.com/e9e69daaec55e841dcb7abf4645346dc8351ca3b/chrome/browser/offline_pages/android/evaluation/run_offline_page_evaluation_test.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4203e8d9998b078d9bdbb8a1e610bc95b1280806 commit 4203e8d9998b078d9bdbb8a1e610bc95b1280806 Author: Egor Pasko <pasko@chromium.org> Date: Fri Sep 08 16:02:16 2017 offline_pages: Use BackgroundLoader unconditionally Remove PrerenderingOffliner which eliminates about 2KiB of binary code from .text on Android. Also some cleanup: * remove the associated base::Feature * remove all layers in offline_pages that PrerenderingOffliner solely depended on * change comments to refer to background loader instead of prerender (there are still a few references to prerender in association with user-initiated prerender disabling, which is respected by background loader afaict) Bug: 755934 Change-Id: I94278d3e0fd72ee27beafeaa52a887d1d676bbe0 Reviewed-on: https://chromium-review.googlesource.com/655239 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#500602} [modify] https://crrev.com/4203e8d9998b078d9bdbb8a1e610bc95b1280806/chrome/browser/BUILD.gn [modify] https://crrev.com/4203e8d9998b078d9bdbb8a1e610bc95b1280806/chrome/browser/about_flags.cc [modify] https://crrev.com/4203e8d9998b078d9bdbb8a1e610bc95b1280806/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/4203e8d9998b078d9bdbb8a1e610bc95b1280806/chrome/browser/flag_descriptions.h [delete] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/chrome/browser/offline_pages/android/prerendering_offliner.cc [delete] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/chrome/browser/offline_pages/android/prerendering_offliner.h [delete] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/chrome/browser/offline_pages/android/prerendering_offliner_unittest.cc [modify] https://crrev.com/4203e8d9998b078d9bdbb8a1e610bc95b1280806/chrome/browser/offline_pages/android/request_coordinator_factory.cc [delete] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/chrome/browser/offline_pages/prerender_adapter.cc [delete] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/chrome/browser/offline_pages/prerender_adapter.h [delete] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/chrome/browser/offline_pages/prerender_adapter_unittest.cc [delete] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/chrome/browser/offline_pages/prerendering_loader.cc [delete] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/chrome/browser/offline_pages/prerendering_loader.h [delete] https://crrev.com/d83f8ec96a36c66b73a6e64f4e9c076380bc3e3e/chrome/browser/offline_pages/prerendering_loader_unittest.cc [modify] https://crrev.com/4203e8d9998b078d9bdbb8a1e610bc95b1280806/chrome/test/BUILD.gn [modify] https://crrev.com/4203e8d9998b078d9bdbb8a1e610bc95b1280806/components/offline_pages/core/background/offliner_policy.h [modify] https://crrev.com/4203e8d9998b078d9bdbb8a1e610bc95b1280806/components/offline_pages/core/background/request_coordinator_unittest.cc [modify] https://crrev.com/4203e8d9998b078d9bdbb8a1e610bc95b1280806/components/offline_pages/core/background/save_page_request.h [modify] https://crrev.com/4203e8d9998b078d9bdbb8a1e610bc95b1280806/components/offline_pages/core/offline_page_feature.cc [modify] https://crrev.com/4203e8d9998b078d9bdbb8a1e610bc95b1280806/components/offline_pages/core/offline_page_feature.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3dd9c7146043fb0e70818cdbbf8fc33320ebbaff commit 3dd9c7146043fb0e70818cdbbf8fc33320ebbaff Author: Egor Pasko <pasko@chromium.org> Date: Thu Oct 12 13:31:22 2017 prerender: Remove AddPrerenderForOffline() Also removed ORIGIN_OFFLINE and deprecated the corresponding suffix in histograms.xml. Bug: 755934 Change-Id: I174b34b772380959deaa728b7f2617aa371e0fdf Reviewed-on: https://chromium-review.googlesource.com/707097 Reviewed-by: Matthew Cary <mattcary@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#508335} [modify] https://crrev.com/3dd9c7146043fb0e70818cdbbf8fc33320ebbaff/chrome/browser/prerender/prerender_browsertest.cc [modify] https://crrev.com/3dd9c7146043fb0e70818cdbbf8fc33320ebbaff/chrome/browser/prerender/prerender_contents.cc [modify] https://crrev.com/3dd9c7146043fb0e70818cdbbf8fc33320ebbaff/chrome/browser/prerender/prerender_histograms.cc [modify] https://crrev.com/3dd9c7146043fb0e70818cdbbf8fc33320ebbaff/chrome/browser/prerender/prerender_manager.cc [modify] https://crrev.com/3dd9c7146043fb0e70818cdbbf8fc33320ebbaff/chrome/browser/prerender/prerender_manager.h [modify] https://crrev.com/3dd9c7146043fb0e70818cdbbf8fc33320ebbaff/chrome/browser/prerender/prerender_origin.cc [modify] https://crrev.com/3dd9c7146043fb0e70818cdbbf8fc33320ebbaff/chrome/browser/prerender/prerender_origin.h [modify] https://crrev.com/3dd9c7146043fb0e70818cdbbf8fc33320ebbaff/chrome/browser/prerender/prerender_resource_throttle.cc [modify] https://crrev.com/3dd9c7146043fb0e70818cdbbf8fc33320ebbaff/chrome/browser/prerender/prerender_unittest.cc [modify] https://crrev.com/3dd9c7146043fb0e70818cdbbf8fc33320ebbaff/tools/metrics/histograms/histograms.xml
Comment 1 by pasko@chromium.org
, Aug 16 2017