New issue
Advanced search Search tips

Issue 755933 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Task

Blocking:
issue 755921



Sign in to add a comment

Prerender: remove SwapInternal()

Project Member Reported by pasko@chromium.org, Aug 16 2017

Issue description

The only remaining client of Prerender is AMP, it does not use swapin, AFAIR.
 

Comment 1 by lizeb@chromium.org, Aug 16 2017

Unfortunately it does.

The way prerender works with AMP is that a Tab will be created with a dummy WebContents, then a prerender will start, and in Tab#loadUrl(), swap will be called.

In this case there is nothing to swap (or we swap "empty" objects), but we still call it.

Comment 2 by pasko@chromium.org, Aug 16 2017

Oh, right. Thanks for reminder!

I vaguely remember dummyWebContents, it was probably back in times when we did not have detached tabs .. It is probably then easiest to unlink all other SwapInternal clients and wait for the switch to BG tab implementation. 
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 16

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: pasko@chromium.org
Status: Assigned (was: Untriaged)
still likely to be fixed :)

Sign in to add a comment