Oh thanks. Yeah, I'll handle the warning.

We keep the ApiHandler internal like that because that's how clank structured it. No good reason for it (and we've received some questions on chromium-dev I think about this). Obviously, the GMS part is still internal, however the overall logic can be upstreamed.

I've been meaning to refactor these classes in issue 748687. Upstreaming is probably a good idea, I may take PlatformServiceBridge as inspiration.

upstreaming for O is happening real soon now, probably wait for that first

> We should either suppress that deprecation warning, or fix it.

We still have to implement deprecated things, so need to suppress them. I think I tried suppressing once long ago, and for some reason, the annotation didn't make the warning go away, so I just gave up

That particular Safe Browsing class is unrelated to O, so I'll suppress the warning now.

The other warnings aren't mine, so someone can feel free to take this from me. Bo, it looks like that class is internal code--why do we need to use deprecated classes if it's not for an API?

it's implementing a deprecated feature

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2d22cf660126d4290da10eb8fd8f6fa60eb0d0c

commit e2d22cf660126d4290da10eb8fd8f6fa60eb0d0c
Author: Nate Fischer <ntfschr@chromium.org>
Date: Thu Aug 17 05:04:14 2017

AW: suppress compile warning

This suppresses a compile warning for an unchecked reflection call on
AwSafeBrowsingApiHandler. The class will always have the method to fetch
user opt-in preference, so it's safe to ignore the warning.

Bug:  755922 
Test: ninja system_webview_google_apk system_webview_apk monochrome_apk
Change-Id: If14900d9bdc42bbb01d4e9f65a0e19f9f0678d12
Reviewed-on: https://chromium-review.googlesource.com/618304
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495079}
[modify] https://crrev.com/e2d22cf660126d4290da10eb8fd8f6fa60eb0d0c/android_webview/java/src/org/chromium/android_webview/AwSafeBrowsingConfigHelper.java

The remaining work is to suppress warnings on ZoomButtonsController. This is mostly mechanical, so I'll pass this off as a 1st bug for a noogler. If someone wants this fixed sooner, I can land the patch.

Assign back if you don't want this for a noogler bug.

---

For whoever takes this up next, you'll need to look up how to suppress warnings for deprecated classes (to suppress the warning from the import statement).

I found more deprecation warnings in the glue layer, which should be resolved the same way:

---

../../android_webview/glue/java/src/com/android/webview/chromium/WebIconDatabaseAdapter.java:8: warning: [deprecation] WebIconDatabase in android.webkit has been deprecated
import android.webkit.WebIconDatabase;
                     ^
../../android_webview/glue/java/src/com/android/webview/chromium/WebIconDatabaseAdapter.java:9: warning: [deprecation] WebIconDatabase in android.webkit has been deprecated
import android.webkit.WebIconDatabase.IconListener;
                     ^
../../android_webview/glue/java/src/com/android/webview/chromium/WebIconDatabaseAdapter.java:9: warning: [deprecation] WebIconDatabase in android.webkit has been deprecated
import android.webkit.WebIconDatabase.IconListener;
                     ^
../../android_webview/glue/java/src/com/android/webview/chromium/WebIconDatabaseAdapter.java:9: warning: [deprecation] IconListener in WebIconDatabase has been deprecated
import android.webkit.WebIconDatabase.IconListener;

Passing to jamwalla@

See examples for how to suppress deprecation warnings:
https://cs.chromium.org/search/?q="@SuppressWarnings(%5C"deprecation%5C")"+lang:java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b09d5a1ec7d5ee8685e8b3fedc5d259d23bd634

commit 3b09d5a1ec7d5ee8685e8b3fedc5d259d23bd634
Author: James Wallace-Lee <jamwalla@chromium.org>
Date: Mon Sep 25 22:40:59 2017

WebView: suppress deprecation warnings

supress deprecation warnings on ZoomButtonsController and
WebIconDatabase

BUG= 755922 

Change-Id: I7b0f6769127b45245652afcd53615d2f2fcde985
Reviewed-on: https://chromium-review.googlesource.com/682997
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504192}
[modify] https://crrev.com/3b09d5a1ec7d5ee8685e8b3fedc5d259d23bd634/android_webview/glue/java/src/com/android/webview/chromium/WebIconDatabaseAdapter.java
[modify] https://crrev.com/3b09d5a1ec7d5ee8685e8b3fedc5d259d23bd634/android_webview/java/src/org/chromium/android_webview/AwZoomControls.java

Is there remaining work for this bug?