New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755921 link

Starred by 7 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Task


Sign in to add a comment

[meta] Remove Prerender code

Project Member Reported by pasko@chromium.org, Aug 16 2017

Issue description

Meta bug to track the cleanup - mostly unreachable paths in code.
 

Comment 1 by pasko@chromium.org, Aug 16 2017

Labels: -Type-Bug Type-Task

Comment 2 by pasko@chromium.org, Aug 16 2017

Blockedon: 689154

Comment 3 by pasko@chromium.org, Aug 16 2017

Blockedon: 755933

Comment 4 by pasko@chromium.org, Aug 16 2017

Blockedon: 755934

Comment 5 by pasko@chromium.org, Aug 16 2017

Blockedon: 755936

Comment 6 by pasko@chromium.org, Aug 16 2017

Blockedon: 476079

Comment 7 by pasko@chromium.org, Aug 21 2017

Blockedon: 757381

Comment 8 by pasko@chromium.org, Aug 22 2017

Blockedon: 603203
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be5f3feb13898aadc116c2754394c9e8e2951703

commit be5f3feb13898aadc116c2754394c9e8e2951703
Author: Marc Treib <treib@chromium.org>
Date: Mon Sep 04 09:53:16 2017

Cleanup: Remove InstantSearchPrerenderer and supporting code

Both prerendering and Instant have been unlaunched, time to get rid of
the code. There's probably a lot more supporting code that can be
removed or vastly simplified, but this is enough for one CL.

Bug:  627747 , 755921
Change-Id: I858134e04d82dbef7c1b3c58f0150081eab335f8
Reviewed-on: https://chromium-review.googlesource.com/623649
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499467}
[modify] https://crrev.com/be5f3feb13898aadc116c2754394c9e8e2951703/chrome/browser/search/instant_service.cc
[modify] https://crrev.com/be5f3feb13898aadc116c2754394c9e8e2951703/chrome/browser/search/instant_service.h
[modify] https://crrev.com/be5f3feb13898aadc116c2754394c9e8e2951703/chrome/browser/search/instant_service_unittest.cc
[modify] https://crrev.com/be5f3feb13898aadc116c2754394c9e8e2951703/chrome/browser/search/search.cc
[modify] https://crrev.com/be5f3feb13898aadc116c2754394c9e8e2951703/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/be5f3feb13898aadc116c2754394c9e8e2951703/chrome/browser/ui/browser.cc
[modify] https://crrev.com/be5f3feb13898aadc116c2754394c9e8e2951703/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/be5f3feb13898aadc116c2754394c9e8e2951703/chrome/browser/ui/browser_instant_controller.cc
[modify] https://crrev.com/be5f3feb13898aadc116c2754394c9e8e2951703/chrome/browser/ui/browser_instant_controller.h
[modify] https://crrev.com/be5f3feb13898aadc116c2754394c9e8e2951703/chrome/browser/ui/browser_navigator.cc
[modify] https://crrev.com/be5f3feb13898aadc116c2754394c9e8e2951703/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
[modify] https://crrev.com/be5f3feb13898aadc116c2754394c9e8e2951703/chrome/browser/ui/omnibox/chrome_omnibox_client.h
[delete] https://crrev.com/e6155ec13276967f56b21c9da9832502f87b9c58/chrome/browser/ui/search/instant_search_prerenderer.cc
[delete] https://crrev.com/e6155ec13276967f56b21c9da9832502f87b9c58/chrome/browser/ui/search/instant_search_prerenderer.h
[delete] https://crrev.com/e6155ec13276967f56b21c9da9832502f87b9c58/chrome/browser/ui/search/instant_search_prerenderer_unittest.cc
[modify] https://crrev.com/be5f3feb13898aadc116c2754394c9e8e2951703/chrome/test/BUILD.gn

Comment 10 by pasko@chromium.org, Oct 25 2017

Blockedon: 778222
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4a75e852127c2c76f1119842ef268ef7dfda99c

commit a4a75e852127c2c76f1119842ef268ef7dfda99c
Author: Egor Pasko <pasko@chromium.org>
Date: Wed Oct 25 13:18:19 2017

Remove PrerenderLocationReplaceGWSHistograms test

It times out frequently on a Windows bot with instrumentation that is
being introduced with:
https://chromium-review.googlesource.com/c/chromium/src/+/713734
(According to siggi@ it can slow down thread startup by 1-2 page faults)

The test checks that a PrefetchTTFCP histogram is recorded correctly in
the case when Prerender is enabled and there is a location.replace. I
believe this codepath is not triggered in the field any more.

The reason for it to fail is probably just time to execute: it is one of
the slowest prerender tests to run AFAIR, and I could not easily spot
any race condition.

Bug: 755921
Change-Id: If9426bb0c48c4b1cbe13da5d91382239d8d806ec
Reviewed-on: https://chromium-review.googlesource.com/737875
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511433}
[modify] https://crrev.com/a4a75e852127c2c76f1119842ef268ef7dfda99c/chrome/browser/prerender/prerender_browsertest.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd1334a2f14e7b00508f73c986419ba25c7e5c04

commit dd1334a2f14e7b00508f73c986419ba25c7e5c04
Author: Egor Pasko <pasko@chromium.org>
Date: Wed Oct 25 16:42:50 2017

Remove AddPrerenderForInstant() and the transitive closure

The function is never called. Also remove the corresponding
prerender::Origin.

Bug: 755921
Change-Id: I183399fdc56a12ae49b8268d3834bd3670891f93
Reviewed-on: https://chromium-review.googlesource.com/738195
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511489}
[modify] https://crrev.com/dd1334a2f14e7b00508f73c986419ba25c7e5c04/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/dd1334a2f14e7b00508f73c986419ba25c7e5c04/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/dd1334a2f14e7b00508f73c986419ba25c7e5c04/chrome/browser/prerender/prerender_field_trial.cc
[modify] https://crrev.com/dd1334a2f14e7b00508f73c986419ba25c7e5c04/chrome/browser/prerender/prerender_field_trial.h
[modify] https://crrev.com/dd1334a2f14e7b00508f73c986419ba25c7e5c04/chrome/browser/prerender/prerender_histograms.cc
[modify] https://crrev.com/dd1334a2f14e7b00508f73c986419ba25c7e5c04/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/dd1334a2f14e7b00508f73c986419ba25c7e5c04/chrome/browser/prerender/prerender_manager.h
[modify] https://crrev.com/dd1334a2f14e7b00508f73c986419ba25c7e5c04/chrome/browser/prerender/prerender_origin.cc
[modify] https://crrev.com/dd1334a2f14e7b00508f73c986419ba25c7e5c04/chrome/browser/prerender/prerender_origin.h
[modify] https://crrev.com/dd1334a2f14e7b00508f73c986419ba25c7e5c04/chrome/browser/prerender/prerender_test_utils.h
[modify] https://crrev.com/dd1334a2f14e7b00508f73c986419ba25c7e5c04/chrome/browser/prerender/prerender_unittest.cc
[modify] https://crrev.com/dd1334a2f14e7b00508f73c986419ba25c7e5c04/tools/metrics/histograms/histograms.xml

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/89118ec272248f3448ab430506d3b5077af72e5a

commit 89118ec272248f3448ab430506d3b5077af72e5a
Author: Matthew Cary <mattcary@google.com>
Date: Tue Mar 27 09:31:17 2018

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/023aea5194464ba40fb371d3217f766453ce7711

commit 023aea5194464ba40fb371d3217f766453ce7711
Author: Matthew Cary <mattcary@chromium.org>
Date: Fri Apr 06 09:03:20 2018

Custom Tabs: permanently disable prerender from custom tabs.

Removes the ability to set a prerender speculation mode for custom tabs,
making the background (hidden) tab the only option. Where appropriate,
method names mentioning "prerender" have been changed to
generically refer to "speculation". In one case shims for
shouldPrerenderOnCellularForSession, etc, have been left in so that
downstream code can be changed in a future CL.

Bug: 755921,710720, 828968
Change-Id: I7234fad18a9616ae65f20af39da4a0261cf75935
Reviewed-on: https://chromium-review.googlesource.com/979992
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548717}
[modify] https://crrev.com/023aea5194464ba40fb371d3217f766453ce7711/chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java
[modify] https://crrev.com/023aea5194464ba40fb371d3217f766453ce7711/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/023aea5194464ba40fb371d3217f766453ce7711/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/023aea5194464ba40fb371d3217f766453ce7711/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/023aea5194464ba40fb371d3217f766453ce7711/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java
[modify] https://crrev.com/023aea5194464ba40fb371d3217f766453ce7711/tools/metrics/histograms/histograms.xml

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83bfc0c839ae2de2b6a0fa49de2b998ffd0bf31d

commit 83bfc0c839ae2de2b6a0fa49de2b998ffd0bf31d
Author: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Date: Fri Apr 06 10:26:52 2018

Revert "Custom Tabs: permanently disable prerender from custom tabs."

This reverts commit 023aea5194464ba40fb371d3217f766453ce7711.

Reason for revert: Causing downstream compile failure.

Bug:755921,710720,828968,829765

Original change's description:
> Custom Tabs: permanently disable prerender from custom tabs.
> 
> Removes the ability to set a prerender speculation mode for custom tabs,
> making the background (hidden) tab the only option. Where appropriate,
> method names mentioning "prerender" have been changed to
> generically refer to "speculation". In one case shims for
> shouldPrerenderOnCellularForSession, etc, have been left in so that
> downstream code can be changed in a future CL.
> 
> Bug: 755921,710720, 828968
> Change-Id: I7234fad18a9616ae65f20af39da4a0261cf75935
> Reviewed-on: https://chromium-review.googlesource.com/979992
> Commit-Queue: Matthew Cary <mattcary@chromium.org>
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Reviewed-by: Egor Pasko <pasko@chromium.org>
> Reviewed-by: Benoit L <lizeb@chromium.org>
> Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548717}

TBR=pasko@chromium.org,bauerb@chromium.org,gayane@chromium.org,lizeb@chromium.org,mattcary@chromium.org

Change-Id: Ib6105a4f7f5d1721374e2b27ba818a86640b7903
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 755921, 710720, 828968
Reviewed-on: https://chromium-review.googlesource.com/998895
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548733}
[modify] https://crrev.com/83bfc0c839ae2de2b6a0fa49de2b998ffd0bf31d/chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java
[modify] https://crrev.com/83bfc0c839ae2de2b6a0fa49de2b998ffd0bf31d/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/83bfc0c839ae2de2b6a0fa49de2b998ffd0bf31d/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/83bfc0c839ae2de2b6a0fa49de2b998ffd0bf31d/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/83bfc0c839ae2de2b6a0fa49de2b998ffd0bf31d/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java
[modify] https://crrev.com/83bfc0c839ae2de2b6a0fa49de2b998ffd0bf31d/tools/metrics/histograms/histograms.xml

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/fac47bba38b5d4fe8d2da3ab587c8db5ac4909a6

commit fac47bba38b5d4fe8d2da3ab587c8db5ac4909a6
Author: Matthew Cary <mattcary@google.com>
Date: Fri Apr 06 15:34:52 2018

Project Member

Comment 17 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2deb4971a31ee19af9fa16081063efa033ef8ea

commit e2deb4971a31ee19af9fa16081063efa033ef8ea
Author: Matthew Cary <mattcary@chromium.org>
Date: Thu Apr 12 09:30:50 2018

Custom Tabs: (reland) permanently disable prerender from custom tabs.

Removes the ability to set a prerender speculation mode for custom tabs,
making the background (hidden) tab the only option. Where appropriate,
method names mentioning "prerender" have been changed to generically
refer to "speculation". In one case shims for
shouldPrerenderOnCellularForSession, etc, have been left in so that
downstream code can be changed in a future CL.

This is a reland of the CL after a downstream patch that allow removing
the constants in SpeculationParams.

TBR: lizeb@chromium.org,pasko@chromium.org,bauerb@chromium.org,gayane@chromium.org
Bug: 755921,710720, 828968
Change-Id: I9a8002d1f0b8c2513d32469d2d7c4ed787912cb4
Reviewed-on: https://chromium-review.googlesource.com/998100
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550116}
[modify] https://crrev.com/e2deb4971a31ee19af9fa16081063efa033ef8ea/chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java
[modify] https://crrev.com/e2deb4971a31ee19af9fa16081063efa033ef8ea/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/e2deb4971a31ee19af9fa16081063efa033ef8ea/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/e2deb4971a31ee19af9fa16081063efa033ef8ea/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/e2deb4971a31ee19af9fa16081063efa033ef8ea/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java
[modify] https://crrev.com/e2deb4971a31ee19af9fa16081063efa033ef8ea/tools/metrics/histograms/histograms.xml

Blockedon: 839030
Project Member

Comment 19 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/8cabae441a786b9da54651304fa5dc9a9ab130cb

commit 8cabae441a786b9da54651304fa5dc9a9ab130cb
Author: Matthew Cary <mattcary@google.com>
Date: Fri May 18 16:38:03 2018

Project Member

Comment 20 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1161a785781de064e4b3408a12e4a020aa5a8da

commit c1161a785781de064e4b3408a12e4a020aa5a8da
Author: Matthew Cary <mattcary@chromium.org>
Date: Tue May 22 16:00:21 2018

Custom Tabs: clean up prerender shims.

Now that downstream has been updated these are no longer necessary. (See
https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/602567).

Bug: 755921,710720
Change-Id: Ie4f1c97d2e39399ae4ebb7d737a7ce5a7ccf9640
Reviewed-on: https://chromium-review.googlesource.com/1068911
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560616}
[modify] https://crrev.com/c1161a785781de064e4b3408a12e4a020aa5a8da/chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java
[modify] https://crrev.com/c1161a785781de064e4b3408a12e4a020aa5a8da/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

Comment 21 by pasko@chromium.org, May 24 2018

Blockedon: 846318
Project Member

Comment 22 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fffc1827c80420b2dea178412e6281a060a4cd01

commit fffc1827c80420b2dea178412e6281a060a4cd01
Author: Egor Pasko <pasko@chromium.org>
Date: Fri May 25 16:32:29 2018

Remove PrerenderBrowserTest.PrerenderSessionStorage

The test causes problems for mojo-ified SessionStorage. Remove the test
to unblock the effort. The purpose of the test is to exercise a scenario
that includes webcontents swap-in, which does not happen in the field
any more (unless forced by a user with about:flags - this ability is
going away soon).

Bug: 755921
Change-Id: I489be7ece2b7d163448126e6b95a00b5a11126d5
Reviewed-on: https://chromium-review.googlesource.com/1073286
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561907}
[modify] https://crrev.com/fffc1827c80420b2dea178412e6281a060a4cd01/chrome/browser/prerender/prerender_browsertest.cc
[delete] https://crrev.com/da96536c9d53ccbaab861546a0b42cf7463184d0/chrome/test/data/prerender/prerender_loader_with_session_storage.html

Project Member

Comment 23 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d7e5cd8f97fc5a33856e181135e5563921e8e74

commit 7d7e5cd8f97fc5a33856e181135e5563921e8e74
Author: Egor Pasko <pasko@chromium.org>
Date: Mon May 28 14:54:28 2018

Prerender: remove dead code from prerender_contents

Remove unused accessors from PrerenderContents, and the associated code
that maintains the unused state.

Bug: 755921
Change-Id: I0efacdb275d6e9c2b1ae76914b9169b7ecfa3e22
Reviewed-on: https://chromium-review.googlesource.com/1072247
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562263}
[modify] https://crrev.com/7d7e5cd8f97fc5a33856e181135e5563921e8e74/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/7d7e5cd8f97fc5a33856e181135e5563921e8e74/chrome/browser/prerender/prerender_contents.h

Project Member

Comment 24 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fed382f74994a26357184fec18cf95cf3c9ce00

commit 6fed382f74994a26357184fec18cf95cf3c9ce00
Author: Egor Pasko <pasko@chromium.org>
Date: Wed May 30 10:33:14 2018

NoStatePrefetch: Remove Finch parameters

The main changes are:
* Leave only a single on/off toggle for nostata-prefetch which maps to
  PRERENDER_MODE_NOSTATE_PREFETCH and
  PRERENDER_MODE_SIMPLE_LOAD_EXPERIMENT
* Change the default mode to PRERENDER_MODE_NOSTATE_PREFETCH (affects
  tests)
* Remove ability to set omnibox mode separately, only SetMode()
  remains
* Since the java tests only use the default mode, allow them to work
  with nostate-prefetch (wait for appropriate FinalStatus instead of
  waiting for prerender to "finish loading")

Along the way:
* Remove the deprecated PRERENDER_MODE_DISABLED.
* Deprecate the PRERENDER_MODE_ENABLED - it is still explicitly set in
  a few tests, will remove in a separate change.
* The PRERENDER_MODE_NOSTATE_PREFETCH is more aggressive at marking as
  duplicate because the state is not cleared on "use".  The workaround
  is to either clear prefetches_ or to avoid reusing the URL in a
  test. Both workarounds are used.
* Small cleanups to pass stricter presubmit checks

Bug: 755921
Change-Id: Ibfcccc61fe7f70f9a7087f29ba68a7263394c32f
Reviewed-on: https://chromium-review.googlesource.com/1042571
Commit-Queue: Egor Pasko <pasko@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562786}
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/android/java/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandler.java
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/android/javatests/src/org/chromium/chrome/browser/PrerenderTest.java
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/about_flags.cc
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/chrome_browser_field_trials_desktop.cc
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/chrome_browser_field_trials_mobile.cc
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/extensions/activity_log/activity_log_browsertest.cc
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/extensions/activity_log/activity_log_unittest.cc
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/media/media_engagement_browsertest.cc
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/predictors/autocomplete_action_predictor.cc
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/prerender/external_prerender_handler_android.cc
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/prerender/external_prerender_handler_android.h
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/prerender/prerender_field_trial.cc
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/prerender/prerender_field_trial.h
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/prerender/prerender_manager.h
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/prerender/prerender_manager_factory.cc
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/prerender/prerender_test_utils.h
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/prerender/prerender_unittest.cc
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/ui/login/login_handler_browsertest.cc
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
[modify] https://crrev.com/6fed382f74994a26357184fec18cf95cf3c9ce00/testing/variations/fieldtrial_testing_config.json

Blocking: 832597
Cc: a...@chromium.org
Blockedon: 898955
Blockedon: 903695
Cc: lfg@chromium.org
pasko@: Can you explain the connection to AMP prerenders from the bug description?  My impression was that "AMP prerender" is unrelated to Chrome's prerendering code-- AMP loads the next page in an iframe and then shows it, unlike loading it in a new WebContents and then swapping WebContents.  (Maybe you were referring to something else?)

I know there's more recent work on portals in issue 865565 which might be closer to Chrome's prerender code, but I don't know if that's a blocker for removing the old code or not.  +lfg for that.
Cc: -droger@chromium.org tbansal@chromium.org
In August of 2017, AMP still used a prerender from the SRP in AGSA custom tabs. That's no longer the case, as that path was migrated to use a background tab instead. 

IIUC, the iframe stuff is used when AMP loads from a SRP in Chrome. So that was always a separate issue. The AMP use pasko@ referred to was the custom tabs flow.



to maybe clarify a tiny bit: mattcary refers to launchUrlInHiddenTab [1] as the current way to load AMP pages when navigated from AGSA. It is android-only and opens a Tab.java with attached WebContents, but without surfacing it in the UI until the real navigation comes in. At that moment it gets visible as a Custom Tab.

[1] https://codesearch.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java?q=launchUrlInHiddenTab&sq=package:chromium&g=0&l=1432
tbansal: this is the master metabug for removing old prerender code
Description: Show this description
Project Member

Comment 35 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e548e0768957d6932ff67456b0f90b84aba67fec

commit e548e0768957d6932ff67456b0f90b84aba67fec
Author: Egor Pasko <pasko@chromium.org>
Date: Fri Nov 30 21:28:49 2018

Remove PrerenderBrowserTest.PrerenderVisibility

The test legitimately fails when "prerender" value gets removed from
visibilityState as it is done in http://crrev.com/c/1356120

Unblock this change by removing the test. Traditional prerenders should
no longer happen, while nostate-prefetch should not ever look at
visibility state.

TBR=mattcary@chromium.org

Bug:  908582 , 755921
Change-Id: I44da809f924b2730ac2b00fd85a1d1e484a3aacb
Reviewed-on: https://chromium-review.googlesource.com/c/1356939
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612792}
[modify] https://crrev.com/e548e0768957d6932ff67456b0f90b84aba67fec/chrome/browser/prerender/prerender_browsertest.cc
[delete] https://crrev.com/104459dbd6e3bab6fea41c00beae46f23775f153/chrome/test/data/prerender/prerender_visibility.html
[delete] https://crrev.com/104459dbd6e3bab6fea41c00beae46f23775f153/chrome/test/data/prerender/prerender_visibility_shared.js

Sign in to add a comment