New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755907 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

DownloadNotificationServiceTest#testResumeAllPendingDownloads is flaky

Project Member Reported by maxmorin@chromium.org, Aug 16 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a3aff75d259d51c76cb3fe2136b84dd1fec25d3

commit 7a3aff75d259d51c76cb3fe2136b84dd1fec25d3
Author: Max Morin <maxmorin@chromium.org>
Date: Wed Aug 16 10:13:17 2017

Disable a DownloadNotificationServiceTest.

Disable DownloadNotificationServiceTest#testResumeAllPendingDownloads,
since it's flaky.

BUG= 755907 
TBR=qinmin

Change-Id: I5f766673db63fd81f18b925232b51988583eb1aa
Reviewed-on: https://chromium-review.googlesource.com/616666
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494742}
[modify] https://crrev.com/7a3aff75d259d51c76cb3fe2136b84dd1fec25d3/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

Comment 2 by jming@chromium.org, Aug 16 2017

Thanks! I'm actually changing the test in my next CL, so it should no longer be flaky.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/387e5384fbb148ed35e6fa7480f78c226a1160ea

commit 387e5384fbb148ed35e6fa7480f78c226a1160ea
Author: Joy Ming <jming@chromium.org>
Date: Thu Aug 17 00:43:03 2017

Integrate DownloadForegroundServiceManager.

This is part of the larger refactor to make downloads a foreground
service. The DownloadForegroundServiceManager (DFSM) was created as a
a manager to keep track of which downloads are active/inactive and turn
the DownloadForegroundService (DFS) on/off accordingly. This CL
integrates the previously isolated DFSM/DFS combination so that updates
from native that go through the SystemDownloadNotifier (SDN) propagate
to the DownloadNotificationService (DNS), as it did before, but,
instead of starting the DNS as a service, it notifies the DFSM, which
starts/stops the DFS. This takes out a lot of the service queuing
logic out of the SDN and cleaning up the DNS so to make sure it is no
longer a service (removing summary notification, extends Service, etc.)

Bug:  749883 , 747563 , 755907 
Change-Id: I0186f3d3f26032f19153568173c01b5618ae8bae
Reviewed-on: https://chromium-review.googlesource.com/613671
Commit-Queue: Joy Ming <jming@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495015}
[modify] https://crrev.com/387e5384fbb148ed35e6fa7480f78c226a1160ea/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastManager.java
[delete] https://crrev.com/5dd2e46656941c9bf9e7c7ff57cccea08691aabf/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastReceiver.java
[modify] https://crrev.com/387e5384fbb148ed35e6fa7480f78c226a1160ea/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadForegroundServiceManager.java
[modify] https://crrev.com/387e5384fbb148ed35e6fa7480f78c226a1160ea/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/387e5384fbb148ed35e6fa7480f78c226a1160ea/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationFactory.java
[modify] https://crrev.com/387e5384fbb148ed35e6fa7480f78c226a1160ea/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/387e5384fbb148ed35e6fa7480f78c226a1160ea/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadResumptionScheduler.java
[modify] https://crrev.com/387e5384fbb148ed35e6fa7480f78c226a1160ea/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
[modify] https://crrev.com/387e5384fbb148ed35e6fa7480f78c226a1160ea/chrome/android/java_sources.gni
[modify] https://crrev.com/387e5384fbb148ed35e6fa7480f78c226a1160ea/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadForegroundServiceManagerTest.java
[modify] https://crrev.com/387e5384fbb148ed35e6fa7480f78c226a1160ea/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
[modify] https://crrev.com/387e5384fbb148ed35e6fa7480f78c226a1160ea/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
[modify] https://crrev.com/387e5384fbb148ed35e6fa7480f78c226a1160ea/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java
[delete] https://crrev.com/5dd2e46656941c9bf9e7c7ff57cccea08691aabf/chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java

Comment 4 by jming@chromium.org, Aug 17 2017

Status: Fixed (was: Assigned)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment