New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755888 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Re-enable testContextMenuOpenInNewTabFromTallPage

Project Member Reported by gambard@chromium.org, Aug 16 2017

Issue description

ContextMenuTestCase.testContextMenuOpenInNewTabFromTallPage is disabled because it is failing consistently on iPhone device: iPhone 6s 10.0.1 on the waterfall.
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone10-device-x64/builds/6535/steps/ios_chrome_integration_egtests%20%28iPhone%206s%20iOS%2010.0.1%29%20on%20iOS-10.0.1/logs/ContextMenuTestCase%26%23x2f%3BtestContextMenuOpenInNewTabFromTallPage
I could reproduce on iPhone SE 9.3.2.

The issue was first found between the commits: 936b4be1f4e1b151e3f9e37a3d0859a32dabb6e1..a7482a88d73040a616ef53294eeef75ca8b6c5a2

Adding noyau/michaeldo as owners of ios/chrome/browser/*/context_menu.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c0e76236671f219294dcb5330590de58f79d396

commit 6c0e76236671f219294dcb5330590de58f79d396
Author: gambard <gambard@chromium.org>
Date: Wed Aug 16 09:22:28 2017

Disable testContextMenuOpenInNewTabFromTallPage

Failing consistently on iPhone devices.

Bug:  755888 
Change-Id: I13921ea4ecec3562a481879415e5046a389e5c9f
Tbr: noyau@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/616564
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494734}
[modify] https://crrev.com/6c0e76236671f219294dcb5330590de58f79d396/ios/chrome/browser/context_menu/BUILD.gn
[modify] https://crrev.com/6c0e76236671f219294dcb5330590de58f79d396/ios/chrome/browser/context_menu/context_menu_egtest.mm

Components: UI>Browser>NewTabPage
Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)
Owner: michaeldo@chromium.org
Components: -UI>Browser>NewTabPage Test>iOS
This is also not a NewTabPage bug, please find a more appropriate component.
Cc: mrefaat@chromium.org pkl@chromium.org eugene...@chromium.org
pkl@ who can be the right owner for this bug since Mike is out? Please reassign
Components: -Test>iOS Tests>Disabled
Not sure why this should be RBS. It should be RBB instead. Gauthier must have made a typo while filing this bug. Since we have passed M62 branch, I am going to make this a 63 RBB
Labels: -ReleaseBlock-Stable -M-62 ReleaseBlock-Beta M-63

Comment 9 by lod@chromium.org, Sep 26 2017

This test is now failing consistently on iPhone X simulator as well. I investigated and identified the cause of failure (I checked and it's the same problem on device; don't know why non-iPhone X simulator doesn't have an issue..). By extending the timeouts I was able to see that the open new tab animation is buggy (see attached video). What's interesting is that the animation is buggy because of an earl grey call. Line 248, there's a condition block that checks that the tab opening animation is complete and the scroll view is interactable. When I remove the following EarlGrey call from the condition:
[[EarlGrey selectElementWithMatcher:WebViewScrollView(chrome_test_util::GetCurrentWebState())]
        assertWithMatcher:grey_interactable()
                    error:&error];

and replace it by "return false;" the behavior is normal and the tab opens with the correct animation (of course the test doesn't proceed any further). So I'm certain that the issue is with the EarlGrey call. I'm not sure where to start with fixing it however. 
For now I'm going to extend the disabling to simulator as well.
buggy_eg.mov
1.0 MB Download
Cc: liaoyuke@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c37fed4906e33dd2643c639a1b272ad678a24a12

commit c37fed4906e33dd2643c639a1b272ad678a24a12
Author: Elodie Banel <lod@google.com>
Date: Tue Sep 26 14:56:21 2017

Disable testContextMenuOpenInNewTabFromTallPage on simulator

This test was already failing and disabled on device. It is now failing on
iPhone X simulator as well for the same reason so disabling it on
simulator as well.

Bug:  755888 
Change-Id: I13ab73aa46a4698ff8c50cea1d786a9c1f5e4a85
Tbr: noyau@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/684312
Reviewed-by: Elodie Banel <lod@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504369}
[modify] https://crrev.com/c37fed4906e33dd2643c639a1b272ad678a24a12/ios/chrome/browser/context_menu/context_menu_egtest.mm

Please fix this before M63 branch on Oct 12th.
Status: Started (was: Assigned)
Thanks for taking a look Mike!
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b37422b828b8d4f717ef7123534ab9907aaefae

commit 2b37422b828b8d4f717ef7123534ab9907aaefae
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Wed Oct 11 18:52:18 2017

Add unittest to find an element in the DOM at the bottom of a tall page.

Bug:  755888 
Change-Id: I605e337b163a74a367ceb3fd202f55dde417861c
Reviewed-on: https://chromium-review.googlesource.com/710222
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508051}
[modify] https://crrev.com/2b37422b828b8d4f717ef7123534ab9907aaefae/ios/web/web_state/js/context_menu_js_unittest.mm

Project Member

Comment 16 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86a04beb31afc4e25eee6d48140bb1f9c0364342

commit 86a04beb31afc4e25eee6d48140bb1f9c0364342
Author: Mike Dougherty <michaeldo@chromium.org>
Date: Fri Oct 13 17:31:24 2017

Remove testContextMenuOpenInNewTabFromTallPage egtest.

This test has been replaced with a unittest (ContextMenuJsTest,
LinkOfTextFromTallPage). The unittest verifies that an element at the
bottom of a long page can be found in the DOM.

Bug:  755888 
Change-Id: Ie14a1ee846c26a5e9cc3981d14d797355e0c7a0e
Reviewed-on: https://chromium-review.googlesource.com/710221
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508740}
[modify] https://crrev.com/86a04beb31afc4e25eee6d48140bb1f9c0364342/ios/chrome/browser/context_menu/context_menu_egtest.mm

Please mark as wontfix since you remove the test.
Status: WontFix (was: Started)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment