Convert DummyWebMediaPlayerClient to a mock in webmediaplayer_impl_unittest. |
||||
Issue descriptionwebmediaplayer_impl_unittest uses a DummyWebMediaPlayerClient. We'd get more meaningful coverage with a mock. Once |client_| is converted from a dummy to a mock, test that |web_layer| is actually used by |client_|.
,
Dec 8 2017
+dalecurtis@ FYI
,
Dec 23 2017
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef15b62a4bbedf654f86fb5149ac23026c23af61 commit ef15b62a4bbedf654f86fb5149ac23026c23af61 Author: CJ DiMeglio <lethalantidote@chromium.org> Date: Fri Jan 12 00:41:59 2018 Mock WebMediaPlayerClient. This CL mocks the WebMediaPlayerClient (previously a fake) in unittesting to confirm that the correct web_layer is being passed to it. I've included a few other expect calls, but since some of the call patterns are highly variable based on commandline args, I demoted this to a NiceMock. Bug: 755880 Change-Id: I1cf844701a115551ff49d104ec61d39da1774eaa Reviewed-on: https://chromium-review.googlesource.com/804699 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#528832} [modify] https://crrev.com/ef15b62a4bbedf654f86fb5149ac23026c23af61/media/blink/webmediaplayer_impl_unittest.cc
,
Jan 12 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by lethalantidote@chromium.org
, Sep 15 2017