Regression:Focus vanishes after hitting spacebar key to delete zoom levels entry.
Reported by
vku...@etouch.net,
Aug 16 2017
|
||||
Issue descriptionChrome Version: 62.0.3182.0 (Official Build) cc46b05b55683ecf63128f6062811093fcf2ad79-refs/heads/master@{#493619}(32/64 bit) OS:Windows(7,8,10), Mac(10.11.6, 0.12.3,10.12.5), Linux(14.04 LTS). What steps will reproduce the problem? (1)Launch chrome and navigate to 2-3 webpages, zoom in all pages via ctrl++ (2)Navigate to chrome://settings/content/zoomLevels, press tab key till focus reaches 'X' icon of first entry. (3)Now hit 'space-bar' key to delete and observe the focus. Actual: Focus vanishes after hitting spacebar key to delete zoom levels entry. Expected: Focus should be seen on 'X' icon of next entry after hitting spacebar key to delete zoom levels entry. This is a regression issue broken in 'M61' and below is the manual regression range Good Build: 61.0.3131.0 Bad Build: 61.0.3132.0
,
Aug 16 2017
Using the per-revision bisect providing the bisect results, Good build: 61.0.3131.0 (Revision:479564). Bad build: 61.0.3132.0 (Revision:479900). You are probably looking for a change made after 479873 (known good), but no later than 479874 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+/bf4adbb1a2b7066a30297d5df51707fd468d391d From the CL above, assigning the issue to the concern owner @scottchen: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Reviewed-On: https://codereview.chromium.org/2848973003 Note: Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.5 and Able to reproduce in latest Canary #62.0.3187.0
,
Aug 16 2017
,
Aug 16 2017
Just to note - this is not a regression issue, the focus being kept was unintended side-effect with the old button. However, I've converted this list to an iron-list, which now will INTENTIONALLY support the focus being preserved, as well as keyboard controls.
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fc91f3a6706c62325b05fd9db52523e496825d6 commit 2fc91f3a6706c62325b05fd9db52523e496825d6 Author: Scott Chen <scottchen@chromium.org> Date: Thu Aug 17 21:19:27 2017 MD Settings: change zoom-level to iron-list Bug: 755878 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2d9c7a28cd4f7a8621c6fdb1341eb270a63a57eb Reviewed-on: https://chromium-review.googlesource.com/617648 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#495321} [modify] https://crrev.com/2fc91f3a6706c62325b05fd9db52523e496825d6/chrome/browser/resources/settings/site_settings/zoom_levels.html
,
Aug 17 2017
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6cf3b33924be786e53784780e85603481d5215f commit d6cf3b33924be786e53784780e85603481d5215f Author: Henrik Kjellander <kjellander@chromium.org> Date: Fri Aug 18 04:39:33 2017 Revert "MD Settings: change zoom-level to iron-list" This reverts commit 2fc91f3a6706c62325b05fd9db52523e496825d6. Reason for revert: Suspected breaking chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1) See https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/29250 Original change's description: > MD Settings: change zoom-level to iron-list > > Bug: 755878 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I2d9c7a28cd4f7a8621c6fdb1341eb270a63a57eb > Reviewed-on: https://chromium-review.googlesource.com/617648 > Commit-Queue: Scott Chen <scottchen@chromium.org> > Reviewed-by: Dave Schuyler <dschuyler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#495321} TBR=dschuyler@chromium.org,scottchen@chromium.org Change-Id: I761f25e448843174696aa0b3695a57d20335f7e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 755878 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/620486 Reviewed-by: Henrik Kjellander <kjellander@chromium.org> Commit-Queue: Henrik Kjellander <kjellander@chromium.org> Cr-Commit-Position: refs/heads/master@{#495462} [modify] https://crrev.com/d6cf3b33924be786e53784780e85603481d5215f/chrome/browser/resources/settings/site_settings/zoom_levels.html |
||||
►
Sign in to add a comment |
||||
Comment 1 by vku...@etouch.net
, Aug 16 2017