New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755862 link

Starred by 15 users

Regression: Chrome gets unresponsive in full-screen mode.

Reported by dchau...@etouch.net, Aug 16 2017

Issue description

Chrome Version: 62.0.3187.0 (Official Build)066a02fc3eda664375a59a5962ccffa0e28c81f-refs/heads/master@{#494644}
OS: Windows

What steps will reproduce the problem?
(1) Launch chrome, press F11 key from keyboard and observe.

Chrome gets unresponsive.
Chrome should be in full-screen mode.

This is a regression issue, broken in M-62 series, will soon update other info.

 

Comment 1 by dchau...@etouch.net, Aug 16 2017

Below is manual regression range.

Good build : 62.0.3186.0
Bad build : 62.0.3187.0

Note: Issue is not reproducible on Mac OS, will soon update the behavior of Linux OS.

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
1.2 MB View Download
Expected behavior.mp4
266 KB View Download

Comment 2 by dchau...@etouch.net, Aug 16 2017

This issue is not reproducible on Linux OS also.

Comment 3 by grt@chromium.org, Aug 16 2017

Cc: sadrul@chromium.org bokan@chromium.org gklassen@chromium.org
Status: Untriaged (was: Unconfirmed)
You are probably looking for a change made after 494391 (known good), but no later than 494404 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/ebb64f8e585ffb3923eee174c080f5ead800e6fb..80423599a8afcf23a7c83c492978a2b73ada40df

I'm cc-ing some folks with a change in that range.
Labels: hasbisect-per-revision
Owner: sadrul@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue using #62.0.3187.0  on Win 10

Bisect Information:
-------------------
You are probably looking for a change made after 494402 (known good), but no lat
er than 494403 (first known bad).

CHANGELOG URL:
--------------
https://chromium.googlesource.com/chromium/src/+log/aa32c7d6e682fb0f27ba3d8389af082a306a2c10..e0466cee3aa3f9f937fe0e515899ae808929ffb3

suspecting https://chromium.googlesource.com/chromium/src/+/2e27e8ef7352fa68de51b0c59257604c66b9781d from above url


@sadrul: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Cc: gov...@chromium.org abdulsyed@chromium.org ligim...@chromium.org ajha@chromium.org
Labels: ReleaseBlock-Dev
Adding Release Block-Dev for this issue.Please remove if not the case.

Thank You!

Comment 6 by siggi@chromium.org, Aug 16 2017

I'm seeing similar problems on 

62.0.3187.1 (Official Build) canary SyzyASan (32-bit) (cohort: ASAN)

Looks like the content area isn't updating, except sometimes on window resize events. 

Comment 7 by sadrul@chromium.org, Aug 16 2017

Status: Started (was: Assigned)

Comment 8 by ajha@chromium.org, Aug 16 2017

 Issue 755859  has been merged into this issue.

Comment 9 by ajha@chromium.org, Aug 16 2017

Please get the suspected CL reverted or fix landed as we have scheduled Dev release soon.  Issue 755862  and  Issue 755859  having the same root cause blocks the Dev release. 
Does this manifest outside of full-screen?

On Windows, I'm finding that some of my Canary windows don't paint content or UI until resized. This appears to be a regression since yesterday.
BlackScreen.jpg
4.4 KB View Download
Another similar issue is seen in the popup windows used by extensions.
Glitch.png
17.8 KB View Download
Sadrul. Can you please revert the suspect ASAP. We are planning a Dev RC today. Need the revert in 3187 branch also.

Comment 13 by wfh@chromium.org, Aug 16 2017

has this been reverted elsewhere? will this be in 3188 as well?
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4b6ff31143a6fa673475af22b2d3ed03e59b107

commit f4b6ff31143a6fa673475af22b2d3ed03e59b107
Author: Sadrul Chowdhury <sadrul@chromium.org>
Date: Wed Aug 16 23:53:16 2017

Revert "compositor: Avoid updating cc if size does not change."

This reverts commit e0466cee3aa3f9f937fe0e515899ae808929ffb3.

Reason for revert: Causes regressions ( crbug.com/755862  for example)

Original change's description:
> compositor: Avoid updating cc if size does not change.
> 
> Setting the size in LayerTreeHost invalidates the LocalSurfaceId. So it
> would be necessary to set it again later. However, if the size actually
> did not change, then ui does not receive a new LocalSurfaceId from the
> server, thus breaking the compositor (because commits are deferred until
> a valid LocalSurfaceId is set).
> 
> BUG= 755238 
> 
> Change-Id: Ifc44596b8ce6a176e9221713727950ead34d3542
> Reviewed-on: https://chromium-review.googlesource.com/614700
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#494403}

TBR=sadrul@chromium.org,piman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  755238 ,  755862 
Change-Id: I2cd039a7c6ae784c0cdcee6c20f0e2bad1f18393
Reviewed-on: https://chromium-review.googlesource.com/617942
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495002}
[modify] https://crrev.com/f4b6ff31143a6fa673475af22b2d3ed03e59b107/ui/compositor/compositor.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 17 2017

Labels: merge-merged-3187
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/509649266c23e307a2e8285b155eb9b0228f7281

commit 509649266c23e307a2e8285b155eb9b0228f7281
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Thu Aug 17 04:59:56 2017

Revert "compositor: Avoid updating cc if size does not change."

This reverts commit e0466cee3aa3f9f937fe0e515899ae808929ffb3.

Reason for revert: Causes regressions ( crbug.com/755862  for example)

Original change's description:
> compositor: Avoid updating cc if size does not change.
>
> Setting the size in LayerTreeHost invalidates the LocalSurfaceId. So it
> would be necessary to set it again later. However, if the size actually
> did not change, then ui does not receive a new LocalSurfaceId from the
> server, thus breaking the compositor (because commits are deferred until
> a valid LocalSurfaceId is set).
>
> BUG= 755238 
>
> Change-Id: Ifc44596b8ce6a176e9221713727950ead34d3542
> Reviewed-on: https://chromium-review.googlesource.com/614700
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#494403}

TBR=piman@chromium.org, sadrul@chromium.org


(cherry picked from commit f4b6ff31143a6fa673475af22b2d3ed03e59b107)

Bug:  755238 ,  755862 
Change-Id: I2cd039a7c6ae784c0cdcee6c20f0e2bad1f18393
Reviewed-on: https://chromium-review.googlesource.com/617942
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495002}
Reviewed-on: https://chromium-review.googlesource.com/617886
Cr-Commit-Position: refs/branch-heads/3187@{#5}
Cr-Branched-From: 1066a02fc3eda664375a59a5962ccffa0e28c81f-refs/heads/master@{#494644}
[modify] https://crrev.com/509649266c23e307a2e8285b155eb9b0228f7281/ui/compositor/compositor.cc

Labels: TE-Verified-M62 TE-Verified-62.0.3188.0
Retested this issue on Windows-(7,8,10) machine using latest Canary build # 62.0.3188.0 (Official Build) and fix is working as expected i.e. Chrome doesn't get unresponsive on pressing 'F11' key from keyboard.

Attaching screen-cast for the same.
Latest Canary 62.0.3188.0 behavior.mp4
518 KB View Download
Cc: catmulli...@chromium.org tapted@chromium.org
 Issue 755923  has been merged into this issue.

Comment 18 by ajha@chromium.org, Aug 17 2017

 Issue 756158  has been merged into this issue.
If there is no pending work, can we tag as fixed?
Status: Fixed (was: Started)
 Issue 755916  has been merged into this issue.
Cc: jmukthavaram@chromium.org irmakk@google.com melandory@chromium.org
 Issue 755867  has been merged into this issue.
 Issue 755864  has been merged into this issue.
Cc: krajshree@chromium.org brajkumar@chromium.org
 Issue 755908  has been merged into this issue.

Sign in to add a comment