New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755861 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 629701



Sign in to add a comment

Impl mojo interface ServiceWorkerContainer

Reported by xiaofeng...@intel.com, Aug 16 2017

Issue description

This is to track all the work to implement ServiceWorkerContainer mojo interface.

According to Falken's design:
https://docs.google.com/document/d/1FxFISiZKBH2MALypxt-aoGAbmyco-7kEMi1zMe5KrzE/edit?pli=1#

"Interface ServiceWorkerContainer roughly corresponds to navigator.serviceWorker. Actually needed for anything that could access a ServiceWorkerRegistration/ServiceWorker. ..... But eventually anything that can touch these objects should be a ServiceWorkerContainer, so it’s OK to use this name.

When the browser initialized the navigation or SW startup, it should send the SWContainer along.

interface ServiceWorkerContainer {
  SetController(ServiceWorkerObject controller);
  ServiceWorkerStateChanged(ServiceWorkerObject);
  ServiceWorkerRegistrationUpdateFound(ServiceWorkerRegistrationObject)
  PostMessage();
};

"



 
Blocking: 629701
Cc: xiaofeng...@intel.com
 Issue 755838  has been merged into this issue.

Comment 3 by dcheng@chromium.org, Aug 21 2017

Cc: dcheng@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e76d258cc729eb5715708115858b560e3391ace

commit 0e76d258cc729eb5715708115858b560e3391ace
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Wed Aug 30 05:35:39 2017

Rename two mojo interfaces ServiceWorkerProvider/ProviderHost

ServiceWorkerProvider/ProviderHost interfaces naming is somehow confusing
what "provider" means, because both of them mainly serve for the functionality
implementations of the javascript interface ServiceWorkerContainer,
see https://w3c.github.io/ServiceWorker/#serviceworkercontainer.

This CL renames these two interfaces to ServiceWorkerContainer/ContainerHost.

BUG= 755861 ,  629701 

Change-Id: I7595d7ec4e9ea4f7db091e5c17f262c2d6150177
Reviewed-on: https://chromium-review.googlesource.com/615094
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498374}
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/browser/service_worker/service_worker_test_utils.cc
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/browser/service_worker/service_worker_test_utils.h
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/child/service_worker/service_worker_dispatcher_unittest.cc
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/child/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/child/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/child/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/child/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/common/BUILD.gn
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/common/service_worker/service_worker.mojom
[add] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/common/service_worker/service_worker_container.mojom
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/common/service_worker/service_worker_provider.mojom
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/common/service_worker/service_worker_provider_host_info.cc
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/common/service_worker/service_worker_provider_host_info.h
[delete] https://crrev.com/c0785b84dfa9509aa6d4e2984ccc60b98606c930/content/common/service_worker/service_worker_provider_interfaces.mojom
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/common/service_worker/service_worker_provider_struct_traits.cc
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/common/service_worker/service_worker_provider_struct_traits.h
[modify] https://crrev.com/0e76d258cc729eb5715708115858b560e3391ace/content/renderer/service_worker/worker_fetch_context_impl.h

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b

commit a59fb76dee9cb53c74ddb4fe82dffe0335ea827b
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Wed Sep 27 17:51:39 2017

[ServiceWorker] Add blink.mojom.ServiceWorkerState enum

This CL creates blink.mojom.ServiceWorkerState enum type and uses it
to replace existing native enum type blink::WebServiceWorkerState.
This is the preparation to impl the method 'ServiceWorkerStateChanged'
of content.mojom.ServiceWorkerContainer interface, which needs to pass
this enum type.

BUG= 755861 

Change-Id: I8d7c3d0b15ab293a46b5b3c4d2ba163e94d1818b
Reviewed-on: https://chromium-review.googlesource.com/674525
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504724}
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/browser/BUILD.gn
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/browser/DEPS
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/browser/service_worker/OWNERS
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/browser/service_worker/service_worker_handle.cc
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/browser/service_worker/service_worker_handle_unittest.cc
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/browser/service_worker/service_worker_provider_host.h
[add] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/browser/service_worker/service_worker_type_converters.cc
[add] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/browser/service_worker/service_worker_type_converters.h
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/child/service_worker/service_worker_dispatcher.cc
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/child/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/child/service_worker/service_worker_handle_reference.h
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/child/service_worker/web_service_worker_impl.cc
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/child/service_worker/web_service_worker_impl.h
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/common/DEPS
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/common/service_worker/service_worker_types.cc
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorker.h
[delete] https://crrev.com/ab01f1a8c03a610ff32b4fa53fec556a67aba487/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerState.h
[add] https://crrev.com/a59fb76dee9cb53c74ddb4fe82dffe0335ea827b/third_party/WebKit/public/platform/modules/serviceworker/service_worker_state.mojom

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16

commit 24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Thu Oct 12 02:36:33 2017

[ServiceWorker] Implement ServiceWorkerContainer.SetController

mojom::ServiceWorkerContainer is a renderer-side interface.
The browser process uses this interface to send messages to documents or
the service worker's context.

This is the first method implementation of the SWContainer.

BUG= 755861 

Change-Id: I1db27022789f7424ab9f333b0cf5a08217b0b8bb
Reviewed-on: https://chromium-review.googlesource.com/648659
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508231}
[modify] https://crrev.com/24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16/content/child/service_worker/service_worker_dispatcher.cc
[modify] https://crrev.com/24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16/content/child/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16/content/child/service_worker/service_worker_dispatcher_unittest.cc
[modify] https://crrev.com/24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16/content/child/service_worker/service_worker_message_filter.cc
[modify] https://crrev.com/24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16/content/child/service_worker/service_worker_message_filter.h
[modify] https://crrev.com/24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16/content/child/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16/content/child/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16/content/child/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16/content/child/service_worker/web_service_worker_provider_impl.cc
[modify] https://crrev.com/24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16/content/child/service_worker/web_service_worker_provider_impl.h
[modify] https://crrev.com/24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16/content/common/service_worker/service_worker_container.mojom
[modify] https://crrev.com/24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16/content/common/service_worker/service_worker_types.mojom
[modify] https://crrev.com/24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16/content/common/service_worker/service_worker_types.typemap

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ec5282f3b0c4045996a992f486f2486cf6351b1

commit 9ec5282f3b0c4045996a992f486f2486cf6351b1
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Oct 17 21:54:48 2017

Revert "[ServiceWorker] Implement ServiceWorkerContainer.SetController"

This reverts commit 24e5c55ff1e1ffa02ccbcd9dc4fcc014d0f32a16.

Revert "[ServiceWorker] Fix the warning for comparison of unsigned expression"

This reverts commit 4d47a13e3d98ef30d74ae3d4671d57c097b7124e.

Reverting due to crashes, see bug.

Bug: 774681,  755861 
Change-Id: Ib90a143dec1ca9f378a487e330a98a1bb3d7d50c
TBR: xiaofeng.zhang, shimazu, tsepez, kinuko
Reviewed-on: https://chromium-review.googlesource.com/722840
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509559}
[modify] https://crrev.com/9ec5282f3b0c4045996a992f486f2486cf6351b1/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/9ec5282f3b0c4045996a992f486f2486cf6351b1/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/9ec5282f3b0c4045996a992f486f2486cf6351b1/content/child/service_worker/service_worker_dispatcher.cc
[modify] https://crrev.com/9ec5282f3b0c4045996a992f486f2486cf6351b1/content/child/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/9ec5282f3b0c4045996a992f486f2486cf6351b1/content/child/service_worker/service_worker_dispatcher_unittest.cc
[modify] https://crrev.com/9ec5282f3b0c4045996a992f486f2486cf6351b1/content/child/service_worker/service_worker_message_filter.cc
[modify] https://crrev.com/9ec5282f3b0c4045996a992f486f2486cf6351b1/content/child/service_worker/service_worker_message_filter.h
[modify] https://crrev.com/9ec5282f3b0c4045996a992f486f2486cf6351b1/content/child/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/9ec5282f3b0c4045996a992f486f2486cf6351b1/content/child/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/9ec5282f3b0c4045996a992f486f2486cf6351b1/content/child/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/9ec5282f3b0c4045996a992f486f2486cf6351b1/content/child/service_worker/web_service_worker_provider_impl.cc
[modify] https://crrev.com/9ec5282f3b0c4045996a992f486f2486cf6351b1/content/child/service_worker/web_service_worker_provider_impl.h
[modify] https://crrev.com/9ec5282f3b0c4045996a992f486f2486cf6351b1/content/common/service_worker/service_worker_container.mojom
[modify] https://crrev.com/9ec5282f3b0c4045996a992f486f2486cf6351b1/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/9ec5282f3b0c4045996a992f486f2486cf6351b1/content/common/service_worker/service_worker_types.mojom
[modify] https://crrev.com/9ec5282f3b0c4045996a992f486f2486cf6351b1/content/common/service_worker/service_worker_types.typemap

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/469f924db9db15c04d18bf544da940feac28e8c0

commit 469f924db9db15c04d18bf544da940feac28e8c0
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Thu Oct 19 00:43:42 2017

[ServiceWorker] Apply mojom struct ServiceWorkerObjectInfo everywhere

This CL replaces native struct content::ServiceWorkerObjectInfo
with mojom struct blink.mojom.ServiceWorkerObjectInfo.

This is an incremental step toward Onion Soup: having less dependence
on content types for service worker.

BUG= 755861 

Change-Id: Ic9b59c771c8eb4687e833fb0cc744987dab40aac
Reviewed-on: https://chromium-review.googlesource.com/715476
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Cr-Commit-Position: refs/heads/master@{#509949}
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/DEPS
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/devtools/protocol/service_worker_handler.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_context_watcher.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_database.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_database_unittest.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_handle.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_handle.h
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_info.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_internals_ui.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_register_job.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_storage.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_storage_unittest.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/child/service_worker/service_worker_dispatcher.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/child/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/child/service_worker/service_worker_dispatcher_unittest.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/child/service_worker/service_worker_handle_reference.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/child/service_worker/service_worker_handle_reference.h
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/child/service_worker/service_worker_message_filter.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/child/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/child/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/child/service_worker/web_service_worker_impl.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/common/DEPS
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/common/service_worker/service_worker_types.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/renderer/service_worker/worker_fetch_context_impl.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/renderer/service_worker/worker_fetch_context_impl.h
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/469f924db9db15c04d18bf544da940feac28e8c0/third_party/WebKit/public/platform/modules/serviceworker/service_worker_object.mojom

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48e7e9482ddded8344f7ec94906bfc37f756552d

commit 48e7e9482ddded8344f7ec94906bfc37f756552d
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Tue Oct 24 07:36:49 2017

Reland of "[ServiceWorker] Implement ServiceWorkerContainer.SetController"

Reason of reland:
Fix the crash issue, see bug:774681.

Original issue's description:
> mojom::ServiceWorkerContainer is a renderer-side interface.
> The browser process uses this interface to send messages to documents or
> the service worker's context.

> This is the first method implementation of the SWContainer.

BUG= 755861 
TBR=tsepez@chromium.org

Change-Id: If6027ffbbaa15ef25bd59b28f415a671b1cae086
Reviewed-on: https://chromium-review.googlesource.com/732330
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Cr-Commit-Position: refs/heads/master@{#511053}
[modify] https://crrev.com/48e7e9482ddded8344f7ec94906bfc37f756552d/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/48e7e9482ddded8344f7ec94906bfc37f756552d/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/48e7e9482ddded8344f7ec94906bfc37f756552d/content/common/service_worker/service_worker_container.mojom
[modify] https://crrev.com/48e7e9482ddded8344f7ec94906bfc37f756552d/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/48e7e9482ddded8344f7ec94906bfc37f756552d/content/renderer/service_worker/service_worker_dispatcher.cc
[modify] https://crrev.com/48e7e9482ddded8344f7ec94906bfc37f756552d/content/renderer/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/48e7e9482ddded8344f7ec94906bfc37f756552d/content/renderer/service_worker/service_worker_dispatcher_unittest.cc
[modify] https://crrev.com/48e7e9482ddded8344f7ec94906bfc37f756552d/content/renderer/service_worker/service_worker_message_filter.cc
[modify] https://crrev.com/48e7e9482ddded8344f7ec94906bfc37f756552d/content/renderer/service_worker/service_worker_message_filter.h
[modify] https://crrev.com/48e7e9482ddded8344f7ec94906bfc37f756552d/content/renderer/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/48e7e9482ddded8344f7ec94906bfc37f756552d/content/renderer/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/48e7e9482ddded8344f7ec94906bfc37f756552d/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/48e7e9482ddded8344f7ec94906bfc37f756552d/content/renderer/service_worker/web_service_worker_provider_impl.cc
[modify] https://crrev.com/48e7e9482ddded8344f7ec94906bfc37f756552d/content/renderer/service_worker/web_service_worker_provider_impl.h

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c355f6b8854b4c98a54e290f58d2f7d059ec78b3

commit c355f6b8854b4c98a54e290f58d2f7d059ec78b3
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Thu Oct 26 03:23:01 2017

[ServiceWorker] Cleanup unused code after mojofication

After mojofication, we don't need send WebServiceWorkerProvider anymore.
And also remove a code missing when mojofy SetController.

BUG= 758151 ,  755861 

Change-Id: I4652d41bb6df6adf08b1fd0c914a1a1af469b0da
Reviewed-on: https://chromium-review.googlesource.com/737510
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Cr-Commit-Position: refs/heads/master@{#511722}
[modify] https://crrev.com/c355f6b8854b4c98a54e290f58d2f7d059ec78b3/content/renderer/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/c355f6b8854b4c98a54e290f58d2f7d059ec78b3/content/renderer/service_worker/web_service_worker_registration_impl.cc
[modify] https://crrev.com/c355f6b8854b4c98a54e290f58d2f7d059ec78b3/content/renderer/service_worker/web_service_worker_registration_impl.h
[modify] https://crrev.com/c355f6b8854b4c98a54e290f58d2f7d059ec78b3/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp
[modify] https://crrev.com/c355f6b8854b4c98a54e290f58d2f7d059ec78b3/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp
[modify] https://crrev.com/c355f6b8854b4c98a54e290f58d2f7d059ec78b3/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

#11: Sounds good.
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dcaa25d8585ce209f32122a800a3cec648cea60

commit 5dcaa25d8585ce209f32122a800a3cec648cea60
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Tue Oct 31 03:28:43 2017

[ServiceWorker] Implement ServiceWorkerContainer.PostMessageToClient

Corresponds to Client.postMessage() method, sends a message from
service worker to a client.

The CL mojofies the legacy IPC: ServiceWorkerMsg_MessageToDocument.

BUG= 755861 

Change-Id: I5795f8af5eb775699b9b22c1dde128c4bba48ec7
Reviewed-on: https://chromium-review.googlesource.com/742237
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512732}
[modify] https://crrev.com/5dcaa25d8585ce209f32122a800a3cec648cea60/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/5dcaa25d8585ce209f32122a800a3cec648cea60/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/5dcaa25d8585ce209f32122a800a3cec648cea60/content/common/service_worker/service_worker_container.mojom
[modify] https://crrev.com/5dcaa25d8585ce209f32122a800a3cec648cea60/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/5dcaa25d8585ce209f32122a800a3cec648cea60/content/renderer/service_worker/service_worker_dispatcher.cc
[modify] https://crrev.com/5dcaa25d8585ce209f32122a800a3cec648cea60/content/renderer/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/5dcaa25d8585ce209f32122a800a3cec648cea60/content/renderer/service_worker/service_worker_dispatcher_unittest.cc
[modify] https://crrev.com/5dcaa25d8585ce209f32122a800a3cec648cea60/content/renderer/service_worker/service_worker_message_filter.cc
[modify] https://crrev.com/5dcaa25d8585ce209f32122a800a3cec648cea60/content/renderer/service_worker/service_worker_message_filter.h
[modify] https://crrev.com/5dcaa25d8585ce209f32122a800a3cec648cea60/content/renderer/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/5dcaa25d8585ce209f32122a800a3cec648cea60/content/renderer/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/5dcaa25d8585ce209f32122a800a3cec648cea60/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/5dcaa25d8585ce209f32122a800a3cec648cea60/content/renderer/service_worker/web_service_worker_provider_impl.cc
[modify] https://crrev.com/5dcaa25d8585ce209f32122a800a3cec648cea60/content/renderer/service_worker/web_service_worker_provider_impl.h

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c48dbe68d0b846b0c9e5be9919157e0d52a7150b

commit c48dbe68d0b846b0c9e5be9919157e0d52a7150b
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Tue Nov 21 05:53:26 2017

[ServiceWorker] Implement ServiceWorkerContainer.CountFeature

The CL mojofies the legacy IPC:ServiceWorkerMsg_CountFeature.
The method is to notify the client that its controller used a feature,
for UseCounter purposes, from browser to renderer.

And also do some code cleanup after finishing mojofication of all the
methods in ServiceWorkerContainer.

BUG= 755861 

Change-Id: I5200a7249d5968dd00dd1863dee128a140fda624
Reviewed-on: https://chromium-review.googlesource.com/753122
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Han Leon <leon.han@intel.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Cr-Commit-Position: refs/heads/master@{#518142}
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/content/browser/DEPS
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/content/browser/service_worker/service_worker_storage.cc
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/content/common/service_worker/service_worker_container.mojom
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/content/renderer/service_worker/service_worker_dispatcher.cc
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/content/renderer/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/content/renderer/service_worker/service_worker_dispatcher_unittest.cc
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/content/renderer/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/content/renderer/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/content/renderer/service_worker/web_service_worker_provider_impl.cc
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/content/renderer/service_worker/web_service_worker_provider_impl.h
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h
[modify] https://crrev.com/c48dbe68d0b846b0c9e5be9919157e0d52a7150b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProviderClient.h

Status: Fixed (was: Started)
The ServiceWorkerStateChanged will be implemented in https://bugs.chromium.org/p/chromium/issues/detail?id=772788

Sign in to add a comment