Issue metadata
Sign in to add a comment
|
Chrome unified language component for iOS |
||||||||||||||||||||||||||||||||||||
Issue descriptionTechnical feature description: Unify user language modeling from various Chrome components (e.g. translate, Zine) into one separate "language" component on iOS. This is the iOS-specific version of the launch described in crbug.com/736929. Eng owner: martis@ PM owner: yyushkina@ Design doc (send to chrome-design-docs@): go/chrome-language-component See particularly the iOS section of the document. Finch/experimentation: Back-end changes only, no experiments planned.
,
Sep 18 2017
Hi, Is manual testing required for this? If so please fill in the testing survey that is by default part of Comment 0 when creating a new launch bug. Thanks,
,
Sep 19 2017
I don't think this requires manual testing; it has extensive browser tests. Setting testing flag to NA.
,
Sep 25 2017
We won't make M63 for this feature - pushing back to M64.
,
Oct 30 2017
Gentle reminder: M64 feature freeze is on Friday (11/10). If you plan to ship this feature for M-64, please transition to a review/request state by 11/10 (Launch-M-Status=Review-Requested/Approval-Requested). Thank you.
,
Oct 30 2017
,
Oct 30 2017
Changing to type=feature because this is really in essence a refactor.
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1 commit a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1 Author: Michael Martis <martis@chromium.org> Date: Wed Nov 01 04:08:45 2017 Moved language detection dispatch into the language component on iOS. This comprises: - Attaching an iOS language detection client (similar to the existing Content-based client) to each web state - Updating the language detection controller (which does the actual CLD) to notify the language detection client rather than translate code, and to use core datatypes (rather than iOS-specific ones) - Updating the translate driver to receive language info via a callback from the language detection client - Updating unit and integration tests to account for these changes Bug: 755856 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7544863835d0d507a3e1453973f55c7fc918ba83 Reviewed-on: https://chromium-review.googlesource.com/740421 Commit-Queue: Michael Martis <martis@chromium.org> Reviewed-by: Renjie Liu <renjieliu@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#513070} [add] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/components/language/ios/browser/BUILD.gn [add] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/components/language/ios/browser/DEPS [add] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/components/language/ios/browser/ios_language_detection_tab_helper.h [add] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/components/language/ios/browser/ios_language_detection_tab_helper.mm [modify] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/components/translate/ios/browser/BUILD.gn [modify] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/components/translate/ios/browser/ios_translate_driver.h [modify] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/components/translate/ios/browser/ios_translate_driver.mm [modify] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/components/translate/ios/browser/language_detection_controller.h [modify] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/components/translate/ios/browser/language_detection_controller.mm [modify] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/components/translate/ios/browser/language_detection_controller_unittest.mm [modify] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/ios/chrome/browser/tabs/BUILD.gn [modify] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/ios/chrome/browser/tabs/tab_helper_util.mm [modify] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/ios/chrome/browser/translate/BUILD.gn [modify] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/ios/chrome/browser/translate/chrome_ios_translate_client.h [modify] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/ios/chrome/browser/translate/chrome_ios_translate_client.mm [modify] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/ios/chrome/browser/translate/translate_egtest.mm [modify] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/ios/web_view/internal/translate/cwv_translation_controller.mm [modify] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/ios/web_view/internal/translate/web_view_translate_client.h [modify] https://crrev.com/a6f9dfdbbe249d8829b87447ed5a7086e2ed99c1/ios/web_view/internal/translate/web_view_translate_client.mm
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f5a1ab101a8cdec721723f1f2cc5e0e5e60db84 commit 5f5a1ab101a8cdec721723f1f2cc5e0e5e60db84 Author: Michael Martis <martis@chromium.org> Date: Thu Nov 02 02:09:07 2017 Added a helper function to improve readability in the translate egtest. Bug: 755856 Change-Id: I7350745d6273f4830e62264ca3c7ed3b27764274 Reviewed-on: https://chromium-review.googlesource.com/749605 Commit-Queue: Michael Martis <martis@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#513371} [modify] https://crrev.com/5f5a1ab101a8cdec721723f1f2cc5e0e5e60db84/ios/chrome/browser/translate/translate_egtest.mm
,
Nov 2 2017
|
|||||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||||||||
Comment 1 Deleted