New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755855 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 755071



Sign in to add a comment

Expand button accessibility string is not helpful in MD notification

Project Member Reported by tetsui@chromium.org, Aug 16 2017

Issue description

Currently, the accessibility string of the expand button is "Maximize/Minimize", which is not helpful in terms of describing what the button would actually do.

From the examples of chrome://settings, it seems the "Expand notification" or "Show notification detail" would be more appropriate as the string.
 

Comment 1 by tetsui@chromium.org, Aug 17 2017

Blockedon: 755071

Comment 2 by tetsui@chromium.org, Aug 17 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/829feacbdd06530940851d5baf3f2f7422b0aebc

commit 829feacbdd06530940851d5baf3f2f7422b0aebc
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Fri Aug 18 02:23:31 2017

Improve accessibility string of expand button.

In MD notification, expand button had accessibility strings
"Maximize"/"Minimize", but dedicated strings that describe exactly what
the button do are better in terms of the usability from screen reader.

The accessibility string was added in the CL: https://crrev.com/c/612962

TEST=manual
BUG= 755855 

Change-Id: I8fc4bc15d4db60e5439b41a23c198f4532de29ed
Reviewed-on: https://chromium-review.googlesource.com/618072
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495429}
[modify] https://crrev.com/829feacbdd06530940851d5baf3f2f7422b0aebc/ui/message_center/views/notification_header_view.cc
[modify] https://crrev.com/829feacbdd06530940851d5baf3f2f7422b0aebc/ui/strings/ui_strings.grd

Comment 4 by tetsui@chromium.org, Aug 18 2017

Status: Fixed (was: Started)

Sign in to add a comment