New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 755853 link

Starred by 3 users
Status: Fixed
Owner:
eirage@chromium.org
Closed: Aug 2017
Cc:
█ krajshree@chromium.org
ajha@chromium.org
nzolghadr@chromium.org
dtapu...@chromium.org
█ brajkumar@chromium.org
eirage@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Bookmark chip is seen missing on coming back to the list

Project Member Reported by keerthan...@techmahindra.com, Aug 16 2017 
Chrome Version: 61.0.3187.0
OS:Ubuntu 14.04

What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://bookmarks
(2)Add some bookmarks and drag any one to the bottom and go back to the list
(3)Observe

Expected:Bookmark chip should be seen
Actual:Instead, it's missing

This is a Regression issue broken in M-62

will update other info soon
BookmarksActual.ogv
531 KB View Download

Comment 1 by keerthan...@techmahindra.com, Aug 16 2017 

Manual Bisect Info:
===================
Good Build:62.0.3186.0
Bad Build: 62.0.3187.0
Expected_bookmark chip.ogv
720 KB View Download

Comment 2 by krajshree@chromium.org, Aug 16 2017

Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Ubuntu 14.04 using latest chrome version #62.0.3187.0.

Comment 3 by keerthan...@techmahindra.com, Aug 16 2017

Labels: -Needs-Bisect ReleaseBlock-Stable hasbisect OS-Windows
Owner: dtapu...@chromium.org
Status: Assigned (was: Untriaged)
Bisect Information:
-------------------
You are probably looking for a change made after 494615 (known good), but no later than 494624 (first known bad).

CHANGELOG URL:
--------------
 https://chromium.googlesource.com/chromium/src/+log/a7482a88d73040a616ef53294eeef75ca8b6c5a2..ae213d06e7dfe13bcfde08d450a3a4181f560c08

suspecting https://chromium.googlesource.com/chromium/src/+/2e27e8ef7352fa68de51b0c59257604c66b9781d from above url


@dtapuska: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Comment 4 by dtapu...@chromium.org, Aug 16 2017 

Looked a little bit. Seems like a dragstart is being generated after you leave the bounds and that cancels the bubble that is showing.

Comment 5 by dtapu...@chromium.org, Aug 16 2017

Cc: nzolghadr@chromium.org dtapu...@chromium.org
Owner: eirage@chromium.org
Ella can you figure out what is going on? I don't expect the drag start to occur..
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed3b65691d52324dd05131cf9675a943701f877a

commit ed3b65691d52324dd05131cf9675a943701f877a
Author: Ella Ge <eirage@chromium.org>
Date: Mon Aug 21 18:41:18 2017

RelativeMotionEvent return kHandledSuppressed

RelativeMotionEvent should return kHandledSuppressed
instead of kNotHandled to prevent handle drag event

Bug:  755853 
Change-Id: If669df2d154f28bab94e79468d1508eabeab66d0
Reviewed-on: https://chromium-review.googlesource.com/619550
Commit-Queue: Ella Ge <eirage@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496002}
[modify] https://crrev.com/ed3b65691d52324dd05131cf9675a943701f877a/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/ed3b65691d52324dd05131cf9675a943701f877a/third_party/WebKit/Source/core/input/PointerEventManager.cpp

Comment 7 by dtapu...@chromium.org, Aug 21 2017

Status: Fixed (was: Assigned)

Comment 8 by eirage@chromium.org, Aug 21 2017

Cc: eirage@chromium.org
 Issue 756402  has been merged into this issue.
►

Sign in to add a comment