New issue
Advanced search Search tips

Issue 755847 link

Starred by 1 user
Status: Duplicate
Merged: issue 654783
Owner: ----
Closed: Aug 2017
Cc:
tapted@chromium.org
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

InkDrop effect does not work on MacViews

Reported by jongkwon...@navercorp.com, Aug 16 2017 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3164.0 Safari/537.36

Steps to reproduce the problem:
1. Build chromium with mac_views_browser=1
2. Move the mouse pointer over reload button of toolbar

What is the expected behavior?
Reload button should show highlight effect

What went wrong?
Reload button does not show highlight effect. Same with other toolbar buttons.

Did this work before? N/A 

Chrome version: 62.0.3164.0  Channel: n/a
OS Version: OS X 10.12.6
Flash Version:

Comment 1 Deleted

Comment 2 by jongkwon...@navercorp.com, Aug 16 2017 

It might dependent on PlatformStyle::kUseRipples. I'll check again with this flag changed.

Comment 3 by sdy@chromium.org, Aug 16 2017

Cc: tapted@chromium.org
Components: -UI UI>Browser
Labels: Proj-MacViews MacViews-Browser
Mac doesn't get ripples AFAIK.

Comment 4 by tapted@chromium.org, Aug 17 2017

Cc: ellyjo...@chromium.org
Status: Available (was: Unconfirmed)
There shouldn't be a ripple upon clicking (see  Issue 701888 ), but there should be a hover/highlight (see  Issue 654783 ). Both of those are fixed - maybe r492987 needs a tweak.

Comment 5 by jongkwon...@navercorp.com, Aug 17 2017 

I see. It seems to be fixed on version 62.0.3188.0 (Developer Build).

Comment 6 by tapted@chromium.org, Aug 17 2017

Mergedinto: 654783
Status: Duplicate (was: Available)
Ah, yep. that landed in 3181.
►

Sign in to add a comment