New issue
Advanced search Search tips

Issue 755840 link

Starred by 3 users
Status: Started
Owner:
siggi@chromium.org
Cc:
chrisha@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocked on:
issue 874968


Sign in to add a comment

[Tab Metrics] Track CPU usage during session restore and background tab opening

Project Member Reported by ducbui@google.com, Aug 16 2017 
We want to measure the CPU utilization of the web browser during session restore and when the browser is loading background tabs. These metrics aim to avoid having a burning tab experience while doing session restore or opening a set of background tabs.

Comment 1 by holte@chromium.org, Aug 21 2017

Components: -Internals>Metrics
Labels: Hotlist-Metrics
Moving bugs about specific metrics recording out of Internals>Metrics component into Hotlist-Metrics

Comment 2 by ducbui@google.com, Aug 25 2017

Cc: -fmea...@chromium.org ducbui@google.com oysteine@chromium.org
Owner: fmea...@chromium.org
Change owner to my host fmeawad@
+oysteine@

Comment 3 by fmea...@chromium.org, Sep 5 2017

Labels: Hotlist-TooManyTabs

Comment 4 by siggi@chromium.org, Apr 10 2018

Cc: -oysteine@chromium.org -ducbui@google.com chrisha@chromium.org
Labels: -Pri-3 Pri-2
Owner: siggi@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a28c6848054ae173930a6a96a1507981b5e843fb

commit a28c6848054ae173930a6a96a1507981b5e843fb
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Tue Apr 17 20:20:47 2018

RC: Bump default render CPU sampling interval to 10 minutes.

R=chrisha@chromium.org

Bug: 755840
Change-Id: Ife8febb03b0fb8d48b864b9987488d90893c4bbf
Reviewed-on: https://chromium-review.googlesource.com/1005408
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551458}
[modify] https://crrev.com/a28c6848054ae173930a6a96a1507981b5e843fb/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.cc
[modify] https://crrev.com/a28c6848054ae173930a6a96a1507981b5e843fb/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.h

Comment 6 by chrisha@chromium.org, Apr 18 2018 

This work has been generalized to making the CPU measurements run all the time, to inform the site characteristics database, and for reuse during session restore / BTO scheduling, as well as tab discarding.

The UKM design has changed slightly, and is described in this companion doc:

https://docs.google.com/document/d/1Y_A4f-oi5qsbOBLvMzbnAkJm3CtQb2dP68-0ZzguKLo/edit#

Comment 7 by chrisha@chromium.org, Apr 18 2018

Labels: -Pri-2 M-68 Pri-1

Comment 8 by chrisha@chromium.org, Apr 18 2018

Labels: OS-Android OS-Chrome
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bdff27a235e5f469c29a229e78f367e9009de53

commit 0bdff27a235e5f469c29a229e78f367e9009de53
Author: Chris Hamilton <chrisha@chromium.org>
Date: Wed Apr 18 19:12:31 2018

Update CPUUsageMeasurement UKM definition.

BUG=755840

Change-Id: I577b0f0c272d6de1debef88d088231a5f110c825
Reviewed-on: https://chromium-review.googlesource.com/1016025
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551773}
[modify] https://crrev.com/0bdff27a235e5f469c29a229e78f367e9009de53/services/resource_coordinator/observers/metrics_collector.cc
[modify] https://crrev.com/0bdff27a235e5f469c29a229e78f367e9009de53/tools/metrics/ukm/ukm.xml
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5aa7962d76c17ba3f2d9b2a5bf9a50d1c2ec68b

commit e5aa7962d76c17ba3f2d9b2a5bf9a50d1c2ec68b
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Wed Apr 18 20:01:32 2018

RC: Index render process map by RPH ID instead of handle.

This avoids creating a new entry in the map for each process on each
cycle on Windows, which was happening as of my last change.
Add a state variable to keep track of when a measurement cycle is
underway in preparation for allowing measurement requests at arbitrary
times. Replace the delegate class with a simple virtual function, and
use protected access control in combination with a Testing* subclass
to expose class' internal state for testing. This allows removing all
test-specific code from the class declaration.

Bug: 755840
Change-Id: I7658a355525fffe92327bb85151ba124cc81d371
Reviewed-on: https://chromium-review.googlesource.com/1015299
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551794}
[modify] https://crrev.com/e5aa7962d76c17ba3f2d9b2a5bf9a50d1c2ec68b/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.cc
[modify] https://crrev.com/e5aa7962d76c17ba3f2d9b2a5bf9a50d1c2ec68b/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.h
[modify] https://crrev.com/e5aa7962d76c17ba3f2d9b2a5bf9a50d1c2ec68b/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e68ce04b2cdf455de1c4216db212cda5a91abdd0

commit e68ce04b2cdf455de1c4216db212cda5a91abdd0
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Tue Apr 24 13:09:08 2018

RC: Fire OnProcessCPUUsageReady after a CPU measurement cycle.

Also rearrange method order a little and rename HandleMetrics to
DispatchMetrics, as there's no need to pass the metrics map to the
method.

R=chrisha@chromium.org

Bug: 755840
Change-Id: If316817f540315bf8c0465d1d32be60734183db6
Reviewed-on: https://chromium-review.googlesource.com/1019563
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553066}
[modify] https://crrev.com/e68ce04b2cdf455de1c4216db212cda5a91abdd0/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.cc
[modify] https://crrev.com/e68ce04b2cdf455de1c4216db212cda5a91abdd0/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.h
[modify] https://crrev.com/e68ce04b2cdf455de1c4216db212cda5a91abdd0/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc
Project Member

Comment 13 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76993c109acfed19f7d43d7e7c2731a55c89abf7

commit 76993c109acfed19f7d43d7e7c2731a55c89abf7
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Wed May 02 21:10:57 2018

RC: Add a batch measurement update interface and mechanism.

Bug: 755840
Change-Id: I3f27b8a1138690f2b9ed9cd6af442bc1758a5f38
Reviewed-on: https://chromium-review.googlesource.com/1028453
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555530}
[modify] https://crrev.com/76993c109acfed19f7d43d7e7c2731a55c89abf7/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.cc
[modify] https://crrev.com/76993c109acfed19f7d43d7e7c2731a55c89abf7/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.h
[modify] https://crrev.com/76993c109acfed19f7d43d7e7c2731a55c89abf7/services/resource_coordinator/coordination_unit/system_coordination_unit_impl.cc
[modify] https://crrev.com/76993c109acfed19f7d43d7e7c2731a55c89abf7/services/resource_coordinator/coordination_unit/system_coordination_unit_impl.h
[modify] https://crrev.com/76993c109acfed19f7d43d7e7c2731a55c89abf7/services/resource_coordinator/coordination_unit/system_coordination_unit_impl_unittest.cc
[modify] https://crrev.com/76993c109acfed19f7d43d7e7c2731a55c89abf7/services/resource_coordinator/public/mojom/coordination_unit.mojom
Project Member

Comment 15 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cb7f1f8cb41f066747b399cc2c5364fd9e163ff

commit 5cb7f1f8cb41f066747b399cc2c5364fd9e163ff
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Thu May 03 13:34:58 2018

RC: Refactor to allow testing the dispatched measurement batch.

This is in preparation for adding and testing memory measurement.

Bug: 755840
Change-Id: I2883368c48cc34b0ec10d247eaf374063c4fcf18
Reviewed-on: https://chromium-review.googlesource.com/1037244
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555706}
[modify] https://crrev.com/5cb7f1f8cb41f066747b399cc2c5364fd9e163ff/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.cc
[modify] https://crrev.com/5cb7f1f8cb41f066747b399cc2c5364fd9e163ff/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.h
[modify] https://crrev.com/5cb7f1f8cb41f066747b399cc2c5364fd9e163ff/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc
Project Member

Comment 17 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b006d85526e1b6ca38e63931826e6f142c066917

commit b006d85526e1b6ca38e63931826e6f142c066917
Author: Marc Treib <treib@chromium.org>
Date: Fri May 04 08:09:33 2018

Revert "RC: Add memory measurement to render process probe."

This reverts commit 6c3cc29541a54364af0392c0c93c3878a79a7560.

Reason for revert: ResourceCoordinatorRenderProcessProbeBrowserTest.TrackAndMeasureActiveRenderProcesses fails on Mac Asan 64:
https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20%281%29/40456
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FMac_ASan_64_Tests__1_%2F40456%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FResourceCoordinatorRenderProcessProbeBrowserTest.TrackAndMeasureActiveRenderProcesses%2F0

../../chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc:171: Failure
Expected: (0u) != (measurement->private_footprint_kb), actual: 0 vs 0

Original change's description:
> RC: Add memory measurement to render process probe.
> 
> Bug: 755840
> Change-Id: I96af63e817abe9bdefb0916da4d652e97c620a2c
> Reviewed-on: https://chromium-review.googlesource.com/1037631
> Commit-Queue: Chris Hamilton <chrisha@chromium.org>
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555844}

TBR=chrisha@chromium.org,fdoray@chromium.org,erikchen@chromium.org,siggi@chromium.org

Change-Id: If2e102252f43c0b62b6a539e0df7793ee05281bc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 755840
Reviewed-on: https://chromium-review.googlesource.com/1043805
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556009}
[modify] https://crrev.com/b006d85526e1b6ca38e63931826e6f142c066917/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.cc
[modify] https://crrev.com/b006d85526e1b6ca38e63931826e6f142c066917/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.h
[modify] https://crrev.com/b006d85526e1b6ca38e63931826e6f142c066917/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc
Project Member

Comment 18 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c02169b8c9cf360d462c615d480ec3a4d5fe4a44

commit c02169b8c9cf360d462c615d480ec3a4d5fe4a44
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Tue May 08 19:36:11 2018

RC: Add memory measurement to render process probe.

This is a re-land of https://chromium-review.googlesource.com/1037631
with a fix to make the test robust against occasional failure to
measure render process' memory. There's an inherent race in the
memory measurement that may occur on spurious renderer creation and
death.

Bug: 755840
Change-Id: Ia5108d844fb41d41e8690868558af99fcb598a89
Reviewed-on: https://chromium-review.googlesource.com/1050508
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556929}
[modify] https://crrev.com/c02169b8c9cf360d462c615d480ec3a4d5fe4a44/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.cc
[modify] https://crrev.com/c02169b8c9cf360d462c615d480ec3a4d5fe4a44/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.h
[modify] https://crrev.com/c02169b8c9cf360d462c615d480ec3a4d5fe4a44/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc
Project Member

Comment 20 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb27eae7ba6d7ed839227d2f5912943a05a8b4fd

commit eb27eae7ba6d7ed839227d2f5912943a05a8b4fd
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Wed May 16 15:29:10 2018

Add a GetCumulativeCPUUsage function to ProcessMetrics.

This also makes the GetPlatformIndependentCPUUsage function generic,
except for a couple of unsupported platforms that seem to retrieve
fractional CPU utilization directly from kernel.

Bug: 755840
Change-Id: I8254a1f1371d7d35d0eeec27f6f4efda03b0dbf9
Reviewed-on: https://chromium-review.googlesource.com/1058079
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559110}
[modify] https://crrev.com/eb27eae7ba6d7ed839227d2f5912943a05a8b4fd/base/process/process_metrics.cc
[modify] https://crrev.com/eb27eae7ba6d7ed839227d2f5912943a05a8b4fd/base/process/process_metrics.h
[modify] https://crrev.com/eb27eae7ba6d7ed839227d2f5912943a05a8b4fd/base/process/process_metrics_freebsd.cc
[modify] https://crrev.com/eb27eae7ba6d7ed839227d2f5912943a05a8b4fd/base/process/process_metrics_fuchsia.cc
[modify] https://crrev.com/eb27eae7ba6d7ed839227d2f5912943a05a8b4fd/base/process/process_metrics_ios.cc
[modify] https://crrev.com/eb27eae7ba6d7ed839227d2f5912943a05a8b4fd/base/process/process_metrics_linux.cc
[modify] https://crrev.com/eb27eae7ba6d7ed839227d2f5912943a05a8b4fd/base/process/process_metrics_mac.cc
[modify] https://crrev.com/eb27eae7ba6d7ed839227d2f5912943a05a8b4fd/base/process/process_metrics_openbsd.cc
[modify] https://crrev.com/eb27eae7ba6d7ed839227d2f5912943a05a8b4fd/base/process/process_metrics_unittest.cc
[modify] https://crrev.com/eb27eae7ba6d7ed839227d2f5912943a05a8b4fd/base/process/process_metrics_win.cc
[modify] https://crrev.com/eb27eae7ba6d7ed839227d2f5912943a05a8b4fd/base/time/time.cc
[modify] https://crrev.com/eb27eae7ba6d7ed839227d2f5912943a05a8b4fd/base/time/time.h
[modify] https://crrev.com/eb27eae7ba6d7ed839227d2f5912943a05a8b4fd/base/time/time_unittest.cc
[modify] https://crrev.com/eb27eae7ba6d7ed839227d2f5912943a05a8b4fd/base/time/time_win.cc
[modify] https://crrev.com/eb27eae7ba6d7ed839227d2f5912943a05a8b4fd/base/time/time_win_unittest.cc
Project Member

Comment 21 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d49fd528eb51d951b6747a241b41a6e4485b492d

commit d49fd528eb51d951b6747a241b41a6e4485b492d
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Wed May 16 18:56:46 2018

RC: Capture cumulative process CPU measurements in render process probe.

The old-style CPUUsage attributes are supported by transforming the
batched cumulatives in the System CU.

Bug: 755840
Change-Id: I3e5d3d66223070a90ad35a835a210db0bb257809
Reviewed-on: https://chromium-review.googlesource.com/1060127
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559209}
[modify] https://crrev.com/d49fd528eb51d951b6747a241b41a6e4485b492d/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.cc
[modify] https://crrev.com/d49fd528eb51d951b6747a241b41a6e4485b492d/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.h
[modify] https://crrev.com/d49fd528eb51d951b6747a241b41a6e4485b492d/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc
[modify] https://crrev.com/d49fd528eb51d951b6747a241b41a6e4485b492d/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.h
[modify] https://crrev.com/d49fd528eb51d951b6747a241b41a6e4485b492d/services/resource_coordinator/coordination_unit/system_coordination_unit_impl.cc
[modify] https://crrev.com/d49fd528eb51d951b6747a241b41a6e4485b492d/services/resource_coordinator/coordination_unit/system_coordination_unit_impl.h
[modify] https://crrev.com/d49fd528eb51d951b6747a241b41a6e4485b492d/services/resource_coordinator/coordination_unit/system_coordination_unit_impl_unittest.cc
[modify] https://crrev.com/d49fd528eb51d951b6747a241b41a6e4485b492d/services/resource_coordinator/public/mojom/coordination_unit.mojom
Project Member

Comment 22 by bugdroid1@chromium.org, May 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6400010f62a8ce09c6ca4c3b7c035fdccfdc026

commit b6400010f62a8ce09c6ca4c3b7c035fdccfdc026
Author: Shuotao Gao <stgao@chromium.org>
Date: Sat May 19 02:02:10 2018

Revert "RC: Capture cumulative process CPU measurements in render process probe."

This reverts commit d49fd528eb51d951b6747a241b41a6e4485b492d.

Reason for revert: 
This CL made ResourceCoordinatorRenderProcessProbeBrowserTest.TrackAndMeasureActiveRenderProcesses flaky.

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy6QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKyAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzgyMjYvdml6X2Jyb3dzZXJfdGVzdHMvVW1WemIzVnlZMlZEYjI5eVpHbHVZWFJ2Y2xKbGJtUmxjbEJ5YjJObGMzTlFjbTlpWlVKeWIzZHpaWEpVWlhOMExsUnlZV05yUVc1a1RXVmhjM1Z5WlVGamRHbDJaVkpsYm1SbGNsQnliMk5sYzNObGN3PT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Original change's description:
> RC: Capture cumulative process CPU measurements in render process probe.
> 
> The old-style CPUUsage attributes are supported by transforming the
> batched cumulatives in the System CU.
> 
> Bug: 755840
> Change-Id: I3e5d3d66223070a90ad35a835a210db0bb257809
> Reviewed-on: https://chromium-review.googlesource.com/1060127
> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
> Reviewed-by: Will Harris <wfh@chromium.org>
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#559209}

TBR=chrisha@chromium.org,fdoray@chromium.org,wfh@chromium.org,siggi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 755840
Change-Id: I7a90f710a553c9d17c9d4e35218d8cf5a5dfafb7
Reviewed-on: https://chromium-review.googlesource.com/1066950
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560142}
[modify] https://crrev.com/b6400010f62a8ce09c6ca4c3b7c035fdccfdc026/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.cc
[modify] https://crrev.com/b6400010f62a8ce09c6ca4c3b7c035fdccfdc026/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.h
[modify] https://crrev.com/b6400010f62a8ce09c6ca4c3b7c035fdccfdc026/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc
[modify] https://crrev.com/b6400010f62a8ce09c6ca4c3b7c035fdccfdc026/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.h
[modify] https://crrev.com/b6400010f62a8ce09c6ca4c3b7c035fdccfdc026/services/resource_coordinator/coordination_unit/system_coordination_unit_impl.cc
[modify] https://crrev.com/b6400010f62a8ce09c6ca4c3b7c035fdccfdc026/services/resource_coordinator/coordination_unit/system_coordination_unit_impl.h
[modify] https://crrev.com/b6400010f62a8ce09c6ca4c3b7c035fdccfdc026/services/resource_coordinator/coordination_unit/system_coordination_unit_impl_unittest.cc
[modify] https://crrev.com/b6400010f62a8ce09c6ca4c3b7c035fdccfdc026/services/resource_coordinator/public/mojom/coordination_unit.mojom
Project Member

Comment 23 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90a3ae316e68a11ca4a4e9080daf902c7e1b23f0

commit 90a3ae316e68a11ca4a4e9080daf902c7e1b23f0
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Tue May 22 14:53:22 2018

RC: Capture cumulative process CPU measurements in render process probe.

The old-style CPUUsage attributes are supported by transforming the
batched cumulatives in the System CU.

This is a re-land of https://chromium-review.googlesource.com/1060127.

TBR: wfh@chromium.org
Bug: 755840
Change-Id: I361ec98549945d3ba6f048ba6279bff3d1aaa9ca
Reviewed-on: https://chromium-review.googlesource.com/1067671
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560582}
[modify] https://crrev.com/90a3ae316e68a11ca4a4e9080daf902c7e1b23f0/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.cc
[modify] https://crrev.com/90a3ae316e68a11ca4a4e9080daf902c7e1b23f0/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.h
[modify] https://crrev.com/90a3ae316e68a11ca4a4e9080daf902c7e1b23f0/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc
[modify] https://crrev.com/90a3ae316e68a11ca4a4e9080daf902c7e1b23f0/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.h
[modify] https://crrev.com/90a3ae316e68a11ca4a4e9080daf902c7e1b23f0/services/resource_coordinator/coordination_unit/system_coordination_unit_impl.cc
[modify] https://crrev.com/90a3ae316e68a11ca4a4e9080daf902c7e1b23f0/services/resource_coordinator/coordination_unit/system_coordination_unit_impl.h
[modify] https://crrev.com/90a3ae316e68a11ca4a4e9080daf902c7e1b23f0/services/resource_coordinator/coordination_unit/system_coordination_unit_impl_unittest.cc
[modify] https://crrev.com/90a3ae316e68a11ca4a4e9080daf902c7e1b23f0/services/resource_coordinator/public/mojom/coordination_unit.mojom
Project Member

Comment 25 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce246a382d9d150fea4a649023da10d3ac0491c3

commit ce246a382d9d150fea4a649023da10d3ac0491c3
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Wed May 23 13:05:41 2018

Render Process Probe: Fix a unittest flake.

As-is a CPU usage measurement of zero will be conflated with the
sentinel value for a new entry, so use a TimeDelta(-1) instead.

Bug:  844388 , 755840
Change-Id: Ia8478dd7e7735aab4335426c3010fb94ee58c832
Reviewed-on: https://chromium-review.googlesource.com/1067863
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561051}
[modify] https://crrev.com/ce246a382d9d150fea4a649023da10d3ac0491c3/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.cc
[modify] https://crrev.com/ce246a382d9d150fea4a649023da10d3ac0491c3/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.h
[modify] https://crrev.com/ce246a382d9d150fea4a649023da10d3ac0491c3/chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc
Project Member

Comment 26 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c502833d6d71871a8b52e10fa998f9081675fec1

commit c502833d6d71871a8b52e10fa998f9081675fec1
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Thu May 24 14:29:06 2018

Remove redundant resource_coordinator in file and class names.

Bug: 755840
Change-Id: If82a6287bacecb3e636b8d0d60cae83e5a3d35a3
Reviewed-on: https://chromium-review.googlesource.com/1070226
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561495}
[modify] https://crrev.com/c502833d6d71871a8b52e10fa998f9081675fec1/chrome/browser/BUILD.gn
[modify] https://crrev.com/c502833d6d71871a8b52e10fa998f9081675fec1/chrome/browser/chrome_browser_main.cc
[rename] https://crrev.com/c502833d6d71871a8b52e10fa998f9081675fec1/chrome/browser/resource_coordinator/render_process_probe.cc
[rename] https://crrev.com/c502833d6d71871a8b52e10fa998f9081675fec1/chrome/browser/resource_coordinator/render_process_probe.h
[rename] https://crrev.com/c502833d6d71871a8b52e10fa998f9081675fec1/chrome/browser/resource_coordinator/render_process_probe_browsertest.cc
[rename] https://crrev.com/c502833d6d71871a8b52e10fa998f9081675fec1/chrome/browser/resource_coordinator/tab_helper.cc
[rename] https://crrev.com/c502833d6d71871a8b52e10fa998f9081675fec1/chrome/browser/resource_coordinator/tab_helper.h
[modify] https://crrev.com/c502833d6d71871a8b52e10fa998f9081675fec1/chrome/browser/resource_coordinator/tab_load_tracker.h
[modify] https://crrev.com/c502833d6d71871a8b52e10fa998f9081675fec1/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/c502833d6d71871a8b52e10fa998f9081675fec1/chrome/browser/resource_coordinator/tab_manager_stats_collector.cc
[modify] https://crrev.com/c502833d6d71871a8b52e10fa998f9081675fec1/chrome/browser/resource_coordinator/tab_manager_stats_collector_unittest.cc
[modify] https://crrev.com/c502833d6d71871a8b52e10fa998f9081675fec1/chrome/browser/resource_coordinator/tab_manager_unittest.cc
[modify] https://crrev.com/c502833d6d71871a8b52e10fa998f9081675fec1/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/c502833d6d71871a8b52e10fa998f9081675fec1/chrome/test/BUILD.gn
[modify] https://crrev.com/c502833d6d71871a8b52e10fa998f9081675fec1/tools/metrics/ukm/ukm.xml
Project Member

Comment 27 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd6ff3fc84bd780c80d6d29f729488f54e74d6bc

commit bd6ff3fc84bd780c80d6d29f729488f54e74d6bc
Author: Fredrik Söderquist <fs@opera.com>
Date: Thu May 24 15:46:33 2018

Remove stray, unneeded (and incorrect) forward declaration

WebContentsObserver is in the 'content' namespace, not in the global.
This causes a collision with a 'using' directive for the same class,
which breaks Jumbo builds.

TBR=avi@chromium.org,siggi@chromium.org

Bug: 755840,  846328 
Change-Id: I977106611b374c955bf3c5c161c8a52eea927698
Reviewed-on: https://chromium-review.googlesource.com/1071663
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#561512}
[modify] https://crrev.com/bd6ff3fc84bd780c80d6d29f729488f54e74d6bc/chrome/browser/resource_coordinator/tab_load_tracker.h
Project Member

Comment 28 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbd86ffeceabb942c9926ddafba7e46a83e791e4

commit cbd86ffeceabb942c9926ddafba7e46a83e791e4
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Thu May 24 17:01:03 2018

Hoist an interface on RenderProcessProbe.

This allows mocking it for testing the upcoming
PerformanceMeasurementManager, which will be a RenderProcessProbe user.

Bug: 755840
Change-Id: I7188529a106eb66044d71a514e26a6d6bd0b65ae
Reviewed-on: https://chromium-review.googlesource.com/1071725
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561529}
[modify] https://crrev.com/cbd86ffeceabb942c9926ddafba7e46a83e791e4/chrome/browser/resource_coordinator/render_process_probe.cc
[modify] https://crrev.com/cbd86ffeceabb942c9926ddafba7e46a83e791e4/chrome/browser/resource_coordinator/render_process_probe.h
[modify] https://crrev.com/cbd86ffeceabb942c9926ddafba7e46a83e791e4/chrome/browser/resource_coordinator/render_process_probe_browsertest.cc
Project Member

Comment 29 by bugdroid1@chromium.org, May 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5590febb66285ef651212ad80a9b9d1aec08114

commit b5590febb66285ef651212ad80a9b9d1aec08114
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Mon May 28 14:20:53 2018

Start on PerformanceMeasurementManager.

This will glue together the measurement cycle from event notifications
from the TabLoadTracker to the measurements in RenderProcessProbe.
Eventually this class will also persist complete measurements issued
from an observer in the RC service by sinking notifications and
persisting to the feature database.

Bug: 755840
Change-Id: I8c6673fcf205709ad96435295f9010a6aceb3017
Reviewed-on: https://chromium-review.googlesource.com/1072232
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562258}
[modify] https://crrev.com/b5590febb66285ef651212ad80a9b9d1aec08114/chrome/browser/BUILD.gn
[add] https://crrev.com/b5590febb66285ef651212ad80a9b9d1aec08114/chrome/browser/resource_coordinator/performance_measurement_manager.cc
[add] https://crrev.com/b5590febb66285ef651212ad80a9b9d1aec08114/chrome/browser/resource_coordinator/performance_measurement_manager.h
[add] https://crrev.com/b5590febb66285ef651212ad80a9b9d1aec08114/chrome/browser/resource_coordinator/performance_measurement_manager_unittest.cc
[modify] https://crrev.com/b5590febb66285ef651212ad80a9b9d1aec08114/chrome/test/BUILD.gn
Project Member

Comment 30 by bugdroid1@chromium.org, Jun 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f9bb804b22ead5f2b779f14c97906bd29dbbf30

commit 8f9bb804b22ead5f2b779f14c97906bd29dbbf30
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Mon Jun 11 18:07:16 2018

RC: Add performance measurement notifications to PageSignalGenerator.

Bug: 755840
Change-Id: I751755efec3d739fa43b5dd3468258c8bba7941f
Reviewed-on: https://chromium-review.googlesource.com/1076508
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566057}
[modify] https://crrev.com/8f9bb804b22ead5f2b779f14c97906bd29dbbf30/chrome/browser/resource_coordinator/page_signal_receiver.cc
[modify] https://crrev.com/8f9bb804b22ead5f2b779f14c97906bd29dbbf30/chrome/browser/resource_coordinator/page_signal_receiver.h
[modify] https://crrev.com/8f9bb804b22ead5f2b779f14c97906bd29dbbf30/chrome/browser/resource_coordinator/tab_manager_resource_coordinator_signal_observer.cc
[modify] https://crrev.com/8f9bb804b22ead5f2b779f14c97906bd29dbbf30/chrome/browser/resource_coordinator/tab_manager_resource_coordinator_signal_observer.h
[modify] https://crrev.com/8f9bb804b22ead5f2b779f14c97906bd29dbbf30/services/resource_coordinator/coordination_unit/system_coordination_unit_impl.cc
[modify] https://crrev.com/8f9bb804b22ead5f2b779f14c97906bd29dbbf30/services/resource_coordinator/coordination_unit/system_coordination_unit_impl.h
[modify] https://crrev.com/8f9bb804b22ead5f2b779f14c97906bd29dbbf30/services/resource_coordinator/coordination_unit/system_coordination_unit_impl_unittest.cc
[modify] https://crrev.com/8f9bb804b22ead5f2b779f14c97906bd29dbbf30/services/resource_coordinator/observers/page_signal_generator_impl.cc
[modify] https://crrev.com/8f9bb804b22ead5f2b779f14c97906bd29dbbf30/services/resource_coordinator/observers/page_signal_generator_impl.h
[modify] https://crrev.com/8f9bb804b22ead5f2b779f14c97906bd29dbbf30/services/resource_coordinator/observers/page_signal_generator_impl_unittest.cc
[modify] https://crrev.com/8f9bb804b22ead5f2b779f14c97906bd29dbbf30/services/resource_coordinator/public/mojom/page_signal.mojom
Project Member

Comment 31 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfff4a2b93be65948b68788c07f2cec2e8374937

commit cfff4a2b93be65948b68788c07f2cec2e8374937
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Tue Jun 12 18:33:08 2018

RC: Plumb the main frame's url to the Page CU.

Bug: 755840
Change-Id: I76dc1108a56197df92263750df7a0b72c1c08d1f
Reviewed-on: https://chromium-review.googlesource.com/1095421
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566511}
[modify] https://crrev.com/cfff4a2b93be65948b68788c07f2cec2e8374937/chrome/browser/resource_coordinator/page_signal_receiver.cc
[modify] https://crrev.com/cfff4a2b93be65948b68788c07f2cec2e8374937/chrome/browser/resource_coordinator/page_signal_receiver.h
[modify] https://crrev.com/cfff4a2b93be65948b68788c07f2cec2e8374937/chrome/browser/resource_coordinator/tab_helper.cc
[modify] https://crrev.com/cfff4a2b93be65948b68788c07f2cec2e8374937/chrome/browser/resource_coordinator/tab_manager_resource_coordinator_signal_observer.cc
[modify] https://crrev.com/cfff4a2b93be65948b68788c07f2cec2e8374937/chrome/browser/resource_coordinator/tab_manager_resource_coordinator_signal_observer.h
[modify] https://crrev.com/cfff4a2b93be65948b68788c07f2cec2e8374937/services/resource_coordinator/coordination_unit/page_coordination_unit_impl.cc
[modify] https://crrev.com/cfff4a2b93be65948b68788c07f2cec2e8374937/services/resource_coordinator/coordination_unit/page_coordination_unit_impl.h
[modify] https://crrev.com/cfff4a2b93be65948b68788c07f2cec2e8374937/services/resource_coordinator/coordination_unit/page_coordination_unit_impl_unittest.cc
[modify] https://crrev.com/cfff4a2b93be65948b68788c07f2cec2e8374937/services/resource_coordinator/observers/ipc_volume_reporter_unittest.cc
[modify] https://crrev.com/cfff4a2b93be65948b68788c07f2cec2e8374937/services/resource_coordinator/observers/metrics_collector_unittest.cc
[modify] https://crrev.com/cfff4a2b93be65948b68788c07f2cec2e8374937/services/resource_coordinator/observers/page_signal_generator_impl.cc
[modify] https://crrev.com/cfff4a2b93be65948b68788c07f2cec2e8374937/services/resource_coordinator/observers/page_signal_generator_impl_unittest.cc
[modify] https://crrev.com/cfff4a2b93be65948b68788c07f2cec2e8374937/services/resource_coordinator/public/cpp/page_resource_coordinator.cc
[modify] https://crrev.com/cfff4a2b93be65948b68788c07f2cec2e8374937/services/resource_coordinator/public/cpp/page_resource_coordinator.h
[modify] https://crrev.com/cfff4a2b93be65948b68788c07f2cec2e8374937/services/resource_coordinator/public/mojom/coordination_unit.mojom
[modify] https://crrev.com/cfff4a2b93be65948b68788c07f2cec2e8374937/services/resource_coordinator/public/mojom/page_signal.mojom
Project Member

Comment 32 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a46966cad179953b001288f58ecfaf2bb9f73dd

commit 6a46966cad179953b001288f58ecfaf2bb9f73dd
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Mon Jun 18 19:05:40 2018

RC: Add a start_time to global memory dumps.

This will allow a narrower guestimate at the validity of performance
measurements relating to load events.

Bug: 755840
Change-Id: I7087c5840106102844ef7518c0ad42648f4abe3e
Reviewed-on: https://chromium-review.googlesource.com/1101304
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568096}
[modify] https://crrev.com/6a46966cad179953b001288f58ecfaf2bb9f73dd/services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
[modify] https://crrev.com/6a46966cad179953b001288f58ecfaf2bb9f73dd/services/resource_coordinator/memory_instrumentation/queued_request.h
[modify] https://crrev.com/6a46966cad179953b001288f58ecfaf2bb9f73dd/services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.cc
[modify] https://crrev.com/6a46966cad179953b001288f58ecfaf2bb9f73dd/services/resource_coordinator/public/mojom/memory_instrumentation/memory_instrumentation.mojom
Project Member

Comment 33 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2843fe1eba723fa8ca1374a0a9315682b55a567

commit c2843fe1eba723fa8ca1374a0a9315682b55a567
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Tue Jun 19 13:54:44 2018

RC: Use ScopedTimeClockOverrides to avoid Sleep and test flakes.

Bug: 755840
Change-Id: I4f693945cb65b7be8360636307dc165a7c317f4f
Reviewed-on: https://chromium-review.googlesource.com/1104868
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568433}
[modify] https://crrev.com/c2843fe1eba723fa8ca1374a0a9315682b55a567/services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
Project Member

Comment 34 by bugdroid1@chromium.org, Jul 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58c1f7a9f54df25403d71df731b04662ae5e8e73

commit 58c1f7a9f54df25403d71df731b04662ae5e8e73
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Tue Jul 03 15:11:32 2018

RC: Start measurement on PageAlmostIdle.

This way there's a consistent measurement point, irrespecive the
setting of how TabLoadTracker assesses the loaded state.

Bug: 755840
Change-Id: I42790bff863e1787db2ac804eecd117b185b5afb
Reviewed-on: https://chromium-review.googlesource.com/1119062
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572218}
[modify] https://crrev.com/58c1f7a9f54df25403d71df731b04662ae5e8e73/chrome/browser/resource_coordinator/performance_measurement_manager.cc
[modify] https://crrev.com/58c1f7a9f54df25403d71df731b04662ae5e8e73/chrome/browser/resource_coordinator/performance_measurement_manager.h
[modify] https://crrev.com/58c1f7a9f54df25403d71df731b04662ae5e8e73/chrome/browser/resource_coordinator/performance_measurement_manager_unittest.cc
Project Member

Comment 35 by bugdroid1@chromium.org, Aug 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b493ea7087351c5d589e14f03b05ab94741ac1be

commit b493ea7087351c5d589e14f03b05ab94741ac1be
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Thu Aug 02 18:35:59 2018

RC: RenderProcessProbe: record UMA metrics for measurements.

Bug: 755840
Change-Id: Ia43352a67cb170ffa8d8177de0ba00ff8dbd6c68
Reviewed-on: https://chromium-review.googlesource.com/1158967
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580262}
[modify] https://crrev.com/b493ea7087351c5d589e14f03b05ab94741ac1be/chrome/browser/resource_coordinator/render_process_probe.cc
[modify] https://crrev.com/b493ea7087351c5d589e14f03b05ab94741ac1be/chrome/browser/resource_coordinator/render_process_probe.h
[modify] https://crrev.com/b493ea7087351c5d589e14f03b05ab94741ac1be/chrome/browser/resource_coordinator/render_process_probe_browsertest.cc
[add] https://crrev.com/b493ea7087351c5d589e14f03b05ab94741ac1be/chrome/browser/resource_coordinator/render_process_probe_unittest.cc
[modify] https://crrev.com/b493ea7087351c5d589e14f03b05ab94741ac1be/chrome/test/BUILD.gn
[modify] https://crrev.com/b493ea7087351c5d589e14f03b05ab94741ac1be/services/resource_coordinator/observers/page_signal_generator_impl.cc
[modify] https://crrev.com/b493ea7087351c5d589e14f03b05ab94741ac1be/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/b493ea7087351c5d589e14f03b05ab94741ac1be/tools/metrics/histograms/histograms.xml
Project Member

Comment 36 by bugdroid1@chromium.org, Aug 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f12e2d5ca69258bc401946f063dc674271a8b7d6

commit f12e2d5ca69258bc401946f063dc674271a8b7d6
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Mon Aug 06 20:50:47 2018

RC: Ditch RenderProcessProbe repeated measurement code.

Also drop the relevant RC feature flags and UKM measurement code.

Bug: 755840
Change-Id: I055e5e7fa7f316aaaa9d48defa3450148b912700
Reviewed-on: https://chromium-review.googlesource.com/1163729
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580981}
[modify] https://crrev.com/f12e2d5ca69258bc401946f063dc674271a8b7d6/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/f12e2d5ca69258bc401946f063dc674271a8b7d6/chrome/browser/resource_coordinator/performance_measurement_manager_unittest.cc
[modify] https://crrev.com/f12e2d5ca69258bc401946f063dc674271a8b7d6/chrome/browser/resource_coordinator/render_process_probe.cc
[modify] https://crrev.com/f12e2d5ca69258bc401946f063dc674271a8b7d6/chrome/browser/resource_coordinator/render_process_probe.h
[modify] https://crrev.com/f12e2d5ca69258bc401946f063dc674271a8b7d6/chrome/browser/resource_coordinator/render_process_probe_browsertest.cc
[modify] https://crrev.com/f12e2d5ca69258bc401946f063dc674271a8b7d6/services/resource_coordinator/observers/metrics_collector.cc
[modify] https://crrev.com/f12e2d5ca69258bc401946f063dc674271a8b7d6/services/resource_coordinator/observers/metrics_collector.h
[modify] https://crrev.com/f12e2d5ca69258bc401946f063dc674271a8b7d6/services/resource_coordinator/public/cpp/resource_coordinator_features.cc
[modify] https://crrev.com/f12e2d5ca69258bc401946f063dc674271a8b7d6/services/resource_coordinator/public/cpp/resource_coordinator_features.h
Project Member

Comment 38 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b3f4a4b324940583771fa063d9fb6fafba27b31

commit 1b3f4a4b324940583771fa063d9fb6fafba27b31
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Wed Aug 08 17:13:11 2018

RC: Add a histogram to record late performance measurements.

Bug: 755840
Change-Id: I276f74b89cfaab3b3d45ed1e1d0b335ff6299fae
Reviewed-on: https://chromium-review.googlesource.com/1165853
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581606}
[modify] https://crrev.com/1b3f4a4b324940583771fa063d9fb6fafba27b31/chrome/browser/resource_coordinator/tab_manager_resource_coordinator_signal_observer.cc
[modify] https://crrev.com/1b3f4a4b324940583771fa063d9fb6fafba27b31/tools/metrics/histograms/histograms.xml

Comment 39 by siggi@chromium.org, Aug 15 

Forgot to tag this CL with the bug #: https://chromium-review.googlesource.com/c/chromium/src/+/1169908

Comment 40 by siggi@chromium.org, Aug 15

Components: Internals>ResourceCoordinator
Project Member

Comment 41 by bugdroid1@chromium.org, Aug 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af95f4cb6104cb96371534e28d8644520e8094b9

commit af95f4cb6104cb96371534e28d8644520e8094b9
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Wed Aug 15 17:45:47 2018

RC: Remove an incorrect comment.

Bug: 755840
Change-Id: I5eba22ebcc2e8a11c1d0df7d249b0dd5c0aa5066
Reviewed-on: https://chromium-review.googlesource.com/1175847
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583306}
[modify] https://crrev.com/af95f4cb6104cb96371534e28d8644520e8094b9/chrome/browser/resource_coordinator/render_process_probe.cc

Comment 42 by siggi@chromium.org, Aug 16

Blockedon: 874968
Project Member

Comment 43 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc537ce0d77c10a1a426dabae4254563625e3434

commit fc537ce0d77c10a1a426dabae4254563625e3434
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Tue Sep 04 20:02:20 2018

RC: Record load time duration with other perf estimates.

Bug: 755840
Change-Id: I2cd09d2ad75b77d221c14d3b954ce9a918dfdccb
Reviewed-on: https://chromium-review.googlesource.com/1197348
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588629}
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/chrome/browser/resource_coordinator/local_site_characteristics_data_impl_unittest.cc
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/chrome/browser/resource_coordinator/local_site_characteristics_data_writer.cc
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/chrome/browser/resource_coordinator/local_site_characteristics_data_writer.h
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/chrome/browser/resource_coordinator/local_site_characteristics_data_writer_unittest.cc
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/chrome/browser/resource_coordinator/local_site_characteristics_noop_data_writer.cc
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/chrome/browser/resource_coordinator/local_site_characteristics_noop_data_writer.h
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer.cc
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer.h
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer_unittest.cc
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/chrome/browser/resource_coordinator/page_signal_receiver.cc
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/chrome/browser/resource_coordinator/page_signal_receiver.h
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/chrome/browser/resource_coordinator/site_characteristics.proto
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/chrome/browser/resource_coordinator/site_characteristics_data_writer.h
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/chrome/browser/resource_coordinator/tab_helper.cc
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/services/resource_coordinator/coordination_unit/page_coordination_unit_impl.cc
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/services/resource_coordinator/coordination_unit/page_coordination_unit_impl.h
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/services/resource_coordinator/coordination_unit/page_coordination_unit_impl_unittest.cc
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/services/resource_coordinator/observers/ipc_volume_reporter_unittest.cc
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/services/resource_coordinator/observers/metrics_collector_unittest.cc
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/services/resource_coordinator/observers/page_signal_generator_impl.cc
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/services/resource_coordinator/observers/page_signal_generator_impl_unittest.cc
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/services/resource_coordinator/public/cpp/page_resource_coordinator.cc
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/services/resource_coordinator/public/cpp/page_resource_coordinator.h
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/services/resource_coordinator/public/mojom/coordination_unit.mojom
[modify] https://crrev.com/fc537ce0d77c10a1a426dabae4254563625e3434/services/resource_coordinator/public/mojom/page_signal.mojom
►

Sign in to add a comment