New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755836 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 629701



Sign in to add a comment

Impl mojo interface ServiceWorkerContainerHost

Project Member Reported by leon....@intel.com, Aug 16 2017

Issue description

This is to track all the work to implement ServiceWorkerContainerHost mojo interface.

"
SW and workers can only use Update and Unregister. Maybe those need to be split into an associated interface ServiceWorkerRegistrationHost.

interface ServiceWorkerContainerHost {
  Register(script_url, opts) => (ServiceWorkerStatus, ServiceWorkerRegistrationObject);

  Update(registration_id) => (ServiceWorkerStatus);

  Unregister(registration_id) => (ServiceWorkerStatus);

  GetRegistration(client_url) => (ServiceWorkerStatus, ServiceWorkerRegistrationObject);

  GetRegistrations() => (ServiceWorkerStatus, ServiceWorkerRegistrationObject);

  GetRegistrationForReady(ServiceWorkerStatus, ServiceWorkerRegistrationObject);

  // Gets an InterfacePtr for the controller.
  GetControllerServiceWorker(ServiceWorkerObject);
};
"
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21a33c55dd85e73891f73f2409052dee89bf1da7

commit 21a33c55dd85e73891f73f2409052dee89bf1da7
Author: Han Leon <leon.han@intel.com>
Date: Mon Aug 21 10:08:06 2017

[ServiceWorker] Move ownership of ServiceWorkerProviderHost interface ptr

This CL moves ownership of ServiceWorkerProviderHost interface ptr from
SWNetworkProvider to SWProviderContext, so that
WebServiceWorkerProviderImpl can easily get the SWProviderHost interface
ptr from SWProviderContext, to implement behaviors of
ServiceWorkerContainer interface in JS context.

BUG= 755836 

Change-Id: I1708fb11699a1649dad5ae042bc3e1528ad5a313
Reviewed-on: https://chromium-review.googlesource.com/615013
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495901}
[modify] https://crrev.com/21a33c55dd85e73891f73f2409052dee89bf1da7/content/child/service_worker/service_worker_dispatcher_unittest.cc
[modify] https://crrev.com/21a33c55dd85e73891f73f2409052dee89bf1da7/content/child/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/21a33c55dd85e73891f73f2409052dee89bf1da7/content/child/service_worker/service_worker_network_provider.h
[modify] https://crrev.com/21a33c55dd85e73891f73f2409052dee89bf1da7/content/child/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/21a33c55dd85e73891f73f2409052dee89bf1da7/content/child/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/21a33c55dd85e73891f73f2409052dee89bf1da7/content/child/service_worker/service_worker_provider_context_unittest.cc

Comment 2 by leon....@intel.com, Aug 23 2017

Blockedon: 758151
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7a613ae31e808d4f12e21a2b029e7007d19f488

commit e7a613ae31e808d4f12e21a2b029e7007d19f488
Author: Han Leon <leon.han@intel.com>
Date: Sun Aug 27 13:29:33 2017

[ServiceWorker] Add blink.mojom.ServiceWorkerErrorType enum

This CL creates blink.mojom.ServiceWorkerErrorType enum type and
uses it to replace existing native enum type
blink::WebServiceWorkerError::ErrorType.
This is for preparation to impl content.mojom.ServiceWorkerProviderHost
interface, whose methods need to pass such an enum type.

BUG= 755836 

Change-Id: I9ee0ae1cc53e462226b179a79a046362aeddbd65
Reviewed-on: https://chromium-review.googlesource.com/620169
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#497677}
[modify] https://crrev.com/e7a613ae31e808d4f12e21a2b029e7007d19f488/content/browser/DEPS
[modify] https://crrev.com/e7a613ae31e808d4f12e21a2b029e7007d19f488/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/e7a613ae31e808d4f12e21a2b029e7007d19f488/content/browser/service_worker/service_worker_registration_status.cc
[modify] https://crrev.com/e7a613ae31e808d4f12e21a2b029e7007d19f488/content/browser/service_worker/service_worker_registration_status.h
[modify] https://crrev.com/e7a613ae31e808d4f12e21a2b029e7007d19f488/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/e7a613ae31e808d4f12e21a2b029e7007d19f488/content/child/service_worker/service_worker_dispatcher.cc
[modify] https://crrev.com/e7a613ae31e808d4f12e21a2b029e7007d19f488/content/child/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/e7a613ae31e808d4f12e21a2b029e7007d19f488/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/e7a613ae31e808d4f12e21a2b029e7007d19f488/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/e7a613ae31e808d4f12e21a2b029e7007d19f488/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/e7a613ae31e808d4f12e21a2b029e7007d19f488/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
[modify] https://crrev.com/e7a613ae31e808d4f12e21a2b029e7007d19f488/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp
[modify] https://crrev.com/e7a613ae31e808d4f12e21a2b029e7007d19f488/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp
[modify] https://crrev.com/e7a613ae31e808d4f12e21a2b029e7007d19f488/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClientCallback.cpp
[modify] https://crrev.com/e7a613ae31e808d4f12e21a2b029e7007d19f488/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/e7a613ae31e808d4f12e21a2b029e7007d19f488/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerError.h
[add] https://crrev.com/e7a613ae31e808d4f12e21a2b029e7007d19f488/third_party/WebKit/public/platform/modules/serviceworker/service_worker_error_type.mojom

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f74b22375380851bbf42079b257ad79b47262a3f

commit f74b22375380851bbf42079b257ad79b47262a3f
Author: Han Leon <leon.han@intel.com>
Date: Mon Sep 04 10:29:39 2017

[ServiceWorker] Implement ServiceWorkerContainerHost.Register

BUG= 755836 

Change-Id: I212a65b6ebf972af18e9597344de14e52cde41a5
Reviewed-on: https://chromium-review.googlesource.com/616740
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499474}
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/child/service_worker/service_worker_dispatcher.cc
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/child/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/child/service_worker/service_worker_message_filter.cc
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/child/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/child/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/child/service_worker/web_service_worker_provider_impl.cc
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/child/service_worker/web_service_worker_provider_impl.h
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/common/DEPS
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/common/service_worker/service_worker_container.mojom
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/common/service_worker/service_worker_messages.h
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/common/service_worker/service_worker_types.mojom
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/common/service_worker/service_worker_types.typemap
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/common/service_worker/service_worker_utils.cc
[modify] https://crrev.com/f74b22375380851bbf42079b257ad79b47262a3f/content/common/service_worker/service_worker_utils.h

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c3da9bc355acdffd3cb37ac39622dd4612aa155

commit 2c3da9bc355acdffd3cb37ac39622dd4612aa155
Author: Han Leon <leon.han@intel.com>
Date: Wed Sep 06 23:54:38 2017

[ServiceWorker] Implement ServiceWorkerContainerHost.GetRegistration[s]

BUG= 755836 

Change-Id: I99733c1a4c513cf96973c0c6ef6437c9f3ecb5b5
Reviewed-on: https://chromium-review.googlesource.com/649127
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#500142}
[modify] https://crrev.com/2c3da9bc355acdffd3cb37ac39622dd4612aa155/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/2c3da9bc355acdffd3cb37ac39622dd4612aa155/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/2c3da9bc355acdffd3cb37ac39622dd4612aa155/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/2c3da9bc355acdffd3cb37ac39622dd4612aa155/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/2c3da9bc355acdffd3cb37ac39622dd4612aa155/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/2c3da9bc355acdffd3cb37ac39622dd4612aa155/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/2c3da9bc355acdffd3cb37ac39622dd4612aa155/content/browser/service_worker/service_worker_registration_status.cc
[modify] https://crrev.com/2c3da9bc355acdffd3cb37ac39622dd4612aa155/content/browser/service_worker/service_worker_registration_status.h
[modify] https://crrev.com/2c3da9bc355acdffd3cb37ac39622dd4612aa155/content/child/service_worker/service_worker_dispatcher.cc
[modify] https://crrev.com/2c3da9bc355acdffd3cb37ac39622dd4612aa155/content/child/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/2c3da9bc355acdffd3cb37ac39622dd4612aa155/content/child/service_worker/service_worker_message_filter.cc
[modify] https://crrev.com/2c3da9bc355acdffd3cb37ac39622dd4612aa155/content/child/service_worker/service_worker_message_filter.h
[modify] https://crrev.com/2c3da9bc355acdffd3cb37ac39622dd4612aa155/content/child/service_worker/web_service_worker_provider_impl.cc
[modify] https://crrev.com/2c3da9bc355acdffd3cb37ac39622dd4612aa155/content/child/service_worker/web_service_worker_provider_impl.h
[modify] https://crrev.com/2c3da9bc355acdffd3cb37ac39622dd4612aa155/content/common/service_worker/service_worker_container.mojom
[modify] https://crrev.com/2c3da9bc355acdffd3cb37ac39622dd4612aa155/content/common/service_worker/service_worker_messages.h

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd7f5972e2e3400bfaa2772370555f22eff12117

commit bd7f5972e2e3400bfaa2772370555f22eff12117
Author: Han Leon <leon.han@intel.com>
Date: Mon Sep 11 11:36:31 2017

[ServiceWorker] Implement ServiceWorkerContainerHost.GetRegistrationForReady

BUG= 755836 

Change-Id: I043bf39fb69990f5e71c5927a0cf09b459f155b4
Reviewed-on: https://chromium-review.googlesource.com/652166
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#500886}
[modify] https://crrev.com/bd7f5972e2e3400bfaa2772370555f22eff12117/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/bd7f5972e2e3400bfaa2772370555f22eff12117/content/browser/service_worker/service_worker_dispatcher_host.cc
[modify] https://crrev.com/bd7f5972e2e3400bfaa2772370555f22eff12117/content/browser/service_worker/service_worker_dispatcher_host.h
[modify] https://crrev.com/bd7f5972e2e3400bfaa2772370555f22eff12117/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/bd7f5972e2e3400bfaa2772370555f22eff12117/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/bd7f5972e2e3400bfaa2772370555f22eff12117/content/child/service_worker/service_worker_dispatcher.cc
[modify] https://crrev.com/bd7f5972e2e3400bfaa2772370555f22eff12117/content/child/service_worker/service_worker_dispatcher.h
[modify] https://crrev.com/bd7f5972e2e3400bfaa2772370555f22eff12117/content/child/service_worker/service_worker_message_filter.cc
[modify] https://crrev.com/bd7f5972e2e3400bfaa2772370555f22eff12117/content/child/service_worker/service_worker_message_filter.h
[modify] https://crrev.com/bd7f5972e2e3400bfaa2772370555f22eff12117/content/child/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/bd7f5972e2e3400bfaa2772370555f22eff12117/content/child/service_worker/web_service_worker_provider_impl.cc
[modify] https://crrev.com/bd7f5972e2e3400bfaa2772370555f22eff12117/content/child/service_worker/web_service_worker_provider_impl.h
[modify] https://crrev.com/bd7f5972e2e3400bfaa2772370555f22eff12117/content/common/service_worker/service_worker_container.mojom
[modify] https://crrev.com/bd7f5972e2e3400bfaa2772370555f22eff12117/content/common/service_worker/service_worker_messages.h

Comment 7 by kinuko@chromium.org, Sep 12 2017

(Fyi, to avoid dup'ed efforts- I'm implementing GetControllerServiceWorker here: https://chromium-review.googlesource.com/c/chromium/src/+/640652)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91432512b69f9b298b0d733751e1ebe3a3a8c0ee

commit 91432512b69f9b298b0d733751e1ebe3a3a8c0ee
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Thu Sep 14 18:03:33 2017

Introduce mojo::ControllerServiceWorker and let SubresourceLoader use it

This is a preparation patch for direct renderer-renderer communication.
- Introduce mojom::ControllerServiceWorker, which is basically a subset
  of ServiceWorkerEventDispatcher. Make relevant refactoring around it.
- Make BrowserSideServiceWorkerEventDispatcher implement
  ControllerServiceWorker (instead of EventDispatcher), and rename it
  to BrowserSideControllerServiceWorker
- Introduce mojom::ServiceWorkerContainerHost::
  GetControllerServiceWorker() and let SubresourceLoader use it
- Introduce ControllerServiceWorkerConnector, which hides the
  connection details so that SubresourceLoader can transparently get
  the ControllerServiceWorker even after the connection is dropped

Bug:  715640 ,  755836 
Change-Id: I37c5bd231a0d0da3138923427b1a859167a46093
Reviewed-on: https://chromium-review.googlesource.com/640652
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501990}
[modify] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/browser/BUILD.gn
[add] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/browser/service_worker/browser_side_controller_service_worker.cc
[add] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/browser/service_worker/browser_side_controller_service_worker.h
[delete] https://crrev.com/dc3f455bb706d8745d400ebd1ba45c2a85fff13b/content/browser/service_worker/browser_side_service_worker_event_dispatcher.cc
[delete] https://crrev.com/dc3f455bb706d8745d400ebd1ba45c2a85fff13b/content/browser/service_worker/browser_side_service_worker_event_dispatcher.h
[modify] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/child/BUILD.gn
[add] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/child/service_worker/controller_service_worker_connector.cc
[add] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/child/service_worker/controller_service_worker_connector.h
[modify] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/child/service_worker/service_worker_dispatcher.cc
[modify] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/child/service_worker/service_worker_provider_context.cc
[modify] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/child/service_worker/service_worker_provider_context.h
[modify] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/child/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/child/service_worker/service_worker_subresource_loader.h
[modify] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/child/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/common/BUILD.gn
[add] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/common/service_worker/controller_service_worker.mojom
[modify] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/common/service_worker/service_worker_container.mojom
[modify] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/common/service_worker/service_worker_event_dispatcher.mojom
[add] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/common/service_worker/service_worker_fetch_response_callback.mojom
[modify] https://crrev.com/91432512b69f9b298b0d733751e1ebe3a3a8c0ee/content/common/service_worker/service_worker_messages.h

Comment 9 by leon....@intel.com, Sep 27 2017

Blockedon: -758151
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/844bf0c2f8a49f242acfd15b8d18a62e08cd2a82

commit 844bf0c2f8a49f242acfd15b8d18a62e08cd2a82
Author: Han Leon <leon.han@intel.com>
Date: Mon Oct 16 09:18:31 2017

[ServiceWorker] Move unit tests related with ServiceWorkerContainterHost interface

Now content::ServiceWorkerProviderHost implements Mojo interface
ServiceWorkerContainterHost, so this CL moves all related unit tests
from service_worker_dispatcher_host_unittest.cc into
service_worker_provider_host_unittest.cc.

BUG= 755836 
TEST=content_unittests
--gtest_filter=ServiceWorkerDispatcherHostTest.*
--gtest_filter=ServiceWorkerProviderHostTest.*

Change-Id: I35f3971ba561d9a5d8746eed8e54973a60161e9b
Reviewed-on: https://chromium-review.googlesource.com/715397
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#509001}
[modify] https://crrev.com/844bf0c2f8a49f242acfd15b8d18a62e08cd2a82/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
[modify] https://crrev.com/844bf0c2f8a49f242acfd15b8d18a62e08cd2a82/content/browser/service_worker/service_worker_provider_host_unittest.cc

Comment 11 by leon....@intel.com, Oct 16 2017

Status: Fixed (was: Started)
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c80a1ee73cd9a6f615792127012f3b47bab8d28

commit 4c80a1ee73cd9a6f615792127012f3b47bab8d28
Author: Han Leon <leon.han@intel.com>
Date: Thu Oct 26 23:35:24 2017

[ServiceWorker] Make GetRegistration respond null registration object info

This CL makes ServiceWorkerContainerHost.GetRegistration() respond a
null registration object info rather than a non-null invalid value when
no registration has been found or the found one is uninstalling.

BUG= 755836 

Change-Id: I198a4c25143115c9db0eb793186eb0c023b1cf81
Reviewed-on: https://chromium-review.googlesource.com/732196
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#512012}
[modify] https://crrev.com/4c80a1ee73cd9a6f615792127012f3b47bab8d28/content/browser/service_worker/embedded_worker_instance_unittest.cc
[modify] https://crrev.com/4c80a1ee73cd9a6f615792127012f3b47bab8d28/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/4c80a1ee73cd9a6f615792127012f3b47bab8d28/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/4c80a1ee73cd9a6f615792127012f3b47bab8d28/content/common/service_worker/service_worker_container.mojom
[modify] https://crrev.com/4c80a1ee73cd9a6f615792127012f3b47bab8d28/content/renderer/service_worker/web_service_worker_provider_impl.cc
[modify] https://crrev.com/4c80a1ee73cd9a6f615792127012f3b47bab8d28/third_party/WebKit/public/platform/modules/serviceworker/service_worker_registration.mojom

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/923a6d873166c8c4633e96301159462bebaac5b3

commit 923a6d873166c8c4633e96301159462bebaac5b3
Author: xzhan96 <xiaofeng.zhang@intel.com>
Date: Tue Nov 07 01:35:44 2017

[ServiceWorker] Eliminate unused function of sw registration status response

After mojofing all methods related with service worker registrations,
we use GetServiceWorkerErrorTypeForRegistration to replace with
GetServiceWorkerRegistrationStatusResponse.

BUG= 755836 

Change-Id: I198c356841ca536d0c6fc6829b747ed8a26eebc6
Reviewed-on: https://chromium-review.googlesource.com/753298
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com>
Cr-Commit-Position: refs/heads/master@{#514333}
[modify] https://crrev.com/923a6d873166c8c4633e96301159462bebaac5b3/content/browser/service_worker/service_worker_registration_status.cc
[modify] https://crrev.com/923a6d873166c8c4633e96301159462bebaac5b3/content/browser/service_worker/service_worker_registration_status.h

Sign in to add a comment