New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755834 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Create BottomSheetTest#testNavigate for Chrome Home

Project Member Reported by yolandyan@chromium.org, Aug 16 2017

Issue description

Model after NavigateTest#testNavigate() to create BottomSheetTest#testNavigate

The action would somewhat be as follow:
1. Focus urlBar
2. Check that the bottom sheet is opened at full height and omnibox suggestions are displayed
3. Set a new URL as text on the url bar
4. Send the "enter" key event
5. Check that the bottom sheet is closed and the new URL is loaded

This is of course part of the initiative to make writing test for Chrome Home great for the first time :)
 
Status: Assigned (was: Untriaged)

Comment 2 by baxley@chromium.org, Nov 10 2017

Cc: -baxley@chromium.org yolandyan@chromium.org
Components: Tests>Missing
Owner: baxley@chromium.org
I have some cycles to poke at this.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44a83d1de950065d946c6f37249e89a3abae41cc

commit 44a83d1de950065d946c6f37249e89a3abae41cc
Author: Mike Baxley <baxley@chromium.org>
Date: Fri Dec 08 21:01:47 2017

Add BottomSheet navigation test.

Test that focuses the bottom sheet, types a URL,
and then verifies navigation.

Bug:  755834 
Change-Id: I1367ec78911aa6a6f3a304fbcf7acf2581a9f140
Reviewed-on: https://chromium-review.googlesource.com/767028
Commit-Queue: Mike Baxley <baxley@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522874}
[modify] https://crrev.com/44a83d1de950065d946c6f37249e89a3abae41cc/chrome/android/java_sources.gni
[add] https://crrev.com/44a83d1de950065d946c6f37249e89a3abae41cc/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNavigateTest.java

Comment 4 by baxley@chromium.org, Feb 14 2018

Cc: aluo@chromium.org
Status: Fixed (was: Assigned)
Closing this bug, since the test has been written. Unfortunately it was disabled and marked flaky in  crbug.com/793534 

Feel free to re-open and re-assign if this should be tracked some other way.

Sign in to add a comment