New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 755825 link

Starred by 1 user
Status: Assigned
Owner:
█ yolandyan@chromium.org
not available
Cc:
jbudorick@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Support test skip checks that might call CommandLine.getInstance in JUnit4

Project Member Reported by yolandyan@chromium.org, Aug 16 2017 
In JUnit3, test skips are done after pre test hooks, which would initialize CommandLine for tests. So skip checks that calls for CommandLine.getInstance() would work.

However, in JUnit4, test skips are done before pre test hook or activity launch.

The issue should can be resolved by implementing the test skips and pretest hook in TestRule.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b3e51dd9301ab842a64556df356b21a870fe7ed

commit 7b3e51dd9301ab842a64556df356b21a870fe7ed
Author: Yoland Yan <yolandyan@chromium.org>
Date: Tue Oct 03 00:53:27 2017

Convert LoadDataWithBaseUrlTest to JUnit4

RestrictionSkipCheck should initialize CommandLine if it is not
initialized for checking device type.

Bug: 755825
Change-Id: Ied37da84ead33b6f2208c61ab5ed07f7b008d3a0
Reviewed-on: https://chromium-review.googlesource.com/616255
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505895}
[modify] https://crrev.com/7b3e51dd9301ab842a64556df356b21a870fe7ed/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

Comment 2 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Untriaged)
►

Sign in to add a comment