PRESUBMIT.py fails when deleting multiple OWNERS files |
|||||
Issue descriptionI was working this CL which removes a couple of entire directories: https://chromium-review.googlesource.com/c/602884 It is failing on presubmit: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/517244 Failure message: owners.SyntaxErrorInOwnersFile: /b/build/slave/linux/build/src/chrome/browser/resources/OWNERS:4 syntax error: //chrome/browser/resources/options/OWNERS does not refer to an existing file. logdog link (not sure if this is persistent): https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Fchromium_presubmit%2F517244%2F%2B%2Frecipes%2Fsteps%2Fpresubmit%2F0%2Fstdout
,
Aug 16 2017
,
Aug 16 2017
Looks like two features of PRESUBMIT/OWNERS are interacting poorly. It recognizes when OWNERS files are deleted, and looks at the old revision of them to make sure the person deleting them has permission to do so. But when parsing those OWNERS files, sometimes they reference other OWNERS files, and then it tries to read those other OWNERS files from disk... but they've also been deleted. Not sure what the best fix is here. Feel free to submit that change with "No-Presubmit: True" in the commit description while we figure out something else.
,
Aug 20
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 22
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by seanmccullough@chromium.org
, Aug 16 2017