New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 755796 link

Starred by 1 user
Status: Fixed
Owner:
dpranke@chromium.org
Closed: Sep 2017
Cc:
liaoyuke@chromium.org
dpranke@chromium.org
█ brettw@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

roll_gn.py should support Gerrit

Project Member Reported by kraynov@chromium.org, Aug 15 2017 
Since Rietveld has been deprecated and Chromium project doesn't accept new issues, it's time to tweak //tools/gn/bin/roll_gn.py for Gerrit.

I have already submitted GN roll by hacking this script and got these findings:

1. API has changed and instead of https://codereview.chromium.org/api/CL/PS/trybot_results we need another API path. https://codereview.appspot.com (used by modern git-cl upload) doesn't support that format.

2. I've grabbed JSON with trybot results by URL like

https://cr-buildbucket.appspot.com/_ah/api/buildbucket/v1/search?max_builds=500&fields=builds(failure_reason%2Cid%2Cparameters_json%2Cresult%2Cstatus%2Ctags%2Curl)&tag=buildset%3Apatch%2Fgerrit%2Fchromium-review.googlesource.com%2F616040%2F1

(grabbed using Chrome dev tools).

So, anyone, please update roll_gn.py for Gerrit to avoid such a nasty workarounds.
Thanks a lot!

Comment 1 by dpranke@chromium.org, Aug 15 2017

Components: Build
Labels: Build-Tools-GN
Yup, this is a bug known to me that I haven't had time to fix or even gotten around to filing, so thanks for filing it :).

Comment 2 by dpranke@chromium.org, Aug 18 2017

Cc: liaoyuke@chromium.org brettw@chromium.org
Owner: dpranke@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78e1a29ade3011e22da4feaca4cedcab6f8488a2

commit 78e1a29ade3011e22da4feaca4cedcab6f8488a2
Author: Dirk Pranke <dpranke@chromium.org>
Date: Tue Aug 29 02:23:05 2017

Update the GN roll script to work with Gerrit and Milo.

Previously the GN roll script required Rietveld to work,
but Rietveld is readonly now. This fixes the script to
work with the new systems we're using.

Also, this CL modifies the script so that you can run it
on a Mac as well, since that should work, and switches
to using the DEPS-ed version of depot_tools in //third_party.

R: iannucci@chromium.org
Bug:  755796 
Change-Id: Ib667225a9b5e4e99b5250497f79aac266625fae3
Reviewed-on: https://chromium-review.googlesource.com/622247
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497987}
[modify] https://crrev.com/78e1a29ade3011e22da4feaca4cedcab6f8488a2/tools/gn/bin/roll_gn.py

Comment 5 by dpranke@chromium.org, Sep 1 2017

Status: Fixed (was: Started)

Comment 6 by liaoyuke@chromium.org, Sep 1 2017 

Thank you for fixing this Dirk!
►

Sign in to add a comment