NQE: Record raw RTT and throughput samples in NQE |
||||
Issue descriptionNQE should record raw RTT and throughput samples using UMA metrics. This would be helpful in monitoring, detecting regressions, and analyzing cases where estimated RTT/throughput values are totally unexpected (e.g., when RTT estimate is 0 msec). To reduce the overhead of UMA logging, we might want to do it for a small percentage of observations. e.g., record a sample with 10% probability. The samples would need to be recorded in different histograms for different observation sources.
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0eb6b8f68b93ff1854811c1d61d2bd91c279436 commit d0eb6b8f68b93ff1854811c1d61d2bd91c279436 Author: Tarun Bansal <tbansal@chromium.org> Date: Fri Aug 18 20:05:42 2017 NQE: Remove duplicated code for adding observations to the buffer Merge the code for adding observation to the buffer and notifying observers. Also, remove the logic for recording the peak network quality histograms which are currently unused. Bug: 755794 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I3426b3b52a269bf0b1244796cc998b42fff31216 Reviewed-on: https://chromium-review.googlesource.com/615181 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#495660} [modify] https://crrev.com/d0eb6b8f68b93ff1854811c1d61d2bd91c279436/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/d0eb6b8f68b93ff1854811c1d61d2bd91c279436/net/nqe/network_quality_estimator.h [modify] https://crrev.com/d0eb6b8f68b93ff1854811c1d61d2bd91c279436/net/nqe/network_quality_estimator_unittest.cc
,
Aug 18 2017
,
Aug 25 2017
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84546bfdaffcaf6f67d4e8a4950b666e23ff1d53 commit 84546bfdaffcaf6f67d4e8a4950b666e23ff1d53 Author: Tarun Bansal <tbansal@chromium.org> Date: Tue Aug 29 18:38:41 2017 Obsolete histograms with connection type suffix from network quality estimator Also, obsolete peak network quality histograms as they are unused. Additionally, there are NQE.RTT.PercentileN.* histograms which capture that data better. Bug: 755794 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I6a17f4eca67929a3ee528bfccf32455164371405 Reviewed-on: https://chromium-review.googlesource.com/636696 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#498180} [modify] https://crrev.com/84546bfdaffcaf6f67d4e8a4950b666e23ff1d53/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/84546bfdaffcaf6f67d4e8a4950b666e23ff1d53/net/nqe/network_quality_estimator.h [modify] https://crrev.com/84546bfdaffcaf6f67d4e8a4950b666e23ff1d53/net/nqe/network_quality_estimator_unittest.cc [modify] https://crrev.com/84546bfdaffcaf6f67d4e8a4950b666e23ff1d53/tools/metrics/histograms/histograms.xml
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2677a15c24d5b46ebff78b6d9a16f2e1ff8f969 commit d2677a15c24d5b46ebff78b6d9a16f2e1ff8f969 Author: Tarun Bansal <tbansal@chromium.org> Date: Thu Aug 31 01:26:38 2017 Add histograms to record raw observations in Network Quality Estimator (NQE). Bug: 755794 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Icd925fb3e597788c1bc3db5beb9ab9a703e012b3 Reviewed-on: https://chromium-review.googlesource.com/636701 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#498705} [modify] https://crrev.com/d2677a15c24d5b46ebff78b6d9a16f2e1ff8f969/net/BUILD.gn [modify] https://crrev.com/d2677a15c24d5b46ebff78b6d9a16f2e1ff8f969/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/d2677a15c24d5b46ebff78b6d9a16f2e1ff8f969/net/nqe/network_quality_estimator_unittest.cc [add] https://crrev.com/d2677a15c24d5b46ebff78b6d9a16f2e1ff8f969/net/nqe/network_quality_observation_source.cc [modify] https://crrev.com/d2677a15c24d5b46ebff78b6d9a16f2e1ff8f969/net/nqe/network_quality_observation_source.h [modify] https://crrev.com/d2677a15c24d5b46ebff78b6d9a16f2e1ff8f969/tools/metrics/histograms/histograms.xml
,
Aug 31 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bengr@chromium.org
, Aug 15 2017