New issue
Advanced search Search tips

Issue 755788 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Fold LayoutManagerDocument into LayoutManager

Project Member Reported by mdjones@chromium.org, Aug 15 2017

Issue description

LayoutManagerDocument is an unnecessary abstraction on the LayoutManager. The two classes should be combined and simplified. If there comes a time when the layout manager does not show web content, this issue can be revisited.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d7a9ea81684ff23d235642fa97f5bbd110911f5

commit 4d7a9ea81684ff23d235642fa97f5bbd110911f5
Author: Matthew Jones <mdjones@chromium.org>
Date: Fri Aug 18 00:24:13 2017

Fold LayoutManagerDocument into LayoutManager

This change removes an unnecessary abstraction on the LayoutManager.
Since all usages display web contents, there is no reason to have
that logic separate; if that changes, simpler abstractions can be
made. This change also removes several unused internal classes and
methods.

BUG= 755788 

Change-Id: Ib2b6206639a7bb085c9d988c41a5a27aad2b5714
Reviewed-on: https://chromium-review.googlesource.com/616068
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495394}
[modify] https://crrev.com/4d7a9ea81684ff23d235642fa97f5bbd110911f5/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/4d7a9ea81684ff23d235642fa97f5bbd110911f5/chrome/android/java/src/org/chromium/chrome/browser/FullscreenActivity.java
[modify] https://crrev.com/4d7a9ea81684ff23d235642fa97f5bbd110911f5/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java
[modify] https://crrev.com/4d7a9ea81684ff23d235642fa97f5bbd110911f5/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java
[delete] https://crrev.com/96b4c361ec7f4e354f8252d7a46aba6194f66f71/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
[modify] https://crrev.com/4d7a9ea81684ff23d235642fa97f5bbd110911f5/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/4d7a9ea81684ff23d235642fa97f5bbd110911f5/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabLayoutManager.java
[modify] https://crrev.com/4d7a9ea81684ff23d235642fa97f5bbd110911f5/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[modify] https://crrev.com/4d7a9ea81684ff23d235642fa97f5bbd110911f5/chrome/android/java_sources.gni

Status: Fixed (was: Assigned)

Sign in to add a comment