New issue
Advanced search Search tips

Issue 755784 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

fio: bw_mean not computed

Project Member Reported by gwendal@chromium.org, Aug 15 2017

Issue description

There is a regression in fio 2.15

https://github.com/axboe/fio/commit/371817093568b7404b47d94a1ef10077f1695264

Fixed in 2.20.

Affect storage qual: hardware_StorageFio complains of unmeant condition:
_seq_read_read_bw_mean >= 50 * 1024: constraint was not met,
_seq_write_write_bw_mean >= 15 * 1024: constraint was not met

As both are now 0.

b/64120507
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8ce50b6b10b6da37d4000f2d99e89b7bef63cf39

commit 8ce50b6b10b6da37d4000f2d99e89b7bef63cf39
Author: Gwendal Grignou <gwendal@chromium.org>
Date: Fri Aug 25 19:09:04 2017

hardware_StorageFio: Use bw instead of _bw_mean

In fio 2.15, bw_mean is not computed if log are not enabled.
Use mean bandwith instead.
It is fixed in fio 2.20, in the meantime, use regualr _bw variables.

BUG= chromium:755784 
TEST=Without change, using fio 2.15, check we fail the constraint
checks, pass with it.

Change-Id: Id507aa6ad23b67f355614a96b2289028875eeebe
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/617240
Reviewed-by: Grant Grundler <grundler@chromium.org>

[modify] https://crrev.com/8ce50b6b10b6da37d4000f2d99e89b7bef63cf39/client/site_tests/hardware_StorageFio/control.hwqual
[modify] https://crrev.com/8ce50b6b10b6da37d4000f2d99e89b7bef63cf39/server/site_tests/hardware_StorageQualBase/hardware_StorageQualBase.py
[modify] https://crrev.com/8ce50b6b10b6da37d4000f2d99e89b7bef63cf39/client/site_tests/suite_HWQual/control.auto

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 15 2017

Labels: merge-merged-release-R61-9765.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a0e0befd9d8b3a499a90c78ab6bce9546c94a560

commit a0e0befd9d8b3a499a90c78ab6bce9546c94a560
Author: Gwendal Grignou <gwendal@chromium.org>
Date: Fri Sep 15 18:44:07 2017

hardware_StorageFio: Use bw instead of _bw_mean

In fio 2.15, bw_mean is not computed if log are not enabled.
Use mean bandwith instead.
It is fixed in fio 2.20, in the meantime, use regualr _bw variables.

BUG= chromium:755784 
TEST=Without change, using fio 2.15, check we fail the constraint
checks, pass with it.

Change-Id: Id507aa6ad23b67f355614a96b2289028875eeebe
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/617240
Reviewed-by: Grant Grundler <grundler@chromium.org>
(cherry picked from commit 8ce50b6b10b6da37d4000f2d99e89b7bef63cf39)
Reviewed-on: https://chromium-review.googlesource.com/668803

[modify] https://crrev.com/a0e0befd9d8b3a499a90c78ab6bce9546c94a560/client/site_tests/hardware_StorageFio/control.hwqual
[modify] https://crrev.com/a0e0befd9d8b3a499a90c78ab6bce9546c94a560/server/site_tests/hardware_StorageQualBase/hardware_StorageQualBase.py
[modify] https://crrev.com/a0e0befd9d8b3a499a90c78ab6bce9546c94a560/client/site_tests/suite_HWQual/control.auto

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment