New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755783 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

chrome://downloads and chrome://bookmarks should work in Chrome Home

Project Member Reported by tedc...@chromium.org, Aug 15 2017

Issue description

We should try to make sure all internal chrome links open the relevant UI in Chrome Home.

If the user types in chrome://bookmarks, we should open the sheet and show bookmarks.  Typing in "bookmarks" into the omnibox presents the suggestion of chrome://bookmarks, so we should make it work (or suppress it if we think relevant).

 

Comment 1 by k...@chromium.org, Aug 16 2017

Labels: Fine-Pri-2.9 Hotlist-Chrome-Home
Status: Available (was: Untriaged)
Sure that makes sense

Comment 2 by k...@chromium.org, Aug 16 2017

Components: UI>Browser>Mobile>NavPanel
Right now navigating to these two URLs opens the native page inside Chrome. If the user focuses the omnibox, doesn't notice the bottom nav and decides to type in a URL, I agree that we should leave Chrome Home open and go to one of the panels. This shouldn't be too hard to implement - we route everything through BottomSheet so we could put some checks in there before allowing the navigation to proceed.

That said, would we block stable launch on this? If not, can we please reprioritize?

Comment 4 by k...@chromium.org, Sep 5 2017

Labels: -Fine-Pri-2.9 Fine-Pri-3.2
Actually yes, right now it seems chrome://bookmarks is broken even on Stable so I'm down to de-pri
Broken on Stable how? Navigating to chrome://bookmarks in non-Chrome Home should open bookmarks as a native page inside the browser.

Comment 6 by k...@chromium.org, Sep 9 2017

When I navigate to chrome://bookmarks in non-Chrome Home on Chrome Stable I see "This site can't be reached" ERR_INVALID_URL.
It looks like chrome://history is the only URL we redirect. I'm not sure if not redirecting was an intentional decision for bookmarks and downloads or an over sight.
Owner: thildebr@chromium.org
Status: Started (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d68edb8418078172477b3ed535f79288156eccc

commit 1d68edb8418078172477b3ed535f79288156eccc
Author: Troy Hildebrandt <thildebr@chromium.org>
Date: Thu Oct 05 16:33:53 2017

[Home] Open chrome://bookmarks, downloads, and history in the sheet.

Bug:  755783 
Change-Id: I2c9e36d26e91b592a41ce94c1a6618ca3bceaea6
Reviewed-on: https://chromium-review.googlesource.com/690750
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506757}
[modify] https://crrev.com/1d68edb8418078172477b3ed535f79288156eccc/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java

Status: Fixed (was: Started)
Works fine as per expected behavior, Verified on 63.0.3234.0
Navigating to chrome://bookmarks, downloads, and history  opens in the chrome- Home sheet it self.


Sign in to add a comment