New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755782 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

testCopyPasteURL fails on iOS 11 iPhone 5s simulator

Project Member Reported by baxley@chromium.org, Aug 15 2017

Issue description

It passed locally on iPhone 7 Plus (iOS 11), so this could be a screen size issue. I'm disabling to make the tree green.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/511e9498fe8e8217c51d3983291fef6ae5aaafe8

commit 511e9498fe8e8217c51d3983291fef6ae5aaafe8
Author: Mike Baxley <baxley@chromium.org>
Date: Tue Aug 15 23:26:28 2017

Disable testCopyPasteURL on iOS 11.

This test is failing on some simulator configurations. It fails
on iPhone 5s, but passes with iPhone 7 Plus.

TBR: justincohen
Bug:  755782 
Change-Id: Idead96a5a80402e076ace8d238288c195c4d1f71
Reviewed-on: https://chromium-review.googlesource.com/616061
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494600}
[modify] https://crrev.com/511e9498fe8e8217c51d3983291fef6ae5aaafe8/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75d2a11652fa651d2d8b6f72bbef804a4c7f234a

commit 75d2a11652fa651d2d8b6f72bbef804a4c7f234a
Author: Justin Cohen <justincohen@google.com>
Date: Thu Aug 17 01:32:54 2017

[ios] Alternate fix for testCopyPasteURL.

After long-press-select-all on an iPhone 5s the copy button
doesn't appear.  Instead, just tap the omnibox and tap the
pre-edit label.

Bug:  755782 
Change-Id: Id875d1b3c86eb369c1b6eaa81160747f2665beb3
Reviewed-on: https://chromium-review.googlesource.com/616420
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495036}
[modify] https://crrev.com/75d2a11652fa651d2d8b6f72bbef804a4c7f234a/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm

Status: Fixed (was: Assigned)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment