Bring back support for local clang patches for debug info experiment |
||
Issue descriptionWe want to apply https://reviews.llvm.org/D36596 locally to clang on Windows so that we can ship some canaries with it and see if it actually improves crash debugging enough, or if a larger effort around optimized debug info will be necessary. There are concerns that that patch isn't the right way to implement optimized debug info going forward, so it's currently blocked, and unlikely to land in its current form. That said, the debug info quality it provides is probably representative of what we can accomplish in the short term. If we apply this patch and variable info quality is still too low, we have more work to do. Effectively, we need to bring back the logic removed in https://codereview.chromium.org/1302053002 and port it to Windows.
,
Aug 16 2017
Nevermind, I'll grab it myself.
,
Aug 16 2017
,
Aug 17 2017
Do we think we need something fancier than what was done in #3, or is that sufficient, i.e. should we close this?
,
Sep 14 2017
Looks like we don't need to do this, we committed what we need under a flag.
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbb9741834cc242d5e6839c0fbb06a4696ed1322 commit cbb9741834cc242d5e6839c0fbb06a4696ed1322 Author: Nico Weber <thakis@chromium.org> Date: Tue Jan 23 17:11:36 2018 Remove some obsolete code. We used to have a local clang-side patch. This was months ago, so all bots should have reverted the local change by now. Bug: 755777 Change-Id: Ia6a20d87396bea6a8d8a8164753b870b8c58d8c9 Reviewed-on: https://chromium-review.googlesource.com/881283 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#531266} [modify] https://crrev.com/cbb9741834cc242d5e6839c0fbb06a4696ed1322/tools/clang/scripts/update.py |
||
►
Sign in to add a comment |
||
Comment 1 by thakis@chromium.org
, Aug 15 2017