New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 755771 link

Starred by 1 user
Status: Fixed
Owner:
█ jming@chromium.org
Last visit > 30 days ago
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 747563


Participants' hotlists:
Downloads-Foreground-Service


Sign in to add a comment

[Downloads Foreground Service] Handle resumption logic story

Project Member Reported by jming@chromium.org, Aug 15 2017 
When DownloadNotificationService was a service, resumption was handled in various cases (onDestroy, START_STICKY with a null intent, etc). However, with the service logic moved into DownloadForegroundServiceManager, this doesn't make as much sense. Come up with a story for the resumption logic, in all of the different cases.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec551c676d717ae37a2130f729dfe6ad9f03ac49

commit ec551c676d717ae37a2130f729dfe6ad9f03ac49
Author: Joy Ming <jming@chromium.org>
Date: Wed Sep 20 21:25:19 2017

Reimplement downloads resumption logic for foreground service.

This is part of a larger refactor to make downloads a foreground
service on all versions of Android. During the refactor, the logic for
resumption/crashes was temporarily removed (ie. onDestroy, START_STICKY,
DownloadResumptionScheduler, etc). This CL reimplements the necessarily
logic for unexpected shutdowns and restarts.

Bug:  755771 , 747563 
Change-Id: I7e1c2d0eef6b8765a0636d0d3f5181eb56c892f5
Reviewed-on: https://chromium-review.googlesource.com/658489
Commit-Queue: Joy Ming <jming@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503251}
[modify] https://crrev.com/ec551c676d717ae37a2130f729dfe6ad9f03ac49/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastManager.java
[modify] https://crrev.com/ec551c676d717ae37a2130f729dfe6ad9f03ac49/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadForegroundService.java
[modify] https://crrev.com/ec551c676d717ae37a2130f729dfe6ad9f03ac49/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadForegroundServiceManager.java
[add] https://crrev.com/ec551c676d717ae37a2130f729dfe6ad9f03ac49/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadForegroundServiceObservers.java
[modify] https://crrev.com/ec551c676d717ae37a2130f729dfe6ad9f03ac49/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService2.java
[add] https://crrev.com/ec551c676d717ae37a2130f729dfe6ad9f03ac49/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationServiceObserver.java
[modify] https://crrev.com/ec551c676d717ae37a2130f729dfe6ad9f03ac49/chrome/android/java_sources.gni
[modify] https://crrev.com/ec551c676d717ae37a2130f729dfe6ad9f03ac49/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest2.java

Comment 2 by jming@chromium.org, Apr 25 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment