New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755760 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Some buttons are not aligned and fuzzy in selection mode

Project Member Reported by mcirimele@chromium.org, Aug 15 2017

Issue description

See attached screenshot. Looks like the "Cancel selection" and "Open" buttons are not aligned. The "delete" (and maybe three dot?) icon look fuzzy. 

This is not the case on Canary, not sure if it's happening for the touch build only. 


 
files-action-bar-align.png
1.3 MB View Download

Comment 1 by oka@chromium.org, Aug 31 2017

Cc: marian...@google.com
Marianne can take this?
Labels: OS-Chrome
Owner: mcirimele@chromium.org
I think "fuzzy images" may be a separate issue.
I did not see the images fuzzy on my Chromebook Plus.
(and the screenshot looks like it's using 16x16 image.)

- On which device were the fuzzy icons observed?
- How did the icons on the blue toolbar looked then?
Cc: -mcirimele@chromium.org fukino@chromium.org
+fukino@ - Is this a similar issue to  crbug.com/751362 ?
This is not related to  crbug.com/751362 .

I guess this depends on the device.
This might happen every device whose screen has 1.5x DPI.
Maria, which device are you using?
Cc: sgabr...@chromium.org
Yes, I think fukino@ is right. I believe this was on Weifang's Lulu device. I found some other issues not related to files app that sgabriel@ and I believe are related to the resolution. 

Adding sgabriel@ as an FYI.
Blocking: -730232
Labels: M-63
Removing as blocking for touch - Adding to M63 for triage
Labels: -M-63 M-64
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11c7d3bf33a22825bfbb19ae664732748eba18d7

commit 11c7d3bf33a22825bfbb19ae664732748eba18d7
Author: Naoki Fukino <fukino@chromium.org>
Date: Thu Oct 26 12:34:49 2017

Files app: Adjust vertical position of toolbar components.

Added 1px top border on the white toolbar to keep the same vertical center as
the blue one.
Added 1px top padding to "Cancel selection" label to make sure that it won't be
placed 1px upper due to the fractional position.

Bug:  755760 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I364b8db45bd655389865626137c984aedfdc5712
Reviewed-on: https://chromium-review.googlesource.com/725643
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511795}
[modify] https://crrev.com/11c7d3bf33a22825bfbb19ae664732748eba18d7/ui/file_manager/file_manager/foreground/css/file_manager.css

fukino@ - It looks like there was a commit associated with this bug. Is this still an open issue or should the CL resolve the bug?
Two issues are mentioned in the bug description.

> Looks like the "Cancel selection" and "Open" buttons are not aligned.
This should have been fixed by the commit.

> The "delete" (and maybe three dot?) icon look fuzzy.
I guess this still reproduces on 1.5x scale displays.
Status: Fixed (was: Untriaged)
Thanks for the update!

Closing this issue and created  crbug.com/793382  to track the second issue.

Sign in to add a comment