New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 755757 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 730232



Sign in to add a comment

Enable context menu on two-finger tap

Project Member Reported by mcirimele@chromium.org, Aug 15 2017

Issue description

It seems like two-finger tap (on screen) no longer brings up the context menu. I think it would be nice to keep it, could we re-enable it to work with the other touch changes?
 
Labels: OS-Chrome
Labels: -Pri-3 M-61 Pri-1
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Cc: mkarkada@chromium.org dhadd...@chromium.org sdantul...@chromium.org abod...@chromium.org
 Issue 757018  has been merged into this issue.
Cc: -weifangsun@chromium.org osh...@chromium.org
Context menu trigger by touch was disabled when we assigned "toggle select" to the long-tap gesture, which had also been assigned to bring-up the context menu. But I agree that two-fingers tap should work like before.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a7a344eb3dd04ddf530161e8ddd1faff3d09e7b

commit 1a7a344eb3dd04ddf530161e8ddd1faff3d09e7b
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Wed Aug 23 06:23:07 2017

Enable opening context menu by two-finger tap.

The context menu has once disabled by 606068 when we assigned long-tap
to enter the selection mode.

Bug:  755757 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I282901d190e63c264eb6238abd34bf0cff107a66
Reviewed-on: https://chromium-review.googlesource.com/625506
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496599}
[modify] https://crrev.com/1a7a344eb3dd04ddf530161e8ddd1faff3d09e7b/ui/file_manager/file_manager/foreground/js/ui/file_tap_handler.js
[modify] https://crrev.com/1a7a344eb3dd04ddf530161e8ddd1faff3d09e7b/ui/file_manager/file_manager/foreground/js/ui/list_container.js

Status: Fixed (was: Started)
Labels: Merge-Request-61
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 23 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 25 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7003411f619e1381d65c6455c3574f448c1a66e2

commit 7003411f619e1381d65c6455c3574f448c1a66e2
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Fri Aug 25 03:17:12 2017

Enable opening context menu by two-finger tap.

The context menu has once disabled by 606068 when we assigned long-tap
to enter the selection mode.

TBR=yamaguchi@chromium.org

(cherry picked from commit 1a7a344eb3dd04ddf530161e8ddd1faff3d09e7b)

Bug:  755757 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I282901d190e63c264eb6238abd34bf0cff107a66
Reviewed-on: https://chromium-review.googlesource.com/625506
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496599}
Reviewed-on: https://chromium-review.googlesource.com/633968
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#871}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/7003411f619e1381d65c6455c3574f448c1a66e2/ui/file_manager/file_manager/foreground/js/ui/file_tap_handler.js
[modify] https://crrev.com/7003411f619e1381d65c6455c3574f448c1a66e2/ui/file_manager/file_manager/foreground/js/ui/list_container.js

Status: Verified (was: Fixed)
9901.66.0, 62.0.3202.82 stable

Sign in to add a comment