Enable context menu on two-finger tap |
|||||||||||
Issue descriptionIt seems like two-finger tap (on screen) no longer brings up the context menu. I think it would be nice to keep it, could we re-enable it to work with the other touch changes?
,
Aug 15 2017
,
Aug 17 2017
,
Aug 21 2017
Issue 757018 has been merged into this issue.
,
Aug 22 2017
Context menu trigger by touch was disabled when we assigned "toggle select" to the long-tap gesture, which had also been assigned to bring-up the context menu. But I agree that two-fingers tap should work like before.
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a7a344eb3dd04ddf530161e8ddd1faff3d09e7b commit 1a7a344eb3dd04ddf530161e8ddd1faff3d09e7b Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Wed Aug 23 06:23:07 2017 Enable opening context menu by two-finger tap. The context menu has once disabled by 606068 when we assigned long-tap to enter the selection mode. Bug: 755757 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I282901d190e63c264eb6238abd34bf0cff107a66 Reviewed-on: https://chromium-review.googlesource.com/625506 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#496599} [modify] https://crrev.com/1a7a344eb3dd04ddf530161e8ddd1faff3d09e7b/ui/file_manager/file_manager/foreground/js/ui/file_tap_handler.js [modify] https://crrev.com/1a7a344eb3dd04ddf530161e8ddd1faff3d09e7b/ui/file_manager/file_manager/foreground/js/ui/list_container.js
,
Aug 23 2017
,
Aug 23 2017
,
Aug 23 2017
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 23 2017
Approving merge to M61 Chrome OS.
,
Aug 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7003411f619e1381d65c6455c3574f448c1a66e2 commit 7003411f619e1381d65c6455c3574f448c1a66e2 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Fri Aug 25 03:17:12 2017 Enable opening context menu by two-finger tap. The context menu has once disabled by 606068 when we assigned long-tap to enter the selection mode. TBR=yamaguchi@chromium.org (cherry picked from commit 1a7a344eb3dd04ddf530161e8ddd1faff3d09e7b) Bug: 755757 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I282901d190e63c264eb6238abd34bf0cff107a66 Reviewed-on: https://chromium-review.googlesource.com/625506 Reviewed-by: Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#496599} Reviewed-on: https://chromium-review.googlesource.com/633968 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#871} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/7003411f619e1381d65c6455c3574f448c1a66e2/ui/file_manager/file_manager/foreground/js/ui/file_tap_handler.js [modify] https://crrev.com/7003411f619e1381d65c6455c3574f448c1a66e2/ui/file_manager/file_manager/foreground/js/ui/list_container.js
,
Nov 13 2017
9901.66.0, 62.0.3202.82 stable |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by weifangsun@chromium.org
, Aug 15 2017