New issue
Advanced search Search tips

Issue 755756 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocked on:
issue 757850

Blocking:
issue 758623



Sign in to add a comment

Change scheduler for wpt-importer to run continuously

Project Member Reported by qyears...@chromium.org, Aug 15 2017

Issue description

Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/617265/
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d268dcab109e37533efe07b13285c9508075964a

commit d268dcab109e37533efe07b13285c9508075964a
Author: Quinten Yearsley <qyearsley@google.com>
Date: Fri Aug 18 15:45:34 2017

Change scheduler for wpt-importer to restart when finished

Bug:  755756 
Change-Id: I513d1d833479f6375bee2f9824340cbfa814bfd0
Reviewed-on: https://chromium-review.googlesource.com/617265
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/d268dcab109e37533efe07b13285c9508075964a/masters/master.chromium.infra.cron/master.cfg

Cc: foolip@chromium.org
This will take effect once the master is restarted. OK to do this today?

Comment 4 by foolip@chromium.org, Aug 18 2017

Maybe it's best to do it on Monday when someone can keep an eye on it?
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95fa323ea61fe25d237758a41ebf03dc38db0fc7

commit 95fa323ea61fe25d237758a41ebf03dc38db0fc7
Author: Quinten Yearsley <qyearsley@google.com>
Date: Fri Aug 18 16:10:55 2017

Add a note in the docs about disabling wpt-importer

Bug:  755756 
Change-Id: Ia53261df2ef3fb8030b0349b6498aa32d02e9347
Reviewed-on: https://chromium-review.googlesource.com/617593
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495564}
[modify] https://crrev.com/95fa323ea61fe25d237758a41ebf03dc38db0fc7/docs/testing/web_platform_tests.md

Is there an ETA for restarting the master?

Comment 7 by foolip@chromium.org, Aug 22 2017

It's a new week, so any time now would be OK.
Blockedon: 757850
Well, the master was restarted and jobs are triggered continuously now -- but not in the way I wanted them to be.

Now new jobs are scheduled every minute even if there's a currently running job, so the list of pending jobs grew very long.

I just cancelled all the pending jobs, but I expect it to keep building up into this problem is fixed:
https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/2befdd4c50dc5fc3f271c23158e203b4286dc9ab

commit 2befdd4c50dc5fc3f271c23158e203b4286dc9ab
Author: Quinten Yearsley <qyearsley@google.com>
Date: Thu Aug 24 15:32:50 2017

Increase the period for wpt-importer jobs to 10 minutes

Even though the longer jobs can take more than 3 hours, it's OK to have
a relatively short period because I've discovered that pending jobs are
cleared when new jobs start.

So this means that we'll normally expect wpt-importer to retry once
every 10 minutes when there's nothing to do, and when there is something
to do, 30-40 pending builds might build up but will be cleared at the
start of a new build.

Bug:  755756 
Change-Id: Ia0319753f75c44a89fb8436da523e3543142e47b
Reviewed-on: https://chromium-review.googlesource.com/630137
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/2befdd4c50dc5fc3f271c23158e203b4286dc9ab/masters/master.chromium.infra.cron/master.cfg

Blocking: 758623
Status: Fixed (was: Started)

Sign in to add a comment