Remove cbuidlbot build failed X times in a row email support for PreCQ builders. |
||||
Issue descriptionWe have Monarch support for builder health, and can so remove support from cbuildbot. This means removing the following build config options, and the code needed to support them. # An integer. If this builder fails this many times consecutively, send # an alert email to the recipients health_alert_recipients. This does # not apply to tryjobs. This feature is similar to the ERROR_WATERMARK # feature of upload_symbols, and it may make sense to merge the features # at some point. health_threshold=0, # List of email addresses to send health alerts to for this builder. It # supports automatic email address lookup for the following sheriff # types: # 'tree': tree sheriffs # 'chrome': chrome gardeners health_alert_recipients=[], This includes logic to increment build failure counters in GS, as well as to check those counters to see if those threshholds have been exceeded. If this is the only thing in cbuildbot generating email (not sure), we can remove cbuildbot direct email support, as well as remove our gmail credentials from the builders.
,
Aug 15 2017
I mean health_threshold
,
Aug 15 2017
Ah. Less code on the chopping block than I was hoping.
,
Aug 15 2017
There are still email alerts for Gardeners, Toolchain, and Lakitu builds. Those can all (hopefully) be replaced by SoM overtime.
,
Aug 16 2017
OK, so what's the final ask of this bug? Looks like we can "only" drop the emails directly generated by pre-cqs? That's cleanup from nxia@'s work, so off to her.
,
Aug 16 2017
I have a CL out to remove the emails we can, which I think is the final ask.
,
Aug 16 2017
,
Aug 16 2017
,
Aug 16 2017
There's a chunk of code to send the emails for pre-cq builds in http://shortn/_oZiw119nGo. I'll clean up the code in the report_stage.
,
Aug 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/1e429f9a67301d257481e47571d009b92b33b9ec commit 1e429f9a67301d257481e47571d009b92b33b9ec Author: Don Garrett <dgarrett@google.com> Date: Fri Aug 18 01:42:28 2017 chromeos_config: Reduce build health emails. Stop sending cbuildbot generated health alert emails to chromeos-infra-eng@grotations.appspotmail.com for PreCQ builders. Stop sending email for any builders to tree sheriffs, since they use Sheriff-O-Matic to monitor builds now. We still generate health alert emails for the Chrome PFQ, toolchain, and lakitu builds. BUG= chromium:755734 TEST=run_tests Change-Id: I670432a445bf6eed4f8ac72339c3948e38f9102b Reviewed-on: https://chromium-review.googlesource.com/616225 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/1e429f9a67301d257481e47571d009b92b33b9ec/cbuildbot/config_dump.json [modify] https://crrev.com/1e429f9a67301d257481e47571d009b92b33b9ec/lib/constants.py [modify] https://crrev.com/1e429f9a67301d257481e47571d009b92b33b9ec/cbuildbot/chromeos_config.py
,
Aug 18 2017
Given the reduced scope of the bug, I think this is fixed. |
||||
►
Sign in to add a comment |
||||
Comment 1 by nxia@chromium.org
, Aug 15 2017