New issue
Advanced search Search tips

Issue 755727 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Adopt std::make_unique from C++14

Project Member Reported by jbroman@chromium.org, Aug 15 2017

Issue description

It should replace base::MakeUnique and WTF::MakeUnique.
 
Showing comments 32 - 131 of 131 Older
Project Member

Comment 32 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6cd028398de42ee935518fc21e14b92b2f9812f

commit e6cd028398de42ee935518fc21e14b92b2f9812f
Author: Ben Chan <benchan@chromium.org>
Date: Wed Oct 18 18:38:41 2017

chromeos: printing: replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: I65d0c82fab73d31dffec9e2e0fd942d4dad0e2f5
Reviewed-on: https://chromium-review.googlesource.com/724731
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509817}
[modify] https://crrev.com/e6cd028398de42ee935518fc21e14b92b2f9812f/chromeos/printing/ppd_provider.cc
[modify] https://crrev.com/e6cd028398de42ee935518fc21e14b92b2f9812f/chromeos/printing/ppd_provider_unittest.cc
[modify] https://crrev.com/e6cd028398de42ee935518fc21e14b92b2f9812f/chromeos/printing/printer_translator.cc

Project Member

Comment 33 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1e2bd2e8afd4dba06030d30be1dbaf7ecd76076

commit b1e2bd2e8afd4dba06030d30be1dbaf7ecd76076
Author: Ben Chan <benchan@chromium.org>
Date: Thu Oct 19 06:31:44 2017

chromeos: binder: replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: Ib1224db452ea366eac2d5dd4d940b26fd5c1b035
Reviewed-on: https://chromium-review.googlesource.com/727374
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510016}
[modify] https://crrev.com/b1e2bd2e8afd4dba06030d30be1dbaf7ecd76076/chromeos/binder/service_manager_proxy_unittest.cc

Project Member

Comment 34 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5279375b55633c89c014c66bfd8bb88d07d4d15f

commit 5279375b55633c89c014c66bfd8bb88d07d4d15f
Author: Peiyong Lin <lpy@chromium.org>
Date: Fri Oct 27 03:49:57 2017

Replace base::MakeUnique with std::make_unique in services/resource_coordinator.

Generated by:
git grep -l base::MakeUnique services/resource_coordinator | xargs perl -pi -e 's/base::MakeUnique/std::make_unique/'

Bug: 755727
Change-Id: I76c926b87acb7ded0e2cf6d818125a2cbcb1abab
Reviewed-on: https://chromium-review.googlesource.com/740441
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Commit-Queue: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512083}
[modify] https://crrev.com/5279375b55633c89c014c66bfd8bb88d07d4d15f/services/resource_coordinator/coordination_unit/coordination_unit_base.cc
[modify] https://crrev.com/5279375b55633c89c014c66bfd8bb88d07d4d15f/services/resource_coordinator/coordination_unit/coordination_unit_manager.cc
[modify] https://crrev.com/5279375b55633c89c014c66bfd8bb88d07d4d15f/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
[modify] https://crrev.com/5279375b55633c89c014c66bfd8bb88d07d4d15f/services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
[modify] https://crrev.com/5279375b55633c89c014c66bfd8bb88d07d4d15f/services/resource_coordinator/observers/coordination_unit_graph_observer_unittest.cc
[modify] https://crrev.com/5279375b55633c89c014c66bfd8bb88d07d4d15f/services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.cc
[modify] https://crrev.com/5279375b55633c89c014c66bfd8bb88d07d4d15f/services/resource_coordinator/public/cpp/memory_instrumentation/tracing_integration_unittest.cc
[modify] https://crrev.com/5279375b55633c89c014c66bfd8bb88d07d4d15f/services/resource_coordinator/public/cpp/memory_instrumentation/tracing_observer.cc
[modify] https://crrev.com/5279375b55633c89c014c66bfd8bb88d07d4d15f/services/resource_coordinator/public/cpp/tracing/chrome_trace_event_agent_unittest.cc
[modify] https://crrev.com/5279375b55633c89c014c66bfd8bb88d07d4d15f/services/resource_coordinator/resource_coordinator_service.cc
[modify] https://crrev.com/5279375b55633c89c014c66bfd8bb88d07d4d15f/services/resource_coordinator/service_callbacks_impl.cc
[modify] https://crrev.com/5279375b55633c89c014c66bfd8bb88d07d4d15f/services/resource_coordinator/tracing/agent_registry.cc
[modify] https://crrev.com/5279375b55633c89c014c66bfd8bb88d07d4d15f/services/resource_coordinator/tracing/coordinator.cc
[modify] https://crrev.com/5279375b55633c89c014c66bfd8bb88d07d4d15f/services/resource_coordinator/tracing/coordinator_unittest.cc
[modify] https://crrev.com/5279375b55633c89c014c66bfd8bb88d07d4d15f/services/resource_coordinator/tracing/recorder_unittest.cc
[modify] https://crrev.com/5279375b55633c89c014c66bfd8bb88d07d4d15f/services/resource_coordinator/tracing/test_util.cc

Project Member

Comment 35 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04f27c37974050559508833241e11258fb8c1a4a

commit 04f27c37974050559508833241e11258fb8c1a4a
Author: Jeremy Roman <jbroman@chromium.org>
Date: Fri Oct 27 15:20:55 2017

Replace base::MakeUnique with std::make_unique in content/.

base/memory/ptr_util.h includes will be cleaned up later.

Generated by:
git grep -l base::MakeUnique content/ | xargs perl -pi -e 's/base::MakeUnique/std::make_unique/'

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I10d622bde1d70b9a5f5aee0f229262c7018ec56b
Reviewed-on: https://chromium-review.googlesource.com/740181
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512186}
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/app/android/content_main.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/accessibility/accessibility_tree_formatter_auralinux.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/accessibility/accessibility_tree_formatter_blink.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/accessibility/accessibility_tree_formatter_browser.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/accessibility/accessibility_tree_formatter_win.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/android/content_view_core.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/android/java/gin_java_bridge_dispatcher_host.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/android/java/gin_java_bridge_message_filter.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/android/java/gin_java_method_invocation_helper.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/android/java/gin_java_method_invocation_helper_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/android/java/gin_java_script_to_java_types_coercion.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/android/overscroll_controller_android.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/android/overscroll_controller_android_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/android/smart_selection_client.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/android/synchronous_compositor_browser_filter.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/android/synchronous_compositor_host.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/android/text_suggestion_host_mojo_impl_android.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/appcache/appcache_backend_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/appcache/appcache_request_handler_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/appcache/appcache_storage_impl_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/appcache/appcache_update_job_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/background_fetch/background_fetch_service_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/background_fetch/background_fetch_service_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/background_fetch/mock_background_fetch_delegate.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/battery_monitor_browsertest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/blob_storage/blob_registry_wrapper.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/blob_storage/blob_url_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/blob_storage/chrome_blob_storage_context.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/bluetooth/frame_connected_bluetooth_devices.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/bluetooth/frame_connected_bluetooth_devices_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/browser_context.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/browser_main_loop.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/browsing_data/browsing_data_filter_builder_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/browsing_data/browsing_data_remover_impl_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/browsing_data/clear_site_data_throttle.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/browsing_data/clear_site_data_throttle_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/cache_storage/cache_storage_blob_to_disk_cache_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/cache_storage/cache_storage_operation_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/cache_storage/cache_storage_scheduler.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/child_process_launcher_helper_mac.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/child_process_security_policy_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/compositor/reflector_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/compositor/reflector_impl_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/cross_site_transfer_browsertest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/dedicated_worker/dedicated_worker_host.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/device_sensors/device_sensor_browsertest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/devtools/devtools_manager.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/devtools/devtools_url_request_interceptor.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/devtools/protocol/storage_handler.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/devtools/protocol/tethering_handler.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/devtools/protocol/tracing_handler.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/devtools/protocol_string.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/dom_storage/dom_storage_area.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/dom_storage/dom_storage_context_wrapper.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/dom_storage/local_storage_context_mojo.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/dom_storage/local_storage_context_mojo_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/download_file_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/download_file_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/download_item_impl_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/download_job_factory.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/download_job_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/download_manager_impl_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/download_request_core.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/download_request_core_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/download_resource_handler.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/download_utils.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/parallel_download_job.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/parallel_download_job_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/save_file_manager.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/save_package_browsertest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/slow_download_http_response.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/test_download_http_response.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/download/url_downloader.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/field_trial_recorder.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/find_request_manager.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/frame_host/data_url_navigation_throttle.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/frame_host/input/input_injector_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/frame_host/input/legacy_ipc_frame_input_handler.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/frame_host/interstitial_page_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/frame_host/keep_alive_handle_factory.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/frame_host/navigation_entry_impl_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/frame_host/navigation_handle_impl_browsertest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/frame_host/navigation_handle_impl_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/generic_sensor_browsertest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/geolocation/geolocation_service_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/geolocation/geolocation_service_impl_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/gpu/compositor_util.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/gpu/gpu_internals_ui.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/host_zoom_map_impl_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/hyphenation/hyphenation_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/image_capture/image_capture_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/cursor_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/database_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_active_blob_registry_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_callbacks.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_database_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_dispatcher_host.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_factory_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_factory_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_index_writer.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_leveldb_coding.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_tombstone_sweeper_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_transaction.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_transaction_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/indexed_db_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/leveldb/leveldb_database.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/leveldb/leveldb_transaction.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/list_set_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/installedapp/installed_app_provider_impl_default.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/keyboard_lock/keyboard_lock_service_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/leveldb_wrapper_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/async_resource_handler.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/async_resource_handler_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/cross_site_resource_handler_browsertest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/detachable_resource_handler.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/detachable_resource_handler_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/downloaded_temp_file_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/intercepting_resource_handler.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/intercepting_resource_handler_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/mime_sniffing_resource_handler.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/mime_sniffing_resource_handler_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/mock_resource_loader.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/navigation_resource_handler.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/navigation_url_loader.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/navigation_url_loader_network_service_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/navigation_url_loader_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/redirect_to_file_resource_handler_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/resource_dispatcher_host_browsertest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/resource_hints_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/resource_scheduler.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/resource_scheduler_browsertest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/resource_scheduler_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/test_resource_handler.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/loader/upload_data_stream_builder.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/manifest/manifest_manager_host.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/media/android/browser_media_player_manager.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/media/capture/cursor_renderer_aura.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/media/capture/cursor_renderer_mac.mm
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/media/capture/screen_capture_device_android.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/media/capture/screen_capture_device_android_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/media/capture/web_contents_video_capture_device_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/media/media_internals.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/media/media_internals_ui.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/media/midi_host.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/media/session/media_session_impl_browsertest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/media/session/media_session_impl_service_routing_unittest.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/media/url_provision_fetcher.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/memory/memory_coordinator_impl.cc
[modify] https://crrev.com/04f27c37974050559508833241e11258fb8c1a4a/content/browser/memory/memory_coordinator_impl_unittest.cc
[modify] https://crrev.com/04f27c379740505
There are hundreds of files affected, so let me outline the stats here:

WTF::MakeUnique
----------------

# Summary of intended CLs and lines changed per CL:

- CL #1: bindings + platform: 55 lines.
- CL #2: core/css + core/layout: 45 lines.
- CL #4  core/exported + core/frame + core/loader: 47 lines.
- CL #5: core/workers + core/html + core/paint: 28 lines.
- CL #6: core/*remaining*: 43 lines.
- CL #7: modules/cachestorage + modules/canvas: 42 lines.
- CL #8: modules/webaudio + modules/indexeddb: 44 lines. 
- CL #9: modules/fetch + modules/websockets + modules/serviceworkers: 42 lines.
- CL #10: modules/*everything*: 48 lines.


## Details of those numbers:

# Number of affected files
$ ack-grep --type=cpp -l -w 'MakeUnique'  ./third_party/WebKit/Source/ | wc -l
184

# Number of lines affected:
$ ack-grep --type=cpp -w 'MakeUnique'  ./third_party/WebKit/Source/ |grep 'WTF::MakeUnique' |wc -l
448

# sed command to update them:
$ ack-grep --type=cpp -l -w 'MakeUnique' ./third_party/WebKit/Source/   |xargs sed -i 's/WTF::MakeUnique/std::make_unique/'

# Number of files grouping by directories:
$ ack-grep --type=cpp -l -w 'MakeUnique'  ./third_party/WebKit/Source/  |cut -d '/' -f 4 |sort |uniq -c
      3 bindings
     89 core
     65 modules
     27 platform

# Number of lines grouping by directories:
$ ack-grep --type=cpp -w 'MakeUnique'  ./third_party/WebKit/Source/ |grep 'WTF::MakeUnique' |cut -d '/' -f 4  |sort |uniq -c
      9 bindings
    217 core
    176 modules
     46 platform

# Drilling down on core and modules:
 $ ack-grep --type=cpp -w 'MakeUnique'  ./third_party/WebKit/Source/core |grep 'WTF::MakeUnique' |cut -d '/' -f 5  |sort |uniq -c     
     10 css
      4 dom
      3 editing
      2 events
     19 exported
      1 fileapi
     10 frame
      8 html
      1 imagebitmap
      3 input
      9 inspector
     35 layout
     18 loader
      5 page
      7 paint
      1 style
      1 timing
     13 workers
      6 xml

$ ack-grep --type=cpp -w 'MakeUnique'  ./third_party/WebKit/Source/modules |grep 'WTF::MakeUnique' |cut -d '/' -f 5  |sort |uniq -c
      2 animationworklet
     20 cachestorage
     22 canvas
      1 credentialmanager
      9 crypto
      1 document_metadata
      1 EventModulesFactory.h:22:    return WTF::MakeUnique<EventModulesFactory>();
      8 exported
     10 fetch
      1 filesystem
     24 indexeddb
      1 installation
      1 installedapp
      2 media_capabilities
      2 media_controls
      1 ModulesInitializer.cpp:122:      WTF::MakeUnique<CanvasRenderingContext2D::Factory>());
      1 ModulesInitializer.cpp:124:      WTF::MakeUnique<WebGLRenderingContext::Factory>());
      1 ModulesInitializer.cpp:126:      WTF::MakeUnique<WebGL2RenderingContext::Factory>());
      1 ModulesInitializer.cpp:128:      WTF::MakeUnique<ImageBitmapRenderingContext::Factory>());
      1 ModulesInitializer.cpp:132:      WTF::MakeUnique<OffscreenCanvasRenderingContext2D::Factory>());
      1 ModulesInitializer.cpp:134:      WTF::MakeUnique<WebGLRenderingContext::Factory>());
      1 ModulesInitializer.cpp:136:      WTF::MakeUnique<WebGL2RenderingContext::Factory>());
      1 payments
      4 presentation
      3 remoteplayback
      1 screen_orientation
     20 serviceworkers
      1 vr
     20 webaudio
      1 webdatabase
      1 webgl
     12 websockets





Owner: lucmult@chromium.org
Project Member

Comment 38 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48698bc5d6e4b774497624d93b91d8844aead2de

commit 48698bc5d6e4b774497624d93b91d8844aead2de
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Thu Nov 09 04:01:32 2017

Replaced WTF:MakeUnique by std::make_unique 1 of 10.

This patch is the first of 10 patches replacing WTF::MakeUnique by
std::make_unique.

This changes files on platform/ and bindings/ directories.

Command used for editing:

$ ack-grep --type=cpp -l -w 'MakeUnique'  \
   ./third_party/WebKit/Source/platform/  \
   ./third_party/WebKit/Source/bindings/  \
   |xargs sed -i 's/WTF::MakeUnique/std::make_unique/'

Additionally fixed lint errors related to includes on files:
- CompositedlayerRasterInvalidator.cpp
- BlobBytesProviderTest.cpp
- FetchParameters.cpp

Bug: 755727, 781645
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3da4e19b40eabcab823eed0d475f9fcec68b8de7
Reviewed-on: https://chromium-review.googlesource.com/756536
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515089}
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/WebThreadSupportingGC.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/bindings/V8PerContextData.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/blob/BlobBytesProviderTest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/blob/BlobData.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/blob/BlobDataTest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/heap/Heap.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/heap/SparseHeapBitmap.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/heap/ThreadState.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/heap/Visitor.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/loader/fetch/BufferingDataPipeWriterTest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/loader/fetch/FetchParameters.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/loader/fetch/RawResource.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/threading/BackgroundTaskRunnerTest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/transforms/TransformationMatrix.h

Project Member

Comment 39 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/451942a420743bc76fa551a9af1058b302ac016e

commit 451942a420743bc76fa551a9af1058b302ac016e
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Nov 14 01:08:51 2017

Replace WTF::MakeUnique with std::make_unique on core/css/ and core/layout/

CL #2 out of 10.

Add include <memory> where needed according to "git cl lint".

Add some other include lines suggested by lint.

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ie75a1450ad57bc283a57d777a050a103f361de8e
Reviewed-on: https://chromium-review.googlesource.com/765562
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516130}
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/css/MediaQuery.cpp
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/css/MediaQuery.h
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/css/parser/CSSParserSelector.cpp
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/css/parser/CSSParserSelector.h
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/css/threaded/MultiThreadedTestUtil.h
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder_test.cc
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/layout/ng/layout_ng_mixin.cc
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/layout/shapes/Shape.cpp
[modify] https://crrev.com/451942a420743bc76fa551a9af1058b302ac016e/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp

An update here:

1. My summary for CLs on comment 36 was missing CL #3 :-/ 

2. Apparently core/animation grew on use of MakeUnique since then, now it has 61 occurrences for MakeUnique, so a CL just for this directory will replace the missing CL #3. :-)

$ ack-grep --type=cpp  -w 'MakeUnique' ./third_party/WebKit/Source/core/ |egrep -v '(/exported/|/frame/|/loader/|/paint/|/workers/|/html/|/css/|/layout/)' |grep 'WTF::MakeUnique' |cut -d '/' -f 5  |sort |uniq -c
     61 animation
      4 dom
      3 editing
      2 events
      1 fileapi
      1 imagebitmap
      3 input
      9 inspector
      5 page
      1 style
      1 timing
      6 xml

Project Member

Comment 41 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b

commit c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Nov 14 06:22:12 2017

Replace WTF:MakeUnique by std::make_unique.

Files on directories core/html, core/paint and core/workers.

CL 4 of 10.

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I45d4e2ae2852bdd7e3b5b59b2db6da3a05bf4807
Reviewed-on: https://chromium-review.googlesource.com/768251
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516214}
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/html/HTMLAreaElement.cpp
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/paint/FragmentData.cpp
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/paint/RarePaintData.cpp
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/paint/VideoPainterTest.cpp
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/paint/ng/ng_paint_fragment.cc
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/workers/GlobalScopeCreationParams.cpp
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
[modify] https://crrev.com/c37b4d02f8a282e12fbd7d6f443591f34dc5ac6b/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h

Project Member

Comment 42 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0908d7c68c20dc3614dcfcf75a68c13286b16421

commit 0908d7c68c20dc3614dcfcf75a68c13286b16421
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Nov 14 08:20:24 2017

Replace WTF:MakeUnique by std::make_unique in modules/indexeddb/ and
modules/webaudio/

Fix missing include for <memory> and some for <utility> as pointed by
lint.

CL 8 of 10.

Bug: 755727
Change-Id: I93d47fc6ad2e8cd63f41ae61f167253cbb8ae461
Reviewed-on: https://chromium-review.googlesource.com/768325
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Chris Watkins <watk@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516226}
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/indexeddb/IDBRequestQueueItem.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/indexeddb/IDBTestHelper.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/indexeddb/IDBValue.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/indexeddb/IDBValueWrapping.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/indexeddb/IDBValueWrappingTest.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandlerTest.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/webaudio/AudioContextTest.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScope.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScopeTest.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/webaudio/AudioWorkletThreadTest.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/webaudio/BiquadProcessor.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/webaudio/DelayProcessor.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/webaudio/PeriodicWave.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp
[modify] https://crrev.com/0908d7c68c20dc3614dcfcf75a68c13286b16421/third_party/WebKit/Source/modules/webaudio/WaveShaperProcessor.cpp

Project Member

Comment 43 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd6ad4809caafce780edb4fe2b9f402de41c1cca

commit dd6ad4809caafce780edb4fe2b9f402de41c1cca
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Nov 14 08:20:17 2017

Replace WTF:MakeUnique by std::make_unique on core/animation/

CL 5 of 10.

Fix lint about missing include <utility>.

Bug: 755727
Change-Id: I7fe773d7b56896e2780e246adede2725aa3ec21f
Reviewed-on: https://chromium-review.googlesource.com/768253
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516225}
[modify] https://crrev.com/dd6ad4809caafce780edb4fe2b9f402de41c1cca/third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp
[modify] https://crrev.com/dd6ad4809caafce780edb4fe2b9f402de41c1cca/third_party/WebKit/Source/core/animation/SVGInterpolationTypesMap.cpp

Project Member

Comment 44 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e

commit ef2f2f4a82b7907438e312c427f73bebe7bd6b8e
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Nov 14 08:21:26 2017

Replace WTF:MakeUnique by std::make_unique in modules/fetch/,
modules/websockets/ and modules/serviceworkers/

Fix missing include for <memory> and some for <utility> as pointed by
lint.

CL 9 of 10.

Bug: 755727
Change-Id: Iadc120e5f4f54767966414bc6169facafdf14e80
Reviewed-on: https://chromium-review.googlesource.com/768593
Reviewed-by: Chris Watkins <watk@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516227}
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/fetch/BytesConsumerForDataConsumerHandleTest.cpp
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.cpp
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerInstalledScriptsManager.cpp
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/serviceworkers/WebEmbeddedWorkerImplTest.cpp
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/websockets/WebPepperSocketImpl.cpp
[modify] https://crrev.com/ef2f2f4a82b7907438e312c427f73bebe7bd6b8e/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

Project Member

Comment 45 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/804cf422e9b43d32ef56d630b6ed762bbd6403d1

commit 804cf422e9b43d32ef56d630b6ed762bbd6403d1
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Nov 14 08:55:01 2017

Replace WTF::MakeUnique with std::make_unique on core/exported, core/frame/ and core/loader/

Add include <memory> where needed according to lint.

Bug: 755727
Change-Id: I4d0e52593f789fc4c23112d8dc178f21c766907c
Reviewed-on: https://chromium-review.googlesource.com/765610
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516236}
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/exported/SharedWorkerRepositoryClientImpl.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/exported/WebPagePopupImpl.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/exported/WebPluginContainerTest.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/frame/FrameTestHelpers.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/frame/LocalFrame.h
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/loader/EmptyClients.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/loader/HistoryItem.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/loader/HistoryItem.h
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/loader/ProgressTracker.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/loader/ScheduledNavigation.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
[modify] https://crrev.com/804cf422e9b43d32ef56d630b6ed762bbd6403d1/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp

Project Member

Comment 46 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80

commit 879e6cd91bd64e86cb3385f5c1cb7caa9c788f80
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Nov 14 08:57:01 2017

Replaced WTF:MakeUnique by std::make_unique on reamining of core/

Add missing <memory> and some other std headers as pointed by lint.

CL 6 of 10.

Bug: 755727
Change-Id: I0781468ccceb4b6bb22ced01290918cec241a1fb
Reviewed-on: https://chromium-review.googlesource.com/768510
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516237}
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/dom/ContextFeatures.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/dom/DocumentTest.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/events/EventFactory.h
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/events/KeyboardEvent.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/inspector/InspectorDOMSnapshotAgent.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/page/PageOverlayTest.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/page/scrolling/ScrollStateTest.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/timing/SubTaskAttribution.h
[modify] https://crrev.com/879e6cd91bd64e86cb3385f5c1cb7caa9c788f80/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

Project Member

Comment 47 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/793947f48b3c78aae7bf8915897f6b429353ce96

commit 793947f48b3c78aae7bf8915897f6b429353ce96
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Nov 14 09:24:28 2017

Replace WTF:MakeUnique by std::make_unique on reamaining of modules/

Fix missing include for <memory> and some for <utility> as pointed by
lint.

CL 10 of 10. After all 10 CLs are merged, I'll remove WTF::MakeUnique.

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id7021e32bc2c366ec35cdc31074cd7e3a04405ef
Reviewed-on: https://chromium-review.googlesource.com/768597
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516243}
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/EventModulesFactory.h
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletGlobalScope.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletThreadTest.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/document_metadata/CopylessPasteServer.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/installation/InstallationServiceImpl.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp
[modify] https://crrev.com/793947f48b3c78aae7bf8915897f6b429353ce96/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Project Member

Comment 49 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83533d7aaf00d7734a396b2a4f0cdc02a74051e1

commit 83533d7aaf00d7734a396b2a4f0cdc02a74051e1
Author: Jeremy Roman <jbroman@chromium.org>
Date: Wed Nov 15 23:39:06 2017

Replace base::MakeUnique with std::make_unique in services/.

base/memory/ptr_util.h includes will be cleaned up later.

Generated by:
git grep -l base::MakeUnique services/ | xargs perl -pi -e 's/base::MakeUnique/std::make_unique/'

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: I38cbcf6411a6a84cbe4cc9ddd7773d5e45ec6500
Reviewed-on: https://chromium-review.googlesource.com/767370
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516892}
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/catalog/catalog.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/catalog/entry.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/catalog/public/tools/catalog.cc.tmpl
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/data_decoder/data_decoder_service.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/battery/battery_monitor_impl_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/battery/battery_status_manager_chromeos.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/battery/battery_status_manager_default.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/battery/battery_status_manager_linux.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/battery/battery_status_manager_mac.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/battery/battery_status_manager_win.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/battery/battery_status_service_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/device_service.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/device_service_test_base.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/fingerprint/fingerprint_chromeos.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/absolute_orientation_euler_angles_fusion_algorithm_using_accelerometer_and_magnetometer_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/generic_sensor_service_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/linear_acceleration_fusion_algorithm_using_accelerometer_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/orientation_euler_angles_fusion_algorithm_using_quaternion_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/orientation_quaternion_fusion_algorithm_using_euler_angles_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/platform_sensor.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/platform_sensor_and_provider_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/platform_sensor_fusion_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/platform_sensor_provider_android.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/platform_sensor_provider_linux.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/platform_sensor_provider_mac.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/platform_sensor_provider_win.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/platform_sensor_reader_linux.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/platform_sensor_reader_win.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/relative_orientation_euler_angles_fusion_algorithm_using_accelerometer_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/generic_sensor/sensor_provider_impl.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/hid/hid_manager_impl.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/power_monitor/power_monitor_message_broadcaster_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/public/cpp/power_monitor/power_monitor_broadcast_source.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/serial/serial_device_enumerator_impl.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/serial/serial_io_handler_impl.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/time_zone_monitor/time_zone_monitor_fuchsia.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/time_zone_monitor/time_zone_monitor_linux.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/vibration/vibration_manager_impl_default.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/wake_lock/wake_lock.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/device/wake_lock/wake_lock_provider.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/file/file_service.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/file/file_system.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/identity/identity_manager.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/identity/identity_manager_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/metrics/metrics_mojo_service.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/metrics/public/cpp/mojo_ukm_recorder.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/metrics/public/cpp/ukm_recorder.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/metrics/ukm_recorder_interface.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/persistent_pref_store_impl.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/persistent_pref_store_impl_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/pref_service_factory_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/pref_store_consistency_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/pref_store_impl.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/pref_store_impl_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/pref_store_manager_impl.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/public/cpp/dictionary_value_update.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/public/cpp/in_process_service_factory.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/public/cpp/lib/util.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/public/cpp/pref_service_factory.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/public/cpp/pref_service_main.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/public/cpp/scoped_pref_update.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/public/cpp/scoped_pref_update.h
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/public/cpp/tests/persistent_pref_store_client_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/public/cpp/tests/pref_store_client_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/tracked/dictionary_hash_store_contents.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/tracked/interceptable_pref_filter_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/tracked/pref_hash_calculator_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/tracked/pref_hash_filter.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/tracked/pref_hash_filter_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/tracked/registry_hash_store_contents_win_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/tracked/segregated_pref_store_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/tracked/tracked_persistent_pref_store_factory.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/preferences/tracked/tracked_preferences_migration.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/proxy_resolver/proxy_resolver_service.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/resource_coordinator/coordination_unit/coordination_unit_base.h
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/README.md
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/background/background_service_manager.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/background/tests/background_service_manager_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/embedder/embedded_instance_manager.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/embedder/embedded_instance_manager_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/embedder/main.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/embedder/manifest_utils_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/public/cpp/binder_registry.h
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/public/cpp/connector.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/public/cpp/service_context.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/public/cpp/service_context_ref.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/public/cpp/service_test.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/public/cpp/test/test_connector_factory.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/service_manager.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/standalone/context.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/tests/connect/connect_test_package.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/tests/connect/connect_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/tests/lifecycle/package.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/tests/service_manager/embedder.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/service_manager/tests/service_manager/service_manager_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/shape_detection/barcode_detection_impl_mac.mm
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/shape_detection/face_detection_impl_mac.mm
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/shape_detection/face_detection_impl_mac_unittest.mm
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/shape_detection/face_detection_impl_win_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/shape_detection/face_detection_provider_impl.h
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/shape_detection/shape_detection_service.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/shape_detection/text_detection_impl_mac.mm
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/test/echo/echo_service.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/test/user_id/user_id_service.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/demo/mus_demo.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/demo/mus_demo_external.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/demo/mus_demo_internal.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/display/screen_manager_forwarding.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/display/screen_manager_ozone_external.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/display/screen_manager_ozone_internal.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/display/screen_manager_ozone_internal_unittests.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/display/screen_manager_stub_internal.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ime/test_ime_driver/test_ime_application.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ime/test_ime_driver/test_ime_driver.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/input_devices/input_device_server.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/input_devices/touch_device_server.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/public/cpp/gpu/gpu.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/service.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/test_wm/test_wm.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/cursor_state.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/cursor_state_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/display.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/display_manager.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/drag_controller_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/event_dispatcher_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/focus_controller.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/gpu_host.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/gpu_host_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/modal_window_controller.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/platform_display.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/platform_display_default.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/platform_display_default_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/server_window.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/test_gpu_host.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/test_utils.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/test_utils.h
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/threaded_image_cursors.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/user_activity_monitor_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/window_manager_client_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/window_manager_state.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/window_server.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/window_server_service_test_base.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/window_server_test_base.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/window_tree.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/ui/ws/window_tree_unittest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/video_capture/device_factory_media_to_mojo_adapter.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/video_capture/device_factory_provider_impl.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/video_capture/device_media_to_mojo_adapter.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/video_capture/public/cpp/receiver_media_to_mojo_adapter.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/video_capture/receiver_mojo_to_media_adapter.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/video_capture/service_impl.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/video_capture/test/device_factory_provider_connectortest.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/video_capture/test/device_factory_provider_test.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/video_capture/test/mock_device_factory.cc
[modify] https://crrev.com/83533d7aaf00d7734a396b2a4f0cdc02a74051e1/services/video_capture/test/mock_device_test.cc

Project Member

Comment 50 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27b1f0662c891e1e2af739cbbba7f16a6c7615d5

commit 27b1f0662c891e1e2af739cbbba7f16a6c7615d5
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Thu Nov 16 01:27:34 2017

Remove WTF::MakeUnique

Remove MakeUnique tests and declartion as well as the last few places
using it.

Fix some missing includes as pointed by lint.

Bug: 755727
Change-Id: I4c2fa83b552bd93d147a07750d9633342744c1f2
Reviewed-on: https://chromium-review.googlesource.com/770910
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516941}
[modify] https://crrev.com/27b1f0662c891e1e2af739cbbba7f16a6c7615d5/third_party/WebKit/Source/platform/exported/WebVideoFrameSubmitter.cpp
[modify] https://crrev.com/27b1f0662c891e1e2af739cbbba7f16a6c7615d5/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp
[modify] https://crrev.com/27b1f0662c891e1e2af739cbbba7f16a6c7615d5/third_party/WebKit/Source/platform/wtf/PtrUtil.h
[modify] https://crrev.com/27b1f0662c891e1e2af739cbbba7f16a6c7615d5/third_party/WebKit/Source/platform/wtf/PtrUtilTest.cpp

Owner: ----
I've finished removing WTF::make_unique.

I'm un-assigning this bug so someone can continue on removing base::make_unique.
Project Member

Comment 52 by bugdroid1@chromium.org, Dec 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8366401d71f9d2c94ce81ee4e6b1d7effda3846

commit e8366401d71f9d2c94ce81ee4e6b1d7effda3846
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Sat Dec 02 00:12:49 2017

Replace base::MakeUnique with std::make_unique in cc/

base/memory/ptr_util.h includes are changed with <memory> as well.

Bug: 755727
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: If706c2ac4d92de45ee525aa49694827903264865
Reviewed-on: https://chromium-review.googlesource.com/802847
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#521136}
[modify] https://crrev.com/e8366401d71f9d2c94ce81ee4e6b1d7effda3846/cc/animation/animation_host.cc
[modify] https://crrev.com/e8366401d71f9d2c94ce81ee4e6b1d7effda3846/cc/paint/paint_image.cc
[modify] https://crrev.com/e8366401d71f9d2c94ce81ee4e6b1d7effda3846/cc/paint/transfer_cache_entry.cc
[modify] https://crrev.com/e8366401d71f9d2c94ce81ee4e6b1d7effda3846/cc/resources/resource_provider_unittest.cc
[modify] https://crrev.com/e8366401d71f9d2c94ce81ee4e6b1d7effda3846/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/e8366401d71f9d2c94ce81ee4e6b1d7effda3846/cc/trees/image_animation_controller_unittest.cc

Project Member

Comment 53 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dae5f104382412c21657092abd0bc45b2aead2de

commit dae5f104382412c21657092abd0bc45b2aead2de
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Mon Dec 04 15:55:38 2017

Replace base::MakeUnique with std::make_unique in android_webview/

base/memory/ptr_util.h includes are changed with <memory> as well.

Bug: 755727
Change-Id: I1beb698b992a863896bd1a63c4ed3801a9a87a5a
Reviewed-on: https://chromium-review.googlesource.com/802850
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#521347}
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/android_protocol_handler.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/aw_browser_context.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/aw_browser_policy_connector.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/aw_browser_terminator.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/aw_contents.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/aw_contents_client_bridge.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/aw_contents_client_bridge_unittest.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/aw_field_trial_creator.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/aw_permission_manager.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/aw_permission_manager_unittest.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/aw_safe_browsing_blocking_page.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/aw_safe_browsing_whitelist_manager.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/aw_settings.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/browser_view_renderer.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/browser_view_renderer_unittest.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/hardware_renderer.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/java_browser_view_renderer_helper.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/net/android_stream_reader_url_request_job.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/net/aw_request_interceptor.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/net/aw_web_resource_response.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/surfaces_instance.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/test/rendering_test.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/browser/tracing/aw_tracing_delegate.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/renderer/aw_content_renderer_client.cc
[modify] https://crrev.com/dae5f104382412c21657092abd0bc45b2aead2de/android_webview/renderer/aw_render_frame_ext.cc

Project Member

Comment 54 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4e2e65212a72810646656c41e68b359c426fa0d

commit f4e2e65212a72810646656c41e68b359c426fa0d
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Wed Dec 06 17:47:08 2017

Replace base::MakeUnique with std::make_unique in content/

base/memory/ptr_util.h includes are changed with <memory> as well.

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ieb3fecb7841ff58dd8ddfee1c164ff522176da57
Reviewed-on: https://chromium-review.googlesource.com/807827
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522129}
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/accessibility/accessibility_ui.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/browser_main_loop.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/download/base_file.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/gpu/compositor_util.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/plugin_service_impl_unittest.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/quota_dispatcher_host.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/renderer_host/input/scroll_latency_browsertest.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/renderer_host/media/fake_video_capture_device_launcher.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/renderer_host/media/fake_video_capture_provider.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/renderer_host/media/render_frame_audio_output_stream_factory.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/renderer_host/media/video_capture_unittest.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/browser/webrtc/webrtc_event_log_manager_unittest.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/network/network_context.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/renderer/dom_storage/dom_storage_cached_area_unittest.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/renderer/media/gpu/rtc_video_encoder_factory.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/renderer/media/rtc_peer_connection_handler.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/shell/browser/layout_test/blink_test_controller.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/shell/browser/layout_test/layout_test_devtools_bindings.cc
[modify] https://crrev.com/f4e2e65212a72810646656c41e68b359c426fa0d/content/test/content_browser_test_utils_internal.cc

Project Member

Comment 55 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef02885827303c7090b966ebe0107f7c40550664

commit ef02885827303c7090b966ebe0107f7c40550664
Author: Lily Houghton <lilyhoughton@chromium.org>
Date: Wed Dec 06 20:52:30 2017

[Cronet] Replace base::MakeUnique with std::make_unique.

Per https://bugs.chromium.org/p/chromium/issues/detail?id=755727, as of C++14,
std::make_unique provides the same functionality as Base::MakeUnique, and is
preferred.

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iaac534f4598872f56ddad67afcfaac4318883edf
Reviewed-on: https://chromium-review.googlesource.com/806595
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522186}
[modify] https://crrev.com/ef02885827303c7090b966ebe0107f7c40550664/components/cronet/android/cert/cert_verifier_cache_serializer_unittest.cc
[modify] https://crrev.com/ef02885827303c7090b966ebe0107f7c40550664/components/cronet/android/cronet_upload_data_stream_adapter.cc
[modify] https://crrev.com/ef02885827303c7090b966ebe0107f7c40550664/components/cronet/android/cronet_url_request_context_adapter.cc
[modify] https://crrev.com/ef02885827303c7090b966ebe0107f7c40550664/components/cronet/cronet_prefs_manager.cc
[modify] https://crrev.com/ef02885827303c7090b966ebe0107f7c40550664/components/cronet/host_cache_persistence_manager_unittest.cc
[modify] https://crrev.com/ef02885827303c7090b966ebe0107f7c40550664/components/cronet/ios/Cronet.mm
[modify] https://crrev.com/ef02885827303c7090b966ebe0107f7c40550664/components/cronet/ios/cronet_environment.mm
[modify] https://crrev.com/ef02885827303c7090b966ebe0107f7c40550664/components/cronet/ios/empty.cc
[modify] https://crrev.com/ef02885827303c7090b966ebe0107f7c40550664/components/cronet/ios/test/test_server.cc
[modify] https://crrev.com/ef02885827303c7090b966ebe0107f7c40550664/components/cronet/url_request_context_config.cc
[modify] https://crrev.com/ef02885827303c7090b966ebe0107f7c40550664/components/cronet/url_request_context_config_unittest.cc

Project Member

Comment 56 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e01fe57354cc53843f6e2a3f4c7419bf4923a94

commit 0e01fe57354cc53843f6e2a3f4c7419bf4923a94
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Thu Dec 07 00:00:01 2017

Replace base::MakeUnique with std::make_unique in headless/

base/memory/ptr_util.h includes are changed with <memory> as well.

Bug: 755727
Change-Id: I12c15e3258153550cd11721b32a76519664ba3e2
Reviewed-on: https://chromium-review.googlesource.com/804612
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#522261}
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/app/headless_shell.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/app/shell_navigation_request.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/lib/browser/headless_browser_context_impl.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/lib/browser/headless_browser_impl_aura.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/lib/browser/headless_content_browser_client.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/lib/browser/headless_devtools_client_impl.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/lib/browser/headless_devtools_manager_delegate.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/lib/browser/headless_net_log.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/lib/browser/headless_print_manager.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/lib/browser/headless_printing_unittest.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/lib/browser/headless_url_request_context_getter.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/lib/browser/headless_web_contents_impl.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/lib/frame_id_browsertest.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/lib/headless_browser_browsertest.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/lib/headless_browser_context_browsertest.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/lib/headless_content_main_delegate.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/lib/headless_devtools_client_browsertest.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/lib/renderer/headless_content_renderer_client.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/public/internal/value_conversions.h
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/public/util/compositor_controller.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/public/util/compositor_controller_browsertest.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/public/util/compositor_controller_unittest.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/public/util/deterministic_dispatcher_test.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/public/util/deterministic_http_protocol_handler.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/public/util/expedited_dispatcher_test.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/public/util/generic_url_request_job_test.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/public/util/http_url_fetcher.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/public/util/testing/test_in_memory_protocol_handler.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/public/util/virtual_time_controller_test.cc
[modify] https://crrev.com/0e01fe57354cc53843f6e2a3f4c7419bf4923a94/headless/test/headless_browser_test.cc

Project Member

Comment 57 by bugdroid1@chromium.org, Dec 9 2017

Project Member

Comment 58 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cbb45ec7b493efb09388105bfd169c6b22fcdb7

commit 5cbb45ec7b493efb09388105bfd169c6b22fcdb7
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Tue Dec 12 02:19:41 2017

Replace base::MakeUnique with std::make_unique in chromeos/

base/memory/ptr_util.h includes are changed with <memory> as well.

Bug: 755727
Change-Id: I640ea7df0e4249400515c8257397ecfd237bea51
Reviewed-on: https://chromium-review.googlesource.com/818674
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523307}
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/cert_loader.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/active_host_network_state_updater_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/active_host_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/ad_hoc_ble_advertiser_impl.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/ad_hoc_ble_advertiser_impl_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/asynchronous_shutdown_object_container_impl.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/asynchronous_shutdown_object_container_impl_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/ble_advertisement_device_queue_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/ble_advertiser_impl.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/ble_advertiser_impl_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/ble_connection_manager.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/ble_connection_manager_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/ble_scanner_impl.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/ble_scanner_impl_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/ble_synchronizer.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/ble_synchronizer_base.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/ble_synchronizer_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/connect_tethering_operation.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/connect_tethering_operation_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/crash_recovery_manager_impl.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/crash_recovery_manager_impl_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/disconnect_tethering_operation.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/disconnect_tethering_operation_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/disconnect_tethering_request_sender_impl.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/disconnect_tethering_request_sender_impl_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/error_tolerant_ble_advertisement_impl.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/error_tolerant_ble_advertisement_impl_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/fake_active_host.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/host_connection_metrics_logger_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/host_scan_cache_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/host_scan_device_prioritizer_impl_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/host_scan_scheduler_impl.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/host_scan_scheduler_impl_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/host_scanner_operation.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/host_scanner_operation_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/host_scanner_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/keep_alive_operation.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/keep_alive_operation_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/keep_alive_scheduler.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/keep_alive_scheduler_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/master_host_scan_cache_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/message_transfer_operation.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/message_transfer_operation_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/message_wrapper.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/network_connection_handler_tether_delegate_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/network_host_scan_cache_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/network_list_sorter_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/notification_remover_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/persistent_host_scan_cache_impl.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/persistent_host_scan_cache_impl_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/synchronous_shutdown_object_container_impl.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/tether_component_impl.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/tether_component_impl_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/tether_connector_impl_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/tether_disconnector_impl_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/tether_host_fetcher.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/tether_host_fetcher_impl.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/tether_host_fetcher_impl_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/tether_host_response_recorder.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/tether_host_response_recorder_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/tether_network_disconnection_handler_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/timer_factory.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/wifi_hotspot_connector.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/components/tether/wifi_hotspot_disconnector_impl_unittest.cc
[modify] https://crrev.com/5cbb45ec7b493efb09388105bfd169c6b22fcdb7/chromeos/printing/ppd_provider.cc

Project Member

Comment 59 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a70a6dafcfb4cd8f727d7740d06434660449ad3d

commit a70a6dafcfb4cd8f727d7740d06434660449ad3d
Author: sebsg <sebsg@chromium.org>
Date: Fri Dec 22 14:50:08 2017

[Payments] Replace base::MakeUnique with std::make_unique.

Bug: 755727
Change-Id: I030c331a0ddff7353adaa70fb6c6f9d2bd0aaf8b
Reviewed-on: https://chromium-review.googlesource.com/841268
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525991}
[modify] https://crrev.com/a70a6dafcfb4cd8f727d7740d06434660449ad3d/chrome/browser/payments/android/payment_manifest_web_data_service_android.cc
[modify] https://crrev.com/a70a6dafcfb4cd8f727d7740d06434660449ad3d/chrome/browser/payments/payment_request_factory.cc
[modify] https://crrev.com/a70a6dafcfb4cd8f727d7740d06434660449ad3d/components/payments/content/android/payment_manifest_downloader_android.cc
[modify] https://crrev.com/a70a6dafcfb4cd8f727d7740d06434660449ad3d/components/payments/content/payment_request.cc
[modify] https://crrev.com/a70a6dafcfb4cd8f727d7740d06434660449ad3d/components/payments/content/payment_request_converter.cc
[modify] https://crrev.com/a70a6dafcfb4cd8f727d7740d06434660449ad3d/components/payments/content/payment_request_display_manager.cc
[modify] https://crrev.com/a70a6dafcfb4cd8f727d7740d06434660449ad3d/components/payments/content/payment_request_spec_unittest.cc
[modify] https://crrev.com/a70a6dafcfb4cd8f727d7740d06434660449ad3d/components/payments/content/payment_response_helper_unittest.cc
[modify] https://crrev.com/a70a6dafcfb4cd8f727d7740d06434660449ad3d/components/payments/content/service_worker_payment_instrument_unittest.cc
[modify] https://crrev.com/a70a6dafcfb4cd8f727d7740d06434660449ad3d/components/payments/core/autofill_payment_instrument_unittest.cc
[modify] https://crrev.com/a70a6dafcfb4cd8f727d7740d06434660449ad3d/components/payments/core/can_make_payment_query.cc
[modify] https://crrev.com/a70a6dafcfb4cd8f727d7740d06434660449ad3d/components/payments/core/payment_manifest_downloader.cc

Project Member

Comment 60 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ff70ab7dab0f1036437bc2b74928cb2457c4445

commit 6ff70ab7dab0f1036437bc2b74928cb2457c4445
Author: sebsg <sebsg@chromium.org>
Date: Fri Dec 22 15:34:16 2017

[Autofill] Replace base::MakeUnique with std::make_unique.

Bug: 755727
Change-Id: I09f72dd24f24b2ce7362912ac43c198b7207dcf9
Reviewed-on: https://chromium-review.googlesource.com/841285
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525994}
[modify] https://crrev.com/6ff70ab7dab0f1036437bc2b74928cb2457c4445/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/6ff70ab7dab0f1036437bc2b74928cb2457c4445/components/autofill/android/autofill_provider_android.cc
[modify] https://crrev.com/6ff70ab7dab0f1036437bc2b74928cb2457c4445/components/autofill/content/browser/content_autofill_driver.cc
[modify] https://crrev.com/6ff70ab7dab0f1036437bc2b74928cb2457c4445/components/autofill/content/browser/content_autofill_driver_factory.cc
[modify] https://crrev.com/6ff70ab7dab0f1036437bc2b74928cb2457c4445/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/6ff70ab7dab0f1036437bc2b74928cb2457c4445/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
[modify] https://crrev.com/6ff70ab7dab0f1036437bc2b74928cb2457c4445/components/autofill/core/browser/autofill_credit_card_policy_handler_unittest.cc
[modify] https://crrev.com/6ff70ab7dab0f1036437bc2b74928cb2457c4445/components/autofill/core/browser/autofill_wallet_data_type_controller_unittest.cc
[modify] https://crrev.com/6ff70ab7dab0f1036437bc2b74928cb2457c4445/components/autofill/core/browser/webdata/autofill_data_type_controller_unittest.cc
[modify] https://crrev.com/6ff70ab7dab0f1036437bc2b74928cb2457c4445/components/autofill/ios/browser/autofill_agent.mm

Project Member

Comment 61 by bugdroid1@chromium.org, Jan 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17610a4d9347c0270f92dd0e0b623d5407421668

commit 17610a4d9347c0270f92dd0e0b623d5407421668
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Mon Jan 01 14:51:40 2018

policy: Replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: I40c12783a9fdadbb693c87282b86bc11bcbcd106
Reviewed-on: https://chromium-review.googlesource.com/846582
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#526423}
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/browser/android/policy_converter.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/browser/configuration_policy_handler.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/browser/configuration_policy_handler_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/browser/configuration_policy_pref_store.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/browser/configuration_policy_pref_store_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/browser/policy_error_map.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/browser/proxy_policy_handler_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/browser/url_blacklist_manager_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/browser/url_blacklist_policy_handler_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/async_policy_provider_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/cloud_policy_client.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/cloud_policy_client_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/cloud_policy_manager_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/cloud_policy_validator.h
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/component_cloud_policy_service.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/component_cloud_policy_store.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/component_cloud_policy_store_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/component_cloud_policy_updater.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/component_cloud_policy_updater_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/external_policy_data_fetcher.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/mock_cloud_external_data_manager.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/mock_cloud_policy_client.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/policy_builder.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/policy_builder.h
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/policy_header_io_helper_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/policy_header_service.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/user_cloud_policy_manager.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/cloud/user_cloud_policy_manager_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/config_dir_policy_loader_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/configuration_policy_provider_test.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/generate_policy_source_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/mac_util.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/mac_util_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/policy_bundle.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/policy_bundle_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/policy_loader_ios_unittest.mm
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/policy_loader_mac_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/policy_loader_win_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/policy_map_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/policy_scheduler.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/policy_scheduler_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/policy_service_impl.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/policy_service_impl_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/policy_statistics_collector_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/preg_parser_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/proxy_policy_provider_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/registry_dict.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/registry_dict_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/remote_commands/test_remote_command_job.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/schema_map_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/schema_registry_tracking_policy_provider_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/core/common/schema_unittest.cc
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/tools/generate_policy_source.py
[modify] https://crrev.com/17610a4d9347c0270f92dd0e0b623d5407421668/components/policy/tools/generate_policy_source_test.py

Project Member

Comment 63 by bugdroid1@chromium.org, Jan 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84b58bdd6b422ca7c840fd001d659bf8dc4a5f7a

commit 84b58bdd6b422ca7c840fd001d659bf8dc4a5f7a
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Mon Jan 01 22:51:35 2018

prefs: Replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: I64bb34f8807685ee0bc9fe581bffee9e3f5fa031
Reviewed-on: https://chromium-review.googlesource.com/846584
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526428}
[modify] https://crrev.com/84b58bdd6b422ca7c840fd001d659bf8dc4a5f7a/components/prefs/command_line_pref_store.cc
[modify] https://crrev.com/84b58bdd6b422ca7c840fd001d659bf8dc4a5f7a/components/prefs/in_memory_pref_store_unittest.cc
[modify] https://crrev.com/84b58bdd6b422ca7c840fd001d659bf8dc4a5f7a/components/prefs/json_pref_store_unittest.cc
[modify] https://crrev.com/84b58bdd6b422ca7c840fd001d659bf8dc4a5f7a/components/prefs/overlay_user_pref_store.cc
[modify] https://crrev.com/84b58bdd6b422ca7c840fd001d659bf8dc4a5f7a/components/prefs/overlay_user_pref_store_unittest.cc
[modify] https://crrev.com/84b58bdd6b422ca7c840fd001d659bf8dc4a5f7a/components/prefs/pref_change_registrar_unittest.cc
[modify] https://crrev.com/84b58bdd6b422ca7c840fd001d659bf8dc4a5f7a/components/prefs/pref_member_unittest.cc
[modify] https://crrev.com/84b58bdd6b422ca7c840fd001d659bf8dc4a5f7a/components/prefs/pref_registry_simple.cc
[modify] https://crrev.com/84b58bdd6b422ca7c840fd001d659bf8dc4a5f7a/components/prefs/pref_service.cc
[modify] https://crrev.com/84b58bdd6b422ca7c840fd001d659bf8dc4a5f7a/components/prefs/pref_service_unittest.cc
[modify] https://crrev.com/84b58bdd6b422ca7c840fd001d659bf8dc4a5f7a/components/prefs/pref_value_map.cc
[modify] https://crrev.com/84b58bdd6b422ca7c840fd001d659bf8dc4a5f7a/components/prefs/pref_value_map_unittest.cc
[modify] https://crrev.com/84b58bdd6b422ca7c840fd001d659bf8dc4a5f7a/components/prefs/testing_pref_store.cc

Project Member

Comment 64 by bugdroid1@chromium.org, Jan 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edffb4eea692c0d8c161a327d8c6e47f635e78d8

commit edffb4eea692c0d8c161a327d8c6e47f635e78d8
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Tue Jan 02 16:48:38 2018

ntp_snippets: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//components/npt_snippets.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016

Bug: 755727
Change-Id: I7628bd96729646ee03b94835e220021b04564eb7
Reviewed-on: https://chromium-review.googlesource.com/846644
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526493}
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/bookmarks/bookmark_suggestions_provider_unittest.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/breaking_news/breaking_news_gcm_app_handler_unittest.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/breaking_news/subscription_manager_impl.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/category_rankers/click_based_category_ranker.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/category_rankers/click_based_category_ranker_unittest.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/content_suggestions_service_unittest.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/contextual/contextual_content_suggestions_service_unittest.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/contextual/contextual_json_request.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/contextual/contextual_suggestion.h
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/contextual/contextual_suggestions_fetcher_impl.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/contextual/contextual_suggestions_fetcher_impl_unittest.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/features.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider_unittest.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/reading_list/reading_list_suggestions_provider.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/reading_list/reading_list_suggestions_provider_unittest.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/remote/cached_image_fetcher_unittest.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/remote/json_request.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/remote/json_request_unittest.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/remote/remote_suggestion.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/remote/remote_suggestion.h
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/remote/remote_suggestions_database.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/remote/remote_suggestions_fetcher_impl.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/remote/remote_suggestions_fetcher_impl_unittest.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/remote/remote_suggestions_provider_impl.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/remote/remote_suggestions_scheduler_impl.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/remote/remote_suggestions_status_service_impl_unittest.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/remote/test_utils.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider_unittest.cc
[modify] https://crrev.com/edffb4eea692c0d8c161a327d8c6e47f635e78d8/components/ntp_snippets/user_classifier_unittest.cc

Project Member

Comment 65 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9a599c21b63d11163b52693e59b777d82932953

commit b9a599c21b63d11163b52693e59b777d82932953
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Wed Jan 03 13:21:34 2018

drive: Replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: Ie2f107a708ee7d4dcd90a8067aa8d43e13c410a9
Reviewed-on: https://chromium-review.googlesource.com/846646
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#526674}
[modify] https://crrev.com/b9a599c21b63d11163b52693e59b777d82932953/components/drive/change_list_processor_unittest.cc
[modify] https://crrev.com/b9a599c21b63d11163b52693e59b777d82932953/components/drive/chromeos/change_list_loader.cc
[modify] https://crrev.com/b9a599c21b63d11163b52693e59b777d82932953/components/drive/chromeos/file_system/download_operation.cc
[modify] https://crrev.com/b9a599c21b63d11163b52693e59b777d82932953/components/drive/chromeos/search_metadata.cc
[modify] https://crrev.com/b9a599c21b63d11163b52693e59b777d82932953/components/drive/file_write_watcher.cc
[modify] https://crrev.com/b9a599c21b63d11163b52693e59b777d82932953/components/drive/job_scheduler.cc
[modify] https://crrev.com/b9a599c21b63d11163b52693e59b777d82932953/components/drive/search_metadata_unittest.cc
[modify] https://crrev.com/b9a599c21b63d11163b52693e59b777d82932953/components/drive/service/drive_api_service.cc
[modify] https://crrev.com/b9a599c21b63d11163b52693e59b777d82932953/components/drive/service/drive_api_service_unittest.cc
[modify] https://crrev.com/b9a599c21b63d11163b52693e59b777d82932953/components/drive/service/fake_drive_service.cc

Project Member

Comment 66 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7818d1c19cdc6cd344758143536f64542e6ee5c

commit c7818d1c19cdc6cd344758143536f64542e6ee5c
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Wed Jan 03 13:23:56 2018

data_reduction_proxy: Replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: I561768ad3d03c177a90a1917d489abab53805973
Reviewed-on: https://chromium-review.googlesource.com/846647
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#526675}
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/content/browser/data_reduction_proxy_pingback_client_impl_unittest.cc
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer.cc
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/core/browser/warmup_url_fetcher_unittest.cc
[modify] https://crrev.com/c7818d1c19cdc6cd344758143536f64542e6ee5c/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc

Project Member

Comment 67 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7

commit 24ca9cd2ce15b7f025f0de1e5afd7723698a8be7
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Wed Jan 03 13:38:15 2018

viz: Replace base::MakeUnique with std::make_unique

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I25f46d97d5ba065edd15aeeb9fc31cc4747354ee
Reviewed-on: https://chromium-review.googlesource.com/846645
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526677}
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/client/client_layer_tree_frame_sink.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/client/client_shared_bitmap_manager.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/common/frame_sinks/delay_based_time_source_unittest.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/common/gl_helper.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/common/gl_helper_scaling.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/host/host_frame_sink_manager.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/host/host_frame_sink_manager_unittest.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/display/display.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/display/display_unittest.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/display/surface_aggregator_perftest.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/display_embedder/buffer_queue.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/display_embedder/compositor_overlay_candidate_validator_android.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/display_embedder/compositor_overlay_candidate_validator_ozone.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/display_embedder/gpu_display_provider.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/display_embedder/server_shared_bitmap_manager.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/display_embedder/server_shared_bitmap_manager_unittest.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/frame_sinks/frame_sink_manager_unittest.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/frame_sinks/surface_synchronization_unittest.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/gl/gpu_service_impl_unittest.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/hit_test/hit_test_aggregator_unittest.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/main/viz_main_impl.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/service/surfaces/surface_manager.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/test/test_layer_tree_frame_sink.cc
[modify] https://crrev.com/24ca9cd2ce15b7f025f0de1e5afd7723698a8be7/components/viz/test/viz_test_suite.cc

Project Member

Comment 68 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb9b09612d47867c7a1404fc7bf07bbb2bef04e3

commit eb9b09612d47867c7a1404fc7bf07bbb2bef04e3
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Wed Jan 03 15:49:02 2018

autofill: Replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: I5ee0dd42892933c502f2fac139ea7c1e6f46d449
Reviewed-on: https://chromium-review.googlesource.com/846601
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526702}
[modify] https://crrev.com/eb9b09612d47867c7a1404fc7bf07bbb2bef04e3/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
[modify] https://crrev.com/eb9b09612d47867c7a1404fc7bf07bbb2bef04e3/components/autofill/core/browser/autofill_policy_handler_unittest.cc

Project Member

Comment 69 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d28a78f78336695daa223cf9cfcf711fd56732b

commit 4d28a78f78336695daa223cf9cfcf711fd56732b
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Wed Jan 03 22:22:56 2018

offline_pages: Replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: I05c8894ef3016166257f2b264fe3d4a60a20648b
Reviewed-on: https://chromium-review.googlesource.com/846602
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526837}
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/content/renovations/test/page_renovator_browsertest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/background/request_coordinator.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/background/request_coordinator_stub_taco.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/background/request_coordinator_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/client_policy_controller.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/downloads/download_ui_adapter.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/downloads/download_ui_adapter_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/model/add_page_task_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/model/clear_digest_task_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/model/clear_legacy_temporary_pages_task_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/model/clear_storage_task.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/model/clear_storage_task_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/model/complete_offline_page_upgrade_task_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/model/delete_page_task_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/model/mark_page_accessed_task_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/model/offline_page_model_taskified.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/model/offline_page_model_taskified_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/model/persistent_pages_consistency_check_task_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/model/start_offline_page_upgrade_task_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/model/temporary_pages_consistency_check_task_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/offline_page_metadata_store_test_util.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/offline_page_model_impl_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/offline_page_model_query.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/offline_page_storage_manager_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/download_archives_task.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/generate_page_bundle_reconcile_task_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/generate_page_bundle_task.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/get_operation_task.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/import_archives_task.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/metrics_finalization_task_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/prefetch_dispatcher_impl.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/prefetch_dispatcher_impl_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/prefetch_download_flow_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/prefetch_downloader_impl_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/prefetch_gcm_app_handler_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/prefetch_network_request_factory_impl.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/prefetch_network_request_factory_impl_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/prefetch_request_test_base.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/prefetch_service_test_taco.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/sent_get_operation_cleanup_task.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/sent_get_operation_cleanup_task_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/stale_entry_finalizer_task_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/store/prefetch_store_schema_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/store/prefetch_store_test_util.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/suggested_articles_observer.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/suggested_articles_observer_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/task_test_base.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/prefetch/test_prefetch_dispatcher.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/recent_tabs/recent_tabs_ui_adapter_delegate.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/recent_tabs/recent_tabs_ui_adapter_delegate_unittest.cc
[modify] https://crrev.com/4d28a78f78336695daa223cf9cfcf711fd56732b/components/offline_pages/core/renovations/page_renovator_unittest.cc

Project Member

Comment 70 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa6b5750d1651fdf1e135212bf5237ad689beba6

commit fa6b5750d1651fdf1e135212bf5237ad689beba6
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Wed Jan 03 22:28:21 2018

search_engines: Replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: Id47d8d9da0a50c9eb16173f6ab6dd70adff6ec84
Reviewed-on: https://chromium-review.googlesource.com/846648
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526839}
[modify] https://crrev.com/fa6b5750d1651fdf1e135212bf5237ad689beba6/components/search_engines/default_search_manager_unittest.cc
[modify] https://crrev.com/fa6b5750d1651fdf1e135212bf5237ad689beba6/components/search_engines/default_search_policy_handler.cc
[modify] https://crrev.com/fa6b5750d1651fdf1e135212bf5237ad689beba6/components/search_engines/default_search_policy_handler_unittest.cc
[modify] https://crrev.com/fa6b5750d1651fdf1e135212bf5237ad689beba6/components/search_engines/search_engine_data_type_controller_unittest.cc
[modify] https://crrev.com/fa6b5750d1651fdf1e135212bf5237ad689beba6/components/search_engines/search_engines_test_util.cc
[modify] https://crrev.com/fa6b5750d1651fdf1e135212bf5237ad689beba6/components/search_engines/search_host_to_urls_map_unittest.cc
[modify] https://crrev.com/fa6b5750d1651fdf1e135212bf5237ad689beba6/components/search_engines/template_url.cc
[modify] https://crrev.com/fa6b5750d1651fdf1e135212bf5237ad689beba6/components/search_engines/template_url_data_util.cc
[modify] https://crrev.com/fa6b5750d1651fdf1e135212bf5237ad689beba6/components/search_engines/template_url_fetcher.cc
[modify] https://crrev.com/fa6b5750d1651fdf1e135212bf5237ad689beba6/components/search_engines/template_url_parser.cc
[modify] https://crrev.com/fa6b5750d1651fdf1e135212bf5237ad689beba6/components/search_engines/template_url_prepopulate_data_unittest.cc
[modify] https://crrev.com/fa6b5750d1651fdf1e135212bf5237ad689beba6/components/search_engines/template_url_service.cc
[modify] https://crrev.com/fa6b5750d1651fdf1e135212bf5237ad689beba6/components/search_engines/template_url_service_util_unittest.cc
[modify] https://crrev.com/fa6b5750d1651fdf1e135212bf5237ad689beba6/components/search_engines/util.cc

Project Member

Comment 71 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da4e428144b50506d1b6d80651f96102215540b9

commit da4e428144b50506d1b6d80651f96102215540b9
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Fri Jan 05 18:30:04 2018

update_client: Replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: I51a9cfe9d116cded27e81142851fda3f9c054b8e
Reviewed-on: https://chromium-review.googlesource.com/846604
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#527329}
[modify] https://crrev.com/da4e428144b50506d1b6d80651f96102215540b9/components/update_client/component.cc
[modify] https://crrev.com/da4e428144b50506d1b6d80651f96102215540b9/components/update_client/crx_downloader.cc
[modify] https://crrev.com/da4e428144b50506d1b6d80651f96102215540b9/components/update_client/ping_manager.cc
[modify] https://crrev.com/da4e428144b50506d1b6d80651f96102215540b9/components/update_client/ping_manager_unittest.cc
[modify] https://crrev.com/da4e428144b50506d1b6d80651f96102215540b9/components/update_client/protocol_builder_unittest.cc
[modify] https://crrev.com/da4e428144b50506d1b6d80651f96102215540b9/components/update_client/protocol_parser.cc
[modify] https://crrev.com/da4e428144b50506d1b6d80651f96102215540b9/components/update_client/request_sender_unittest.cc
[modify] https://crrev.com/da4e428144b50506d1b6d80651f96102215540b9/components/update_client/update_checker.cc
[modify] https://crrev.com/da4e428144b50506d1b6d80651f96102215540b9/components/update_client/update_client.cc
[modify] https://crrev.com/da4e428144b50506d1b6d80651f96102215540b9/components/update_client/update_client_unittest.cc
[modify] https://crrev.com/da4e428144b50506d1b6d80651f96102215540b9/components/update_client/update_engine.cc
[modify] https://crrev.com/da4e428144b50506d1b6d80651f96102215540b9/components/update_client/updater_state.cc

Project Member

Comment 72 by bugdroid1@chromium.org, Jan 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba94d997b79b2dda9a48d64b39a5be7e56b9541b

commit ba94d997b79b2dda9a48d64b39a5be7e56b9541b
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Sat Jan 06 02:45:59 2018

download: Replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: Id53f688a8a8547ac285379fea2337bd711487ac1
Reviewed-on: https://chromium-review.googlesource.com/846583
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#527486}
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/content/factory/download_service_factory.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/content/internal/download_driver_impl.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/content/internal/download_driver_impl_unittest.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/content/public/download_navigation_observer.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/downloader/in_progress/in_progress_cache_impl_unittest.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/internal/client_set_unittest.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/internal/controller_impl_unittest.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/internal/download_service_impl_unittest.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/internal/download_store.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/internal/download_store_unittest.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/internal/file_monitor_unittest.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/internal/model_impl.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/internal/model_impl_unittest.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/internal/navigation_monitor_impl_unittests.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/internal/proto_conversions.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/internal/proto_conversions_unittest.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/internal/scheduler/device_status_listener.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/internal/scheduler/device_status_listener_unittest.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/internal/scheduler/scheduler_impl_unittest.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/internal/test/noop_store.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/internal/test/test_device_status_listener.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/internal/test/test_store.cc
[modify] https://crrev.com/ba94d997b79b2dda9a48d64b39a5be7e56b9541b/components/download/public/test/test_download_service.cc

Project Member

Comment 73 by bugdroid1@chromium.org, Jan 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f490602978a78012563d26d873eceb3977d64fe

commit 2f490602978a78012563d26d873eceb3977d64fe
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Sat Jan 06 02:47:10 2018

feature_engagement: Replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: I010a97a565f62ccc15fc945af285ba69f8affdd8
Reviewed-on: https://chromium-review.googlesource.com/846605
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#527487}
[modify] https://crrev.com/2f490602978a78012563d26d873eceb3977d64fe/components/feature_engagement/internal/availability_model_impl_unittest.cc
[modify] https://crrev.com/2f490602978a78012563d26d873eceb3977d64fe/components/feature_engagement/internal/event_model_impl_unittest.cc
[modify] https://crrev.com/2f490602978a78012563d26d873eceb3977d64fe/components/feature_engagement/internal/in_memory_event_store.cc
[modify] https://crrev.com/2f490602978a78012563d26d873eceb3977d64fe/components/feature_engagement/internal/in_memory_event_store_unittest.cc
[modify] https://crrev.com/2f490602978a78012563d26d873eceb3977d64fe/components/feature_engagement/internal/init_aware_event_model_unittest.cc
[modify] https://crrev.com/2f490602978a78012563d26d873eceb3977d64fe/components/feature_engagement/internal/persistent_availability_store.cc
[modify] https://crrev.com/2f490602978a78012563d26d873eceb3977d64fe/components/feature_engagement/internal/persistent_availability_store_unittest.cc
[modify] https://crrev.com/2f490602978a78012563d26d873eceb3977d64fe/components/feature_engagement/internal/persistent_event_store.cc
[modify] https://crrev.com/2f490602978a78012563d26d873eceb3977d64fe/components/feature_engagement/internal/persistent_event_store_unittest.cc
[modify] https://crrev.com/2f490602978a78012563d26d873eceb3977d64fe/components/feature_engagement/internal/tracker_impl.cc
[modify] https://crrev.com/2f490602978a78012563d26d873eceb3977d64fe/components/feature_engagement/internal/tracker_impl_unittest.cc
[modify] https://crrev.com/2f490602978a78012563d26d873eceb3977d64fe/components/feature_engagement/test/test_tracker.cc

Project Member

Comment 74 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62a5de4bc81283b79edcd9e6d8edffd925f44f9f

commit 62a5de4bc81283b79edcd9e6d8edffd925f44f9f
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Wed Jan 10 09:48:42 2018

Replace base::MakeUnique with std::make_unique in media/

base/memory/ptr_util.h includes are changed to <memory> as well.

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib009e868f6b0a0856664a790461132634cc5194c
Reviewed-on: https://chromium-review.googlesource.com/848473
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528270}
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/alsa/alsa_output_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/android/audio_android_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/android/audio_manager_android.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/audio_debug_recording_helper.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/audio_debug_recording_helper_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/audio_debug_recording_manager.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/audio_debug_recording_manager_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/audio_input_controller_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/audio_input_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/audio_low_latency_input_output_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/audio_manager_base.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/audio_manager_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/audio_output_controller_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/audio_output_proxy_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/audio_output_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/cras/cras_input_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/cras/cras_unified_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/fake_audio_input_stream.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/fake_audio_log_factory.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/fuchsia/audio_manager_fuchsia.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/linux/audio_manager_linux.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/mac/audio_auhal_mac_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/mac/audio_low_latency_input_mac_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/mac/audio_manager_mac.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/sounds/audio_stream_handler_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/sounds/sounds_manager_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/test_audio_thread.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/win/audio_low_latency_input_win_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/win/audio_low_latency_output_win_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/win/audio_manager_win.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/audio/win/audio_output_win_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/android/media_drm_bridge.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/android/media_service_throttler.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/android/mock_android_overlay.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/android/mock_media_codec_bridge.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/android/test_destruction_observable.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/audio_converter_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/audio_renderer_mixer_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/bind_to_current_loop.h
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/bind_to_current_loop_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/decoder_buffer_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/fake_demuxer_stream.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/media_tracks.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/multi_channel_resampler.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/renderer_factory_selector_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/text_renderer_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/user_input_monitor_linux.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/user_input_monitor_mac.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/user_input_monitor_win.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/base/video_frame_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/blink/cdm_session_adapter.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/blink/multibuffer_data_source_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/blink/resource_multibuffer_data_provider_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/blink/url_index.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/blink/video_decode_stats_reporter_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/blink/video_frame_compositor_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/blink/watch_time_reporter_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/blink/webcontentdecryptionmodulesession_impl.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/blink/webencryptedmediaclient_impl.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/chromeos/camera_device_delegate.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/chromeos/camera_device_delegate_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/chromeos/camera_hal_delegate.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/chromeos/camera_hal_dispatcher_impl.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/chromeos/camera_hal_dispatcher_impl_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/chromeos/local_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/chromeos/mock_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/chromeos/stream_buffer_manager.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/chromeos/stream_buffer_manager_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/chromeos/video_capture_device_arc_chromeos.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/fake_video_capture_device.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/fake_video_capture_device_factory.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/fake_video_capture_device_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/linux/v4l2_capture_delegate_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/linux/video_capture_device_linux.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/video_capture_buffer_tracker_factory_impl.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/video_capture_device_client.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/video_capture_device_client_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/video_capture_device_factory.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/capture/video/video_capture_device_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/cast/logging/stats_event_subscriber.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/cast/net/cast_transport_impl_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/cast/sender/audio_sender_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/cast/sender/frame_sender.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/cast/sender/video_sender_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/cast/test/cast_benchmarks.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/cast/test/end2end_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/cast/test/receiver.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/cast/test/sender.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/cast/test/simulator.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/cast/test/utility/in_process_receiver.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/cdm/aes_decryptor.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/cdm/cdm_adapter.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/cdm/json_web_key.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/cdm/ppapi/clear_key_cdm/clear_key_persistent_session_cdm.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/cdm/simple_cdm_allocator.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/filters/chunk_demuxer.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/filters/frame_processor.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/filters/frame_processor_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/filters/source_buffer_range_by_dts.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/filters/source_buffer_range_by_pts.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/filters/source_buffer_stream.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/filters/video_frame_stream_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/formats/mp2t/mp2t_stream_parser.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/formats/mpeg/adts_stream_parser_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/formats/mpeg/mpeg1_audio_stream_parser_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/formats/webm/opus_packet_builder.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/android_video_decode_accelerator_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/android_video_surface_chooser_impl.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/android_video_surface_chooser_impl_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/avda_codec_allocator.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/avda_codec_allocator_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/codec_image_group_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/codec_image_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/codec_wrapper_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/content_video_view_overlay.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/fake_codec_allocator.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/media_codec_video_decoder.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/media_codec_video_decoder_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/promotion_hint_aggregator_impl.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/promotion_hint_aggregator_impl_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/surface_chooser_helper.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/surface_chooser_helper_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/video_frame_factory_impl.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/android/video_frame_factory_impl_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/gles2_decoder_helper.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/gpu_jpeg_decode_accelerator_factory.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/gpu_video_decode_accelerator_factory.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/jpeg_decode_accelerator_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/vaapi/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/video_decode_accelerator_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/video_encode_accelerator_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/vt_video_decode_accelerator_mac.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/gpu/windows/d3d11_video_decoder.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/midi/midi_device_android.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/midi/midi_manager_alsa.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/midi/midi_manager_mac_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/midi/midi_manager_usb.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/midi/midi_manager_win.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/midi/task_service.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/midi/task_service_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/midi/usb_midi_device_factory_android.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/clients/mojo_audio_decoder_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/clients/mojo_cdm_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/clients/mojo_decoder_factory.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/clients/mojo_media_log_service.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/clients/mojo_renderer_factory.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/clients/mojo_video_encode_accelerator.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/clients/mojo_video_encode_accelerator_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/common/media_type_converters.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/common/media_type_converters_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/common/mojo_data_pipe_read_write_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/common/mojo_decoder_buffer_converter_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/android_mojo_media_client.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/gpu_mojo_media_client.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/interface_factory_impl.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/media_metrics_provider.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/media_service_factory.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/media_service_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/mojo_audio_input_stream_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/mojo_audio_output_stream_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/mojo_cdm_allocator.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/mojo_cdm_helper.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/mojo_cdm_service.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/mojo_decryptor_service.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/mojo_media_drm_storage.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/mojo_video_decoder_service.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/mojo_video_encode_accelerator_provider.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/mojo_video_encode_accelerator_service.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/mojo_video_encode_accelerator_service_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/services/test_mojo_media_client.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/mojo/test/mojo_video_encode_accelerator_integration_test.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/muxers/webm_muxer.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/muxers/webm_muxer_fuzzertest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/muxers/webm_muxer_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/remoting/courier_renderer_factory.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/remoting/courier_renderer_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/remoting/end2end_test_renderer.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/remoting/fake_remoter.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/remoting/integration_test.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/remoting/remoting_cdm_factory.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/remoting/renderer_controller_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/renderers/audio_renderer_impl.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/renderers/audio_renderer_impl_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/renderers/default_renderer_factory.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/test/pipeline_integration_test.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/test/pipeline_integration_test_base.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/video/h264_parser_unittest.cc
[modify] https://crrev.com/62a5de4bc81283b79edcd9e6d8edffd925f44f9f/media/video/mock_gpu_video_accelerator_factories.cc

Project Member

Comment 75 by bugdroid1@chromium.org, Jan 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f8b7a56a3dc78891f604f9e7796465e7f4807bf

commit 4f8b7a56a3dc78891f604f9e7796465e7f4807bf
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Sat Jan 13 00:06:05 2018

Replace base::MakeUnique with std::make_unique in storage/

If file doesn't use base::WrapUnique, base/memory/ptr_util.h includes
are changed to <memory>.

Bug: 755727
Change-Id: I20f40d246d2ce380a0a1f074d0ca3f4c036d9f84
Reviewed-on: https://chromium-review.googlesource.com/863343
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529113}
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/blob/blob_flattener_unittest.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/blob/blob_impl.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/blob/blob_impl_unittest.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/blob/blob_memory_controller.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/blob/blob_registry_impl.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/blob/blob_registry_impl_unittest.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/blob/blob_storage_context.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/blob/blob_storage_context_unittest.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/blob/blob_storage_registry.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/blob/blob_transport_strategy.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/blob/blob_transport_strategy_unittest.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/fileapi/copy_or_move_operation_delegate.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/fileapi/dragged_file_util_unittest.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/fileapi/external_mount_points.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/fileapi/file_system_dir_url_request_job_unittest.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/fileapi/file_system_url_request_job_unittest.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/fileapi/file_system_usage_cache.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/fileapi/isolated_context.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/fileapi/isolated_file_system_backend.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/fileapi/local_file_util.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/fileapi/native_file_util.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/fileapi/obfuscated_file_util.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/fileapi/transient_file_util_unittest.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/quota/storage_monitor.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/quota/usage_tracker.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/test/mock_blob_url_request_context.cc
[modify] https://crrev.com/4f8b7a56a3dc78891f604f9e7796465e7f4807bf/storage/browser/test/test_file_system_context.cc

Project Member

Comment 76 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2

commit 7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Mon Jan 15 14:36:07 2018

webui: Replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: Ie2c4b3c79312b6963411f92b201bd6e6514dfcbe
Reviewed-on: https://chromium-review.googlesource.com/866621
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#529275}
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/app_launcher_page_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/app_list/start_page_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/browsing_history_handler_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/certificate_viewer_webui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/certificates_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/certificate_manager_dialog_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/cryptohome_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/emulator/device_emulator_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/first_run/first_run_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui_browsertest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/login/active_directory_password_change_screen_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/login/arc_kiosk_splash_screen_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/login/base_webui_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/login/l10n_util.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/login/l10n_util_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/network_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/power_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/set_time_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/slow_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/chromeos/sys_internals/sys_internals_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/components_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/conflicts_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/constrained_web_dialog_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/cookies_tree_model_util.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/crashes_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/device_log_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/extensions/extension_icon_source.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/extensions/extensions_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/flags_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/flash_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/gcm_internals_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/identity_internals_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/inspect_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/invalidations_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/local_discovery/local_discovery_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/local_state/local_state_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/md_history_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/media/media_engagement_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/media/webrtc_logs_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/media_router/media_router_file_dialog.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/media_router/media_router_file_dialog_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/media_router/media_router_web_ui_test.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/media_router/query_result_manager.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/memory_internals_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/module_database_conflicts_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/nacl_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/net_export_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/ntp/app_icon_webui_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/ntp/new_tab_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/offline/offline_internals_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/physical_web/physical_web_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/policy_tool_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/policy_tool_ui_browsertest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/policy_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/policy_ui_browsertest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/predictors/predictors_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/predictors/predictors_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/print_preview/extension_printer_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/print_preview/pdf_printer_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/print_preview/pdf_printer_handler_win_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/print_preview/printer_capabilities.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/print_preview/printer_capabilities_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/print_preview/printer_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/print_preview/privet_printer_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/print_preview/sticky_settings.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/profile_helper.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/profile_helper_browsertest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/quota_internals/quota_internals_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/about_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/chromeos/device_power_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/chromeos/device_power_handler_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/chromeos/device_stylus_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/chromeos/fingerprint_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/metrics_reporting_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/people_handler_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/profile_info_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/protocol_handlers_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/search_engines_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/signin/inline_login_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/signin/md_user_manager_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/signin/signin_error_handler_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/signin/signin_error_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/signin/sync_confirmation_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/signin_internals_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/site_settings_helper_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/snippets_internals_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/supervised_user_internals_message_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/supervised_user_internals_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/sync_internals_message_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/sync_internals_message_handler_unittest.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/sync_internals_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/system_info_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/task_scheduler_internals/task_scheduler_internals_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/user_actions/user_actions_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/version_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/webapks_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/welcome_ui.cc
[modify] https://crrev.com/7ab7a4e7644eebdae66084611e1ea1a6f9ee0cf2/chrome/browser/ui/webui/welcome_win10_ui.cc

Project Member

Comment 78 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5378d2149c94364010ef75ee94daec77735fa152

commit 5378d2149c94364010ef75ee94daec77735fa152
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Mon Jan 15 16:30:17 2018

subresource_filter: Replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: I2d8ed4d24fd21f9f4a410b4e9794239360e9e068
Reviewed-on: https://chromium-review.googlesource.com/866352
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#529293}
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle_unittest.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/content/browser/content_ruleset_service.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle_unittest.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/content/browser/subresource_filter_safe_browsing_client.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/content/renderer/subresource_filter_agent.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/content/renderer/web_document_subresource_filter_impl.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/core/browser/ruleset_service_unittest.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/core/browser/subresource_filter_features.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/core/common/activation_state.cc
[modify] https://crrev.com/5378d2149c94364010ef75ee94daec77735fa152/components/subresource_filter/core/common/test_ruleset_creator.cc

Project Member

Comment 79 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426

commit 7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Mon Jan 15 18:04:12 2018

android: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//chrome/browser/android.

This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Change-Id: I216f1a4180be7604d91132cedf48eb9c015074a7
Reviewed-on: https://chromium-review.googlesource.com/867172
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#529310}
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/background_tab_manager.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/bookmarks/bookmark_bridge.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/bookmarks/partner_bookmarks_reader.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/bookmarks/partner_bookmarks_shim.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/bookmarks/partner_bookmarks_shim_unittest.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/bottombar/overlay_panel_content.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/compositor/layer_title_cache.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/compositor/resources/toolbar_resource.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/compositor/tab_content_manager.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/contextualsearch/contextual_search_delegate_unittest.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/contextualsearch/contextual_search_manager.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/customtabs/origin_verifier.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/data_usage/data_use_matcher.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/devtools_manager_delegate_android.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/download/download_controller.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/history/browsing_history_bridge.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/history_report/data_observer_unittest.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/history_report/delta_file_backend_leveldb.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/instantapps/instant_apps_infobar_delegate.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/logo_bridge.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/net/external_estimate_provider_android_unittest.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/ntp/content_suggestions_notifier_service_unittest.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/ntp/most_visited_sites_bridge.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/photo_picker_sandbox_bridge.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/physical_web/physical_web_data_source_android.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/physical_web/physical_web_data_source_android_unittest.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/search_permissions/search_geolocation_disclosure_infobar_delegate.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/search_permissions/search_permissions_service_unittest.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/service_tab_launcher.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/usb/web_usb_chooser_service_android.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/vr_shell/autocomplete_controller.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/vr_shell/mailbox_to_surface_bridge.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/vr_shell/vr_controller.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/vr_shell/vr_usage_monitor.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/webapk/webapk_install_service.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/webapk/webapk_installer.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/webapk/webapk_installer_unittest.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/webapps/add_to_homescreen_manager.cc
[modify] https://crrev.com/7fa90e87f01ef9f6b0fc141c5fe5d66516d6d426/chrome/browser/android/widget/thumbnail_generator.cc

Project Member

Comment 80 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6bfaaa7154655078e4adf098a854f3e31de5bd8

commit a6bfaaa7154655078e4adf098a854f3e31de5bd8
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Mon Jan 15 18:04:42 2018

vr: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//chrome/browser/vr.

This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I712d777c4675a9a0462a477df07fc85eaeef15f1
Reviewed-on: https://chromium-review.googlesource.com/867131
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529311}
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/assets_loader.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/content_input_delegate.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/controller_mesh.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/databinding/binding.h
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/databinding/vector_binding.h
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/databinding/vector_binding_unittest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/audio_permission_prompt.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/button.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/disc_button.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/exit_prompt.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/linear_layout_unittest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/rect_unittest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/repositioner_unittest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/scaled_depth_adjuster_unittest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/shadow_unittest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/spinner.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/spinner_unittest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/text.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/text_input.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/text_unittest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/throbber_unittest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/toast.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/transient_element_unittest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/ui_element_iterator_unittest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/ui_element_unittest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/url_bar.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/vector_icon.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/vector_icon_unittest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/viewport_aware_root_unittest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/elements/webvr_url_toast.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/gltf_parser.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/speech_recognizer.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/test/ui_pixel_test.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/test/ui_test.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/test/vr_test_suite.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/testapp/test_keyboard_delegate.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/testapp/vr_testapp.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/text_input_unittest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/text_perftest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/toolbar_helper.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/ui.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/ui_element_renderer.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/ui_input_manager_unittest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/ui_scene.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/ui_scene_unittest.cc
[modify] https://crrev.com/a6bfaaa7154655078e4adf098a854f3e31de5bd8/chrome/browser/vr/ui_unittest.cc

Project Member

Comment 81 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c79a2d7c819edb1769b86b52c07bae4b61feb18

commit 4c79a2d7c819edb1769b86b52c07bae4b61feb18
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Mon Jan 15 23:42:12 2018

safe_browsing: Replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: I020529ed6e6ca825c95d0fc9349c2999e22134f2
Reviewed-on: https://chromium-review.googlesource.com/866410
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#529345}
[modify] https://crrev.com/4c79a2d7c819edb1769b86b52c07bae4b61feb18/components/safe_browsing/base_blocking_page.cc
[modify] https://crrev.com/4c79a2d7c819edb1769b86b52c07bae4b61feb18/components/safe_browsing/browser/browser_url_loader_throttle.cc
[modify] https://crrev.com/4c79a2d7c819edb1769b86b52c07bae4b61feb18/components/safe_browsing/browser/mojo_safe_browsing_impl.cc
[modify] https://crrev.com/4c79a2d7c819edb1769b86b52c07bae4b61feb18/components/safe_browsing/db/v4_database.cc
[modify] https://crrev.com/4c79a2d7c819edb1769b86b52c07bae4b61feb18/components/safe_browsing/db/v4_database_unittest.cc
[modify] https://crrev.com/4c79a2d7c819edb1769b86b52c07bae4b61feb18/components/safe_browsing/db/v4_local_database_manager.cc
[modify] https://crrev.com/4c79a2d7c819edb1769b86b52c07bae4b61feb18/components/safe_browsing/db/v4_local_database_manager_unittest.cc
[modify] https://crrev.com/4c79a2d7c819edb1769b86b52c07bae4b61feb18/components/safe_browsing/db/v4_store.cc
[modify] https://crrev.com/4c79a2d7c819edb1769b86b52c07bae4b61feb18/components/safe_browsing/db/v4_test_util.cc
[modify] https://crrev.com/4c79a2d7c819edb1769b86b52c07bae4b61feb18/components/safe_browsing/db/v4_update_protocol_manager_unittest.cc
[modify] https://crrev.com/4c79a2d7c819edb1769b86b52c07bae4b61feb18/components/safe_browsing/db/whitelist_checker_client.cc
[modify] https://crrev.com/4c79a2d7c819edb1769b86b52c07bae4b61feb18/components/safe_browsing/db/whitelist_checker_client_unittest.cc
[modify] https://crrev.com/4c79a2d7c819edb1769b86b52c07bae4b61feb18/components/safe_browsing/password_protection/password_protection_request.cc
[modify] https://crrev.com/4c79a2d7c819edb1769b86b52c07bae4b61feb18/components/safe_browsing/password_protection/password_protection_service.cc
[modify] https://crrev.com/4c79a2d7c819edb1769b86b52c07bae4b61feb18/components/safe_browsing/password_protection/password_protection_service_unittest.cc
[modify] https://crrev.com/4c79a2d7c819edb1769b86b52c07bae4b61feb18/components/safe_browsing/renderer/websocket_sb_handshake_throttle_unittest.cc
[modify] https://crrev.com/4c79a2d7c819edb1769b86b52c07bae4b61feb18/components/safe_browsing/web_ui/safe_browsing_ui.cc

Project Member

Comment 82 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3

commit 2a49191b1a9604e0da6462a8d31c7aa4ced21dc3
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Tue Jan 16 07:21:30 2018

policy: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//chrome/browser/policy.

This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Change-Id: I1567501b253c7df6f549dbcc51b4711b1ec9b8a8
Reviewed-on: https://chromium-review.googlesource.com/867175
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#529372}
[modify] https://crrev.com/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3/chrome/browser/policy/chrome_browser_policy_connector.cc
[modify] https://crrev.com/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
[modify] https://crrev.com/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3/chrome/browser/policy/cloud/policy_header_service_factory.cc
[modify] https://crrev.com/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3/chrome/browser/policy/cloud/user_policy_signin_service.cc
[modify] https://crrev.com/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3/chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc
[modify] https://crrev.com/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3/chrome/browser/policy/javascript_policy_handler_unittest.cc
[modify] https://crrev.com/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3/chrome/browser/policy/local_sync_policy_handler.cc
[modify] https://crrev.com/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3/chrome/browser/policy/local_sync_policy_handler_unittest.cc
[modify] https://crrev.com/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3/chrome/browser/policy/managed_bookmarks_policy_handler_unittest.cc
[modify] https://crrev.com/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3/chrome/browser/policy/policy_network_browsertest.cc
[modify] https://crrev.com/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3/chrome/browser/policy/policy_prefs_browsertest.cc
[modify] https://crrev.com/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3/chrome/browser/policy/policy_startup_browsertest.cc
[modify] https://crrev.com/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3/chrome/browser/policy/profile_policy_connector_unittest.cc
[modify] https://crrev.com/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3/chrome/browser/policy/site_isolation_policy_browsertest.cc
[modify] https://crrev.com/2a49191b1a9604e0da6462a8d31c7aa4ced21dc3/chrome/browser/policy/test/local_policy_test_server.cc

Project Member

Comment 83 by bugdroid1@chromium.org, Jan 16 2018

Project Member

Comment 84 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/761b7a15d024efbd1502d2e9a1df79a0636dc82f

commit 761b7a15d024efbd1502d2e9a1df79a0636dc82f
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Tue Jan 16 10:36:12 2018

signin: Replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: Idb885d732fe2ee5512c1f58dfe2c763935d17d96
Reviewed-on: https://chromium-review.googlesource.com/866271
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#529395}
[modify] https://crrev.com/761b7a15d024efbd1502d2e9a1df79a0636dc82f/components/signin/core/browser/about_signin_internals.cc
[modify] https://crrev.com/761b7a15d024efbd1502d2e9a1df79a0636dc82f/components/signin/core/browser/account_fetcher_service.cc
[modify] https://crrev.com/761b7a15d024efbd1502d2e9a1df79a0636dc82f/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/761b7a15d024efbd1502d2e9a1df79a0636dc82f/components/signin/core/browser/child_account_info_fetcher.cc
[modify] https://crrev.com/761b7a15d024efbd1502d2e9a1df79a0636dc82f/components/signin/core/browser/child_account_info_fetcher_android.cc
[modify] https://crrev.com/761b7a15d024efbd1502d2e9a1df79a0636dc82f/components/signin/core/browser/fake_profile_oauth2_token_service.cc
[modify] https://crrev.com/761b7a15d024efbd1502d2e9a1df79a0636dc82f/components/signin/core/browser/gaia_cookie_manager_service.cc
[modify] https://crrev.com/761b7a15d024efbd1502d2e9a1df79a0636dc82f/components/signin/core/browser/profile_management_switches.cc
[modify] https://crrev.com/761b7a15d024efbd1502d2e9a1df79a0636dc82f/components/signin/core/browser/signin_manager_base.cc
[modify] https://crrev.com/761b7a15d024efbd1502d2e9a1df79a0636dc82f/components/signin/core/browser/signin_manager_unittest.cc
[modify] https://crrev.com/761b7a15d024efbd1502d2e9a1df79a0636dc82f/components/signin/core/browser/test_signin_client.cc
[modify] https://crrev.com/761b7a15d024efbd1502d2e9a1df79a0636dc82f/components/signin/core/browser/webdata/token_web_data.cc

Project Member

Comment 86 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/befb1c2f66dc8422fe459692be252302f96ffa46

commit befb1c2f66dc8422fe459692be252302f96ffa46
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Tue Jan 16 18:40:10 2018

bookmarks: Replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: I6b7cadd94dc979439079ad543145ef46057020c7
Reviewed-on: https://chromium-review.googlesource.com/866473
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#529468}
[modify] https://crrev.com/befb1c2f66dc8422fe459692be252302f96ffa46/components/bookmarks/browser/bookmark_codec.cc
[modify] https://crrev.com/befb1c2f66dc8422fe459692be252302f96ffa46/components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc
[modify] https://crrev.com/befb1c2f66dc8422fe459692be252302f96ffa46/components/bookmarks/browser/bookmark_index_unittest.cc
[modify] https://crrev.com/befb1c2f66dc8422fe459692be252302f96ffa46/components/bookmarks/browser/bookmark_model.cc
[modify] https://crrev.com/befb1c2f66dc8422fe459692be252302f96ffa46/components/bookmarks/browser/bookmark_model_unittest.cc
[modify] https://crrev.com/befb1c2f66dc8422fe459692be252302f96ffa46/components/bookmarks/browser/bookmark_node.h
[modify] https://crrev.com/befb1c2f66dc8422fe459692be252302f96ffa46/components/bookmarks/browser/bookmark_utils.cc
[modify] https://crrev.com/befb1c2f66dc8422fe459692be252302f96ffa46/components/bookmarks/browser/bookmark_utils_unittest.cc
[modify] https://crrev.com/befb1c2f66dc8422fe459692be252302f96ffa46/components/bookmarks/managed/managed_bookmark_service.cc
[modify] https://crrev.com/befb1c2f66dc8422fe459692be252302f96ffa46/components/bookmarks/managed/managed_bookmarks_tracker.cc
[modify] https://crrev.com/befb1c2f66dc8422fe459692be252302f96ffa46/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc

Project Member

Comment 87 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26d6ad1930e4fe0cc084cea8c61af5bd13934809

commit 26d6ad1930e4fe0cc084cea8c61af5bd13934809
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Wed Jan 17 04:19:07 2018

previews: Replace base::MakeUnique with std::make_unique

Bug: 755727
Change-Id: I65e54d29210d9f19b2decdfa3fd92640392df7b8
Reviewed-on: https://chromium-review.googlesource.com/866470
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#529600}
[modify] https://crrev.com/26d6ad1930e4fe0cc084cea8c61af5bd13934809/components/previews/content/previews_io_data_unittest.cc
[modify] https://crrev.com/26d6ad1930e4fe0cc084cea8c61af5bd13934809/components/previews/content/previews_ui_service_unittest.cc
[modify] https://crrev.com/26d6ad1930e4fe0cc084cea8c61af5bd13934809/components/previews/core/previews_amp_converter.cc
[modify] https://crrev.com/26d6ad1930e4fe0cc084cea8c61af5bd13934809/components/previews/core/previews_black_list.cc
[modify] https://crrev.com/26d6ad1930e4fe0cc084cea8c61af5bd13934809/components/previews/core/previews_black_list_unittest.cc
[modify] https://crrev.com/26d6ad1930e4fe0cc084cea8c61af5bd13934809/components/previews/core/previews_experiments_unittest.cc
[modify] https://crrev.com/26d6ad1930e4fe0cc084cea8c61af5bd13934809/components/previews/core/previews_logger_unittest.cc
[modify] https://crrev.com/26d6ad1930e4fe0cc084cea8c61af5bd13934809/components/previews/core/previews_opt_out_store_sql.cc
[modify] https://crrev.com/26d6ad1930e4fe0cc084cea8c61af5bd13934809/components/previews/core/previews_opt_out_store_sql_unittest.cc

Project Member

Comment 88 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5216cec25a8efa22418c5c9526eb2d4695d125f

commit b5216cec25a8efa22418c5c9526eb2d4695d125f
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Wed Jan 17 19:43:11 2018

extensions: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//chrome/browser/extensions.

This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Change-Id: Iad81c59fef2a7b92eb6d27fb891bc8c19643d32d
Reviewed-on: https://chromium-review.googlesource.com/867171
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#529852}
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/active_tab_apitest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/active_tab_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/activity_log/activity_log.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/autofill_private/autofill_util.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/automation_internal/automation_event_router.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/chrome_extensions_api_client.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/commands/command_service.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/commands/command_service_browsertest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/content_settings/content_settings_store.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/content_settings/content_settings_store_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/cookies/cookies_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/cookies/cookies_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/debugger/debugger_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/declarative_content/content_action.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/developer_private/developer_private_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/device_permissions_manager_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/dial/dial_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_connection_manager.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/extension_action/extension_action_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/file_system/chrome_file_system_delegate.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/font_settings/font_settings_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/gcm/gcm_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/history/history_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/identity/identity_apitest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/identity/identity_get_auth_token_function.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/identity/identity_launch_web_auth_flow_function.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/identity/web_auth_flow.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/image_writer_private/unzip_helper.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/input_ime/input_ime_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/instance_id/instance_id_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/management/management_api_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/mdns/mdns_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/mdns/mdns_api_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/mdns/mdns_apitest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/messaging/chrome_messaging_delegate.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/module/module.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/music_manager_private/music_manager_private_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/networking_cast_private/networking_cast_private_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/networking_cast_private/networking_cast_private_apitest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/networking_private/networking_private_service_client_apitest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/networking_private/networking_private_ui_delegate_factory_impl.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/notifications/notifications_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/notifications/notifications_apitest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/permissions/permissions_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/permissions/permissions_api_helpers.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/preference/preference_helpers.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/proxy/proxy_api_helpers.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/sessions/sessions_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/sessions/sessions_apitest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/settings_overrides/settings_overrides_browsertest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/settings_private/settings_private_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/settings_private/settings_private_delegate.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/socket/combined_socket_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/socket/socket_api_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_api_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/storage/settings_sync_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/storage/sync_storage_backend.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/storage/syncable_settings_storage.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/system_private/system_private_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/tabs/app_window_controller.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/tabs/tabs_event_router.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/tabs/windows_event_router.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/terminal/terminal_private_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/bookmark_app_helper_browsertest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/chrome_app_icon.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/chrome_app_icon_service.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/chrome_app_sorting.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/chrome_app_sorting_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/chrome_content_verifier_delegate.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/chrome_extensions_browser_client.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/content_verifier_browsertest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/convert_user_script.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/convert_web_app.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/convert_web_app_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/crx_installer.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/crx_installer_browsertest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/default_apps.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/error_console/error_console.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/event_router_forwarder.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_action_manager.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_action_runner.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_action_runner_browsertest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_action_test_util.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_action_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_assets_manager_chromeos.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_context_menu_model_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_disabled_ui.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_garbage_collector_factory.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_icon_manager_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_install_prompt.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_install_prompt_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_keybinding_registry.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_management.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_management_test_util.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_management_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_message_bubble_controller.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_messages_apitest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_migrator_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_navigation_throttle_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_override_apitest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_protocols_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_reenabler.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_service_sync_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_special_storage_policy.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_special_storage_policy_unittest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_storage_monitor.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_storage_monitor_browsertest.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_system_impl.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_tab_util.cc
[modify] https://crrev.com/b5216cec25a8efa22418c5c9526eb2d4695d125f/chrome/browser/extensions/extension_tab_util_unittest.cc
[modify] https://crre
Project Member

Comment 89 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/341ce5b0c2f8b083585f203bbf66c4a8f0658359

commit 341ce5b0c2f8b083585f203bbf66c4a8f0658359
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Wed Jan 17 22:46:03 2018

chromeos: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//chrome/browser/chromeos.

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Change-Id: If5b12bd4167727804e6340eac8c20b7f09753411
Reviewed-on: https://chromium-review.googlesource.com/867130
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#529934}
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/accessibility/spoken_feedback_event_rewriter_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_manager.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/app_mode/kiosk_app_data_base.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/app_mode/kiosk_session_plugin_handler.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/certificate_provider/thread_safe_certificate_map.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/dbus/chrome_display_power_service_provider_delegate.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/display/display_prefs_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/display/output_protection_delegate.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/drive/download_handler.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/events/event_rewriter_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/action_handlers/action_handlers_apitest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/dictionary_event_router.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/external_cache_impl_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/file_manager/event_router.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/file_manager/job_event_router.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/ime_menu_event_router.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/info_private_api.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/info_private_apitest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/input_method_api.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/input_method_event_router.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/public_session_permission_helper.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/signin_screen_policy_provider.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/users_private/users_private_api.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_manager/file_browser_handlers.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_manager/file_tasks.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_manager/file_tasks_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_manager/url_util.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_system_provider/operations/get_actions_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_system_provider/operations/get_metadata_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_system_provider/operations/operation.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_system_provider/provided_file_system.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_system_provider/registry_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_system_provider/request_manager.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_system_provider/request_manager_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_system_provider/service.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/file_system_provider/throttled_file_system_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/fileapi/file_system_backend.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/fileapi/recent_arc_media_source.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/fileapi/recent_arc_media_source_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/fileapi/recent_download_source_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/fileapi/recent_model.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/fileapi/recent_model_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/input_method/mock_input_method_manager_impl.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/launcher_search_provider/launcher_search_provider_service.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/lock_screen_apps/app_manager_impl.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/lock_screen_apps/app_manager_impl_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/lock_screen_apps/lock_screen_profile_creator_impl_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/lock_screen_apps/note_taking_browsertest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/lock_screen_apps/state_controller.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/lock_screen_apps/state_controller_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/active_directory_login_browsertest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/app_launch_signin_screen.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/arc_kiosk_controller.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/helper.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/kiosk_browsertest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/profile_auth_data_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/quick_unlock/fingerprint_storage_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/quick_unlock/pin_storage_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/quick_unlock/quick_unlock_storage.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/quick_unlock/quick_unlock_storage_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/saml/saml_browsertest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/screens/user_image_screen.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/screens/user_selection_screen_browsertest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/session/chrome_session_manager_browsertest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/signin/oauth2_browsertest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/signin_partition_manager_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/ui/preloaded_web_view.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/users/default_user_image/default_user_images.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/mobile_config.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/net/network_pref_state_observer_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/net/network_throttling_observer_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/night_light/night_light_client.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/night_light/night_light_client_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/note_taking_helper.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/note_taking_helper_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/options/vpn_config_view.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/options/wifi_config_view.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/platform_keys/key_permissions.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/platform_keys/platform_keys_service.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/platform_keys/platform_keys_service_factory.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/active_directory_policy_manager.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/active_directory_policy_manager_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/affiliated_invalidation_service_provider_impl.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/affiliated_invalidation_service_provider_impl_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/affiliation_test_helper.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/auto_enrollment_client.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/auto_enrollment_client_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/blocking_login_browsertest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/cached_policy_key_loader_chromeos_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/cloud_external_data_manager_base.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/cloud_external_data_policy_observer_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/device_cloud_policy_initializer_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/device_local_account_external_data_manager.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/device_local_account_policy_provider.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/device_local_account_policy_service.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/device_local_account_policy_store.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/dm_token_storage_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/extension_cache_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/fake_device_cloud_policy_initializer.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/off_hours/device_off_hours_controller.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/off_hours/device_off_hours_controller_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/off_hours/off_hours_interval.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/off_hours/off_hours_policy_applier.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/off_hours/off_hours_proto_parser.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/off_hours/off_hours_proto_parser_unittest.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/off_hours/time_utils.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/off_hours/weekly_time.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/policy_cert_verifier.cc
[modify] https://crrev.com/341ce5b0c2f8b083585f203bbf66c4a8f0658359/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.cc
[modify] https://crre
Project Member

Comment 90 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc280793e5fbbca12e3af2531f3c1d29e5eb0738

commit cc280793e5fbbca12e3af2531f3c1d29e5eb0738
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Wed Jan 17 23:33:55 2018

ui: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//chrome/browser/ui.

This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Change-Id: I24c3bf337dcff38ce271bef336075e3fcca9ce16
Reviewed-on: https://chromium-review.googlesource.com/870530
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529947}
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/android/content_settings/ads_blocked_infobar_delegate.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/android/infobars/autofill_save_card_infobar.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/android/infobars/confirm_infobar.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/android/infobars/data_reduction_promo_infobar.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/android/infobars/generated_password_saved_infobar.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/android/infobars/previews_infobar.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/android/infobars/reader_mode_infobar.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/android/infobars/simple_confirm_infobar_builder.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/android/infobars/survey_infobar.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/android/infobars/translate_compact_infobar.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/app_list_syncable_service.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/app_list_syncable_service_factory.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/app_list_syncable_service_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/arc/arc_app_icon.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/arc/arc_app_model_builder.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/arc/arc_app_test.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/arc/arc_pai_starter.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/extension_app_model_builder.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/search/answer_card/answer_card_result.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/search/answer_card/answer_card_result_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/search/answer_card/answer_card_search_provider_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/search/answer_card/answer_card_web_contents.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/search/app_search_provider.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/search/arc/arc_playstore_search_result.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/search/arc_app_result.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/search/common/webservice_cache.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/search/extension_app_result.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/search/history_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/search/omnibox_provider.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/search/webstore/webstore_provider.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/app_list/search/webstore/webstore_result.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/apps/chrome_app_window_client.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/app_list/app_list_service_ash.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/ash_shell_init.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/ash_util.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/cast_config_client_media_router.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/chrome_keyboard_ui.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/chrome_launcher_prefs.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/ime_controller_client_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/launcher/browser_status_monitor.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/launcher/chrome_launcher_controller_test_util.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/launcher/settings_window_observer.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/network/tether_notification_presenter.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/network/tether_notification_presenter_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/session_controller_client.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/sort_windows_by_z_index.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ash/window_positioner_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/ask_google_for_suggestions_dialog_browsertest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/blocked_content/popup_opener_tab_helper.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/blocked_content/popup_opener_tab_helper_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/blocked_content/popup_tracker.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/blocked_content/scoped_visibility_tracker_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/blocked_content/tab_under_navigation_throttle.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/browser_instant_controller.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/browser_instant_controller_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/browser_live_tab_context.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/browser_window_state.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/chrome_pages.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/chrome_select_file_policy_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/animated_icon.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/autofill/simple_grid_layout.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/browser_dialogs_views_mac.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac_unittest.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/permission_bubble/chooser_bubble_ui_views_mac.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_interactive_uitest.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_views_cocoa_browsertest.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/permission_bubble/permission_prompt_impl_views_mac.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller_browsertest.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/status_icons/status_tray_mac.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/cocoa/toolbar/app_toolbar_button_unittest.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_bubble_controller_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_util_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/extensions/extension_enable_flow.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/extensions/extension_installed_bubble_browsertest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/extensions/extension_message_bubble_bridge.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/extensions/extension_message_bubble_bridge_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/fast_unload_controller.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/global_error/global_error_browsertest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/libgtkui/gtk_ui.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/libgtkui/select_file_dialog_impl_kde.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/location_bar/location_bar.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/location_bar/location_bar_browsertest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/omnibox/omnibox_controller_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/overlay/overlay_surface_embedder.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/page_info/page_info.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/page_info/page_info_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/passwords/manage_passwords_state.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/passwords/password_dialog_controller_impl_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/passwords/password_manager_presenter.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/search/instant_test_base.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/search/local_ntp_doodle_browsertest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/search/local_ntp_one_google_bar_browsertest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/search/new_tab_page_interceptor_browsertest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/search/search_ipc_router_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/search/search_tab_helper.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/search/search_tab_helper_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/search_engines/search_engine_tab_helper.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/search_engines/template_url_table_model.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/tabs/pinned_tab_service_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/tabs/tab_strip_model.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/tabs/tab_strip_model_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/tabs/web_contents_closer.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/toolbar/app_menu_model.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/toolbar/component_toolbar_actions_browsertest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/toolbar/media_router_action.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/toolbar/media_router_action_controller_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/toolbar/mock_component_toolbar_actions_factory.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/toolbar/test_toolbar_actions_bar_bubble_delegate.h
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/toolbar/toolbar_actions_model.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_browsertest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/apps/shaped_app_window_targeter.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/autofill/autofill_popup_view_native_views_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/certificate_selector_browsertest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/certificate_selector_dialog_browsertest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/chrome_cleaner_dialog_browsertest_win.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/collected_cookies_views.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/content_setting_bubble_contents.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_browsertest.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_bubble_view.cc
[modify] https://crrev.com/cc280793e5fbbca12e3af2531f3c1d29e5eb0738/chrome/browser/ui/views/desktop_ios_promotion/desktop_ios_promotion_footnote_view.cc
[modify] https://crrev.com/cc2807
Project Member

Comment 91 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e86b81637de48a75fe5476dac6b6680c575523d

commit 6e86b81637de48a75fe5476dac6b6680c575523d
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Thu Jan 18 17:45:02 2018

page_load_metrics: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//chrome/browser/page_load_metrics.

This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Change-Id: I7697f39bf56c13e8859dca5547e20328ae55f748
Reviewed-on: https://chromium-review.googlesource.com/873252
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#530188}
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/experiments/delay_navigation_throttle.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/experiments/delay_navigation_throttle_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/loading_predictor_page_load_metrics_observer.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/loading_predictor_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/local_network_requests_page_load_metrics_observer.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/local_network_requests_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/multi_tab_loading_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/noscript_preview_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/previews_ukm_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/session_restore_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
[modify] https://crrev.com/6e86b81637de48a75fe5476dac6b6680c575523d/chrome/browser/page_load_metrics/page_load_metrics_observer.cc

Project Member

Comment 92 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02ffb4967a66c01d22cf52b15dc2a615569c8f74

commit 02ffb4967a66c01d22cf52b15dc2a615569c8f74
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Thu Jan 18 17:58:38 2018

predictors: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//chrome/browser/predictors.

This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Change-Id: I04bafb5521c7c739c2ec3a56ed1ae189c54cd05f
Reviewed-on: https://chromium-review.googlesource.com/874171
Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#530196}
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/autocomplete_action_predictor_table_unittest.cc
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/autocomplete_action_predictor_unittest.cc
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/glowplug_key_value_data.h
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/loading_data_collector.cc
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/loading_data_collector_unittest.cc
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/loading_predictor.cc
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/loading_predictor_unittest.cc
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/loading_stats_collector_unittest.cc
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/preconnect_manager.cc
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/preconnect_manager_unittest.cc
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/predictor_database.cc
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/resource_prefetch_predictor.cc
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/resource_prefetch_predictor_tables.cc
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/resource_prefetch_predictor_tables_unittest.cc
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/resource_prefetcher.cc
[modify] https://crrev.com/02ffb4967a66c01d22cf52b15dc2a615569c8f74/chrome/browser/predictors/resource_prefetcher_unittest.cc

Project Member

Comment 93 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2442deb0fb803cb584bd6e2379987316bc35786

commit a2442deb0fb803cb584bd6e2379987316bc35786
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Thu Jan 18 17:59:41 2018

ssl: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//chrome/browser/ssl.

This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Change-Id: Ib2d59f2b26e905cdb63ae692347c4a051c26a497
Reviewed-on: https://chromium-review.googlesource.com/874172
Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530197}
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/bad_clock_blocking_page.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/captive_portal_blocking_page.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/captive_portal_helper_android.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/chrome_expect_ct_reporter.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/chrome_expect_ct_reporter_browsertest.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/chrome_ssl_host_state_delegate.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/insecure_sensitive_input_driver_factory.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/insecure_sensitive_input_driver_unittest.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/mitm_software_blocking_page.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/security_state_tab_helper_browsertest.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/security_state_tab_helper_unittest.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/ssl_blocking_page.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/ssl_browsertest.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/ssl_client_auth_requestor_mock.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/ssl_error_assistant.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/ssl_error_assistant_unittest.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/ssl_error_handler.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/ssl_error_handler_unittest.cc
[modify] https://crrev.com/a2442deb0fb803cb584bd6e2379987316bc35786/chrome/browser/ssl/ssl_error_tab_helper_unittest.cc

Project Member

Comment 94 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5482c552b9cc02cd8388ccb6482466d45d26783

commit c5482c552b9cc02cd8388ccb6482466d45d26783
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Thu Jan 18 18:42:31 2018

media: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//chrome/browser/media.

This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I3b86cf3585632e18a46306ae1d3580cf00e587a4
Reviewed-on: https://chromium-review.googlesource.com/874170
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#530210}
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/android/remote/remote_media_player_manager.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/cast_remoting_connector.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/cast_remoting_connector_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/cast_remoting_sender.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/cast_transport_host_filter.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/media_engagement_score.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/media_engagement_score_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/discovery/dial/device_description_fetcher_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/discovery/dial/dial_app_info_fetcher_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/discovery/dial/dial_registry.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/discovery/dial/dial_service.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/discovery/dial/safe_dial_app_info_parser.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/discovery/discovery_network_monitor.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/discovery/discovery_network_monitor_metric_observer_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/discovery/mdns/dns_sd_registry.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/event_page_request_manager_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/media_router_base.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/media_router_dialog_controller.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/media_router_dialog_controller_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/mojo/media_route_controller_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/mojo/media_router_desktop_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/presentation/browser_presentation_connection_proxy.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/presentation/browser_presentation_connection_proxy_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/presentation/local_presentation_manager.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/presentation/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/providers/extension/extension_media_route_provider_proxy_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/router/test/mock_media_router.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/webrtc/media_stream_capture_indicator.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/webrtc/native_desktop_media_list_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/chrome/browser/media/webrtc/webrtc_log_uploader_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/media/audio/audio_debug_recording_manager.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/media/cast/net/udp_packet_pipe_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/media/gpu/jpeg_encode_accelerator_unittest.cc
[modify] https://crrev.com/c5482c552b9cc02cd8388ccb6482466d45d26783/media/gpu/windows/d3d11_picture_buffer.cc

Project Member

Comment 95 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1437dd6170889ae9662717c9ecf24d7a415bf3ff

commit 1437dd6170889ae9662717c9ecf24d7a415bf3ff
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Thu Jan 18 22:35:47 2018

safe_browsing: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//chrome/browser/safe_browsing.

This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Change-Id: Ifd0b4b4a06feb3de9725191bde9979a248e2bb2f
Reviewed-on: https://chromium-review.googlesource.com/874033
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#530308}
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_browsertest_win.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_reboot_dialog_controller_impl_browsertest_win.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_reboot_dialog_controller_impl_win.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_browsertest_win.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_win.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/chrome_password_protection_service.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/client_side_detection_host_browsertest.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/download_protection/check_client_download_request.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/download_protection/download_feedback_service.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/download_protection/download_protection_service.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident_unittest.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/incident_reporting/delayed_callback_runner_unittest.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/incident_reporting/resource_request_detector.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident_unittest.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/local_database_manager.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/notification_image_reporter.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/notification_image_reporter_unittest.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/permission_reporter.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/permission_reporter_browsertest.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/ping_manager.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/safe_browsing_database.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/safe_browsing_navigation_observer.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/safe_browsing_navigation_observer_unittest.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/services_delegate_impl.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/settings_reset_prompt/default_settings_fetcher.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model_browsertest_win.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model_unittest.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_test_utils.cc
[modify] https://crrev.com/1437dd6170889ae9662717c9ecf24d7a415bf3ff/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_util_win.cc

Project Member

Comment 96 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d71087e3cf21cf3bd3302c04cfc72777f18ef004

commit d71087e3cf21cf3bd3302c04cfc72777f18ef004
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Thu Jan 18 22:35:55 2018

search_engines: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//chrome/browser/search_engines.

This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Change-Id: I9d43839370510fb7369f52d54f22ed9a84511ef2
Reviewed-on: https://chromium-review.googlesource.com/874250
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#530309}
[modify] https://crrev.com/d71087e3cf21cf3bd3302c04cfc72777f18ef004/chrome/browser/search_engines/template_url_fetcher_unittest.cc
[modify] https://crrev.com/d71087e3cf21cf3bd3302c04cfc72777f18ef004/chrome/browser/search_engines/template_url_service_android.cc
[modify] https://crrev.com/d71087e3cf21cf3bd3302c04cfc72777f18ef004/chrome/browser/search_engines/template_url_service_factory.cc
[modify] https://crrev.com/d71087e3cf21cf3bd3302c04cfc72777f18ef004/chrome/browser/search_engines/template_url_service_sync_unittest.cc
[modify] https://crrev.com/d71087e3cf21cf3bd3302c04cfc72777f18ef004/chrome/browser/search_engines/template_url_service_unittest.cc

Project Member

Comment 97 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b940d6f476d7663dca9d7dcdf48f896bb32157b8

commit b940d6f476d7663dca9d7dcdf48f896bb32157b8
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Thu Jan 18 22:39:04 2018

ios: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//ios.

This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7d62699d862da199d76ed44e22a988e0d96bab4e
Reviewed-on: https://chromium-review.googlesource.com/873890
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#530312}
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/app/application_delegate/app_state_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/app/startup/chrome_main_starter.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/app/startup/network_stack_setup.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/application_context_impl.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/autocomplete/autocomplete_classifier_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/autocomplete/shortcuts_backend_factory.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/bookmarks/bookmark_model_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/bookmarks/startup_task_runner_service_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/browser_state/chrome_browser_state_io_data.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/browser_state/test_chrome_browser_state.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/browsing_data/ios_browsing_data_counter_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/chrome_browser_provider_observer_bridge_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/desktop_promotion/desktop_promotion_sync_service_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/dom_distiller/dom_distiller_service_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/favicon/favicon_client_impl.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/favicon/favicon_service_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/google/google_logo_service_factory.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/google/google_url_tracker_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/history/history_client_impl.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/history/history_service_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/history/web_history_service_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ios_chrome_io_thread.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/language/language_model_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/language/url_language_histogram_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/net/cookie_util.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/net/ios_chrome_url_request_context_getter.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/notification_promo.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/notification_promo_unittest.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory_util.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ntp_tiles/ios_most_visited_sites_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ntp_tiles/ios_popular_sites_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/omaha/omaha_service.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/omaha/omaha_service_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/open_from_clipboard/create_clipboard_recent_content.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/passwords/credential_manager_egtest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/passwords/credential_manager_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/passwords/credential_manager_util_unittest.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/passwords/password_controller_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/payments/ios_payment_instrument_finder.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/payments/ios_payment_instrument_finder_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/payments/ios_payment_instrument_launcher.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/payments/ios_payment_instrument_launcher_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/payments/payment_request.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/payments/payment_request_test_util.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/payments/payment_request_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/payments/payment_request_unittest_base.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/payments/payment_response_helper_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/prerender/prerender_service_factory.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/prerender/prerender_service_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/providers/chromium_browser_provider.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/providers/chromium_browser_provider_factory.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/reading_list/offline_url_utils_unittest.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/reading_list/reading_list_distiller_page_factory.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/reading_list/reading_list_download_service.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/reading_list/reading_list_download_service_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/reading_list/reading_list_model_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/reading_list/reading_list_web_state_observer_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/search_engines/search_engines_util.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/search_engines/template_url_service_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/services/gcm/ios_chrome_gcm_profile_service_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/sessions/ios_chrome_tab_restore_service_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios_factory.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/share_extension/share_extension_service_factory.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/signin/account_consistency_service_factory.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/signin/browser_state_data_remover.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/signin/gaia_cookie_manager_service_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/signin/identity_manager_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/signin/identity_service_creator.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/signin/oauth2_token_service_factory.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/snapshots/lru_cache.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ssl/captive_portal_detector_tab_helper.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ssl/insecure_input_tab_helper.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ssl/ios_security_state_tab_helper.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/tabs/tab_model.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/tabs/tab_model_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/tabs/tab_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/test/perf_test_with_bvc_ios.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/translate/chrome_ios_translate_client.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/translate/translate_accept_languages_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/translate/translate_egtest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/translate/translate_ranker_factory.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/authentication/re_signin_infobar_delegate.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/authentication/signin_promo_view_mediator.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/bookmarks/bookmark_utils_ios.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/browser_list/browser_list_session_service_factory.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/browser_list/browser_list_session_service_impl.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/browser_view_controller_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/chrome_web_view_factory_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/content_suggestions/content_suggestions_mediator.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/content_suggestions/ntp_home_mediator.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/content_suggestions/ntp_home_mediator_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/content_suggestions/ntp_home_provider_test_singleton.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/dialogs/java_script_dialog_blocking_state_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/download/pass_kit_egtest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/fullscreen/chrome_coordinator+fullscreen_disabling.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/fullscreen/fullscreen_controller_factory.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/fullscreen/fullscreen_controller_impl.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/fullscreen/fullscreen_scroll_end_animator.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/fullscreen/fullscreen_web_state_list_observer_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/fullscreen/fullscreen_web_state_observer.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/fullscreen/fullscreen_web_state_observer_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/fullscreen/system_notification_fullscreen_disabler.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/history/history_collection_view_controller_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/main_content/web_scroll_view_main_content_ui_forwarder.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_coordinator_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/ntp/recent_tabs/synced_sessions.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/omnibox/chrome_omnibox_client_ios.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/omnibox/location_bar_controller_impl.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/omnibox_perftest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/overlays/overlay_queue_manager_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/overlays/overlay_scheduler_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/overlays/overlay_service_factory.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/payments/address_edit_coordinator_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/payments/address_edit_mediator.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/payments/contact_info_edit_coordinator_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/payments/credit_card_edit_coordinator_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/payments/payment_items_display_mediator_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/payments/payment_request_coordinator.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/payments/payment_request_debit_egtest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/payments/payment_request_egtest_base.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/payments/payment_request_manager.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/payments/shipping_option_selection_mediator_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/reading_list/reading_list_coordinator_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/reading_list/reading_list_mediator_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/settings/passphrase_collection_view_controller_test.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/settings/settings_egtest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/settings/settings_navigation_controller_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/settings/sync_encryption_collection_view_controller.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/settings/sync_encryption_collection_view_controller_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/settings/utils/pref_backed_boolean_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/static_content/static_html_view_controller_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/tab_switcher/tab_switcher_model.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/tab_switcher/tab_switcher_model_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/toolbar/clean/toolbar_mediator_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/toolbar/legacy_toolbar_coordinator.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/toolbar/legacy_toolbar_ui_updater.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/toolbar/legacy_toolbar_ui_updater_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios_unittest.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/toolbar/tools_menu_button_observer_bridge.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/webui/crashes_ui.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/webui/flags_ui.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/webui/gcm/gcm_internals_ui.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/webui/net_export/net_export_ui.mm
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/ui/webui/omaha_ui.cc
[modify] https://crrev.com/b940d6f476d7663dca9d7dcdf48f896bb32157b8/ios/chrome/browser/u
Project Member

Comment 98 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b10ad1f3af32819c4a62b986120d15a1a4c2caa3

commit b10ad1f3af32819c4a62b986120d15a1a4c2caa3
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Thu Jan 18 22:56:58 2018

chromecast: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//chromecast.

This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Change-Id: I64d44049e6778913ae7d6b4d83862d2ded4b105d
Reviewed-on: https://chromium-review.googlesource.com/874031
Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#530323}
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/base/alarm_manager.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/base/alarm_manager_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/base/bind_to_task_runner_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/base/cast_features.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/base/cast_features_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/base/cast_sys_info_android.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/base/cast_sys_info_util_simple.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/base/device_capabilities_impl.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/base/device_capabilities_impl_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/base/observer.h
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/base/observer_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/base/thread_health_checker.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/browser/cast_browser_context.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/browser/cast_content_browser_client.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/browser/cast_media_blocker_browsertest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/browser/cast_media_blocker_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/browser/cast_net_log.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/browser/cast_network_delegate_simple.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/browser/cast_web_contents_manager.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/browser/metrics/cast_metrics_service_client.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/browser/service/cast_service_simple.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/browser/test/cast_browser_test.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/browser/test/cast_features_browsertest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/browser/url_request_context_factory.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/crash/cast_crashdump_uploader.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/crash/cast_crashdump_uploader_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/crash/linux/crash_testing_utils.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/crash/linux/dump_info.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/crash/linux/synchronized_minidump_manager.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/crash/linux/synchronized_minidump_manager_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/audio/cast_audio_manager.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/audio/cast_audio_manager_alsa_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/audio/cast_audio_manager_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/audio/cast_audio_mixer.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/audio/cast_audio_mixer_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/audio/cast_audio_output_stream.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/audio/cast_audio_output_stream_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/base/slew_volume_unittests.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/cdm/cast_cdm.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/cma/backend/alsa/stream_mixer_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/cma/backend/desktop/audio_decoder_desktop.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/cma/backend/desktop/media_pipeline_backend_desktop.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/cma/backend/desktop/video_decoder_desktop.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/cma/backend/media_pipeline_backend_manager.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/cma/backend/media_pipeline_backend_wrapper.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/cma/backend/multizone_backend_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/cma/backend/post_processing_pipeline_impl.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/cma/backend/post_processors/governor_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/cma/base/multi_demuxer_stream_adapter_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/cma/pipeline/audio_video_pipeline_impl_unittest.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/media/service/cast_mojo_media_client.cc
[modify] https://crrev.com/b10ad1f3af32819c4a62b986120d15a1a4c2caa3/chromecast/net/fake_stream_socket.cc

Project Member

Comment 99 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/138fde381a93a4ffb37e8f3444c9a43928417b9f

commit 138fde381a93a4ffb37e8f3444c9a43928417b9f
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Thu Jan 18 23:13:42 2018

remoting: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//chrome/browser/remoting.

This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Change-Id: I78a995a4e57c8c2111c09239cb85225f7f84ee2e
Reviewed-on: https://chromium-review.googlesource.com/874030
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#530328}
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/base/buffered_socket_writer.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/base/chromium_url_request.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/client/chromoting_client.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/client/chromoting_client_runtime.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/client/chromoting_session.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/client/display/gl_desktop.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/client/display/gl_renderer_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/client/dual_buffer_frame_consumer.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/client/jni/jni_gl_display_handler.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/client/plugin/chromoting_instance.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/client/plugin/pepper_main_thread_task_runner.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/client/plugin/pepper_port_allocator_factory.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/client/plugin/pepper_url_request.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/client/plugin/pepper_video_renderer_2d.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/client/software_video_renderer_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/codec/cast_software_video_encoder_adapter.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/codec/webrtc_video_encoder_gpu.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/codec/webrtc_video_encoder_selector_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/basic_desktop_environment.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/chromoting_host.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/client_session.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/client_session_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/continue_window_chromeos.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/continue_window_linux.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/continue_window_mac.mm
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/continue_window_win.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/desktop_capturer_proxy.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/desktop_session_agent.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/desktop_session_proxy.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/desktop_session_win.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/disconnect_window_chromeos.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/disconnect_window_linux.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/disconnect_window_mac.mm
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/disconnect_window_win.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/fake_desktop_environment.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/fake_host_extension.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/file_proxy_wrapper_linux.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/file_proxy_wrapper_linux_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/file_transfer_message_handler.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/file_transfer_message_handler_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/heartbeat_sender.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/heartbeat_sender_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/host_event_logger_win.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/input_injector_x11.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/ipc_desktop_environment.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/it2me/it2me_confirmation_dialog_chromeos.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/it2me/it2me_confirmation_dialog_linux.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/it2me/it2me_confirmation_dialog_mac.mm
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/it2me/it2me_confirmation_dialog_proxy_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/it2me/it2me_confirmation_dialog_win.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/it2me/it2me_host_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/it2me/it2me_native_messaging_host.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/it2me/it2me_native_messaging_host_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/mouse_cursor_monitor_proxy_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/pairing_registry_delegate_linux.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/pairing_registry_delegate_win.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/pam_authorization_factory_posix.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/policy_watcher.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/policy_watcher_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/register_support_host_request.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/remoting_me2me_host.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/resizing_host_observer_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/security_key/fake_security_key_ipc_client.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/security_key/fake_security_key_ipc_server.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/security_key/security_key_extension_session.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/security_key/security_key_ipc_server_impl.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/setup/host_starter.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/setup/me2me_native_messaging_host.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/setup/me2me_native_messaging_host_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/test_echo_extension.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/token_validator_base_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/token_validator_factory_impl.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/token_validator_factory_impl_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/win/session_desktop_environment.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/host/win/wts_session_process_delegate.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/ios/audio/audio_player_ios.mm
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/ios/display/gl_display_handler.mm
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/audio_pump.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/authenticator.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/channel_multiplexer.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/chromium_port_allocator_factory.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/connection_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/data_channel_manager_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/fake_authenticator.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/fake_message_pipe.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/fake_session.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/fake_video_renderer.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/http_ice_config_request_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/ice_transport_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/it2me_host_authenticator_factory.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/jingle_session_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/me2me_host_authenticator_factory.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/message_decoder_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/negotiating_authenticator_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/pairing_registry_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/ssl_hmac_channel_authenticator.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/stream_message_pipe_adapter.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/transport_context.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/video_frame_pump.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/video_frame_pump_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/webrtc_audio_module.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/protocol/webrtc_transport.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/signaling/server_log_entry.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/signaling/xmpp_signal_strategy_unittest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/test/fake_port_allocator.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/test/protocol_perftest.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/test/test_chromoting_client.cc
[modify] https://crrev.com/138fde381a93a4ffb37e8f3444c9a43928417b9f/remoting/test/test_chromoting_client_unittest.cc

Project Member

Comment 100 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90fa2680f6bc99b5be36a0267f9add8fae9d0379

commit 90fa2680f6bc99b5be36a0267f9add8fae9d0379
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Fri Jan 19 09:46:39 2018

installer: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//chrome/installer.

This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Change-Id: Ia0b8dc7b79bdb16ee8f59d47cec72f3953bb98c8
Reviewed-on: https://chromium-review.googlesource.com/874974
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530464}
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/setup/install_worker_unittest.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/setup/setup_install_details.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/setup/setup_install_details_unittest.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/setup/setup_util.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/setup/setup_util_unittest.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/util/beacons.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/util/beacons_unittest.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/util/browser_distribution.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/util/firewall_manager_win.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/util/google_chrome_distribution.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/util/google_update_settings_unittest.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/util/install_util_unittest.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/util/lzma_file_allocator_unittest.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/util/product.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/util/product_unittest.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/util/scoped_user_protocol_entry.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/util/scoped_user_protocol_entry_unittest.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/util/shell_util.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/zucchini/disassembler_win32.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/zucchini/reloc_utils_unittest.cc
[modify] https://crrev.com/90fa2680f6bc99b5be36a0267f9add8fae9d0379/chrome/installer/zucchini/test_disassembler.cc

Project Member

Comment 101 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6afb508ae3bfe9594cfcc2ff2e44325f329f7707

commit 6afb508ae3bfe9594cfcc2ff2e44325f329f7707
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Fri Jan 19 13:35:57 2018

Replace base::MakeUnique with std::make_unique in components/ - 1

If file doesn't use base::WrapUnique, base/memory/ptr_util.h includes
are changed to <memory>.

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I544c5037c1f1a4d9b3e1eb37ff6398ebbad2da39
Reviewed-on: https://chromium-review.googlesource.com/866616
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Doug Steedman <dougsteed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530499}
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/assist_ranker/base_predictor_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/assist_ranker/binary_classifier_predictor.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/assist_ranker/binary_classifier_predictor_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/assist_ranker/ranker_model.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/assist_ranker/ranker_model_loader_impl.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/assist_ranker/ranker_model_loader_impl_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/assist_ranker/ranker_model_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/bookmarks/browser/bookmark_codec.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/bookmarks/browser/bookmark_index_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/bookmarks/browser/bookmark_model.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/bookmarks/browser/bookmark_model_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/bookmarks/managed/managed_bookmark_service.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/bookmarks/managed/managed_bookmarks_tracker.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/browsing_data/core/counters/autofill_counter.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/browsing_data/core/counters/browsing_data_counter.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/browsing_data/core/counters/history_counter.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/browsing_data/core/counters/passwords_counter.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cast_certificate/cast_cert_validator.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cast_certificate/cast_crl.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cast_channel/cast_socket.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cast_channel/cast_socket_service_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cast_channel/keep_alive_delegate_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cdm/browser/media_drm_storage_impl.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cdm/browser/media_drm_storage_impl_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/certificate_reporting/error_report_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/certificate_reporting/error_reporter.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/certificate_transparency/log_dns_client_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/certificate_transparency/single_tree_tracker_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/certificate_transparency/tree_state_tracker.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/certificate_transparency/tree_state_tracker_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cloud_devices/common/description_items_inl.h
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cloud_devices/common/printer_description.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/component_updater/component_installer_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/component_updater/component_updater_service.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/component_updater/component_updater_service_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/consent_auditor/consent_auditor.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/consent_auditor/consent_auditor_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/constrained_window/constrained_window_views_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/content_settings/core/browser/content_settings_default_provider.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/content_settings/core/browser/content_settings_global_value_map.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/content_settings/core/browser/content_settings_pref.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/content_settings/core/browser/content_settings_pref_provider.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/content_settings/core/browser/content_settings_registry.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/content_settings/core/browser/host_content_settings_map.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/content_settings/core/browser/website_settings_registry_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/content_settings/core/common/content_settings.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/content_settings/core/common/content_settings_pattern.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/content_settings/core/common/content_settings_utils.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/contextual_search/browser/contextual_search_js_api_service_impl.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/crash/content/app/run_as_crashpad_handler_win.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/crash/content/browser/crash_handler_host_linux.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cronet/url_request_context_config_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/crx_file/crx_verifier.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/background_eid_generator.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/background_eid_generator_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/ble/ble_advertisement_generator.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/ble/ble_advertisement_generator_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/ble/bluetooth_low_energy_weave_packet_generator_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/ble/bluetooth_low_energy_weave_packet_receiver_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/cryptauth_client_impl.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/cryptauth_device_manager.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/cryptauth_device_manager_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/cryptauth_enrollment_manager.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/cryptauth_enrollment_manager_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/device_capability_manager_impl.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/device_capability_manager_impl_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/device_to_device_authenticator.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/device_to_device_authenticator_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/device_to_device_operations_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/device_to_device_secure_context_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/fake_connection.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/fake_cryptauth_service.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/foreground_eid_generator.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/foreground_eid_generator_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/local_device_data_provider_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/mock_foreground_eid_generator.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/remote_beacon_seed_fetcher_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/remote_device_loader_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/remote_device_provider_impl_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/secure_channel.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/secure_channel_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/cryptauth/sync_scheduler_impl.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/data_reduction_proxy/core/browser/warmup_url_fetcher_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/data_use_measurement/core/data_use_ascriber.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/data_use_measurement/core/data_use_measurement_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/data_use_measurement/core/data_use_network_delegate_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/data_use_measurement/core/data_use_user_data.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/discardable_memory/client/client_discardable_shared_memory_manager.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/discardable_memory/common/discardable_shared_memory_heap.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/discardable_memory/common/discardable_shared_memory_heap_perftest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/dom_distiller/content/browser/distillability_driver.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/dom_distiller/content/browser/distiller_javascript_service_impl.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/dom_distiller/content/browser/distiller_page_web_contents.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/dom_distiller/core/distillable_page_detector_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/dom_distiller/core/distiller.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/dom_distiller/core/distiller_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/dom_distiller/core/dom_distiller_service.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/dom_distiller/core/dom_distiller_store_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/dom_distiller/ios/distiller_page_factory_ios.mm
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/dom_distiller/webui/dom_distiller_ui.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/domain_reliability/beacon.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/domain_reliability/config_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/domain_reliability/dispatcher.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/domain_reliability/google_configs.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/domain_reliability/header.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/domain_reliability/monitor.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/domain_reliability/scheduler.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/domain_reliability/test_util.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/error_page/common/localized_error.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/exo/wayland/clients/test/wayland_client_test.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/exo/wayland/server.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/favicon/core/favicon_driver_impl.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/favicon/core/favicon_handler_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/favicon/core/large_icon_service.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/favicon/core/large_icon_service_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/favicon_base/select_favicon_frames.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/feedback/anonymizer_tool.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/feedback/feedback_data_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/feedback/feedback_uploader_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/feedback/system_logs/system_logs_fetcher.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/feedback/system_logs/system_logs_fetcher.h
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/filesystem/directory_impl.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/filesystem/file_impl.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/filesystem/file_system_app.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/filesystem/file_system_impl.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/flags_ui/flags_state.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/grpc_support/bidirectional_stream_c.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/grpc_support/bidirectional_stream_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/grpc_support/test/get_stream_engine.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/guest_view/browser/guest_view_base.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/guest_view/browser/guest_view_message_filter.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/guest_view/browser/test_guest_view_manager.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/history/core/browser/history_backend.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/history/core/browser/history_model_worker.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/history/core/browser/top_sites_impl.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/history/core/browser/typed_url_sync_bridge.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/history/core/browser/typed_url_sync_bridge_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/history/core/browser/visitsegment_database.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/history/core/test/history_client_fake_bookmarks.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/image_fetcher/ios/ios_image_data_fetcher_wrapper_unittest.mm
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/image_fetcher/ios/ios_image_decoder_impl.mm
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/invalidation/impl/gcm_invalidation_bridge.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/invalidation/impl/registration_manager.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/invalidation/impl/sync_system_resources.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/invalidation/impl/ticl_invalidation_service_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/json_schema/json_schema_validator.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/json_schema/json_schema_validator_unittest_base.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/leveldb/leveldb_service_impl.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/leveldb_proto/proto_database_impl.h
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/leveldb_proto/proto_database_impl_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/login/screens/screen_context.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/metrics/call_stack_profile_collector.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/metrics/file_metrics_provider.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/metrics/metrics_service.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/metrics/metrics_state_manager.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/metrics/net/network_metrics_provider_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/metrics/persistent_system_profile_unittest.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/metrics/single_sample_metrics.cc
[modify] https://crrev.com/6afb508ae3bfe9594cfcc2ff2e44325f329f7707/components/metrics/single_sample_metrics_factory_impl.cc

Project Member

Comment 102 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f1795eeb1e1b573b780b4ef24e525adc6a4dcf4

commit 5f1795eeb1e1b573b780b4ef24e525adc6a4dcf4
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Mon Jan 22 11:49:19 2018

permissions: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//chrome/browser/permissions.

This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Change-Id: I7a977e6145e1d999bb1f170df265d5abbc12ddbf
Reviewed-on: https://chromium-review.googlesource.com/874230
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#530840}
[modify] https://crrev.com/5f1795eeb1e1b573b780b4ef24e525adc6a4dcf4/chrome/browser/permissions/chooser_context_base.cc
[modify] https://crrev.com/5f1795eeb1e1b573b780b4ef24e525adc6a4dcf4/chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc
[modify] https://crrev.com/5f1795eeb1e1b573b780b4ef24e525adc6a4dcf4/chrome/browser/permissions/permission_blacklist_client.cc
[modify] https://crrev.com/5f1795eeb1e1b573b780b4ef24e525adc6a4dcf4/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/5f1795eeb1e1b573b780b4ef24e525adc6a4dcf4/chrome/browser/permissions/permission_context_base_unittest.cc
[modify] https://crrev.com/5f1795eeb1e1b573b780b4ef24e525adc6a4dcf4/chrome/browser/permissions/permission_decision_auto_blocker.cc
[modify] https://crrev.com/5f1795eeb1e1b573b780b4ef24e525adc6a4dcf4/chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc
[modify] https://crrev.com/5f1795eeb1e1b573b780b4ef24e525adc6a4dcf4/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/5f1795eeb1e1b573b780b4ef24e525adc6a4dcf4/chrome/browser/permissions/permission_manager_unittest.cc
[modify] https://crrev.com/5f1795eeb1e1b573b780b4ef24e525adc6a4dcf4/chrome/browser/permissions/permission_prompt_android.cc
[modify] https://crrev.com/5f1795eeb1e1b573b780b4ef24e525adc6a4dcf4/chrome/browser/permissions/permission_request_manager_browsertest.cc
[modify] https://crrev.com/5f1795eeb1e1b573b780b4ef24e525adc6a4dcf4/chrome/browser/permissions/permission_request_manager_test_api.cc

Project Member

Comment 103 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b084c0832974592b5fdb639b1d2558b4f5549ac

commit 8b084c0832974592b5fdb639b1d2558b4f5549ac
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Tue Jan 23 13:34:37 2018

Replace base::MakeUnique with std::make_unique in components/ - 2

If file doesn't use base::WrapUnique, base/memory/ptr_util.h includes
are changed to <memory>.

Bug: 755727
Change-Id: I6fc3a696a2222e140d6d366b2bc9b285fdef2dbc
Reviewed-on: https://chromium-review.googlesource.com/878083
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#531218}
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/offline_items_collection/core/android/offline_content_aggregator_bridge.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/offline_pages/core/model/add_page_to_download_manager_task_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/os_crypt/os_crypt_mocker_linux.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/password_manager/core/browser/password_manager_metrics_recorder.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/payments/core/payment_request_data_util.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/pdf/renderer/pepper_pdf_host.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/physical_web/data_source/fake_physical_web_data_source.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/physical_web/webui/physical_web_base_message_handler.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/printing/renderer/print_render_frame_helper.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/printing/renderer/print_render_frame_helper_mac.mm
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/printing/service/pdf_compositor_service.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/printing/test/print_test_content_renderer_client.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/proximity_auth/bluetooth_low_energy_connection_finder.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/proximity_auth/bluetooth_low_energy_connection_finder_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/proximity_auth/bluetooth_low_energy_setup_connection_finder.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/proximity_auth/messenger_impl.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/proximity_auth/messenger_impl_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/proximity_auth/promotion_manager_unittests.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/proximity_auth/remote_device_life_cycle_impl.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/proximity_auth/screenlock_bridge.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/proximity_auth/unlock_manager_impl.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/proximity_auth/webui/proximity_auth_ui.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/proximity_auth/webui/proximity_auth_webui_handler.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/proxy_config/ios/proxy_service_factory.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/proxy_config/proxy_config_dictionary.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/query_parser/query_parser.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/rappor/rappor_recorder_impl.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/rappor/rappor_service_impl.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/renderer_context_menu/context_menu_delegate.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/search_provider_logos/fixed_logo_api.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/search_provider_logos/google_logo_api.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/search_provider_logos/logo_cache.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/search_provider_logos/logo_cache_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/security_state/content/content_utils.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/security_state/content/content_utils_browsertest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/security_state/content/ssl_status_input_event_data.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/security_state/core/security_state_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/security_state/ios/ssl_status_input_event_data.mm
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/spellcheck/browser/spelling_service_client.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/spellcheck/renderer/spellcheck.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/spellcheck/renderer/spellcheck_provider_test.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/ssl_config/ssl_config_service_manager_pref_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/ssl_errors/error_classification_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/startup_metric_utils/browser/startup_metric_host_impl.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/storage_monitor/storage_monitor_linux.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/suggestions/image_encoder_ios.mm
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/sync_preferences/pref_model_associator.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/sync_preferences/pref_model_associator_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/sync_preferences/pref_service_syncable_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/sync_wifi/wifi_config_delegate_chromeos_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/sync_wifi/wifi_credential.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/sync_wifi/wifi_credential_syncable_service_factory.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/sync_wifi/wifi_credential_syncable_service_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/task_scheduler_util/common/variations_util.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/test/components_test_suite.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/timers/alarm_timer_chromeos.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/timers/alarm_timer_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/tracing/test/trace_event_perftest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/translate/core/browser/mock_translate_client.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/translate/core/browser/translate_prefs.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/translate/core/browser/translate_ranker_impl.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/translate/core/browser/translate_ranker_impl_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/translate/core/common/language_detection_logging_helper.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/translate/ios/browser/language_detection_controller_unittest.mm
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/translate/ios/browser/translate_controller_unittest.mm
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/ui_devtools/devtools_server.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/ui_devtools/views/dom_agent.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/ui_devtools/views/ui_devtools_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/ukm/content/source_url_recorder_browsertest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/ukm/ukm_recorder_impl.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/ukm/ukm_reporting_service.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/ukm/ukm_service_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/undo/undo_manager_test.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/url_matcher/regex_set_matcher.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/url_matcher/url_matcher_factory.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/url_matcher/url_matcher_factory_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/user_manager/user_manager_base.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/visitedlink/browser/visitedlink_master.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/wallpaper/wallpaper_color_calculator_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/wallpaper/wallpaper_resizer_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/web_cache/renderer/web_cache_impl.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/web_resource/web_resource_service.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/web_restrictions/browser/web_restrictions_mojo_implementation.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/webcrypto/algorithms/aes_cbc_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/webcrypto/algorithms/aes_kw_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/webcrypto/algorithms/hmac_unittest.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/webcrypto/algorithms/sha.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/webdata_services/web_data_service_wrapper.cc
[modify] https://crrev.com/8b084c0832974592b5fdb639b1d2558b4f5549ac/components/zoom/zoom_event_manager.cc

Project Member

Comment 104 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f33b4295354af3026b60da8c83a088f8d54888d

commit 6f33b4295354af3026b60da8c83a088f8d54888d
Author: Jinho Bang <jinho.bang@samsung.com>
Date: Tue Jan 23 16:55:27 2018

google_apis: Replace base::MakeUnique with std::make_unique

Should use std::make_unique directly instead of using base::MakeUnique
since August[1]. So, this change removes usages of base::MakeUnique in
//google_apis.

This change removes `#include "base/memory/ptr_util.h"` if it's no more
used in files. (Might not remove if base::WrapUnique is used)

This change also adds `#include <memory>` header except the following
two cases:
  - Not add the header if the file contains the <memory> header
  - Not add the header if the related header contains <memory> header
    (The style guide[2] says that foo.cc can rely on foo.h's includes)

Confirmed no additional lint errors(by `git cl lint`) after this change.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/616016
[2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Bug: 755727
Change-Id: Iaffa8eb5fad583f7e7923fa37ee686f26b0717d9
Reviewed-on: https://chromium-review.googlesource.com/874032
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#531260}
[modify] https://crrev.com/6f33b4295354af3026b60da8c83a088f8d54888d/google_apis/drive/base_requests.cc
[modify] https://crrev.com/6f33b4295354af3026b60da8c83a088f8d54888d/google_apis/drive/base_requests_server_unittest.cc
[modify] https://crrev.com/6f33b4295354af3026b60da8c83a088f8d54888d/google_apis/drive/base_requests_unittest.cc
[modify] https://crrev.com/6f33b4295354af3026b60da8c83a088f8d54888d/google_apis/drive/drive_api_requests.cc
[modify] https://crrev.com/6f33b4295354af3026b60da8c83a088f8d54888d/google_apis/drive/drive_api_requests_unittest.cc
[modify] https://crrev.com/6f33b4295354af3026b60da8c83a088f8d54888d/google_apis/drive/files_list_request_runner.cc
[modify] https://crrev.com/6f33b4295354af3026b60da8c83a088f8d54888d/google_apis/drive/request_sender_unittest.cc
[modify] https://crrev.com/6f33b4295354af3026b60da8c83a088f8d54888d/google_apis/gaia/fake_oauth2_token_service.cc
[modify] https://crrev.com/6f33b4295354af3026b60da8c83a088f8d54888d/google_apis/gaia/gaia_auth_util.cc
[modify] https://crrev.com/6f33b4295354af3026b60da8c83a088f8d54888d/google_apis/gaia/google_service_auth_error.cc
[modify] https://crrev.com/6f33b4295354af3026b60da8c83a088f8d54888d/google_apis/gaia/oauth2_token_service_unittest.cc
[modify] https://crrev.com/6f33b4295354af3026b60da8c83a088f8d54888d/google_apis/gaia/ubertoken_fetcher.cc

Project Member

Comment 105 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb7965ee7f9d554ed4838be6b298efbb0c05cfba

commit cb7965ee7f9d554ed4838be6b298efbb0c05cfba
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Thu Jan 25 00:39:01 2018

Replace base::MakeUnique with std::make_unique in components/ - 3

Final cleanup CL in componenets/. If file doesn't use base::WrapUnique,
base/memory/ptr_util.h includes are changed to <memory>.

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I8752f3bede1d7556538f63e7942501e78f78f411
Reviewed-on: https://chromium-review.googlesource.com/882242
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#531763}
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/data_reduction_proxy/core/browser/warmup_url_fetcher_unittest.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/multidevice/service/multidevice_service.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/multidevice/service/multidevice_service_unittest.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/multidevice/service/test_main.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/nacl/browser/nacl_broker_host_win.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/nacl/common/nacl_service.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/nacl/loader/nacl_ipc_adapter.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/nacl/loader/nacl_listener.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/nacl/loader/nacl_trusted_listener.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/nacl/loader/nonsfi/nonsfi_listener.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/nacl/zygote/nacl_fork_delegate_linux.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/navigation_interception/intercept_navigation_delegate.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/net_log/chrome_net_log.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/net_log/net_export_file_writer.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/net_log/net_export_file_writer_unittest.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/network_session_configurator/browser/network_session_configurator_unittest.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/network_time/network_time_test_utils.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/network_time/network_time_tracker.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/ntp_tiles/icon_cacher_impl_unittest.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/ntp_tiles/most_visited_sites_unittest.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/ntp_tiles/popular_sites_impl.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/ntp_tiles/popular_sites_impl_unittest.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc
[modify] https://crrev.com/cb7965ee7f9d554ed4838be6b298efbb0c05cfba/components/viz/presubmit_checks.py

Project Member

Comment 106 by bugdroid1@chromium.org, Jan 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b480abab5631117f34b33620c6c3262efd0efd07

commit b480abab5631117f34b33620c6c3262efd0efd07
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Sat Jan 27 07:00:04 2018

Replace base::MakeUnique with std::make_unique in chromecast/, extensions/, net/, ppapi/, printing/

If updated files don't use base::WrapUnique, base/memory/ptr_util.h includes are changed to
<memory>.

Bug: 755727
Change-Id: Ifb9ad8d3ee41130ac5c159cf084c979a304b80ed
Reviewed-on: https://chromium-review.googlesource.com/885383
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532173}
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/chromecast/browser/cast_web_contents_manager.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/chromecast/gpu/cast_content_gpu_client.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/chromecast/media/cma/backend/post_processor_factory.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/extensions/browser/api/device_permissions_prompt.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/extensions/browser/api/hid/hid_apitest.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/extensions/browser/api/management/management_api.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/extensions/browser/api/networking_private/networking_private_chromeos.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/net/http/http_cache_writers_unittest.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/net/network_error_logging/network_error_logging_service.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/net/network_error_logging/network_error_logging_service_unittest.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/ppapi/proxy/audio_encoder_resource.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/ppapi/proxy/flash_font_file_resource.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/ppapi/proxy/interface_list.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/ppapi/proxy/plugin_dispatcher.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/ppapi/proxy/udp_socket_filter.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/ppapi/proxy/video_encoder_resource.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/ppapi/proxy/vpn_provider_resource.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/printing/backend/cups_connection.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/printing/backend/cups_ipp_util_unittest.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/printing/backend/print_backend_chromeos.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/printing/backend/print_backend_win.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/printing/emf_win.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/printing/print_settings_conversion.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/printing/printing_context_chromeos.cc
[modify] https://crrev.com/b480abab5631117f34b33620c6c3262efd0efd07/printing/printing_context_no_system_dialog.cc

Project Member

Comment 107 by bugdroid1@chromium.org, Jan 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0ace88904cb0bd7389b4d23ea9d63f297ddae08

commit d0ace88904cb0bd7389b4d23ea9d63f297ddae08
Author: codeimpl <codeimpl@gmail.com>
Date: Sat Jan 27 14:38:16 2018

Replace base::MakeUnique with std::make_unique in ui/

base/memroy/ptr_util.h includes are changed with <memory> as well.

Bug: 755727
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5076f4b596ee4051e4b02a2c8c23ab73448ec983
Reviewed-on: https://chromium-review.googlesource.com/882527
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532212}
[modify] https://crrev.com/d0ace88904cb0bd7389b4d23ea9d63f297ddae08/AUTHORS
[modify] https://crrev.com/d0ace88904cb0bd7389b4d23ea9d63f297ddae08/ui/events/blink/blink_event_util.cc
[modify] https://crrev.com/d0ace88904cb0bd7389b4d23ea9d63f297ddae08/ui/gl/gl_fence_android_native_fence_sync.cc
[modify] https://crrev.com/d0ace88904cb0bd7389b4d23ea9d63f297ddae08/ui/views/view_unittest.cc
[modify] https://crrev.com/d0ace88904cb0bd7389b4d23ea9d63f297ddae08/ui/wm/test/wm_test_helper.cc

Project Member

Comment 108 by bugdroid1@chromium.org, Feb 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/637cefb7e3f2910b34040834471ee3006f38fa30

commit 637cefb7e3f2910b34040834471ee3006f38fa30
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Sat Feb 03 03:03:21 2018

Change base::MakeUnique with std::make_unique in apps/, base/, cc/, content/, gpu/, mash/

If updated files don't use base::WrapUnique, base/memory/ptr_util.h includes are changed to
<memory>.

Bug: 755727
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib2b82ee10c9c4367896055e882df9b241edc666f
Reviewed-on: https://chromium-review.googlesource.com/890575
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534249}
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/apps/launcher.cc
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/apps/saved_files_service.cc
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/base/message_loop/message_pump_mac.mm
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/cc/animation/animation_player_unittest.cc
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/cc/animation/animation_ticker.cc
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/content/browser/android/gesture_listener_manager.cc
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/content/browser/blob_storage/chrome_blob_storage_context.cc
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/content/browser/loader/web_package_loader.cc
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/content/browser/loader/web_package_request_handler.cc
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/content/renderer/gpu/queue_message_swap_promise.cc
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/gpu/command_buffer/service/gpu_fence_manager.cc
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/gpu/ipc/client/command_buffer_proxy_impl.cc
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/mash/simple_wm/simple_wm.cc
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/mash/task_viewer/task_viewer.cc
[modify] https://crrev.com/637cefb7e3f2910b34040834471ee3006f38fa30/mash/test/mash_test_suite.cc

Project Member

Comment 109 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec48d7afb5df4c5d1c3b49afef1a4da249711fef

commit ec48d7afb5df4c5d1c3b49afef1a4da249711fef
Author: Jeremy Roman <jbroman@chromium.org>
Date: Thu Mar 01 17:35:09 2018

Replace base::MakeUnique with std::make_unique in chrome/browser/.

base/memory/ptr_util.h includes will be cleaned up later.

Generated by:
git grep -l base::MakeUnique chrome/browser/ | xargs perl -pi -e 's/base::MakeUnique/std::make_unique/'

Presubmit bypassed due to unrelated existing errors in touched lines.

Bug: 755727
No-Presubmit: true
Change-Id: Ib4480069b2a369566e6ae4a3d426a0797f5984bb
Reviewed-on: https://chromium-review.googlesource.com/943461
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540201}
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/autocomplete/chrome_autocomplete_provider_client_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/autocomplete/search_provider_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/autocomplete/shortcuts_backend_factory.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/background/background_application_list_model.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/background/background_application_list_model_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/background/background_contents_service.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/background/background_mode_manager.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/banners/app_banner_manager_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/banners/app_banner_settings_helper.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/bookmarks/bookmark_model_factory.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/bookmarks/chrome_bookmark_client.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/bookmarks/managed_bookmark_service_factory.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/bookmarks/managed_bookmark_service_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/browser_process_platform_part_chromeos.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/browser_process_platform_part_win.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/browsing_data/browsing_data_channel_id_helper_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/browsing_data/browsing_data_cookie_helper.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/browsing_data/cookies_tree_model.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/browsing_data/counters/browsing_data_counter_factory.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/browsing_data/counters/cache_counter.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/browsing_data/counters/conditional_cache_counting_helper_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/browsing_data/counters/hosted_apps_counter.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/browsing_data/counters/media_licenses_counter.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/browsing_data/counters/media_licenses_counter_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/browsing_data/counters/site_settings_counter_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/budget_service/budget_database_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/budget_service/budget_service_impl.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/cache_stats_recorder.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/chrome_browser_main_android.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/chrome_content_browser_client_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/client_hints/client_hints.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/client_hints/client_hints_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/client_hints/client_hints_observer.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/command_updater_impl.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/component_updater/cros_component_installer_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/component_updater/optimization_hints_component_installer_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/component_updater/origin_trials_component_installer_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/component_updater/sw_reporter_installer_win_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/conflicts/installed_programs_win.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/conflicts/installed_programs_win_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/conflicts/module_event_sink_impl_win.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/conflicts/module_event_sink_impl_win_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/conflicts/module_info_util_win.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/conflicts/module_info_win.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/content_settings/host_content_settings_map_factory.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/content_settings/host_content_settings_map_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/content_settings/local_shared_objects_container.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/content_settings/sound_content_setting_observer_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/cryptauth/chrome_cryptauth_service.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/custom_handlers/protocol_handler_registry.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/devtools/device/adb/mock_adb_server.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/devtools/device/usb/android_usb_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/devtools/device/usb/android_usb_device.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/devtools/devtools_file_helper.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/devtools/devtools_protocol.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/devtools/devtools_targets_ui.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/devtools/devtools_window.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/devtools/global_confirm_info_bar_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/devtools/protocol_string.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/devtools/remote_debugging_server.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/devtools/serialize_host_descriptions.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/diagnostics/recon_diagnostics.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/diagnostics/sqlite_diagnostics.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/dom_distiller/tab_utils_android.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/domain_reliability/browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/download/default_download_dir_policy_handler.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/download/download_crx_util.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/download/download_danger_prompt_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/download/download_dir_policy_handler.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/download/download_dir_policy_handler_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/download/download_history_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/download/download_query_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/download/download_service_factory.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/download/download_status_updater.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/download/download_status_updater_mac.mm
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/download/download_status_updater_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/download/download_target_determiner_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/download/download_ui_controller_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/download/notification/download_notification_manager.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/engagement/important_sites_util.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/engagement/site_engagement_score.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/engagement/site_engagement_service.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/engagement/site_engagement_service_android.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/exo_parts.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/extensions/webstore_inline_installer.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/extensions/webstore_inline_installer_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/favicon/favicon_service_factory.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/favicon/large_icon_service_factory.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/feature_engagement/bookmark/bookmark_tracker_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/feature_engagement/feature_tracker_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/feature_engagement/incognito_window/incognito_window_tracker_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/feature_engagement/new_tab/new_tab_tracker_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/feature_engagement/new_tab/new_tab_tracker_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/feature_engagement/session_duration_updater_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/feedback/system_logs/about_system_logs_fetcher.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/feedback/system_logs/chrome_system_logs_fetcher.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/file_select_helper.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/first_run/first_run.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/font_pref_change_notifier_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/gcm/gcm_profile_service_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/history/android/sqlite_cursor_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/history/chrome_history_backend_client.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/history/chrome_history_client.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/history/history_service_factory.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/icon_loader_auralinux.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/icon_loader_chromeos.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/icon_loader_mac.mm
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/icon_loader_win.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/importer/external_process_importer_client.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/importer/in_process_importer_bridge.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/installable/installable_manager.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/installable/installable_manager_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/installable/installable_manager_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/installable/installable_metrics.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/io_thread.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/io_thread_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/local_discovery/service_discovery_client_mdns.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/media_galleries/chromeos/mtp_read_file_worker.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/media_galleries/gallery_watch_manager.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/media_galleries/media_file_system_registry.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/media_galleries/media_file_system_registry_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/media_galleries/media_galleries_preferences.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/media_galleries/media_galleries_test_util.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/memory/memory_kills_monitor.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/memory/swap_thrashing_monitor.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/memory/swap_thrashing_monitor_delegate_win.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/memory/swap_thrashing_monitor_delegate_win_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/metrics/antivirus_metrics_provider_win_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/metrics/chrome_metrics_services_manager_client.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/metrics/subprocess_metrics_provider.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/metrics/subprocess_metrics_provider_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/metrics/tab_reactivation_tracker.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/metrics/ukm_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/net/disk_cache_dir_policy_handler.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/net/disk_cache_dir_policy_handler_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/net/loading_predictor_observer.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/net/net_export_helper.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/net/predictor.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/net/predictor_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/net/predictor_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/net/proxy_browsertest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/net/referrer.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/net/spdyproxy/data_reduction_promo_infobar_delegate_android.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/net_benchmarking.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/notifications/notification_permission_context_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/ntp_snippets/content_suggestions_notifier_service_factory.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/ntp_snippets/contextual_content_suggestions_service_factory.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/ntp_snippets/download_suggestions_provider.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/ntp_tiles/chrome_most_visited_sites_factory.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/ntp_tiles/chrome_popular_sites_factory.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/browser/offline_pages/android/background_scheduler_bridge.cc
[modify] https://crrev.com/ec48d7afb5df4c5d1c3b49afef1a4da249711fef/chrome/brow
Project Member

Comment 110 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42e81a6acef8011976f19ad45bc554f805c24825

commit 42e81a6acef8011976f19ad45bc554f805c24825
Author: Jeremy Roman <jbroman@chromium.org>
Date: Thu Mar 01 19:08:59 2018

Replace base::MakeUnique with std::make_unique.

base/memory/ptr_util.h includes will be cleaned up later.

Generated by:
git grep -l base::MakeUnique | xargs perl -pi -e 's/base::MakeUnique/std::make_unique/'
git grep -l MakeUnique< base | xargs perl -pi -e 's/MakeUnique</std::make_unique</'

Presubmit bypassed due to unrelated existing errors in touched lines.

Bug: 755727
No-Presubmit: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iedc5caf5bc04e119dadd0e3e8cc5c4dbf2fddc80
Reviewed-on: https://chromium-review.googlesource.com/943728
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540241}
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/base/message_loop/message_loop_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/base/threading/sequence_local_storage_slot.h
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/base/trace_event/process_memory_dump_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/cc/animation/animation_player_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/cc/animation/keyframe_effect.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/cc/animation/single_keyframe_effect_animation.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/common/chrome_content_client_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/common/custom_handlers/protocol_handler.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/common/extensions/api/common_extension_api_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/common/extensions/api/extension_action/action_info.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/common/extensions/command_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/common/extensions/manifest_handlers/content_scripts_handler.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/common/extensions/manifest_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/common/extensions/sync_type_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/common/media_router/route_request_result.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/common/profiling/profiling_client.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/common/safe_browsing/mach_o_image_reader_mac.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/gpu/chrome_content_gpu_client.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/install_static/test/scoped_install_details.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/profiling/memlog_connection_manager.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/profiling/profiling_service.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/renderer/chrome_content_renderer_client_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/renderer/chrome_render_thread_observer.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/renderer/extensions/extension_localization_peer.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/renderer/extensions/extension_localization_peer_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/renderer/media/cast_session_delegate.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/renderer/net/net_error_helper_core_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/renderer/page_load_metrics/page_timing_metrics_sender_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/renderer/pepper/chrome_renderer_pepper_host_factory.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/renderer/pepper/pepper_helper.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/renderer/sandbox_status_extension_android.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/renderer/security_filter_peer.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/service/cloud_print/cloud_print_message_handler.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/service/cloud_print/printer_job_handler_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/service/service_process.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/service/service_process_prefs.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/services/media_gallery_util/public/cpp/safe_media_metadata_parser.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/services/printing/pdf_to_emf_converter_factory.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/base/ash_test_environment_chrome.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/base/browser_with_test_window_test.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/base/chrome_render_view_test.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/base/javascript_browser_test.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/base/test_browser_window.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/chromedriver/chrome/console_logger_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/chromedriver/chrome/web_view_impl.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/chromedriver/chrome_launcher.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/chromedriver/commands.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/chromedriver/commands_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/chromedriver/logging.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/chromedriver/net/url_request_context_getter.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/chromedriver/performance_logger_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/chromedriver/server/http_handler.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/chromedriver/window_commands.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/data/webui/signin_browsertest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/media_router/media_router_integration_browsertest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/test/views/chrome_views_test_base.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/utility/importer/edge_database_reader_win.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/utility/importer/firefox_importer.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/utility/importer/profile_import_service.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/utility/safe_browsing/mac/hfs.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chrome/utility/safe_browsing/mac/udif.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/chromecast/media/cma/backend/post_processor_factory.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/components/spellcheck/browser/spell_check_host_impl.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/components/ui_devtools/views/dom_agent.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/content/browser/quota_dispatcher_host.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/content/utility/utility_thread_impl.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/courgette/adjustment_method_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/courgette/disassembler.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/courgette/disassembler_elf_32_x86_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/crypto/ec_signature_creator.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/crypto/nss_util.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/crypto/secure_hash.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/device/bluetooth/bluetooth_remote_gatt_service_win.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/device/gamepad/gamepad_haptics_manager.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/device/geolocation/geolocation_context.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/headless/public/util/compositor_controller_browsertest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/media/mojo/services/cdm_service.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/rlz/chromeos/lib/rlz_value_store_chromeos.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/sandbox/win/src/broker_services.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/services/data_decoder/data_decoder_service.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/services/identity/public/cpp/identity_manager.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/services/identity/public/cpp/primary_account_access_token_fetcher_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/services/ui/service.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/services/video_capture/device_factory_provider_impl.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/skia/ext/benchmarking_canvas.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/skia/ext/platform_canvas.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/skia/ext/raster_handle_allocator_win.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/tools/android/forwarder2/forwarders_manager.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/tools/battor_agent/battor_connection_impl.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/tools/battor_agent/battor_connection_impl_unittest.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/tools/ipc_fuzzer/fuzzer/fuzzer.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/tools/ipc_fuzzer/message_dump/message_dump.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/tools/ipc_fuzzer/message_lib/message_file_reader.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/tools/ipc_fuzzer/message_replay/replay_process.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/tools/win/chromeexts/chrome_exts_command.h
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/ui/ozone/platform/wayland/wayland_connection.cc
[modify] https://crrev.com/42e81a6acef8011976f19ad45bc554f805c24825/ui/views/controls/views_text_services_context_menu_mac.mm

Project Member

Comment 111 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96e7354289973217a73853ce3ff5d7c18ac35b40

commit 96e7354289973217a73853ce3ff5d7c18ac35b40
Author: Luis Hector Chavez <lhchavez@google.com>
Date: Thu Mar 01 22:35:44 2018

arc: Remove the base::MakeUnique presubmit

Now that base::MakeUnique is no more, we don't need this anymore.

Bug: 755727
Test: git cl upload
Change-Id: Ia90edbd28bbaca79afa5aa554677855e3b98cdfd
Reviewed-on: https://chromium-review.googlesource.com/944511
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540312}
[modify] https://crrev.com/96e7354289973217a73853ce3ff5d7c18ac35b40/components/arc/PRESUBMIT.py

Project Member

Comment 112 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e26b21394de64e30cdeebe308df851129dd5eff

commit 0e26b21394de64e30cdeebe308df851129dd5eff
Author: Jeremy Roman <jbroman@chromium.org>
Date: Fri Mar 02 00:26:59 2018

Remove base::MakeUnique.

All call sites now use std::make_unique.

Bug: 755727
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I08adbff1480987b2c29bca8ad32b096a46d937ba
Reviewed-on: https://chromium-review.googlesource.com/944048
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540371}
[modify] https://crrev.com/0e26b21394de64e30cdeebe308df851129dd5eff/base/memory/ptr_util.h
[modify] https://crrev.com/0e26b21394de64e30cdeebe308df851129dd5eff/base/memory/ptr_util_unittest.cc

Project Member

Comment 113 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52b846982a8630a4aef247c58082528156803b52

commit 52b846982a8630a4aef247c58082528156803b52
Author: Jeremy Roman <jbroman@chromium.org>
Date: Fri Mar 02 15:42:37 2018

Replace all references to base::MakeUnique in styleguide/.

base::MakeUnique no longer exists.

Finally, add a link to Google/Abseil C++ TOTW 126, which further
explains the guidance around make_unique.

Bug: 755727
Change-Id: I953cff07f88d8d3dcf4f3c31870abc25397e8107
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/944918
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540523}
[modify] https://crrev.com/52b846982a8630a4aef247c58082528156803b52/styleguide/c++/c++-dos-and-donts.md
[modify] https://crrev.com/52b846982a8630a4aef247c58082528156803b52/styleguide/c++/c++11.html

Project Member

Comment 114 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0760a40a696bd540c5e79d51fed33319f8be6b2

commit e0760a40a696bd540c5e79d51fed33319f8be6b2
Author: Jeremy Roman <jbroman@chromium.org>
Date: Fri Mar 02 18:19:40 2018

Update docs/webui_explainer.md to refer to std::make_unique.

Bug: 755727
Change-Id: I001537e46fa19ad521c1df58243fddbf4782e40b
Reviewed-on: https://chromium-review.googlesource.com/946123
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540558}
[modify] https://crrev.com/e0760a40a696bd540c5e79d51fed33319f8be6b2/docs/webui_explainer.md

Project Member

Comment 115 by bugdroid1@chromium.org, Mar 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6836677823de13dfda5518b25eb15e24f65a86d3

commit 6836677823de13dfda5518b25eb15e24f65a86d3
Author: Jeremy Roman <jbroman@chromium.org>
Date: Sat Mar 03 02:39:48 2018

[blink_gc_plugin] Narrow the unique_ptr function list to those that still exist.

Bug: 755727
Change-Id: Ief44c8e53de86bb86fa01f423da5bb59ec8b7105
Reviewed-on: https://chromium-review.googlesource.com/946124
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540724}
[modify] https://crrev.com/6836677823de13dfda5518b25eb15e24f65a86d3/tools/clang/blink_gc_plugin/BadPatternFinder.cpp

Project Member

Comment 116 by bugdroid1@chromium.org, Mar 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fbce50dac40122e403c9310ede35924ba438be4

commit 8fbce50dac40122e403c9310ede35924ba438be4
Author: Jeremy Roman <jbroman@chromium.org>
Date: Sat Mar 03 18:05:36 2018

Replace WrapArrayUnique function with std::make_unique in partition_alloc_unittest.cc.

std::make_unique is the more usual way to do this, and Blink doesn't even
have WrapArrayUnique anymore for this reason.

Bug: 755727
Change-Id: I9dc78827b8ef84da7c297ebc147a3ef157d0acc1
Reviewed-on: https://chromium-review.googlesource.com/946125
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540759}
[modify] https://crrev.com/8fbce50dac40122e403c9310ede35924ba438be4/base/allocator/partition_allocator/partition_alloc_unittest.cc

Project Member

Comment 117 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6533c7b5483ceea50c6e899ed0b0097d5553a25

commit e6533c7b5483ceea50c6e899ed0b0097d5553a25
Author: Jeremy Roman <jbroman@chromium.org>
Date: Mon Mar 05 17:44:46 2018

IWYU some sites which use std::unique_ptr or base::MakeUnique without an include.

This pre-emptively fixes breakage which would otherwise occur in the
follow-up CL, which removes includes of base/memory/ptr_util.h from files
which do not use base::WrapUnique.

A couple of call sites were moved from WrapUnique to make_unique, because this
avoids the extra include and achieves the same thing.

Bug: 755727
Tbr: jam@chromium.org
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I06f82a7d30b9b97fadfc93f1a3e522d329903151
Reviewed-on: https://chromium-review.googlesource.com/946650
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540858}
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/base/process/process_info_win.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/base/test/scoped_task_environment.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/cc/animation/animation_host.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/cc/animation/worklet_animation_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chrome/browser/media/router/discovery/discovery_network_monitor_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chrome/browser/offline_pages/android/cct_request_observer.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_fetcher_win_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chrome/browser/ui/overlay/overlay_surface_embedder.h
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chrome/browser/ui/overlay/overlay_window.h
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/active_host_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/ad_hoc_ble_advertiser_impl_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/asynchronous_shutdown_object_container_impl.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/ble_advertiser_impl.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/ble_connection_manager.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/ble_connection_manager_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/ble_scanner_impl.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/connect_tethering_operation.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/connect_tethering_operation_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/connection_preserver_impl_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/disconnect_tethering_operation.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/disconnect_tethering_operation_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/disconnect_tethering_request_sender_impl.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/disconnect_tethering_request_sender_impl_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/host_scanner_impl_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/host_scanner_operation.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/host_scanner_operation_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/keep_alive_operation.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/keep_alive_operation_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/keep_alive_scheduler_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/master_host_scan_cache_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/message_transfer_operation_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/network_connection_handler_tether_delegate_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/synchronous_shutdown_object_container_impl.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/tether_component_impl.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/tether_component_impl_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/tether_connector_impl_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/tether_host_response_recorder_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/chromeos/components/tether/wifi_hotspot_disconnector_impl_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/components/autofill/core/browser/webdata/autofill_data_type_controller_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/components/cast_channel/cast_socket_service_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/components/content_settings/core/browser/content_settings_default_provider.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/components/content_settings/core/browser/host_content_settings_map.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/components/cryptauth/ble/ble_advertisement_generator_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/components/cryptauth/cryptauth_device_manager_impl_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/components/cryptauth/cryptauth_enrollment_manager_impl_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/components/cryptauth/device_capability_manager_impl.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/components/cryptauth/local_device_data_provider_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/components/metrics/net/network_metrics_provider_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/components/offline_pages/core/prefetch/suggested_articles_observer_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/components/rappor/rappor_service_impl.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/components/sync_preferences/pref_service_syncable_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/extensions/browser/shared_user_script_master.h
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/extensions/shell/browser/shell_navigation_ui_data.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/headless/lib/browser/devtools_api/domain_type_conversions_h.template
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/media/renderers/video_renderer_impl_unittest.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/mojo/public/cpp/bindings/message.h
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/remoting/ios/display/gl_display_handler.h
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/storage/browser/blob/blob_reader.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/third_party/dom_distiller_js/protoc_plugins/json_values_converter.py
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/third_party/dom_distiller_js/test_sample_json_converter.h.golden
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/ui/gl/gl_fence.h
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/ui/gl/gl_fence_android_native_fence_sync.cc
[modify] https://crrev.com/e6533c7b5483ceea50c6e899ed0b0097d5553a25/ui/gl/gl_fence_egl.cc

Project Member

Comment 118 by bugdroid1@chromium.org, Apr 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2b78049f6189f83391cb19d4533ec867d735694

commit e2b78049f6189f83391cb19d4533ec867d735694
Author: Jeremy Roman <jbroman@chromium.org>
Date: Sat Apr 07 02:48:13 2018

Remove unnecessary includes of base/memory/ptr_util.h in chrome/.

It no longer defines base::MakeUnique, so it should only be included
where base::WrapUnique is used.

Generated by:
  for x in `git grep -l '#include "base/memory/ptr_util.h"' chrome`; do \
    grep -q WrapUnique "$x" || sed -i -e \
    '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done

Bug: 755727
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I965e46aab6b3ffbc092f3318a0e999768a5984d6
Reviewed-on: https://chromium-review.googlesource.com/954013
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549018}
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/android/compositor/layer/tab_layer.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/android/contextualsearch/unhandled_tap_notifier_impl.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/android/contextualsearch/unhandled_tap_web_contents_observer.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/android/locale/special_locale_handler.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/android/ntp/content_suggestions_notifier_service.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/android/preferences/pref_change_registrar_android.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/android/vr/vr_dialog.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/android/webapk/webapk_update_manager.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/app_controller_mac.mm
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/autocomplete/chrome_autocomplete_provider_client_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/autocomplete/search_provider_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/autocomplete/shortcuts_backend_factory.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/background/background_application_list_model.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/background/background_application_list_model_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/background/background_contents_service.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/background/background_mode_manager.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/banners/app_banner_manager_browsertest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/banners/app_banner_settings_helper.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/bookmarks/bookmark_model_factory.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/bookmarks/chrome_bookmark_client.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/bookmarks/managed_bookmark_service_factory.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/bookmarks/managed_bookmark_service_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/browser_process_impl_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/browser_process_platform_part_chromeos.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/browser_process_platform_part_win.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/browsing_data/browsing_data_channel_id_helper_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/browsing_data/browsing_data_cookie_helper.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_factory.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/browsing_data/counters/browsing_data_counter_factory.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/browsing_data/counters/hosted_apps_counter.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/browsing_data/counters/media_licenses_counter.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/browsing_data/counters/media_licenses_counter_browsertest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/budget_service/budget_manager.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/budget_service/budget_manager_factory.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/budget_service/budget_manager_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/budget_service/budget_service_impl.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/cache_stats_recorder.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chrome_content_browser_client_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/arc/cast_receiver/arc_cast_receiver_service.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/drive/drive_file_stream_reader.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/events/event_rewriter_controller.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/file_system_provider/extension_provider.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/file_system_provider/fake_extension_provider.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/file_system_provider/registry_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/fileapi/recent_download_source.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/hats/hats_notification_controller.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/login/easy_unlock/chrome_proximity_auth_client.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/login/hid_detection_browsertest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/login/login_manager_test.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/login/quick_unlock/quick_unlock_storage.h
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/login/session/chrome_session_manager.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/login/users/multi_profile_user_controller.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/login/version_info_updater.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/login/webview_login_browsertest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/net/client_cert_store_chromeos.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/net/network_throttling_observer.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/platform_keys/platform_keys.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/policy/active_directory_policy_manager.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/policy/off_hours/off_hours_policy_applier_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/policy/user_cloud_external_data_manager_browsertest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/power/ml/idle_event_notifier_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/printing/external_printers.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/printing/specifics_translation_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/printing/synced_printers_manager.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/printing/zeroconf_printer_detector_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/resource_reporter/resource_reporter.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/smb_client/smb_file_system.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/smb_client/smb_service_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/system_logs/touch_log_source.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/client_hints/client_hints.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/command_updater_impl.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/component_updater/cros_component_installer_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/component_updater/optimization_hints_component_installer_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/component_updater/origin_trials_component_installer_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/conflicts/module_database_win_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/conflicts/module_event_sink_impl_win.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/conflicts/module_event_sink_impl_win_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/conflicts/module_info_win.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/content_settings/content_settings_default_provider_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/content_settings/local_shared_objects_container.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/custom_handlers/protocol_handler_registry.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/devtools/device/adb/mock_adb_server.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/devtools/device/devtools_android_bridge.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/devtools/device/usb/android_usb_browsertest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/devtools/device/usb/android_usb_device.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/devtools/devtools_file_helper.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/devtools/devtools_sanity_interactive_browsertest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/devtools/devtools_targets_ui.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/devtools/devtools_window.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/devtools/global_confirm_info_bar_browsertest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/devtools/remote_debugging_server.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/devtools/serialize_host_descriptions.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/diagnostics/recon_diagnostics.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/diagnostics/sqlite_diagnostics.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/domain_reliability/browsertest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/download/default_download_dir_policy_handler.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/download/download_danger_prompt_browsertest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/download/download_dir_policy_handler.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/download/download_history_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/download/download_query_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/download/download_service_factory.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/download/download_status_updater_mac.mm
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/download/download_status_updater_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/download/download_target_determiner_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/download/download_ui_controller_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/download/notification/download_notification_manager.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/engagement/important_sites_util.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/engagement/site_engagement_score.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/engagement/site_engagement_service.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/engagement/site_engagement_service_android.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/extensions/api/cast_streaming/performance_test.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/extensions/api/file_system/consent_provider.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/extensions/api/file_system/file_entry_picker.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/extensions/api/identity/identity_api.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/extensions/api/networking_cast_private/chrome_networking_cast_private_delegate.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/extensions/api/notifications/extension_notification_display_helper.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/extensions/api/omnibox/omnibox_api.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/extensions/api/page_capture/page_capture_api.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/extensions/api/preference/preference_api_prefs_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/extensions/api/tab_capture/offscreen_tab.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/extensions/content_script_apitest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/extensions/pack_extension_job.h
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/extensions/policy_extension_reinstaller.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/feedback/system_logs/about_system_logs_fetcher.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/feedback/system_logs/chrome_system_logs_fetcher.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/file_select_helper.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/font_pref_change_notifier_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/gcm/gcm_profile_service_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/history/android/sqlite_cursor_unittest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/history/chrome_history_backend_client.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/history/chrome_history_client.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/history/history_service_factory.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/icon_loader_auralinux.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/icon_loader_chromeos.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/icon_loader_mac.mm
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/icon_loader_win.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/importer/external_process_importer_client.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/importer/ie_importer_browsertest_win.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/importer/in_process_importer_bridge.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/importer/profile_writer.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/installable/installable_manager_browsertest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/installable/installable_metrics.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/io_thread.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/io_thread_browsertest.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/local_discovery/service_discovery_client_mdns.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/media/android/cdm/media_drm_storage_factory.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/media/media_engagement_score.h
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/media/platform_verification_impl.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/media/public_session_media_access_handler.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/media/public_session_tab_capture_access_handler.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/media/router/discovery/dial/dial_app_discovery_service.cc
[modify] https://crrev.com/e2b78049f6189f83391cb19d4533ec867d735694/chrome/browser/media/router/discovery/mdns/cast_media_sink_service.cc
[modify] https://crrev.com/e2b78049
Project Member

Comment 119 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/186074b98562b34bf27ceab75a9167d3561488aa

commit 186074b98562b34bf27ceab75a9167d3561488aa
Author: Jeremy Roman <jbroman@chromium.org>
Date: Mon Apr 09 16:26:26 2018

Remove unnecessary includes of base/memory/ptr_util.h in extensions/.

It no longer defines base::MakeUnique, so it should only be included
where base::WrapUnique is used.

Generated by:
  for x in `git grep -l '#include "base/memory/ptr_util.h"' extensions`; do \
    grep -q WrapUnique "$x" || sed -i -e \
    '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done

Bug: 755727
Change-Id: I28ad1f38f58669b14b5dde345cf84249e79ad9b8
Reviewed-on: https://chromium-review.googlesource.com/1000427
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549194}
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/alarms/alarms_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/app_runtime/app_runtime_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/audio/audio_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/audio/audio_service_chromeos.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/bluetooth/bluetooth_event_router_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/cast_channel/cast_channel_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/clipboard/clipboard_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/declarative/rules_cache_delegate.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/declarative/rules_registry_service.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/declarative_net_request/indexed_rule_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/extensions_api_client.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/feedback_private/feedback_private_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/feedback_private/feedback_private_api_chromeos_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/feedback_private/feedback_private_api_unittest_base_chromeos.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/feedback_private/log_source_access_manager.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/file_system/file_system_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/hid/hid_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/hid/hid_device_manager.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/idle/idle_api_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/idle/idle_manager.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/lock_screen_data/data_item.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/lock_screen_data/data_item_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/lock_screen_data/lock_screen_item_storage.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/lock_screen_data/lock_screen_item_storage_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/lock_screen_data/lock_screen_value_store_migrator_impl_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/media_perception_private/conversion_utils.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/media_perception_private/conversion_utils_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/media_perception_private/media_perception_api_manager_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/media_perception_private/media_perception_private_apitest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/messaging/extension_message_port.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/messaging/message_service.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/metrics_private/metrics_private_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/mime_handler_private/mime_handler_private.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/networking_config/networking_config_service.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/networking_config/networking_config_service_factory.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/networking_private/networking_private_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/networking_private/networking_private_linux.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/runtime/runtime_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/serial/serial_connection.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/socket/socket_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/sockets_tcp/sockets_tcp_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/sockets_tcp/sockets_tcp_api_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/sockets_udp/sockets_udp_api_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/storage/settings_test_util.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/storage/storage_api_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/system_display/system_display_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/system_storage/system_storage_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/system_storage/system_storage_apitest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/test/test_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/usb/usb_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/usb/usb_apitest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/vpn_provider/vpn_provider_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/web_request/web_request_api_helpers.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/web_request/web_request_event_details.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/webcam_private/visca_webcam_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/api_test_utils.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/app_window/app_window.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/app_window/app_window_geometry_cache.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/app_window/app_window_geometry_cache_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/computed_hashes.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/content_hash_fetcher_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/content_verifier/content_hash.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/content_verify_job_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/declarative_user_script_manager.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/declarative_user_script_master.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/error_map.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/event_listener_map_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/event_router.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/event_router_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/events/lazy_event_dispatch_util.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/events/lazy_event_dispatcher.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/extension_function.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/extension_icon_image_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/extension_icon_placeholder.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/extension_prefs.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/extension_protocols.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/extension_throttle_manager.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/extensions_test.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/guest_view/extension_view/extension_view_guest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/guest_view/web_view/web_view_find_helper.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/guest_view/web_view/web_view_guest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/guest_view/web_view/web_view_permission_helper.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/lazy_background_task_queue.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/lazy_background_task_queue_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/load_monitoring_extension_host_queue_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/preload_check_group_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/preload_check_test_util.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/process_manager_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/quota_service_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/renderer_startup_helper_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/requirements_checker_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/shared_user_script_master.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/user_script_loader.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/value_store/legacy_value_store_factory.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/value_store/testing_value_store.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/value_store/value_store_change.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/value_store/value_store_change_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/value_store/value_store_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/browser/view_type_utils.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/api/declarative_net_request/dnr_manifest_handler.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/api/printer_provider/usb_printer_manifest_data.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/event_filter.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/event_filter_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/extension_builder.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/extension_l10n_util.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/extension_l10n_util_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/extension_set_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/features/feature_provider_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/features/feature_session_type.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/file_util_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/manifest_handlers/action_handlers_handler.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/manifest_handlers/app_isolation_info.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/manifest_handlers/content_scripts_handler.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/manifest_handlers/csp_info.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/manifest_handlers/incognito_info.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/manifest_handlers/kiosk_mode_info.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/manifest_handlers/oauth2_manifest_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/manifest_handlers/offline_enabled_info.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/manifest_handlers/permissions_parser.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/message_bundle_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/permissions/manifest_permission_set_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/permissions/mock_manifest_permission.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/permissions/settings_override_permission.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/permissions/usb_device_permission.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/url_pattern_set.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/user_script_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/value_builder.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/common/value_counter.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/api_activity_logger_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/api_binding.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/api_binding_hooks.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/api_binding_test.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/api_binding_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/api_bindings_system.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/api_bindings_system_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/api_event_handler.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/api_event_handler_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/api_event_listeners.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/api_request_handler.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/api_request_handler_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/api_signature.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/api_signature_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/argument_spec.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/argument_spec_builder.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/argument_spec_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/declarative_event.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/declarative_event_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/event_emitter_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/exception_handler.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/bindings/test_js_runner.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/chrome_setting.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/content_setting.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/declarative_content_hooks_delegate.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/event_bindings.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/feature_cache_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/js_extension_bindings_system.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/messaging_bindings.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/module_system_test.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/native_extension_bindings_system.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/request_sender.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/script_injection.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/script_injection_manager.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/storage_area.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/user_script_set_manager.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/wake_event_page.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/renderer/worker_thread_dispatcher.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/shell/browser/api/identity/identity_api.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/shell/browser/root_window_controller_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/shell/browser/shell_desktop_controller_aura.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/shell/browser/shell_extension_system.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/shell/browser/shell_extensions_api_client.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/shell/browser/shell_native_app_window_aura_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/shell/browser/shell_navigation_ui_data.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/shell/browser/shell_oauth2_token_service.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/shell/browser/shell_oauth2_token_service_unittest.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/shell/browser/shell_url_request_context_getter.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/shell/browser/system_logs/log_sources/basic_log_source.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/shell/browser/system_logs/shell_system_logs_fetcher.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/shell/renderer/shell_extensions_renderer_client.cc
[modify] https://crrev.com/186074b98562b34bf27ceab75a9167d3561488aa/extensions/test/test_content_utility_client.cc

Project Member

Comment 120 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/553e64434b37353f950810d9f21c50ca89558213

commit 553e64434b37353f950810d9f21c50ca89558213
Author: Jeremy Roman <jbroman@chromium.org>
Date: Wed Apr 11 13:30:41 2018

Remove unnecessary includes of base/memory/ptr_util.h in services/.

It no longer defines base::MakeUnique, so it should only be included
where base::WrapUnique is used.

Generated by:
  for x in `git grep -l '#include "base/memory/ptr_util.h"' services`; do \
    grep -q WrapUnique "$x" || sed -i -e \
    '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done

Bug: 755727
Tbr: rsesek@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I878e7960b4cd4f0b9fdc58f65cf8d17741d0441a
Reviewed-on: https://chromium-review.googlesource.com/1005840
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549869}
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/audio/sync_reader.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/catalog/catalog.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/catalog/entry.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/catalog/public/tools/catalog.cc.tmpl
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/data_decoder/data_decoder_service.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/data_decoder/json_parser_impl.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/battery/battery_monitor_impl_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/battery/battery_status_manager_chromeos.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/battery/battery_status_manager_default.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/battery/battery_status_manager_mac.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/battery/battery_status_manager_win.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/battery/battery_status_service_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/device_service.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/device_service_test_base.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/generic_sensor/absolute_orientation_euler_angles_fusion_algorithm_using_accelerometer_and_magnetometer_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/generic_sensor/linear_acceleration_fusion_algorithm_using_accelerometer_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/generic_sensor/orientation_euler_angles_fusion_algorithm_using_quaternion_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/generic_sensor/orientation_quaternion_fusion_algorithm_using_euler_angles_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/generic_sensor/platform_sensor.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/generic_sensor/platform_sensor_and_provider_unittest_win.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/generic_sensor/platform_sensor_fusion_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/generic_sensor/platform_sensor_provider_android.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/generic_sensor/platform_sensor_provider_linux.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/generic_sensor/platform_sensor_provider_mac.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/generic_sensor/platform_sensor_provider_win.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/generic_sensor/platform_sensor_reader_linux.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/generic_sensor/relative_orientation_euler_angles_fusion_algorithm_using_accelerometer_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/hid/hid_connection_impl.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/hid/hid_connection_linux.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/hid/hid_connection_win.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/hid/hid_manager_impl.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/hid/hid_service_linux.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/power_monitor/power_monitor_message_broadcaster.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/serial/serial_device_enumerator_impl.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/serial/serial_io_handler_impl.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/time_zone_monitor/time_zone_monitor_fuchsia.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/time_zone_monitor/time_zone_monitor_linux.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/vibration/vibration_manager_impl_default.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/device/wake_lock/wake_lock.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/file/file_service.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/file/file_system.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/identity/public/cpp/identity_manager.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/identity/public/cpp/primary_account_access_token_fetcher_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/metrics/metrics_mojo_service.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/metrics/public/cpp/ukm_recorder.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/metrics/ukm_recorder_interface.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/network/http_cache_data_remover.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/network/http_cache_data_remover_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/network/ignore_errors_cert_verifier.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/network/network_context_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/network/proxy_resolver_factory_mojo.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/network/proxy_resolver_factory_mojo_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/network/proxy_service_mojo.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/network/public/cpp/simple_url_loader.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/network/public/cpp/simple_url_loader_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/network/resource_scheduler.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/network/resource_scheduler_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/network/restricted_cookie_manager.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/network/socket_factory.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/network/tcp_connected_socket.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/network/udp_socket.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/network/websocket.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/persistent_pref_store_impl.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/persistent_pref_store_impl_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/pref_service_factory_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/pref_store_consistency_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/pref_store_impl_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/public/cpp/dictionary_value_update.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/public/cpp/in_process_service_factory.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/public/cpp/lib/util.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/public/cpp/scoped_pref_update.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/public/cpp/tests/persistent_pref_store_client_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/public/cpp/tests/pref_store_client_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/tracked/dictionary_hash_store_contents.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/tracked/interceptable_pref_filter_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/tracked/pref_hash_calculator_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/tracked/pref_hash_filter.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/tracked/pref_hash_filter_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/tracked/registry_hash_store_contents_win_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/tracked/segregated_pref_store_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/preferences/tracked/tracked_preferences_migration.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/proxy_resolver/proxy_resolver_factory_impl.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/proxy_resolver/proxy_resolver_factory_impl_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/proxy_resolver/proxy_resolver_impl.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/background/background_service_manager.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/background/tests/background_service_manager_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/embedder/embedded_instance_manager.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/embedder/embedded_instance_manager_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/embedder/main.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/embedder/manifest_utils.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/embedder/manifest_utils_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/public/cpp/binder_registry.h
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/public/cpp/connector.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/public/cpp/service_context_ref.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/public/cpp/service_test.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/sandbox/linux/bpf_gpu_policy_linux.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/sandbox/linux/bpf_network_policy_linux.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/sandbox/linux/sandbox_linux.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/standalone/context.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/tests/connect/connect_test_exe.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/tests/connect/connect_test_package.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/tests/connect/connect_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/tests/lifecycle/package.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/tests/service_manager/embedder.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/service_manager/tests/service_manager/target.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/demo/mus_demo.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/demo/window_tree_data.h
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/display/screen_manager_ozone_internal.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/display/screen_manager_ozone_internal_unittests.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/display/screen_manager_stub_internal.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ime/ime_driver_bridge.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ime/test_ime_driver/test_ime_application.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/public/cpp/input_devices/input_device_controller_client.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/service.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/test_wm/test_wm.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/cursor_state.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/display.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/display_manager.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/drag_controller_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/event_processor.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/event_processor_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/event_targeter.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/focus_controller.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/gpu_host.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/gpu_host_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/modal_window_controller.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/platform_display.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/platform_display_default.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/server_window.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/test_utils.h
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/user_activity_monitor_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/window_manager_client_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/window_manager_state_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/window_server_service_test_base.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/window_server_test_base.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/ui/ws2/window_tree_client_unittest.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/video_capture/device_factory_media_to_mojo_adapter.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/video_capture/device_factory_provider_impl.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/video_capture/device_media_to_mojo_adapter.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/video_capture/test/mock_device_factory.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/video_capture/test/mock_device_test.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/video_capture/virtual_device_enabled_device_factory.cc
[modify] https://crrev.com/553e64434b37353f950810d9f21c50ca89558213/services/video_capture/virtual_device_mojo_adapter.cc

Project Member

Comment 121 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01ebde12a03d5b0d79a255b14304fd4ad12fe485

commit 01ebde12a03d5b0d79a255b14304fd4ad12fe485
Author: Jeremy Roman <jbroman@chromium.org>
Date: Wed Apr 11 13:39:25 2018

Remove unnecessary includes of base/memory/ptr_util.h in components/.

It no longer defines base::MakeUnique, so it should only be included
where base::WrapUnique is used.

Generated by:
  for x in `git grep -l '#include "base/memory/ptr_util.h"' components`; do \
    grep -q WrapUnique "$x" || sed -i -e \
    '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done

Bug: 755727
Tbr: dcheng@chromium.org
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ieee129f09e26c25487f68845c510a683aef2fd33
Reviewed-on: https://chromium-review.googlesource.com/1005803
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549871}
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/assist_ranker/base_predictor.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/autofill/android/autofill_provider_android.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/autofill/core/browser/address_normalization_manager.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/autofill/core/browser/autofill_credit_card_filling_infobar_delegate_mobile.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/autofill/core/browser/autofill_credit_card_policy_handler_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/autofill/core/browser/autofill_profile_validation_util.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/autofill/core/browser/autofill_wallet_data_type_controller_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/autofill/core/browser/region_combobox_model_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/autofill/core/browser/webdata/autocomplete_sync_bridge_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/autofill/ios/browser/autofill_agent.mm
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/browser_watcher/stability_report_user_stream_data_source.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/browsing_data/core/counters/bookmark_counter.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/cast_certificate/cast_crl.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/cast_channel/cast_auth_util.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/cast_channel/logger.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/certificate_transparency/log_dns_client.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/content_settings/core/common/content_settings.h
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/content_settings/core/common/content_settings_struct_traits.h
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/contextual_search/renderer/overlay_js_render_frame_observer.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/cronet/android/test/mock_url_request_job_factory.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/cronet/host_cache_persistence_manager.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/cronet/stale_host_resolver.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/cryptauth/device_capability_manager_impl.h
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/cryptauth/device_to_device_initiator_helper.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/cryptauth/fake_authenticator.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/cryptauth/local_device_data_provider.h
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/cryptauth/mock_local_device_data_provider.h
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/data_reduction_proxy/content/browser/data_reduction_proxy_pingback_client_impl_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/dom_distiller/ios/distiller_page_ios.mm
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/download/internal/background_service/config.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/download/internal/background_service/controller_impl.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/download/internal/background_service/entry_utils_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/download/internal/background_service/file_monitor_impl.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/download/internal/background_service/logger_impl.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/download/internal/common/download_file_impl.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/download/internal/common/download_file_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/download/internal/common/download_job_factory.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/download/internal/common/parallel_download_job.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/download/internal/common/parallel_download_job_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/download/public/background_service/download_service.h
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/drive/drive_uploader_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/encrypted_messages/message_encrypter.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/exo/buffer.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/exo/client_controlled_shell_surface.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/exo/data_offer_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/exo/shared_memory.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/exo/shared_memory_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/exo/sub_surface_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/exo/surface_tree_host.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/exo/test/exo_test_base.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/exo/wayland/clients/client_base.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/exo/wayland/clients/rects.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/exo/wm_helper.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/feature_engagement/internal/chrome_variations_configuration.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/history/core/browser/history_model_worker_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/history/core/browser/visit_tracker.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/history/core/test/history_service_test_util.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/image_fetcher/ios/ios_image_data_fetcher_wrapper.mm
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/metrics/metrics_service.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/metrics/reporting_service.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/mirroring/browser/cast_remoting_sender_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/navigation_interception/intercept_navigation_throttle_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/network_time/network_time_tracker_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/ntp_snippets/breaking_news/subscription_json_request_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/ntp_snippets/content_suggestions_service.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/ntp_snippets/contextual/contextual_content_suggestions_service.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/ntp_snippets/contextual/contextual_json_request_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/ntp_snippets/remote/remote_suggestion_builder.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/ntp_tiles/icon_cacher_impl.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/offline_items_collection/core/offline_content_aggregator.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/offline_items_collection/core/offline_content_aggregator_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/offline_items_collection/core/throttled_offline_content_provider_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/offline_pages/core/downloads/download_notifying_observer_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/offline_pages/core/prefetch/download_cleanup_task.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/offline_pages/core/prefetch/generate_page_bundle_reconcile_task.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/offline_pages/core/prefetch/metrics_finalization_task.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/offline_pages/core/prefetch/prefetch_downloader_impl_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/offline_pages/core/prefetch/prefetch_gcm_app_handler.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/offline_pages/core/prefetch/prefetch_service_impl.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/offline_pages/core/prefetch/test_prefetch_network_request_factory.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/pairing/bluetooth_host_pairing_controller.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/payments/content/android/payment_manifest_downloader_android.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/payments/content/android/payment_manifest_parser_android.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/payments/content/payment_request.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/payments/content/payment_request_converter.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/payments/content/payment_request_display_manager.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/payments/content/utility/payment_manifest_parser.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/payments/core/can_make_payment_query.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/payments/core/payment_manifest_downloader.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/payments/core/payments_profile_comparator_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/physical_web/data_source/fake_physical_web_data_source.h
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/policy/core/browser/configuration_policy_handler_list.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/policy/core/common/cloud/cloud_policy_validator_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/policy/core/common/cloud/machine_level_user_cloud_policy_store.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/policy/core/common/policy_map.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/policy/core/common/policy_test_utils.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/prefs/pref_registry.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/prefs/testing_pref_service.h
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/previews/content/previews_io_data.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/previews/core/previews_logger.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/previews/core/previews_logger.h
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/previews/core/previews_user_data_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/safe_browsing/db/database_manager_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/safe_browsing/db/v4_get_hash_protocol_manager_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/safe_browsing/db/v4_store_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/safe_browsing/db/v4_update_protocol_manager.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/safe_browsing/db/whitelist_checker_client.h
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/security_interstitials/core/mitm_software_ui.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/security_state/ios/ssl_status_input_event_data.h
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/services/filesystem/file_system_impl.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/services/heap_profiling/connection_manager.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/sessions/content/content_platform_specific_tab_data.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/signin/core/browser/child_account_info_fetcher_android.h
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/signin/core/browser/fake_gaia_cookie_manager_service.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/spellcheck/browser/spell_check_host_impl.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/spellcheck/renderer/spellcheck_provider_test.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/suggestions/suggestions_service_impl.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/suggestions/suggestions_store_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/tracing/test/heap_profiler_perftest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/translate/core/browser/translate_manager_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/translate/core/browser/translate_ui_delegate_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/ukm/ukm_reporting_service.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/ukm/ukm_service.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/update_client/update_checker_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/update_client/updater_state_win.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/visitedlink/test/visitedlink_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/common/frame_sinks/begin_frame_source.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/common/frame_sinks/copy_output_request.h
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/common/frame_sinks/delay_based_time_source.h
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/common/gpu/context_cache_controller_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/common/gpu/in_process_context_provider.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/service/display/bsp_tree.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/service/display/draw_polygon.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/service/display/draw_polygon_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/service/display/software_renderer.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/service/display/software_renderer_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/service/display_embedder/gl_output_surface.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/service/display_embedder/gl_output_surface_buffer_queue.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/service/frame_sinks/referenced_surface_tracker_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/service/frame_sinks/surface_references_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/service/surfaces/surface_unittest.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/test/test_context_provider.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/test/test_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/viz/test/test_shared_bitmap_manager.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/web_resource/web_resource_service.cc
[modify] https://crrev.com/01ebde12a03d5b0d79a255b14304fd4ad12fe485/components/webcrypto/algorithms/sha.cc

Project Member

Comment 122 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dfbfecd30ba802743e3a86009c533508ae31b52

commit 8dfbfecd30ba802743e3a86009c533508ae31b52
Author: Jeremy Roman <jbroman@chromium.org>
Date: Wed Apr 11 17:35:53 2018

Remove unnecessary includes of base/memory/ptr_util.h in content/.

It no longer defines base::MakeUnique, so it should only be included
where base::WrapUnique is used.

Generated by:
  for x in `git grep -l '#include "base/memory/ptr_util.h"' content`; do \
    grep -q WrapUnique "$x" || sed -i -e \
    '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done

Bug: 755727
Tbr: mkwst@chromium.org
Change-Id: Ie2a34ff8f0fe83491185cd9f1a0aa52aa21829bb
Reviewed-on: https://chromium-review.googlesource.com/1005834
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549918}
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/app/android/content_main.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/accessibility/accessibility_tree_formatter.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/accessibility/accessibility_tree_formatter_auralinux.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/accessibility/accessibility_tree_formatter_blink.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/accessibility/accessibility_tree_formatter_browser.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/accessibility/accessibility_tree_formatter_win.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/accessibility/accessibility_win_browsertest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/android/java/gin_java_bridge_dispatcher_host.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/android/java/gin_java_bridge_message_filter.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/android/java/gin_java_method_invocation_helper.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/android/java/gin_java_method_invocation_helper_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/android/java/gin_java_script_to_java_types_coercion.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/android/overscroll_controller_android.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/android/overscroll_controller_android_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/android/selection/smart_selection_client.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/android/synchronous_compositor_browser_filter.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/appcache/appcache_backend_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/appcache/appcache_request_handler_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/appcache/appcache_storage_impl_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/background_fetch/background_fetch_delegate_proxy.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/background_fetch/background_fetch_job_controller.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/background_fetch/background_fetch_service_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/background_fetch/background_fetch_test_base.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/blob_storage/blob_url_loader_factory.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/blob_storage/blob_url_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/bluetooth/frame_connected_bluetooth_devices.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/bluetooth/frame_connected_bluetooth_devices_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/browser_child_process_host_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/browsing_data/browsing_data_filter_builder_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/browsing_data/browsing_data_remover_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/browsing_data/clear_site_data_throttle_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/cache_storage/cache_storage_blob_to_disk_cache_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/cache_storage/cache_storage_operation_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/cache_storage/cache_storage_scheduler.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/child_process_launcher_helper_mac.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/child_process_security_policy_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/compositor/browser_compositor_output_surface.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/compositor/reflector_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/compositor/reflector_impl_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/cross_site_transfer_browsertest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/device_sensors/device_sensor_browsertest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/devtools/devtools_interceptor_controller.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/devtools/devtools_io_context.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/devtools/devtools_manager.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/devtools/devtools_pipe_handler.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/devtools/devtools_url_request_interceptor.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/devtools/protocol/system_info_handler.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/devtools/protocol/tethering_handler.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/dom_storage/dom_storage_context_wrapper.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/dom_storage/local_storage_context_mojo.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/download/download_request_core.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/download/download_request_core_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/download/download_utils.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/download/save_file_manager.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/field_trial_recorder.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/frame_host/data_url_navigation_throttle.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/frame_host/render_frame_host_manager_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/gpu/gpu_internals_ui.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/gpu/gpu_ipc_browsertests.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/host_zoom_map_impl_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/hyphenation/hyphenation_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/image_capture/image_capture_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/cursor_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/database_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/indexed_db_active_blob_registry_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/indexed_db_callbacks.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/indexed_db_database_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/indexed_db_dispatcher_host.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/indexed_db_dispatcher_host_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/indexed_db_factory_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/indexed_db_factory_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/indexed_db_index_writer.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/indexed_db_leveldb_coding.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/indexed_db_tombstone_sweeper_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/indexed_db_transaction.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/indexed_db_transaction_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/indexed_db_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/leveldb/leveldb_transaction_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/indexed_db/list_set_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/leveldb_wrapper_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/cross_site_document_resource_handler_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/detachable_resource_handler.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/detachable_resource_handler_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/downloaded_temp_file_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/intercepting_resource_handler.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/intercepting_resource_handler_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/mime_sniffing_resource_handler_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/mock_resource_loader.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/navigation_url_loader.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/navigation_url_loader_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/redirect_to_file_resource_handler_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/resource_dispatcher_host_browsertest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/resource_hints_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/resource_requester_info.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/resource_scheduler_browsertest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/test_resource_handler.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/upload_data_stream_builder.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/url_loader_factory_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/loader/url_loader_factory_impl_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/manifest/manifest_manager_host.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/media/android/browser_media_player_manager.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/media/capture/cursor_renderer.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/media/capture/cursor_renderer_aura.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/media/capture/cursor_renderer_mac.mm
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/media/capture/cursor_renderer_mac_unittest.mm
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/media/capture/fake_webcontent_capture_machine.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/media/capture/screen_capture_device_android.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/media/capture/screen_capture_device_android_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/media/media_internals_ui.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/media/midi_host.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/media/session/audio_focus_manager.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/media/session/media_session_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/media/session/media_session_impl_service_routing_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/media/url_provision_fetcher.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/memory/memory_coordinator_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/memory/memory_coordinator_impl_browsertest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/memory/memory_coordinator_impl_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/memory/memory_monitor_chromeos.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/memory/memory_monitor_linux.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/mime_registry_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/net/network_quality_observer_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/payments/payment_app_database.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/permissions/permission_service_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/plugin_private_storage_helper.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/posix_file_descriptor_info_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/ppapi_plugin_process_host.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/push_messaging/push_messaging_manager.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/compositor_resize_lock_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/input/input_router_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/input/input_router_impl_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/input/legacy_input_router_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/input/passthrough_touch_event_queue.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/input/synthetic_pointer_driver.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/input/touch_timeout_handler.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/audio_input_delegate_impl_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/audio_input_renderer_host_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/audio_output_authorization_handler.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/audio_output_authorization_handler_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/audio_output_delegate_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/audio_output_delegate_impl_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/audio_renderer_host_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/in_process_video_capture_provider.h
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/media_devices_dispatcher_host.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/renderer_audio_output_stream_factory_context_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/video_capture_controller.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/video_capture_controller_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/video_capture_host.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/video_capture_manager.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/video_capture_manager_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/media/video_capture_provider.h
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/offscreen_canvas_provider_impl_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/offscreen_canvas_surface_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/p2p/socket_dispatcher_host.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/p2p/socket_host_udp_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/pepper/pepper_socket_utils.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/pepper/pepper_vpn_provider_message_filter_chromeos.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c533508ae31b52/content/browser/renderer_host/render_process_host_unittest.cc
[modify] https://crrev.com/8dfbfecd30ba802743e3a86009c5335
Project Member

Comment 123 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cfcdb1f7b704815da152c8b496309c652af043c

commit 1cfcdb1f7b704815da152c8b496309c652af043c
Author: Jeremy Roman <jbroman@chromium.org>
Date: Thu Apr 12 17:02:45 2018

Remove unnecessary includes of base/memory/ptr_util.h in cc/ and gpu/.

It no longer defines base::MakeUnique, so it should only be included
where base::WrapUnique is used.

Generated by:
  for x in `git grep -l '#include "base/memory/ptr_util.h"' cc gpu`; do \
    grep -q WrapUnique "$x" || sed -i -e \
    '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done

Bug: 755727
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5e19711f9932ba6ef30c8361fd62387bfab507ac
Reviewed-on: https://chromium-review.googlesource.com/1007894
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550245}
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/animation/animation_host.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/animation/element_animations.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/animation/keyframe_model_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/animation/scroll_offset_animations_impl.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/animation/transform_operations_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/animation/worklet_animation.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/benchmarks/invalidation_benchmark.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/benchmarks/micro_benchmark_controller.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/blink/web_compositor_support_impl.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/blink/web_content_layer_impl.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/blink/web_scrollbar_layer_impl.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/input/browser_controls_offset_manager_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/layer_impl.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/layer_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/nine_patch_generator.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/picture_layer_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/recording_source_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/scrollbar_layer_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/surface_layer.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/texture_layer.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/touch_action_region.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/ui_resource_layer.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/discardable_image_map.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/display_item_list.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/display_item_list_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/paint_image_builder.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/paint_recorder.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/paint_shader.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/record_paint_canvas.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/skia_paint_canvas.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/raster/bitmap_raster_buffer_provider.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/raster/one_copy_raster_buffer_provider.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/raster/playback_image_provider.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/raster/raster_buffer_provider_perftest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/raster/raster_buffer_provider_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/raster/staging_buffer_pool.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/resources/resource_pool.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/resources/video_resource_updater_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/scheduler/scheduler.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/fake_painted_scrollbar_layer.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/fake_tile_manager.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/fake_tile_task_manager.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/layer_tree_pixel_resource_test.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/layer_tree_pixel_test.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/pixel_test.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/push_properties_counting_layer_impl.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/scheduler_test_common.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/skia_common.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/test_in_process_context_provider.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/checker_image_tracker.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/checker_image_tracker_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/eviction_tile_priority_queue.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/picture_layer_tiling.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/picture_layer_tiling_set_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/raster_tile_priority_queue_all.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/tile_manager.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/tile_manager_perftest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/clip_node.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_host_pixeltest_scrollbars.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_host_unittest_copyrequest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_host_unittest_scroll.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/mutator_host.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/proxy_impl.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/proxy_main.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/swap_promise_manager_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/client/client_discardable_manager.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/client/cmd_buffer_helper_test.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/client/fenced_allocator_test.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/client/mapped_memory_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/client/query_tracker.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/client/ring_buffer_test.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/command_buffer_service.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/command_buffer_service_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/context_group.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/gpu_tracer_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/mailbox_manager_factory.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/mailbox_manager_sync.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/mailbox_manager_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/scheduler.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/scheduler_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/sync_point_manager.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/sync_point_manager_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/transfer_buffer_manager_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/tests/fuzzer_main.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/tests/gl_compressed_copy_texture_CHROMIUM_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/config/gpu_control_list.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/gles2_conform_support/egl/context.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/host/shader_disk_cache.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/host/shader_disk_cache_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/service/child_window_win.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/service/direct_composition_child_surface_win.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/service/direct_composition_surface_win.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/service/gles2_command_buffer_stub.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/service/gpu_channel_manager.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/service/gpu_channel_test_common.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/service/raster_command_buffer_stub.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/tools/compositor_model_bench/render_models.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/vulkan/vulkan_descriptor_pool.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/vulkan/vulkan_shader_module.cc

Project Member

Comment 124 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b25be978af9b230ba645049fb4fe4ddc5cc8077b

commit b25be978af9b230ba645049fb4fe4ddc5cc8077b
Author: Jeremy Roman <jbroman@chromium.org>
Date: Thu Apr 12 17:24:55 2018

Remove unnecessary includes of base/memory/ptr_util.h in ui/.

It no longer defines base::MakeUnique, so it should only be included
where base::WrapUnique is used.

Generated by:
  for x in `git grep -l '#include "base/memory/ptr_util.h"' ui`; do \
    grep -q WrapUnique "$x" || sed -i -e \
    '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done

Bug: 755727
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0da214ef2afbb6d41d1a14ee21ac91df34ddb2e2
Reviewed-on: https://chromium-review.googlesource.com/1007893
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550252}
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/accessibility/ax_tree_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/accessibility/platform/ax_snapshot_node_android_platform.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/android/resources/nine_patch_resource.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/android/resources/resource.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/android/resources/resource_manager_impl_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/app_list/views/app_list_view_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/app_list/views/indicator_chip_view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/app_list/views/page_switcher.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/app_list/views/pulsing_block_view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/app_list/views/search_result_answer_card_view_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/app_list/views/search_result_list_view_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/app_list/views/search_result_page_view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/app_list/views/search_result_tile_item_list_view_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/arc/notification/arc_notification_content_view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/arc/notification/arc_notification_item_impl.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/arc/notification/arc_notification_manager_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/arc/notification/arc_notification_surface_manager_impl.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/arc/notification/arc_notification_view_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/env.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/gestures/gesture_recognizer_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/client_surface_embedder.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/drag_drop_controller_mus.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/drag_drop_controller_mus_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/input_method_mus.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/mus_context_factory.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/os_exchange_data_provider_mus_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/property_converter.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/user_activity_forwarder_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/window_tree_host_mus.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/window_tree_host_mus_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/test/aura_test_base.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/test/aura_test_helper.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/test/mus/test_window_tree_client_setup.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/window.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/window_port_for_shutdown.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/class_property_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/cocoa/menu_controller.mm
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/dragdrop/os_exchange_data_provider_builder_mac.mm
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/dragdrop/os_exchange_data_provider_factory.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/dragdrop/os_exchange_data_provider_win.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/ime/input_method_chromeos.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/ime/linux/fake_input_method_context_factory.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/l10n/l10n_util_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/models/list_model.h
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/models/list_model_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/models/tree_node_iterator_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/models/tree_node_model_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/nine_image_painter_factory.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/resource/data_pack.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/resource/resource_bundle.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/resource/resource_bundle_android.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/resource/resource_bundle_win.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/x/selection_owner.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/chromeos/events/event_rewriter_chromeos.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/chromeos/ime/candidate_window_view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/compositor/callback_layer_animation_observer_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/compositor/layer_animation_element.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/compositor/layer_animator_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/compositor/layer_owner.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/compositor/layer_owner_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/compositor/layer_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/compositor/test/test_suite.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/chromeos/display_change_observer_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/chromeos/display_configurator.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/chromeos/display_configurator_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/chromeos/touch_device_manager_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/chromeos/touch_transform_controller_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/chromeos/update_display_configuration_task_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/display_manager.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/fake_display_delegate.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/fake_display_snapshot.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/blink/compositor_thread_event_queue.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/blink/event_with_callback.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/gestures/blink/web_gesture_curve_impl.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/device/device_manager.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/device/udev/device_manager_udev.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/evdev/event_converter_test_util.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/evdev/event_factory_evdev.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/evdev/gamepad_event_converter_evdev_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/evdev/input_controller_evdev.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/evdev/touch_filter/false_touch_finder.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/gamepad/gamepad_mapping.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/gamepad/generic_gamepad_mapping.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/gamepad/generic_gamepad_mapping_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/platform/platform_event_source.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/platform/platform_event_source_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/platform/x11/x11_event_source_glib.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/platform/x11/x11_event_source_libevent.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/system_input_injector.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/test/event_generator.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/test/scoped_event_test_tick_clock.h
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/test/test_event_target.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/x/events_x_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/animation/animation.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/animation/animation_test_api.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/color_transform.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/gpu_fence_handle.h
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/image/canvas_image_source.h
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/image/mojo/image_traits_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/interpolated_transform.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/interpolated_transform_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/paint_vector_icon.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/render_text.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/render_text_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/skia_paint_util.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gl/gl_fence.h
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gl/gl_gl_api_implementation.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gl/gl_implementation.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gl/gl_surface_egl.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gl/test/run_all_unittests.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/keyboard/keyboard_controller_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/keyboard/keyboard_util_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/message_center/message_center_impl.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/native_theme/common_theme.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/cast/client_native_pixmap_factory_cast.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/cast/gl_ozone_egl_cast.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/cast/gl_surface_cast.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/common/drm_util.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/drm_display.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/drm_thread_proxy.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/drm_window.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/gbm_surfaceless.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/hardware_display_controller.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/screen_manager.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/host/drm_display_host.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/host/drm_display_host_manager.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/host/drm_overlay_manager.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/ozone_platform_gbm.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/headless/headless_surface_factory.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/headless/ozone_platform_headless.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/wayland/ozone_platform_wayland.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/wayland/wayland_touch.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/wayland/wayland_window.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/x11/ozone_platform_x11.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/x11/x11_surface_factory.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/snapshot/snapshot_aura.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/touch_selection/touch_handle_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/touch_selection/touch_selection_controller_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/accessibility/native_view_accessibility_auralinux.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/accessibility/native_view_accessibility_base.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/accessibility/native_view_accessibility_mac.mm
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/accessibility/native_view_accessibility_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/accessibility/native_view_accessibility_win.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/accessible_pane_view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/animation/ink_drop_highlight_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/animation/ink_drop_host_view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/animation/ink_drop_impl.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/animation/ink_drop_impl_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/animation/test/ink_drop_impl_test_api.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/animation/test/test_ink_drop_host.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/background.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/bubble/bubble_dialog_delegate.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/bubble/tooltip_icon.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/cocoa/bridged_native_widget.mm
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/button/label_button.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/button/toggle_button_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/image_view_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/label.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/label_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/menu/menu_controller.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/menu/menu_runner_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/menu/menu_scroll_view_container.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/menu/native_menu_win.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/scroll_view_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/textfield/textfield_model.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/tree/tree_view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/tree/tree_view_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/views_text_services_context_menu_mac.mm
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/examples/box_layout_example.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/examples/examples_window.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/examples/examples_window_with_content.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/examples/text_example.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/examples/tree_view_example.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/focus/external_focus_tracker.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/focus/focus_manager.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/focus/focus_manager_factory.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/focus/focus_manager_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/focus/focus_traversal_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/layout/layout_provider.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/mus/desktop_window_tree_host_mus.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/mus/desktop_window_tree_host_mus_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/mus/pointer_watcher_event_router_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/mus/views_mus_test_suite.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/painter.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/style/platform_style.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/style/platform_style_mac.mm
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/test/combobox_test_api.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/test/native_widget_factory_aura_mus.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/test/platform_test_helper_cocoa.mm
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/test/test_views_delegate.h
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/view_tracker_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/views_delegate.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/widget/desktop_aura/desktop_drop_target_win.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/widget/desktop_aura/x11_topmost_window_finder_interactive_uitest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/widget/native_widget_aura.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/widget/native_widget_aura_interactive_uitest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/win/pen_event_processor.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/wm/core/focus_controller_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/wm/core/window_animati
Project Member

Comment 125 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b01030721aeb92c24bb7263628245471c5dd885

commit 5b01030721aeb92c24bb7263628245471c5dd885
Author: Jeremy Roman <jbroman@chromium.org>
Date: Thu Apr 12 17:52:31 2018

Remove unnecessary includes of base/memory/ptr_util.h in third_party/blink/.

It no longer defines base::MakeUnique, so it should only be included
where base::WrapUnique is used.

Generated by:
  for x in `git grep -l '#include "base/memory/ptr_util.h"' third_party/blink`; do \
    grep -q WrapUnique "$x" || sed -i -e \
    '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done

One include was added to
  third_party/blink/renderer/platform/scheduler/main_thread/web_main_thread_scheduler.cc
which previously depended on ptr_util.h being included by one of its
headers.

Bug: 755727
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I425109636a07f0f54c0f9a1019a5633fab153722
Reviewed-on: https://chromium-review.googlesource.com/1010266
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550261}
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/common/test/run_all_unittests.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/public/platform/scheduler/test/renderer_scheduler_test_support.h
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/modules/cachestorage/InspectorCacheStorageAgent.cpp
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/modules/peerconnection/rtc_dtmf_sender.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/modules/speech/speech_recognition_client_proxy.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/graphics/video_frame_resource_provider.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/child/idle_canceled_delayed_task_sweeper_unittest.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/child/idle_helper_unittest.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/child/task_runner_impl.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/child/web_scheduler_impl.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/child/worker_global_scope_scheduler_unittest.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/common/scheduler_helper_unittest.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/common/throttling/budget_pool.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/common/throttling/cpu_time_budget_pool.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/main_thread/web_main_thread_scheduler.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/renderer/auto_advancing_virtual_time_domain.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/renderer/queueing_time_estimator.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/test/lazy_thread_controller_for_test.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/util/task_duration_metric_reporter_unittest.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler_unittest.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/wtf/text/icu/collator_icu.cc

Project Member

Comment 126 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92051612dbfede6aed168a6a6e0f89909136eef8

commit 92051612dbfede6aed168a6a6e0f89909136eef8
Author: Jeremy Roman <jbroman@chromium.org>
Date: Thu Apr 12 19:01:52 2018

Remove unnecessary includes of base/memory/ptr_util.h in net/

It no longer defines base::MakeUnique, so it should only be included
where base::WrapUnique is used.

Generated by:
  for x in `git grep -l '#include "base/memory/ptr_util.h"' net`; do \
    grep -q WrapUnique "$x" || sed -i -e \
    '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done

One include was added to net/cert/multi_threaded_cert_verifier.cc
which previously depended on ptr_util.h being included by one of its
headers.

Bug: 755727
Tbr: kerrnel@chromium.org
Change-Id: I61a99097ffab3ad39b77a6506d793c9bde54d8ef
Reviewed-on: https://chromium-review.googlesource.com/1010402
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550293}
[modify] https://crrev.com/92051612dbfede6aed168a6a6e0f89909136eef8/net/cert/multi_threaded_cert_verifier.cc
[modify] https://crrev.com/92051612dbfede6aed168a6a6e0f89909136eef8/net/dns/mojo_host_struct_traits.cc
[modify] https://crrev.com/92051612dbfede6aed168a6a6e0f89909136eef8/net/network_error_logging/network_error_logging_service.cc
[modify] https://crrev.com/92051612dbfede6aed168a6a6e0f89909136eef8/net/socket/udp_socket_unittest.cc
[modify] https://crrev.com/92051612dbfede6aed168a6a6e0f89909136eef8/net/ssl/ssl_client_session_cache_unittest.cc

Project Member

Comment 127 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cfcdb1f7b704815da152c8b496309c652af043c

commit 1cfcdb1f7b704815da152c8b496309c652af043c
Author: Jeremy Roman <jbroman@chromium.org>
Date: Thu Apr 12 17:02:45 2018

Remove unnecessary includes of base/memory/ptr_util.h in cc/ and gpu/.

It no longer defines base::MakeUnique, so it should only be included
where base::WrapUnique is used.

Generated by:
  for x in `git grep -l '#include "base/memory/ptr_util.h"' cc gpu`; do \
    grep -q WrapUnique "$x" || sed -i -e \
    '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done

Bug: 755727
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5e19711f9932ba6ef30c8361fd62387bfab507ac
Reviewed-on: https://chromium-review.googlesource.com/1007894
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550245}
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/animation/animation_host.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/animation/element_animations.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/animation/keyframe_model_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/animation/scroll_offset_animations_impl.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/animation/transform_operations_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/animation/worklet_animation.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/benchmarks/invalidation_benchmark.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/benchmarks/micro_benchmark_controller.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/blink/web_compositor_support_impl.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/blink/web_content_layer_impl.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/blink/web_scrollbar_layer_impl.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/input/browser_controls_offset_manager_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/layer_impl.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/layer_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/nine_patch_generator.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/picture_layer_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/recording_source_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/scrollbar_layer_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/surface_layer.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/texture_layer.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/touch_action_region.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/layers/ui_resource_layer.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/discardable_image_map.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/display_item_list.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/display_item_list_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/paint_image_builder.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/paint_recorder.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/paint_shader.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/record_paint_canvas.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/paint/skia_paint_canvas.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/raster/bitmap_raster_buffer_provider.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/raster/one_copy_raster_buffer_provider.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/raster/playback_image_provider.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/raster/raster_buffer_provider_perftest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/raster/raster_buffer_provider_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/raster/staging_buffer_pool.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/resources/resource_pool.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/resources/video_resource_updater_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/scheduler/scheduler.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/fake_painted_scrollbar_layer.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/fake_tile_manager.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/fake_tile_task_manager.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/layer_tree_pixel_resource_test.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/layer_tree_pixel_test.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/pixel_test.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/push_properties_counting_layer_impl.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/scheduler_test_common.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/skia_common.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/test/test_in_process_context_provider.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/checker_image_tracker.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/checker_image_tracker_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/eviction_tile_priority_queue.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/picture_layer_tiling.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/picture_layer_tiling_set_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/raster_tile_priority_queue_all.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/tile_manager.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/tile_manager_perftest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/clip_node.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_frame_sink_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_host.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_host_pixeltest_scrollbars.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_host_unittest_copyrequest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_host_unittest_scroll.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_impl.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/layer_tree_impl_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/mutator_host.h
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/proxy_impl.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/proxy_main.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/cc/trees/swap_promise_manager_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/client/client_discardable_manager.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/client/cmd_buffer_helper_test.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/client/fenced_allocator_test.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/client/mapped_memory_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/client/query_tracker.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/client/ring_buffer_test.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/command_buffer_service.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/command_buffer_service_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/context_group.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/gpu_tracer_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/mailbox_manager_factory.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/mailbox_manager_sync.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/mailbox_manager_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/scheduler.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/scheduler_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/sync_point_manager.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/sync_point_manager_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/service/transfer_buffer_manager_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/tests/fuzzer_main.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/command_buffer/tests/gl_compressed_copy_texture_CHROMIUM_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/config/gpu_control_list.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/gles2_conform_support/egl/context.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/host/shader_disk_cache.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/host/shader_disk_cache_unittest.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/service/child_window_win.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/service/direct_composition_child_surface_win.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/service/direct_composition_surface_win.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/service/gles2_command_buffer_stub.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/service/gpu_channel_manager.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/service/gpu_channel_test_common.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/ipc/service/raster_command_buffer_stub.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/tools/compositor_model_bench/render_models.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/vulkan/vulkan_descriptor_pool.cc
[modify] https://crrev.com/1cfcdb1f7b704815da152c8b496309c652af043c/gpu/vulkan/vulkan_shader_module.cc

Project Member

Comment 128 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b25be978af9b230ba645049fb4fe4ddc5cc8077b

commit b25be978af9b230ba645049fb4fe4ddc5cc8077b
Author: Jeremy Roman <jbroman@chromium.org>
Date: Thu Apr 12 17:24:55 2018

Remove unnecessary includes of base/memory/ptr_util.h in ui/.

It no longer defines base::MakeUnique, so it should only be included
where base::WrapUnique is used.

Generated by:
  for x in `git grep -l '#include "base/memory/ptr_util.h"' ui`; do \
    grep -q WrapUnique "$x" || sed -i -e \
    '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done

Bug: 755727
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0da214ef2afbb6d41d1a14ee21ac91df34ddb2e2
Reviewed-on: https://chromium-review.googlesource.com/1007893
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550252}
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/accessibility/ax_tree_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/accessibility/platform/ax_snapshot_node_android_platform.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/android/resources/nine_patch_resource.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/android/resources/resource.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/android/resources/resource_manager_impl_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/app_list/views/app_list_view_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/app_list/views/indicator_chip_view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/app_list/views/page_switcher.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/app_list/views/pulsing_block_view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/app_list/views/search_result_answer_card_view_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/app_list/views/search_result_list_view_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/app_list/views/search_result_page_view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/app_list/views/search_result_tile_item_list_view_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/arc/notification/arc_notification_content_view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/arc/notification/arc_notification_item_impl.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/arc/notification/arc_notification_manager_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/arc/notification/arc_notification_surface_manager_impl.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/arc/notification/arc_notification_view_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/env.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/gestures/gesture_recognizer_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/client_surface_embedder.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/drag_drop_controller_mus.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/drag_drop_controller_mus_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/input_method_mus.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/mus_context_factory.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/os_exchange_data_provider_mus_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/property_converter.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/user_activity_forwarder_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/window_tree_host_mus.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/mus/window_tree_host_mus_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/test/aura_test_base.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/test/aura_test_helper.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/test/mus/test_window_tree_client_setup.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/window.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/aura/window_port_for_shutdown.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/class_property_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/cocoa/menu_controller.mm
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/dragdrop/os_exchange_data_provider_builder_mac.mm
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/dragdrop/os_exchange_data_provider_factory.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/dragdrop/os_exchange_data_provider_win.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/ime/input_method_chromeos.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/ime/linux/fake_input_method_context_factory.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/l10n/l10n_util_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/models/list_model.h
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/models/list_model_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/models/tree_node_iterator_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/models/tree_node_model_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/nine_image_painter_factory.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/resource/data_pack.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/resource/resource_bundle.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/resource/resource_bundle_android.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/resource/resource_bundle_win.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/base/x/selection_owner.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/chromeos/events/event_rewriter_chromeos.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/chromeos/ime/candidate_window_view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/compositor/callback_layer_animation_observer_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/compositor/layer_animation_element.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/compositor/layer_animator_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/compositor/layer_owner.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/compositor/layer_owner_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/compositor/layer_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/compositor/test/test_suite.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/chromeos/display_change_observer_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/chromeos/display_configurator.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/chromeos/display_configurator_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/chromeos/touch_device_manager_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/chromeos/touch_transform_controller_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/chromeos/update_display_configuration_task_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/display_manager.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/fake_display_delegate.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/display/manager/fake_display_snapshot.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/blink/compositor_thread_event_queue.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/blink/event_with_callback.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/gestures/blink/web_gesture_curve_impl.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/device/device_manager.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/device/udev/device_manager_udev.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/evdev/event_converter_test_util.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/evdev/event_factory_evdev.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/evdev/gamepad_event_converter_evdev_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/evdev/input_controller_evdev.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/evdev/touch_filter/false_touch_finder.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/gamepad/gamepad_mapping.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/gamepad/generic_gamepad_mapping.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/gamepad/generic_gamepad_mapping_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/platform/platform_event_source.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/platform/platform_event_source_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/platform/x11/x11_event_source_glib.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/platform/x11/x11_event_source_libevent.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/system_input_injector.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/test/event_generator.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/test/scoped_event_test_tick_clock.h
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/test/test_event_target.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/events/x/events_x_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/animation/animation.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/animation/animation_test_api.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/color_transform.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/gpu_fence_handle.h
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/image/canvas_image_source.h
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/image/mojo/image_traits_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/interpolated_transform.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/interpolated_transform_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/paint_vector_icon.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/render_text.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/render_text_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gfx/skia_paint_util.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gl/gl_fence.h
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gl/gl_gl_api_implementation.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gl/gl_implementation.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gl/gl_surface_egl.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/gl/test/run_all_unittests.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/keyboard/keyboard_controller_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/keyboard/keyboard_util_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/message_center/message_center_impl.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/native_theme/common_theme.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/cast/client_native_pixmap_factory_cast.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/cast/gl_ozone_egl_cast.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/cast/gl_surface_cast.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/common/drm_util.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/drm_display.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/drm_thread_proxy.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/drm_window.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/gbm_surfaceless.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/hardware_display_controller.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/gpu/screen_manager.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/host/drm_display_host.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/host/drm_display_host_manager.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/host/drm_overlay_manager.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/drm/ozone_platform_gbm.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/headless/headless_surface_factory.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/headless/ozone_platform_headless.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/wayland/ozone_platform_wayland.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/wayland/wayland_touch.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/wayland/wayland_window.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/x11/ozone_platform_x11.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/ozone/platform/x11/x11_surface_factory.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/snapshot/snapshot_aura.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/touch_selection/touch_handle_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/touch_selection/touch_selection_controller_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/accessibility/native_view_accessibility_auralinux.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/accessibility/native_view_accessibility_base.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/accessibility/native_view_accessibility_mac.mm
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/accessibility/native_view_accessibility_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/accessibility/native_view_accessibility_win.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/accessible_pane_view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/animation/ink_drop_highlight_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/animation/ink_drop_host_view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/animation/ink_drop_impl.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/animation/ink_drop_impl_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/animation/test/ink_drop_impl_test_api.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/animation/test/test_ink_drop_host.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/background.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/bubble/bubble_dialog_delegate.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/bubble/tooltip_icon.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/cocoa/bridged_native_widget.mm
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/button/label_button.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/button/toggle_button_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/image_view_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/label.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/label_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/menu/menu_controller.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/menu/menu_runner_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/menu/menu_scroll_view_container.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/menu/native_menu_win.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/scroll_view_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/textfield/textfield_model.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/tree/tree_view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/tree/tree_view_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/controls/views_text_services_context_menu_mac.mm
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/examples/box_layout_example.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/examples/examples_window.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/examples/examples_window_with_content.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/examples/text_example.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/examples/tree_view_example.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/focus/external_focus_tracker.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/focus/focus_manager.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/focus/focus_manager_factory.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/focus/focus_manager_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/focus/focus_traversal_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/layout/layout_provider.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/mus/desktop_window_tree_host_mus.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/mus/desktop_window_tree_host_mus_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/mus/pointer_watcher_event_router_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/mus/views_mus_test_suite.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/painter.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/style/platform_style.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/style/platform_style_mac.mm
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/test/combobox_test_api.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/test/native_widget_factory_aura_mus.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/test/platform_test_helper_cocoa.mm
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/test/test_views_delegate.h
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/view.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/view_tracker_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/views_delegate.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/widget/desktop_aura/desktop_drop_target_win.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/widget/desktop_aura/x11_topmost_window_finder_interactive_uitest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/widget/native_widget_aura.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/widget/native_widget_aura_interactive_uitest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/views/win/pen_event_processor.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/wm/core/focus_controller_unittest.cc
[modify] https://crrev.com/b25be978af9b230ba645049fb4fe4ddc5cc8077b/ui/wm/core/window_animati
Project Member

Comment 129 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b01030721aeb92c24bb7263628245471c5dd885

commit 5b01030721aeb92c24bb7263628245471c5dd885
Author: Jeremy Roman <jbroman@chromium.org>
Date: Thu Apr 12 17:52:31 2018

Remove unnecessary includes of base/memory/ptr_util.h in third_party/blink/.

It no longer defines base::MakeUnique, so it should only be included
where base::WrapUnique is used.

Generated by:
  for x in `git grep -l '#include "base/memory/ptr_util.h"' third_party/blink`; do \
    grep -q WrapUnique "$x" || sed -i -e \
    '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done

One include was added to
  third_party/blink/renderer/platform/scheduler/main_thread/web_main_thread_scheduler.cc
which previously depended on ptr_util.h being included by one of its
headers.

Bug: 755727
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I425109636a07f0f54c0f9a1019a5633fab153722
Reviewed-on: https://chromium-review.googlesource.com/1010266
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550261}
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/common/test/run_all_unittests.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/public/platform/scheduler/test/renderer_scheduler_test_support.h
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/modules/cachestorage/InspectorCacheStorageAgent.cpp
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/modules/peerconnection/rtc_dtmf_sender.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/modules/speech/speech_recognition_client_proxy.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/graphics/video_frame_resource_provider.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/child/idle_canceled_delayed_task_sweeper_unittest.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/child/idle_helper_unittest.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/child/task_runner_impl.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/child/web_scheduler_impl.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/child/worker_global_scope_scheduler_unittest.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/common/scheduler_helper_unittest.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/common/throttling/budget_pool.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/common/throttling/cpu_time_budget_pool.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/main_thread/web_main_thread_scheduler.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/renderer/auto_advancing_virtual_time_domain.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/renderer/queueing_time_estimator.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/test/lazy_thread_controller_for_test.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/util/task_duration_metric_reporter_unittest.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler_unittest.cc
[modify] https://crrev.com/5b01030721aeb92c24bb7263628245471c5dd885/third_party/blink/renderer/platform/wtf/text/icu/collator_icu.cc

Project Member

Comment 130 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92051612dbfede6aed168a6a6e0f89909136eef8

commit 92051612dbfede6aed168a6a6e0f89909136eef8
Author: Jeremy Roman <jbroman@chromium.org>
Date: Thu Apr 12 19:01:52 2018

Remove unnecessary includes of base/memory/ptr_util.h in net/

It no longer defines base::MakeUnique, so it should only be included
where base::WrapUnique is used.

Generated by:
  for x in `git grep -l '#include "base/memory/ptr_util.h"' net`; do \
    grep -q WrapUnique "$x" || sed -i -e \
    '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done

One include was added to net/cert/multi_threaded_cert_verifier.cc
which previously depended on ptr_util.h being included by one of its
headers.

Bug: 755727
Tbr: kerrnel@chromium.org
Change-Id: I61a99097ffab3ad39b77a6506d793c9bde54d8ef
Reviewed-on: https://chromium-review.googlesource.com/1010402
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550293}
[modify] https://crrev.com/92051612dbfede6aed168a6a6e0f89909136eef8/net/cert/multi_threaded_cert_verifier.cc
[modify] https://crrev.com/92051612dbfede6aed168a6a6e0f89909136eef8/net/dns/mojo_host_struct_traits.cc
[modify] https://crrev.com/92051612dbfede6aed168a6a6e0f89909136eef8/net/network_error_logging/network_error_logging_service.cc
[modify] https://crrev.com/92051612dbfede6aed168a6a6e0f89909136eef8/net/socket/udp_socket_unittest.cc
[modify] https://crrev.com/92051612dbfede6aed168a6a6e0f89909136eef8/net/ssl/ssl_client_session_cache_unittest.cc

Status: Fixed (was: Started)
AFAICT this is fixed -- MakeUnique no longer exists.  Optimistically closing.

Great work here!
Showing comments 32 - 131 of 131 Older

Sign in to add a comment