Chrome pref for Metrics not updated during ARC opt-in |
||
Issue descriptionDuring ARC opt-in, if user opt-out metrics recording we show a check-box for user to enable metrics recording. However, user's update is not updating Chrome-pref. https://cs.chromium.org/chromium/src/chrome/browser/chromeos/arc/optin/arc_optin_preference_handler.cc?type=cs&l=100
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89d27148d9110c91bc56bf1841d37bbc54eaef43 commit 89d27148d9110c91bc56bf1841d37bbc54eaef43 Author: khmel <khmel@google.com> Date: Tue Oct 31 23:58:36 2017 arc: Fix metrics change in ARC OptIn is not reflected in Settings. This modifies ChromeOS settings for metrics instead of lower level metrics preferences. ChromeOS settings change has mapping to lower level metrics but not the opposite way. That is why change in metrics mode from ARC OptIn page was not propogated to Chrome settings. Test: Manually on device Bug: 755716 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I81ce5d38d34ade6d6f2737804eee5c1e7fa0822e Reviewed-on: https://chromium-review.googlesource.com/736145 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#513014} [modify] https://crrev.com/89d27148d9110c91bc56bf1841d37bbc54eaef43/chrome/browser/chromeos/arc/optin/arc_optin_preference_handler.cc [modify] https://crrev.com/89d27148d9110c91bc56bf1841d37bbc54eaef43/chrome/browser/chromeos/arc/optin/arc_optin_preference_handler.h [modify] https://crrev.com/89d27148d9110c91bc56bf1841d37bbc54eaef43/chrome/browser/metrics/chrome_metrics_service_accessor.h
,
Nov 8 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by khmel@chromium.org
, Oct 24 2017